GNU bug report logs -
#44108
calc windows should be marked as dedicated
Previous Next
Reported by: Boruch Baum <boruch_baum <at> gmx.com>
Date: Tue, 20 Oct 2020 23:03:02 UTC
Severity: normal
Tags: patch
Done: Eli Zaretskii <eliz <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44108 in the body.
You can then email your comments to 44108 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Tue, 20 Oct 2020 23:03:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Boruch Baum <boruch_baum <at> gmx.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Tue, 20 Oct 2020 23:03:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Windows that display calc buffers (ie. the stack buffer and the trail
buffer) are typically small-sized single-use windows, yet they are not
marked as dedicated. The consequence is that functions that perform
`pop-to-buffer' or `display-buffer' can use one of them as targets,
which will always be undesirable. A simple example, the one that
prompted this bug report, is when I was in a calc buffer and issued calc
command "u v" to display a 'units description' buffer. This is a long
and wide buffer, yet was displayed in the short and narrow calc trail
window. I vaguely recall having this also happen in the past with help
buffers, but was only motivated now to submit the report.
The solution is that when the calc and calc trail buffers are created,
they should be marked (set-window-dedicated-p)
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7'286 0036 9E45 1595 8BC0
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Tue, 20 Oct 2020 23:10:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 44108 <at> debbugs.gnu.org (full text, mbox):
I need to elaborate on my initial report: people who use calc a lot will
be closing and re-opening windows used for the same calc buffers, so the
(set-window-dedicated-p) operation needs to be done at each window
creation event for calc and calc-trail windows, not at buffer creation
events.
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Thu, 22 Oct 2020 07:46:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 44108 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Attached.
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
[calc-dedicated-windows.patch (text/x-diff, attachment)]
Added tag(s) patch.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Fri, 23 Oct 2020 15:05:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Sat, 31 Oct 2020 07:55:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 44108 <at> debbugs.gnu.org (full text, mbox):
> Date: Thu, 22 Oct 2020 03:45:09 -0400
> From: Boruch Baum <boruch_baum <at> gmx.com>
>
> diff --git a/calc.el b/calc.el
> index 4bebd5f..90dcce6 100644
> --- a/calc.el
> +++ b/calc.el
> @@ -1472,6 +1472,7 @@ commands given here will actually operate on the *Calculator* stack."
> (and (windowp full-display)
> (window-point full-display)
> (select-window full-display))
> + (set-window-dedicated-p nil t)
> (calc-check-defines)
> (when (and calc-said-hello interactive)
> (sit-for 2)
> @@ -2136,7 +2137,8 @@ the United States."
> (if calc-trail-window-hook
> (run-hooks 'calc-trail-window-hook)
> (let ((w (split-window nil (/ (* (window-width) 2) 3) t)))
> - (set-window-buffer w calc-trail-buffer)))
> + (set-window-buffer w calc-trail-buffer)
> + (set-window-dedicated-p w t)))
> (calc-wrapper
> (setq overlay-arrow-string calc-trail-overlay
> overlay-arrow-position calc-trail-pointer)
Thanks.
Would people who routinely use Calc please chime in and comment on
this? Could this have some adverse consequences in some use cases?
Should we have a user option for controlling this behavior?
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Sat, 07 Nov 2020 08:18:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 44108 <at> debbugs.gnu.org (full text, mbox):
Ping! Could someone please chime in?
If no comments are heard, I will push this change conditioned on a new
defcustom, in one week's time.
> Date: Sat, 31 Oct 2020 09:54:16 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 44108 <at> debbugs.gnu.org
>
> > Date: Thu, 22 Oct 2020 03:45:09 -0400
> > From: Boruch Baum <boruch_baum <at> gmx.com>
> >
> > diff --git a/calc.el b/calc.el
> > index 4bebd5f..90dcce6 100644
> > --- a/calc.el
> > +++ b/calc.el
> > @@ -1472,6 +1472,7 @@ commands given here will actually operate on the *Calculator* stack."
> > (and (windowp full-display)
> > (window-point full-display)
> > (select-window full-display))
> > + (set-window-dedicated-p nil t)
> > (calc-check-defines)
> > (when (and calc-said-hello interactive)
> > (sit-for 2)
> > @@ -2136,7 +2137,8 @@ the United States."
> > (if calc-trail-window-hook
> > (run-hooks 'calc-trail-window-hook)
> > (let ((w (split-window nil (/ (* (window-width) 2) 3) t)))
> > - (set-window-buffer w calc-trail-buffer)))
> > + (set-window-buffer w calc-trail-buffer)
> > + (set-window-dedicated-p w t)))
> > (calc-wrapper
> > (setq overlay-arrow-string calc-trail-overlay
> > overlay-arrow-position calc-trail-pointer)
>
> Thanks.
>
> Would people who routinely use Calc please chime in and comment on
> this? Could this have some adverse consequences in some use cases?
> Should we have a user option for controlling this behavior?
>
>
>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44108
; Package
emacs
.
(Sat, 07 Nov 2020 09:00:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 44108 <at> debbugs.gnu.org (full text, mbox):
> Ping! Could someone please chime in?
> If no comments are heard, I will push this change conditioned on a new
> defcustom, in one week's time.
IMHO _any_ use of dedicated windows in Emacs should be optional so a
defcustom is certainly a good idea.
Note that 'display-buffer' already processes a 'dedicated' action alist
entry so if 'calc' used it in this context, the option would already be
available now.
martin
Reply sent
to
Eli Zaretskii <eliz <at> gnu.org>
:
You have taken responsibility.
(Sat, 14 Nov 2020 13:06:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Boruch Baum <boruch_baum <at> gmx.com>
:
bug acknowledged by developer.
(Sat, 14 Nov 2020 13:06:01 GMT)
Full text and
rfc822 format available.
Message #27 received at 44108-done <at> debbugs.gnu.org (full text, mbox):
> Date: Sat, 07 Nov 2020 10:17:15 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 44108 <at> debbugs.gnu.org
>
> Ping! Could someone please chime in?
> If no comments are heard, I will push this change conditioned on a new
> defcustom, in one week's time.
Done.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 13 Dec 2020 12:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 135 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.