GNU bug report logs - #44129
Patch to improve valac version detection

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44129 in the body.
You can then email your comments to 44129 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-automake <bug-automake <at> gnu.org>
Subject: Patch to improve valac version detection
Date: Wed, 21 Oct 2020 23:37:51 +0100

[Message part 1 (text/plain, inline)]

Attached, a patch to improve valac version detection. The vala compiler,
valac, can report the API version it supports. For releases, this is the
same as the major & minor version of the compiler, so for example:

$ valac --version
Vala 0.48.11
$ valac --api-version
0.48

The advantage of using the API version is that it's semantically
meaningful. It's also simpler to parse! It can be to allow a 3rd-party,
patched, or unreleased compiler to be used more easily.

(For example, the current Vala git master compiler reports:

$ valac-0.52 --version
Vala 0.50.1.19-135c0
$ valac-0.52 --api-version
0.52

)

-- 
https://rrt.sc3d.org

[Message part 2 (text/html, inline)]

[0001-Improve-Vala-compiler-detection-use-API-version-not-.patch (text/x-patch, attachment)]

Message #8 received at 44129 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: rrt <at> sc3d.org
Cc: 44129 <at> debbugs.gnu.org
Subject: Re: bug#44129: Patch to improve valac version detection
Date: Fri, 23 Oct 2020 07:51:30 -0600

    $ valac --api-version
    0.48

Thanks Reuben. Unfortunately, when I install this patch, the
t/vala-configure.sh test fails for me with:

  configure: WARNING: Vala compiler not found or too old
  configure: WARNING: you will not be able to compile Vala source files

I'm using CentOS 7, which reports:
$ vala --version
Vala 0.40.8
$ valac --api-version
0.40

In any event, the test should not fail. It passed for me before the patch.
I hope you can look into this (and that it's easy)? --thanks, karl.

Message #11 received at 44129 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: 44129 <at> debbugs.gnu.org
Subject: Re: bug#44129: Patch to improve valac version detection
Date: Fri, 23 Oct 2020 17:53:11 +0100

[Message part 1 (text/plain, inline)]

Sorry, I simply failed to update the test; I noticed a failure message, and
didn't understand it. Simply lack of effort on my part, apologies.

I attach an updated patch, which now also patches the test to account for
the new mode of operation (checking --api-version not --version) and
updated error message in case of failure.

[Message part 2 (text/html, inline)]

[0001-Improve-Vala-compiler-detection-use-API-version-not-.patch (text/x-patch, attachment)]

Message #14 received at 44129 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: rrt <at> sc3d.org
Cc: 44129 <at> debbugs.gnu.org
Subject: Re: bug#44129: Patch to improve valac version detection
Date: Fri, 23 Oct 2020 15:40:58 -0600

    I simply failed to update the test; 

I'm glad it was simple.

All the tests pass for me now, and I pushed your patch, and am closing
this bug. Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.