GNU bug report logs - #44188
[PATCH] Use lexical binding in wdired.el

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> mailfence.com>

Date: Fri, 23 Oct 2020 23:16:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44188 in the body.
You can then email your comments to 44188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44188; Package emacs. (Fri, 23 Oct 2020 23:16:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brian Leung <leungbk <at> mailfence.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 23 Oct 2020 23:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use lexical binding in wdired.el
Date: Sat, 24 Oct 2020 01:15:42 +0200 (CEST)
[Message part 1 (text/plain, inline)]
See attached. I don't notice any byte-compilation warnings, or unused let-bound variables. Please let me know if there's anything else that needs to be done.

-- 
Sent with https://mailfence.com
Secure and private email
[0001-Use-lexical-binding-in-wdired.el.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44188; Package emacs. (Fri, 23 Oct 2020 23:24:01 GMT) Full text and rfc822 format available.

Message #8 received at 44188 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: 44188 <at> debbugs.gnu.org
Subject: [PATCH] Use lexical binding for several Elisp files
Date: Sat, 24 Oct 2020 01:23:36 +0200 (CEST)
[Message part 1 (text/plain, inline)]
I enforced lexical binding in a few other files.

-- 
Sent with https://mailfence.com
Secure and private email
[0001-Use-lexical-binding-in-wdired.el.patch (text/x-diff, attachment)]
[0002-Use-lexical-binding-in-wid-browse.el.patch (text/x-diff, attachment)]
[0003-Use-lexical-binding-in-widget.el.patch (text/x-diff, attachment)]
[0004-Use-lexical-binding-in-winner.el.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44188; Package emacs. (Mon, 26 Oct 2020 16:03:01 GMT) Full text and rfc822 format available.

Message #11 received at 44188 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 44188 <at> debbugs.gnu.org
Subject: Re: bug#44188: [PATCH] Use lexical binding in wdired.el
Date: Mon, 26 Oct 2020 17:01:44 +0100
Brian Leung <leungbk <at> mailfence.com> writes:

> I enforced lexical binding in a few other files.

Thanks, but I'm slightly worried whether these have been tested?
There's sometimes subtle problems with converting to lexical binding
that's not obvious from just compiling the files, but is only revealed
by actually using the functions.

So when converting to lexical binding, we try to (where it makes sense)
to add some unit tests to test/lisp/<file>-tests.el at the same time to
give us greater confidence that the mechanisms still work.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44188; Package emacs. (Tue, 11 May 2021 13:38:01 GMT) Full text and rfc822 format available.

Message #14 received at 44188 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 44188 <at> debbugs.gnu.org
Subject: Re: bug#44188: [PATCH] Use lexical binding in wdired.el
Date: Tue, 11 May 2021 15:37:36 +0200
All the files in question have been converted to lexical binding now, as
far as I can tell, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 11 May 2021 13:38:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 44188 <at> debbugs.gnu.org and Brian Leung <leungbk <at> mailfence.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 11 May 2021 13:38:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Jun 2021 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 293 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.