GNU bug report logs - #44258
Add Network UPS Tools

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Nicolò Balzarotti <anothersms@HIDDEN>; Keywords: patch; dated Tue, 27 Oct 2020 16:13:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) patch. Request was from Bruno Victal <mirai@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 44258 <at> debbugs.gnu.org:


Received: (at 44258) by debbugs.gnu.org; 14 Nov 2020 16:45:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 14 11:45:22 2020
Received: from localhost ([127.0.0.1]:51797 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kdyfy-0001Wo-3v
	for submit <at> debbugs.gnu.org; Sat, 14 Nov 2020 11:45:22 -0500
Received: from mail-wr1-f50.google.com ([209.85.221.50]:43791)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <anothersms@HIDDEN>) id 1kdyfw-0001WY-DW
 for 44258 <at> debbugs.gnu.org; Sat, 14 Nov 2020 11:45:21 -0500
Received: by mail-wr1-f50.google.com with SMTP id s8so13733342wrw.10
 for <44258 <at> debbugs.gnu.org>; Sat, 14 Nov 2020 08:45:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:subject:in-reply-to:references:date:message-id:mime-version;
 bh=mi/vzqMZqdmkKd9rObKtuAlnD04MxyGYlo49c1xMuJI=;
 b=L2WQdKGOQRJkoHQH6IDOHgdClYRoTavUqcy25E918mJflDnNLwmUuxWsCbBPO70e2L
 NEJuJcLdu/kbK6GajuCAX6ExqWmmXGk3qqABIjhHAHis7ExnAlrzdV984bSPEJjRf4px
 z7N2ebCJ1DSmRSm3NmwAlNXc6tK7DwyeDG7ZodMFq7U/J5eOjQi2gAO5F5ihAiUxgKg5
 n+jlhPiNkMT4bm/Xq48YfnQiffg/OrEWgwXpGx9KvuSsGVU0E13qOsC0qxbRbdTSnirR
 HZ6G7HPy6hDCZCUNJktD3bvLkSexo87b5+WYC15GuJBYAaDgSuVZ3WbaR9sM/AmE11sO
 jZeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:subject:in-reply-to:references:date
 :message-id:mime-version;
 bh=mi/vzqMZqdmkKd9rObKtuAlnD04MxyGYlo49c1xMuJI=;
 b=eizdLFt4Shp2o/GlxZuclvAGRqHVjEOzRwuh6aL3w/ifqQtOFaC7P8F6BmQ+gYQjcy
 uoyqrhFxRFYxGRxS88rCsaKpCCSyur0oLZbg+c+QfvWwBbtzFZuhHDO7o8xy8tQDyLHu
 GKQQOiFDfQrQdkvp2rxzREgkMbrNePDxB1X5uYynj1w85+AlHn7b/lhvAfC969C4GOmd
 qL4o9RDSHDAQMcM/WGVM8zrRNGuXPhhDTqlPheMe5DQEhX3iirAXoxT+hqvINcCkgN1b
 wE/MnsesgTC/oFcHWluomQZaGxLWMUNmsPWJkfhn9yL5HtZ/PMYlMPNXKpAThKWPh3Ta
 d/iQ==
X-Gm-Message-State: AOAM530hWhbqsBQLw6w+b7HCpO/wA37vThqJIiLmADNIjqnPu0thrhuC
 IyeG2VV/NZKE4g34GN+z1o5MgjhzmR0=
X-Google-Smtp-Source: ABdhPJxHFTg+IuH2oIQAVg4cJwGHI5FAp9NRxDTHYSXwZ1YDuj/dXnytPn9TR8GR3T8CG+Axwa/JGQ==
X-Received: by 2002:adf:db4a:: with SMTP id f10mr10217501wrj.420.1605372314160; 
 Sat, 14 Nov 2020 08:45:14 -0800 (PST)
Received: from guixSD (host-95-244-15-230.retail.telecomitalia.it.
 [95.244.15.230])
 by smtp.gmail.com with ESMTPSA id v2sm15527231wrm.96.2020.11.14.08.45.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 14 Nov 2020 08:45:13 -0800 (PST)
From: =?utf-8?Q?Nicol=C3=B2?= Balzarotti <anothersms@HIDDEN>
To: Marius Bakke <marius@HIDDEN>, 44258 <at> debbugs.gnu.org
Subject: Re: [bug#44258] Add Network UPS Tools
In-Reply-To: <87h7pxdm10.fsf@HIDDEN>
References: <87lffrmyvp.fsf@HIDDEN>
 <87h7pxdm10.fsf@HIDDEN>
Date: Sat, 14 Nov 2020 17:45:11 +0100
Message-ID: <87sg9b99bc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi,
 thanks for the reply. Marius Bakke writes: > > Avoid hard-coding
 versions in URLs. You can use the version-major+minor > procedure to create
 that "2.7" URL component. 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (anothersms[at]gmail.com)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
 [URI: nixo.xyz (xyz)]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.221.50 listed in wl.mailspike.net]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.221.50 listed in list.dnswl.org]
X-Debbugs-Envelope-To: 44258
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi, thanks for the reply.

Marius Bakke <marius@HIDDEN> writes:

>
> Avoid hard-coding versions in URLs.  You can use the version-major+minor
> procedure to create that "2.7" URL component.

Done!

> This got merged in 2017, and still not released!
>
> Looking at the pull request[0], this URL is a squashed version of 7
> commits.  While convenient, this trick has failed before due to subtle
> changes in GitHub machinery, eventually leading to a hash mismatch[1].
>
> Taking 7 patches directly is no fun either, so I wonder if we can just
> stick with OpenSSL 1.0 for now?
>
Fine! Using openssl-1.0 now.

>> +                           ;; powerman is required (where is it hosted?)
>> +                           "--without-powerman"
>
> Can you elaborate on powerman being required?  Is the package not usable
> without it?
>
Expanded a bit, following nut readme.

>> +                           ;; cgi requires libgd
>> +                           "--without-cgi")
>
> We do have libgd (in the 'gd' package).
>
Oh, I don't know how I missed it.  Added!  Now cgi is working (output is
in folder /cgi-bin, is this correct for guix?)

Since nut release is really old, it used to use gdlib-config.  It has=20
been removed and replaced by pkg-config.  However, the patch [1] does
not apply.  So I had to do the "terrible" fix of calling pkg-config
myself (in the new "fix-ligdb-check" phase).  Terrible because I wanted
to call it in guile and save the output to the file, but the only way I
know of is with popen (and I could not find another package doing this
(while some package like python-libmpsse are just inserting the call
like I did here).

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'configure 'update-configure
>> +           ;; required to apply the patch to the ./configure script
>> +           (lambda _
>> +             (invoke "autoconf"))))))
>
> This may not be necessary due to the 'bootstrap' phase (but I haven't
> verified).
>
Well, now that I switched to openssl-1.0 it sure is not needed anymore.
But previously I remember without the autoreconf call, it was not working.

>> +    (native-inputs `(("autoconf" ,autoconf)n
>> +                     ("cppunit" ,cppunit)
>> +                     ("pkg-config" ,pkg-config)))
>> +    (inputs `(("avahi" ,avahi)
>> +              ("libusb" ,libusb-compat)
>> +              ("libltdl" ,libltdl)
>> +              ("freeipmi" ,freeipmi)
>> +              ("neon" ,neon)
>> +              ("openssl" ,openssl)
>> +              ("net-snmp" ,net-snmp)))
>
> The indentation of these are a bit weird.  :-)
>
ops :)

>> +    (home-page "https://networkupstools.org")
>> +    (license
>> +     (list
>> +      ;; - most files under gpl2+
>> +      license:gpl2+
>> +      ;; - scripts/python/ under gpl3+
>> +      license:gpl3+
>> +      ;; - scripts/perl/Nut.pm same as perl (either gpl1+ or artistic)
>> +      license:gpl1+ license:artistic2.0))
>
> Great job at listing licenses!
>
>> +    (synopsis "Collection of programs for monitoring and administering =
UPS")
>> +    (description "Network UPS Tools is a collection of programs which p=
rovide
>> +a common interface for monitoring and administering UPS, PDU and SCD ha=
rdware.
>> +It uses a layered approach to connect all of the parts.  Drivers are pr=
ovided
>> +for a wide assortment of equipment.")))
>
> Maybe add @acronym{UPS, Uninterruptible Power Supply},
> @acronym{PDU, ...} etc, but no strong opinion.
>
Sure!

> Can you send an updated patch?

I also added the phase "fix-search-paths" which fixes nut-scanner.
nut scanner now finds my ups device (but I still could not get it to
work, not sure if the problem is in my config or in this package.  I'd
wait to merge this until someone can try.

Thanks again,
Nicol=C3=B2


--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment; filename=v2-0001-gnu-Add-nut.patch
Content-Transfer-Encoding: quoted-printable

From baf9ef419fb36a2198597894c72b23d8553b012a Mon Sep 17 00:00:00 2001
From: nixo <nicolo@HIDDEN>
Date: Tue, 27 Oct 2020 10:56:35 +0100
Subject: [PATCH v2] gnu: Add nut.

* gnu/packages/admin.scm (nut): New variable.
---
 gnu/packages/admin.scm | 87 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 8dcf8afd84..5f14c4b68a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -35,6 +35,7 @@
 ;;; Copyright =C2=A9 2020 Michael Rohleder <mike@HIDDEN>
 ;;; Copyright =C2=A9 2020 Vincent Legoll <vincent.legoll@HIDDEN>
 ;;; Copyright =C2=A9 2020 Morgan Smith <Morgan.J.Smith@HIDDEN>
+;;; Copyright =C2=A9 2020 Nicol=C3=B2 Balzarotti <nicolo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -70,6 +71,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autogen)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages avahi)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
@@ -85,8 +87,10 @@
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages freeipmi)
   #:use-module (gnu packages gawk)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gd)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
@@ -110,6 +114,7 @@
   #:use-module (gnu packages mcrypt)
   #:use-module (gnu packages mpi)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages networking)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages patchutils)
   #:use-module (gnu packages pciutils)
@@ -880,6 +885,88 @@ IPv6, proxies, and Unix sockets.")
     (license (list license:bsd-3
                    license:bsd-2))))  ; atomicio.*, socks.c
=20
+(define-public nut
+  (package
+    (name "nut")
+    (version "2.7.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://networkupstools.org/source/" (version-major+minor ve=
rsion)
+             "/nut-" version ".tar.gz"))
+       (sha256
+        (base32
+         "19r5dm07sfz495ckcgbfy0pasx0zy3faa0q7bih69lsjij8q43lq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       `("--with-all"
+         "--with-openssl"
+         ;; nut supports a bridge to the powerman-daemon to handle
+         ;; powerman-supported devices.  For this bridge, powerman is
+         ;; required.
+         "--without-powerman"
+         ,(string-append "--with-udev-dir=3D"
+                         (assoc-ref %outputs "out")
+                         "/lib/udev"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'fix-libgd-check
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (substitute* "configure"
+               (("-L/usr/X11R6/lib")
+                ;; without --static, it won't find zlib and libjpeg
+                "$(pkg-config --static --libs gdlib)"))
+             #t))
+         (add-before 'build 'fix-search-paths
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             ;; nutscan will search libraries only under output/lib, and in
+             ;; some standard path (e.g., /usr/lib).  Add correct paths he=
re
+             (substitute* "tools/nut-scanner/nutscan-init.c"
+               (("LIBDIR,")
+                (string-append
+                 "LIBDIR,\n"
+                 (string-join
+                  (map (lambda (label)
+                         (string-append "\"" (assoc-ref inputs label) "/li=
b/\""))
+                       '("avahi" "freeipmi" "libusb" "neon" "net-snmp"))
+                  ",\n")
+                 ",\n")))
+             #t)))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("cppunit" ,cppunit)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("avahi" ,avahi)
+       ("libusb" ,libusb-compat)
+       ("libltdl" ,libltdl)
+       ;; libxpm and libx11 required when cgi is enabled
+       ("libxpm" ,libxpm)
+       ("libx11" ,libx11)
+       ("freeipmi" ,freeipmi)
+       ("gd" ,gd)
+       ("neon" ,neon)
+       ("openssl" ,openssl-1.0)
+       ("net-snmp" ,net-snmp)))
+    (home-page "https://networkupstools.org")
+    (license
+     (list
+      ;; - most files under gpl2+
+      license:gpl2+
+      ;; - scripts/python/ under gpl3+
+      license:gpl3+
+      ;; - scripts/perl/Nut.pm same as perl (either gpl1+ or artistic)
+      license:gpl1+ license:artistic2.0))
+    (synopsis "Collection of programs for monitoring and administering UPS=
")
+    (description "Network @acronym{UPS, Uninterruptible Power Supply} Tool=
s is
+a collection of programs which provide a common interface for monitoring a=
nd
+administering @acronym{UPS} @acronym{PDU,Power Distribution Unit} and
+@acronym{SCD, Solar Controller Device} hardware.  It uses a layered approa=
ch
+to connect all of the parts.  Drivers are provided for a wide assortment of
+equipment.")))
+
 (define-public sipcalc
   (package
     (name "sipcalc")
--=20
2.29.2


--=-=-=
Content-Type: text/plain



[1] https://github.com/networkupstools/nut/pull/809/commits/cb507c44d26d8ae04a0cc3d1c24e79e3bf33ba23

--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#44258; Package guix-patches. Full text available.

Message received at 44258 <at> debbugs.gnu.org:


Received: (at 44258) by debbugs.gnu.org; 10 Nov 2020 19:55:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 10 14:55:57 2020
Received: from localhost ([127.0.0.1]:38969 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kcZkD-0008TN-Ge
	for submit <at> debbugs.gnu.org; Tue, 10 Nov 2020 14:55:57 -0500
Received: from eggs.gnu.org ([209.51.188.92]:57756)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marius@HIDDEN>) id 1kcZkB-0008TB-3s
 for 44258 <at> debbugs.gnu.org; Tue, 10 Nov 2020 14:55:55 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:39405)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <marius@HIDDEN>)
 id 1kcZk5-0003V0-Q3; Tue, 10 Nov 2020 14:55:49 -0500
Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:50674
 helo=localhost)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <marius@HIDDEN>)
 id 1kcZjx-0005gw-MQ; Tue, 10 Nov 2020 14:55:47 -0500
From: Marius Bakke <marius@HIDDEN>
To: =?utf-8?Q?Nicol=C3=B2?= Balzarotti <anothersms@HIDDEN>,
 44258 <at> debbugs.gnu.org
Subject: Re: [bug#44258] Add Network UPS Tools
In-Reply-To: <87lffrmyvp.fsf@HIDDEN>
References: <87lffrmyvp.fsf@HIDDEN>
Date: Tue, 10 Nov 2020 20:55:39 +0100
Message-ID: <87h7pxdm10.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.3 (/)
X-Debbugs-Envelope-To: 44258
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Nicol=C3=B2 Balzarotti <anothersms@HIDDEN> writes:

> Hi guix!
> This patch adds Network UPS Tools (nut).

Cool!

[...]

>>From 0e3a16eb19bc481d38edbe36c241ec4631cbdd33 Mon Sep 17 00:00:00 2001
> From: nixo <nicolo@HIDDEN>
> Date: Tue, 27 Oct 2020 10:56:35 +0100
> Subject: [PATCH] gnu: Add nut.
>
> * gnu/packages/admin.scm (nut): New variable.

[...]
=20=20
> +(define-public nut
> +  (package
> +    (name "nut")
> +    (version "2.7.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri "https://networkupstools.org/source/2.7/nut-2.7.4.tar.gz")

Avoid hard-coding versions in URLs.  You can use the version-major+minor
procedure to create that "2.7" URL component.

> +       (patches
> +        (list
> +         ;; OpenSSL 1.1 support
> +         (origin
> +           (method url-fetch)
> +           (uri (string-append "https://patch-diff.githubusercontent.com=
/raw/"
> +                               "networkupstools/nut/pull/504.patch"))
> +           (sha256
> +            (base32 "1dabbzlmb886qy39xjx6nxlfrzfkm99n48la1ip32zm3baal6qp=
h"))
> +           (file-name (string-append name "-openssl1.1")))))))

This got merged in 2017, and still not released!

Looking at the pull request[0], this URL is a squashed version of 7
commits.  While convenient, this trick has failed before due to subtle
changes in GitHub machinery, eventually leading to a hash mismatch[1].

Taking 7 patches directly is no fun either, so I wonder if we can just
stick with OpenSSL 1.0 for now?

[0] https://github.com/networkupstools/nut/pull/504
[1] commit 7670efefe4fb4aca12cb19ea5d89ff37c48e3ea6

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags '("--with-all"
> +                           "--with-openssl"
> +                           ;; powerman is required (where is it hosted?)
> +                           "--without-powerman"

Can you elaborate on powerman being required?  Is the package not usable
without it?

> +                           ;; cgi requires libgd
> +                           "--without-cgi")

We do have libgd (in the 'gd' package).

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'update-configure
> +           ;; required to apply the patch to the ./configure script
> +           (lambda _
> +             (invoke "autoconf"))))))

This may not be necessary due to the 'bootstrap' phase (but I haven't
verified).

> +    (native-inputs `(("autoconf" ,autoconf)
> +                     ("cppunit" ,cppunit)
> +                     ("pkg-config" ,pkg-config)))
> +    (inputs `(("avahi" ,avahi)
> +              ("libusb" ,libusb-compat)
> +              ("libltdl" ,libltdl)
> +              ("freeipmi" ,freeipmi)
> +              ("neon" ,neon)
> +              ("openssl" ,openssl)
> +              ("net-snmp" ,net-snmp)))

The indentation of these are a bit weird.  :-)

> +    (home-page "https://networkupstools.org")
> +    (license
> +     (list
> +      ;; - most files under gpl2+
> +      license:gpl2+
> +      ;; - scripts/python/ under gpl3+
> +      license:gpl3+
> +      ;; - scripts/perl/Nut.pm same as perl (either gpl1+ or artistic)
> +      license:gpl1+ license:artistic2.0))

Great job at listing licenses!

> +    (synopsis "Collection of programs for monitoring and administering U=
PS")
> +    (description "Network UPS Tools is a collection of programs which pr=
ovide
> +a common interface for monitoring and administering UPS, PDU and SCD har=
dware.
> +It uses a layered approach to connect all of the parts.  Drivers are pro=
vided
> +for a wide assortment of equipment.")))

Maybe add @acronym{UPS, Uninterruptible Power Supply},
@acronym{PDU, ...} etc, but no strong opinion.

Can you send an updated patch?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+q8DsPHG1hcml1c0Bn
bnUub3JnAAoJEKKgbfKjOlT6UtYH/AtjrjHebyz5YlGQhv4giwVK3illSb0fYfY+
nvzsdm/KqnbH6IORxCOosKDOz6RIZJXpeIjO/Y1d2xC3KalAcXXCis16zSo+cgu/
yaTwmez8QUXqcWZuBBrcW44W1xIIP1/4AYRtPi3YOdHdlmUCTJW45Jb4nSWuvHIc
gKMUamvqVrxSJ691tEL21I/gSqLynmUsgoMgCeHkkET3pZLVlmRrmNCWipUUYfIU
jWEEGz7Uoe7Jbd8scZU1iAcfEhrhXxikKf8hhUq5t30vRtlTzbc3MVqo+JBRUz0/
tFpMTVTKgB/agGtxNXMdJ4D2ifeVTdjGWiqxCLnBX1LUBuNrOy0=
=mfMe
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#44258; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Oct 2020 16:12:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 27 12:12:42 2020
Received: from localhost ([127.0.0.1]:45516 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kXRaP-0006eY-PP
	for submit <at> debbugs.gnu.org; Tue, 27 Oct 2020 12:12:42 -0400
Received: from lists.gnu.org ([209.51.188.17]:58938)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <anothersms@HIDDEN>) id 1kXRaN-0006eR-LZ
 for submit <at> debbugs.gnu.org; Tue, 27 Oct 2020 12:12:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46022)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <anothersms@HIDDEN>)
 id 1kXRaN-0004ia-Gb
 for guix-patches@HIDDEN; Tue, 27 Oct 2020 12:12:35 -0400
Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38205)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <anothersms@HIDDEN>)
 id 1kXRaK-0007hP-2k
 for guix-patches@HIDDEN; Tue, 27 Oct 2020 12:12:35 -0400
Received: by mail-wr1-x436.google.com with SMTP id n18so2567521wrs.5
 for <guix-patches@HIDDEN>; Tue, 27 Oct 2020 09:12:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:subject:date:message-id:mime-version;
 bh=bkKgaz073C6pfIBTewg/Fuu5z4jSBnnTmkl8sQ0aVG0=;
 b=rPRbywd/OvvRrN1nyLaHLdtQRqPBF7tf4OEgfbhBeFMN/CLOISjqppp/NhJWZ7qV0K
 omV/Ub0IATOaZXTQPux9wrCEiG5VgWE/5jI2/W5Wq+1dxgAxSXd3+fw0281W6yn8L0NR
 jbetDoC+PjJbF2wvfcUqSDni6C3Q6cIOgYsqFt/CGdcVEAfrAAsFex8kMLObiV07qXiU
 sHSqB/HT5NAZjNU2xBGfOoMcRCL+2whTlIB0mc/mNSPl1zVLVkwZiC/OfITdJhW5mucU
 xtu36Dt+jezwzPc2sneHV16KrguyTOGFB5ILPhdNI2cbiv8t5ve8WKRCWKzj3ZCumtck
 vWLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:subject:date:message-id:mime-version;
 bh=bkKgaz073C6pfIBTewg/Fuu5z4jSBnnTmkl8sQ0aVG0=;
 b=qtfxB0qKLorUgba7EVPkM34Xy/gCKTjfvzKdl/LoCqebmi7CVFmJsf4OWwhK81ZqsX
 fVNGsEFE1sKPQNPgn1FrcPVFnHvkx4hBGqYVnqerYPo7TV3c1lS8y1hkHkIbJqBvhkZX
 7k8CbG9R1O3AaxIpN9q5rtR4r85es2Rir7oVMCLH9X8W9deEOWE3WM2TJ7zavrehjC+H
 rrP0X09Ej50zZgScVRKI7jqAqR/WeGeICtMBZa+MsYNemYAsYX6d55W/X99r9F6ud4Qz
 hFaiqLo/aPZR0147oHTy3CetjpU+XwizqaX6w6w7Ua71lLGkVAm3XeBgUsK9qI4vHDbJ
 CS1w==
X-Gm-Message-State: AOAM530X7CvYDuRm/2tRwbbyH5AZ/vtx6JczWszkDXm9Ey7Lg7jDphtt
 +MEAKxHUVVmYNqH74aM4vJd3vO2BGFI=
X-Google-Smtp-Source: ABdhPJy5hitYGRNuHvkXiTLEjbzIARm2uRDCEG8N54Oq5CtR8CCPxyBKggsQYGymlXMtKtmAm6A2GQ==
X-Received: by 2002:adf:a1cb:: with SMTP id v11mr3589392wrv.86.1603815149723; 
 Tue, 27 Oct 2020 09:12:29 -0700 (PDT)
Received: from guixSD (host-87-8-141-238.retail.telecomitalia.it.
 [87.8.141.238])
 by smtp.gmail.com with ESMTPSA id v9sm2326970wmh.23.2020.10.27.09.12.27
 for <guix-patches@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 27 Oct 2020 09:12:28 -0700 (PDT)
From: =?utf-8?Q?Nicol=C3=B2_Balzarotti?= <anothersms@HIDDEN>
To: guix-patches@HIDDEN
Subject: Add Network UPS Tools
Date: Tue, 27 Oct 2020 17:12:26 +0100
Message-ID: <87lffrmyvp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::436;
 envelope-from=anothersms@HIDDEN; helo=mail-wr1-x436.google.com
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.4 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi guix! This patch adds Network UPS Tools (nut). I could
 test that binaries run, but could not connect to a real UPS (I need to replace
 my UPSs as they are currently dead). Let me know if any of you can try! 
 Content analysis details:   (2.4 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (anothersms[at]gmail.com)
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
 [URI: nixo.xyz (xyz)]
 0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
 [209.51.188.17 listed in wl.mailspike.net]
 0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 1.7 SPOOFED_FREEMAIL       No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Hi guix! This patch adds Network UPS Tools (nut). I could
   test that binaries run, but could not connect to a real UPS (I need to replace
    my UPSs as they are currently dead). Let me know if any of you can try! 
 
 Content analysis details:   (2.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (anothersms[at]gmail.com)
  1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
  2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
                             [URI: nixo.xyz (xyz)]
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Hi guix!
This patch adds Network UPS Tools (nut).

I could test that binaries run, but could not connect to a real UPS (I
need to replace my UPSs as they are currently dead).

Let me know if any of you can try!

Thanks, Nicol=C3=B2


--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment; filename=0001-gnu-Add-nut.patch
Content-Transfer-Encoding: quoted-printable

From 0e3a16eb19bc481d38edbe36c241ec4631cbdd33 Mon Sep 17 00:00:00 2001
From: nixo <nicolo@HIDDEN>
Date: Tue, 27 Oct 2020 10:56:35 +0100
Subject: [PATCH] gnu: Add nut.

* gnu/packages/admin.scm (nut): New variable.
---
 gnu/packages/admin.scm | 64 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 8dcf8afd84..02dccd8021 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -35,6 +35,7 @@
 ;;; Copyright =C2=A9 2020 Michael Rohleder <mike@HIDDEN>
 ;;; Copyright =C2=A9 2020 Vincent Legoll <vincent.legoll@HIDDEN>
 ;;; Copyright =C2=A9 2020 Morgan Smith <Morgan.J.Smith@HIDDEN>
+;;; Copyright =C2=A9 2020 Nicol=C3=B2 Balzarotti <nicolo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -70,6 +71,7 @@
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autogen)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages avahi)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
@@ -85,6 +87,7 @@
   #:use-module (gnu packages elf)
   #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages freeipmi)
   #:use-module (gnu packages gawk)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gl)
@@ -110,6 +113,7 @@
   #:use-module (gnu packages mcrypt)
   #:use-module (gnu packages mpi)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages networking)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages patchutils)
   #:use-module (gnu packages pciutils)
@@ -880,6 +884,66 @@ IPv6, proxies, and Unix sockets.")
     (license (list license:bsd-3
                    license:bsd-2))))  ; atomicio.*, socks.c
=20
+(define-public nut
+  (package
+    (name "nut")
+    (version "2.7.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri "https://networkupstools.org/source/2.7/nut-2.7.4.tar.gz")
+       (sha256
+        (base32
+         "19r5dm07sfz495ckcgbfy0pasx0zy3faa0q7bih69lsjij8q43lq"))
+       (patches
+        (list
+         ;; OpenSSL 1.1 support
+         (origin
+           (method url-fetch)
+           (uri (string-append "https://patch-diff.githubusercontent.com/r=
aw/"
+                               "networkupstools/nut/pull/504.patch"))
+           (sha256
+            (base32 "1dabbzlmb886qy39xjx6nxlfrzfkm99n48la1ip32zm3baal6qph"=
))
+           (file-name (string-append name "-openssl1.1")))))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--with-all"
+                           "--with-openssl"
+                           ;; powerman is required (where is it hosted?)
+                           "--without-powerman"
+                           ;; cgi requires libgd
+                           "--without-cgi")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'update-configure
+           ;; required to apply the patch to the ./configure script
+           (lambda _
+             (invoke "autoconf"))))))
+    (native-inputs `(("autoconf" ,autoconf)
+                     ("cppunit" ,cppunit)
+                     ("pkg-config" ,pkg-config)))
+    (inputs `(("avahi" ,avahi)
+              ("libusb" ,libusb-compat)
+              ("libltdl" ,libltdl)
+              ("freeipmi" ,freeipmi)
+              ("neon" ,neon)
+              ("openssl" ,openssl)
+              ("net-snmp" ,net-snmp)))
+    (home-page "https://networkupstools.org")
+    (license
+     (list
+      ;; - most files under gpl2+
+      license:gpl2+
+      ;; - scripts/python/ under gpl3+
+      license:gpl3+
+      ;; - scripts/perl/Nut.pm same as perl (either gpl1+ or artistic)
+      license:gpl1+ license:artistic2.0))
+    (synopsis "Collection of programs for monitoring and administering UPS=
")
+    (description "Network UPS Tools is a collection of programs which prov=
ide
+a common interface for monitoring and administering UPS, PDU and SCD hardw=
are.
+It uses a layered approach to connect all of the parts.  Drivers are provi=
ded
+for a wide assortment of equipment.")))
+
 (define-public sipcalc
   (package
     (name "sipcalc")
--=20
2.28.0


--=-=-=--




Acknowledgement sent to Nicolò Balzarotti <anothersms@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#44258; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 30 Mar 2023 23:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.