GNU bug report logs - #44311
[PATCH] gnu: Add r-deconstructsigs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44311 in the body.
You can then email your comments to 44311 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aniket Patil <aniket112.patil <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Aniket Patil <aniket112.patil <at> gmail.com>
Subject: [PATCH] gnu: Add r-deconstructsigs.
Date: Thu, 29 Oct 2020 22:39:49 +0530

* gnu/packages/cran.scm (r-deconstructsigs): New variable.
---
 gnu/packages/cran.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 82caaf54f6..75d9ae7de2 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -24715,3 +24715,33 @@ modal regression and conditional density estimation in the
 presence/absence of measurement error. Bandwidth selection is 
 also provided for each method.")
     (license license:gpl2+)))
+
+(define-public r-deconstructsigs
+  (package
+    (name "r-deconstructsigs")
+    (version "1.8.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "deconstructSigs" version))
+        (sha256
+          (base32
+            "014x0nb23jb98666kaav2phkvmkr38pi38jv0dqd4jv7zp0gdf1a"))))
+    (properties
+      `((upstream-name . "deconstructSigs")))
+    (build-system r-build-system)
+    (propagated-inputs
+      `(("r-bsgenome" ,r-bsgenome)
+        ("r-bsgenome-hsapiens-ucsc-hg19"
+         ,r-bsgenome-hsapiens-ucsc-hg19)
+        ("r-genomeinfodb" ,r-genomeinfodb)
+        ("r-reshape2" ,r-reshape2)))
+    (home-page
+      "https://github.com/raerose01/deconstructSigs")
+    (synopsis "Identifies Signatures Present in a Tumor Sample")
+    (description
+      "Takes sample information in the form of the fraction of 
+mutations in each of 96 trinucleotide contexts and identifies 
+the weighted combination of published signatures that, when summed, 
+most closely reconstructs the mutational profile.")
+    (license license:gpl2+)))
-- 
2.28.0

Message #8 received at 44311 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Aniket Patil <aniket112.patil <at> gmail.com>, Ricardo Wurmus
 <rekado <at> elephly.net>
Cc: 44311 <at> debbugs.gnu.org
Subject: Re: [bug#44311] [PATCH] gnu: Add r-deconstructsigs.
Date: Tue, 22 Dec 2020 19:15:41 +0100

Hi Aniket,

(CC Ricardo since it could provide the correct gitlogy magic :-))

The patch does not apply because the file gnu/packages/cran.scm changed
in the meantime.  I am sorry that we have not been enough reactive.

However, when creating the patch, you had used the option ’--base’;
which really helps because I would be able to apply it and rebase
myself.

Currently, I do not know how to do without copy/pasting by hand, so
loosing your authorship.  Could you rebase on the top of master?

If you cannot, no worry.  Just let me know.


Ricardo, any tip to bypass this kind of issue?

On Thu, 29 Oct 2020 at 22:39, Aniket Patil <aniket112.patil <at> gmail.com> wrote:
> * gnu/packages/cran.scm (r-deconstructsigs): New variable.
> ---
>  gnu/packages/cran.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 82caaf54f6..75d9ae7de2 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -24715,3 +24715,33 @@ modal regression and conditional density estimation in the
>  presence/absence of measurement error. Bandwidth selection is 
>  also provided for each method.")
>      (license license:gpl2+)))
> +
> +(define-public r-deconstructsigs
> +  (package
> +    (name "r-deconstructsigs")
> +    (version "1.8.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (cran-uri "deconstructSigs" version))
> +        (sha256
> +          (base32
> +            "014x0nb23jb98666kaav2phkvmkr38pi38jv0dqd4jv7zp0gdf1a"))))
> +    (properties
> +      `((upstream-name . "deconstructSigs")))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +      `(("r-bsgenome" ,r-bsgenome)
> +        ("r-bsgenome-hsapiens-ucsc-hg19"
> +         ,r-bsgenome-hsapiens-ucsc-hg19)
> +        ("r-genomeinfodb" ,r-genomeinfodb)
> +        ("r-reshape2" ,r-reshape2)))
> +    (home-page
> +      "https://github.com/raerose01/deconstructSigs")
> +    (synopsis "Identifies Signatures Present in a Tumor Sample")
> +    (description
> +      "Takes sample information in the form of the fraction of 
> +mutations in each of 96 trinucleotide contexts and identifies 
> +the weighted combination of published signatures that, when summed, 
> +most closely reconstructs the mutational profile.")
> +    (license license:gpl2+)))

Cheers,
simon

Message #11 received at 44311 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 44311 <at> debbugs.gnu.org,
 Aniket Patil <aniket112.patil <at> gmail.com>
Subject: Re: [bug#44311] [PATCH] gnu: Add r-deconstructsigs.
Date: Tue, 22 Dec 2020 14:07:27 -0500

On Tue, Dec 22, 2020 at 07:15:41PM +0100, zimoun wrote:
> Currently, I do not know how to do without copy/pasting by hand, so
> loosing your authorship.  Could you rebase on the top of master?

`git commit` allows you to choose the author. In cases like this one, I
sometimes use that feature:

$ git commit --signoff --author="Aniket Patil <aniket112.patil <at> gmail.com>"

If you wanted to make it really seamless, you can also reset the date:

$ git commit --signoff --author="Aniket Patil <aniket112.patil <at> gmail.com>" --date="Thu, 29 Oct 2020 22:39:49 +0530"

Message #16 received at 44311-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Aniket Patil <aniket112.patil <at> gmail.com>
Cc: 44311-done <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#44311] [PATCH] gnu: Add r-deconstructsigs.
Date: Tue, 22 Dec 2020 23:38:30 +0100

Hi Aniket,

> * gnu/packages/cran.scm (r-deconstructsigs): New variable.

I’m sorry, but we need to drop this patch because
gnu/packages/bioconductor.scm already contains this definition.

“Already” really isn’t quite the right word, because you submitted your
patch before I added the definition to the bioconductor module when
Simon and I upgraded our CRAN and Bioconductor packages.

This package is in the bioconductor module because it depends on the
Bioconductor package r-bsgenome-hsapiens-ucsc-hg19.

-- 
Ricardo

Message #19 received at 44311-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>, Aniket Patil
 <aniket112.patil <at> gmail.com>
Cc: 44311-done <at> debbugs.gnu.org
Subject: Re: [bug#44311] [PATCH] gnu: Add r-deconstructsigs.
Date: Wed, 23 Dec 2020 09:51:51 +0100

Hi Aniket,

On Tue, 22 Dec 2020 at 23:38, Ricardo Wurmus <rekado <at> elephly.net> wrote:

>> * gnu/packages/cran.scm (r-deconstructsigs): New variable.
>
> I’m sorry, but we need to drop this patch because
> gnu/packages/bioconductor.scm already contains this definition.
>
> “Already” really isn’t quite the right word, because you submitted your
> patch before I added the definition to the bioconductor module when
> Simon and I upgraded our CRAN and Bioconductor packages.

Sorry Aniket to not have noticed and used your patch instead.

All the best,
simon

Message #22 received at 44311 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 44311 <at> debbugs.gnu.org,
 Aniket Patil <aniket112.patil <at> gmail.com>
Subject: Re: [bug#44311] [PATCH] gnu: Add r-deconstructsigs.
Date: Wed, 23 Dec 2020 09:49:44 +0100

Hi Leo,

On Tue, 22 Dec 2020 at 14:07, Leo Famulari <leo <at> famulari.name> wrote:
> On Tue, Dec 22, 2020 at 07:15:41PM +0100, zimoun wrote:
>> Currently, I do not know how to do without copy/pasting by hand, so
>> loosing your authorship.  Could you rebase on the top of master?
>
> `git commit` allows you to choose the author. In cases like this one, I
> sometimes use that feature:
>
> $ git commit --signoff --author="Aniket Patil <aniket112.patil <at> gmail.com>"
>
> If you wanted to make it really seamless, you can also reset the date:
>
> $ git commit --signoff --author="Aniket Patil <aniket112.patil <at> gmail.com>" --date="Thu, 29 Oct 2020 22:39:49 +0530"

Thank you.  Once you wrote it, it appears obvious. :-)
I have definitely lacked of imagination.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.