GNU bug report logs - #44345
[PATCH 1/2] gnu: Add r-metafor.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44345 in the body.
You can then email your comments to 44345 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aniket Patil <aniket112.patil <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Aniket Patil <aniket112.patil <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add r-metafor.
Date: Sat, 31 Oct 2020 20:38:50 +0530

* gnu/packages/cran.scm (r-metafor): New variable.
---
 gnu/packages/cran.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 75d9ae7de2..cc4e5f2bba 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -24745,3 +24745,42 @@ mutations in each of 96 trinucleotide contexts and identifies
 the weighted combination of published signatures that, when summed, 
 most closely reconstructs the mutational profile.")
     (license license:gpl2+)))
+
+(define-public r-metafor
+  (package
+    (name "r-metafor")
+    (version "2.4-0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "metafor" version))
+        (sha256
+          (base32
+            "1b599fxk7s0brkchmx698fr5k4g1kzkia2rnlvhg349ffs5nfjmn"))))
+    (properties `((upstream-name . "metafor")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-matrix" ,r-matrix)
+       ("r-nlme" ,r-nlme)))
+    (home-page
+      "https://cran.r-project.org/web/packages/metafor")
+    (synopsis "Meta-Analysis Package for R")
+    (description
+      "This package provides a comprehensive collection of 
+functions for conducting meta-analyses in R.  The package 
+includes functions to calculate various effect sizes or outcome 
+measures, fit fixed-, random-, and mixed-effects models to such 
+data, carry out moderator and meta-regression analyses, and create 
+various types of meta-analytical plots (e.g., forest, funnel, radial, 
+L'Abbe, Baujat, GOSH plots).  For meta-analyses of binomial and 
+person-time data, the package also provides functions that implement 
+specialized methods, including the Mantel-Haenszel method, Peto's 
+method, and a variety of suitable generalized linear (mixed-effects) 
+models (i.e., mixed-effects logistic and Poisson regression models).  
+Finally, the package provides functionality for fitting meta-analytic 
+multivariate/multilevel models that account for non-independent 
+sampling errors and/or true effects (e.g., due to the inclusion of 
+multiple treatment studies, multiple endpoints, or other forms of clustering).  
+Network meta-analyses and meta-analyses accounting for known correlation 
+structures (e.g., due to phylogenetic relatedness) can also be conducted.")
+    (license license:gpl2+)))
-- 
2.28.0

Message #10 received at 44345 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Aniket Patil <aniket112.patil <at> gmail.com>
Cc: 44345 <at> debbugs.gnu.org
Subject: Re: [bug#44345] [PATCH 1/2] gnu: Add r-metafor.
Date: Tue, 22 Dec 2020 19:28:27 +0100

Hi Aniket,

On Sat, 31 Oct 2020 at 20:38, Aniket Patil <aniket112.patil <at> gmail.com> wrote:
> * gnu/packages/cran.scm (r-metafor): New variable.
> ---
>  gnu/packages/cran.scm | 39 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 75d9ae7de2..cc4e5f2bba 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm

Idem than bug#44311.  <http://issues.guix.gnu.org/issue/44311>

Repeat here to easy the reading. :-)

The patch does not apply because the file gnu/packages/cran.scm changed
in the meantime.  I am sorry that we have not been enough reactive.

However, when creating the patch, you had used the option ’--base’;
which really helps because I would be able to apply it and rebase
myself.

Currently, I do not know how to do without copy/pasting by hand, so
loosing your authorship.  Could you rebase on the top of master?

If you cannot, no worry.  Just let me know.


All the best,
simon

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: guix-patches <at> gnu.org, 44345 <at> debbugs.gnu.org,
 Aniket Patil <aniket112.patil <at> gmail.com>
Subject: Re: [bug#44345] [PATCH 1/2] gnu: Add r-metafor.
Date: Tue, 22 Dec 2020 21:46:46 +0100

Hi Simon,

>
> On Sat, 31 Oct 2020 at 20:38, Aniket Patil <aniket112.patil <at> gmail.com> wrote:
>> * gnu/packages/cran.scm (r-metafor): New variable.
>> ---
>>  gnu/packages/cran.scm | 39 +++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>
>> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
>> index 75d9ae7de2..cc4e5f2bba 100644
>> --- a/gnu/packages/cran.scm
>> +++ b/gnu/packages/cran.scm
>
> Idem than bug#44311.  <http://issues.guix.gnu.org/issue/44311>
>
> Repeat here to easy the reading. :-)
>
> The patch does not apply because the file gnu/packages/cran.scm changed
> in the meantime.  I am sorry that we have not been enough reactive.

You can still apply the patch with “git am -C0” to ignore all context.
Sometimes with patches that add packages this works.

-- 
Ricardo

Message #21 received at 44345-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 44346-done <at> debbugs.gnu.org, Aniket Patil <aniket112.patil <at> gmail.com>,
 44345-done <at> debbugs.gnu.org
Subject: Re: [bug#44345] [PATCH 1/2] gnu: Add r-metafor.
Date: Tue, 22 Dec 2020 23:32:48 +0100

zimoun <zimon.toutoune <at> gmail.com> writes:

> Hi Aniket,
>
> On Sat, 31 Oct 2020 at 20:38, Aniket Patil <aniket112.patil <at> gmail.com> wrote:
>> * gnu/packages/cran.scm (r-metafor): New variable.
>> ---
>>  gnu/packages/cran.scm | 39 +++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>
>> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
>> index 75d9ae7de2..cc4e5f2bba 100644
>> --- a/gnu/packages/cran.scm
>> +++ b/gnu/packages/cran.scm
>
> Idem than bug#44311.  <http://issues.guix.gnu.org/issue/44311>
>
> Repeat here to easy the reading. :-)
>
> The patch does not apply because the file gnu/packages/cran.scm changed
> in the meantime.  I am sorry that we have not been enough reactive.

I applied the two patches with commit
6d1160db8e16ee0da5b38c5297cf22cd6dd230d6.

I used “git am -C0” to ignore mismatched context.  I also updated the
descriptions and re-indented the definitions.

-- 
Ricardo

Message #29 received at 44345-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 44346-done <at> debbugs.gnu.org, Aniket Patil <aniket112.patil <at> gmail.com>,
 44345-done <at> debbugs.gnu.org
Subject: Re: [bug#44345] [PATCH 1/2] gnu: Add r-metafor.
Date: Wed, 23 Dec 2020 09:47:27 +0100

Hi Ricardo,

On Tue, 22 Dec 2020 at 23:32, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> I applied the two patches with commit
> 6d1160db8e16ee0da5b38c5297cf22cd6dd230d6.
>
> I used “git am -C0” to ignore mismatched context.  I also updated the
> descriptions and re-indented the definitions.

Thanks for both, the tip and the patch application.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.