GNU bug report logs - #44427
[PATCH] lint: Add 'check-haskell-stackage' checker.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44427 in the body.
You can then email your comments to 44427 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] lint: Add 'check-haskell-stackage' checker.
Date: Tue, 03 Nov 2020 21:47:23 -0500

[Message part 1 (text/plain, inline)]

Hello!

After the most recent issue with Haskell package versions, I was
inspired to finally make it a bit better.  This patch adds a lint
checker to make sure that a Haskell package’s version is not ahead of
the desired Stackage LTS version!  The check itself is nice and simple,
but I also added a test that is anything but.

To make the test work, I made sure our Hackage and Stackage importers
use base URLs that are parameters.  Then, I used ‘with-http-server’ and
‘parameterize’d the URLs to use the local server.  (This all follows the
example of the SWH checker.)  It might be clearer if the test were split
in two, but the Stackage importer memoizes the list of packages sent
from the Stackage server.  That means that the two tests would have to
be run in a certain order to work, which is pretty dodgy.

Is the test too complicated to be worth it?  I might be able to make it
a little clearer, but I’m not sure it’s worth including at all.
Thoughts?


-- Tim

[0001-lint-Add-check-haskell-stackage-checker.patch (text/x-patch, attachment)]

Message #8 received at 44427 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timothy Sample <samplet <at> ngyro.com>
Cc: 44427 <at> debbugs.gnu.org
Subject: Re: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker.
Date: Wed, 18 Nov 2020 22:45:42 +0100

Hi Timothy,

Timothy Sample <samplet <at> ngyro.com> skribis:

> To make the test work, I made sure our Hackage and Stackage importers
> use base URLs that are parameters.  Then, I used ‘with-http-server’ and
> ‘parameterize’d the URLs to use the local server.  (This all follows the
> example of the SWH checker.)  It might be clearer if the test were split
> in two, but the Stackage importer memoizes the list of packages sent
> from the Stackage server.  That means that the two tests would have to
> be run in a certain order to work, which is pretty dodgy.
>
> Is the test too complicated to be worth it?  I might be able to make it
> a little clearer, but I’m not sure it’s worth including at all.
> Thoughts?

I think it’s fine.

>>From 7e01e8adddeaba7a2c0b3a79425da26f3c2584df Mon Sep 17 00:00:00 2001
> From: Timothy Sample <samplet <at> ngyro.com>
> Date: Tue, 3 Nov 2020 15:30:28 -0500
> Subject: [PATCH] lint: Add 'check-haskell-stackage' checker.
>
> * guix/lint.scm (check-haskell-stackage): New procedure.
> (%network-dependent-checkers): Add 'haskell-stackage' checker.
> * guix/import/hackage.scm (%hackage-url): New variable.
> (hackage-source-url, hackage-cabal-url): Use it in place of a
> hard-coded string.
> * guix/import/stackage.scm (%stackage-url): Make it a parameter.
> (stackage-lts-info-fetch): Update accordingly.
> * tests/lint.scm ("hackage-stackage"): New test.

LGTM, thank you!

‘%stackage-updater’ only offers versions that are in LTS Stackage,
right?

Ludo’.

Message #13 received at 44427-done <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44427-done <at> debbugs.gnu.org
Subject: Re: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker.
Date: Sat, 21 Nov 2020 22:21:38 -0500

Hello!

Ludovic Courtès <ludo <at> gnu.org> writes:

> LGTM, thank you!

Thanks for the review!

> ‘%stackage-updater’ only offers versions that are in LTS Stackage,
> right?

Yup.  It tracks the version of LTS Stackage that corresponds to our
version of GHC.


-- Tim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.