GNU bug report logs - #44457
[PATCH]: gnu: Add hunspell-dict-it-it.

Previous Next

Package: guix-patches;

Reported by: paul <goodoldpaul <at> autistici.org>

Date: Thu, 5 Nov 2020 01:23:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44457 in the body.
You can then email your comments to 44457 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Thu, 05 Nov 2020 01:23:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to paul <goodoldpaul <at> autistici.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 05 Nov 2020 01:23:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Subject: [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Thu, 5 Nov 2020 02:22:34 +0100
[Message part 1 (text/plain, inline)]
Dear Guixers,

as discussed here [0] and [1], I'm sending a patch to add a new 
hunspell.scm file to store hunspell dictionaries and an Italian 
dictionary. I tried to make my implementation reusable by other 
languages by defining a function that produces dictionary packages.

If there is consensus I can move other hunspell dictionaries to the new 
file and/or convert them to use the new function.

Thank you for your review.

Cheers,

Giacomo


[0]: https://issues.guix.gnu.org/42474

[1]: https://lists.nongnu.org/archive/html/guix-devel/2020-11/msg00000.html

[0001-gnu-Add-hunspell-dict-it-it.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Thu, 05 Nov 2020 15:32:01 GMT) Full text and rfc822 format available.

Message #8 received at 44457 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 44457 <at> debbugs.gnu.org
Subject: [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Thu, 5 Nov 2020 16:31:01 +0100
> Subject: [PATCH] gnu: Add hunspell-dict-it-it.

In theory you could it split into two commits: one for the
hunspell-dictionary function and the other for the italian dict. But I
think it's okay so.

> +    (build-system gnu-build-system)
> +    (arguments

Maybe it would be an idea to (build-system trivial-build-system) instead?

> +(define-public hunspell-dict-it-it

If there is only one language version like with Italian, I think it
would be nicer to have it name `hunspell-dict-it`. But I guess it makes
the code a bit more complicated.

> +  (let ((home-page "https://libreitalia.org/")
> +        (license license:gpl3))
> +    (hunspell-dictionary "it_IT" "Italian"
> +                         #:home-page home-page
> +                         #:license license)))

For me the let feels a bit useless...

hunspell-dict-it-it builds and installs fine. It works in LibreOffice
just fine!

~Jonathan




Information forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Sat, 07 Nov 2020 01:21:01 GMT) Full text and rfc822 format available.

Message #11 received at 44457 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: 44457 <at> debbugs.gnu.org
Subject: Re: [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Sat, 7 Nov 2020 02:20:02 +0100
[Message part 1 (text/plain, inline)]
Hi Jonathan,

I'm attaching an updated patch.

I changed the build system to trivial and removed the useless let (I 
must admit I forgot it there). About the variable naming, technically 
there is also it_CH: the Italian spoke in a region of Switzerland. In 
the Libreoffice repository there's still no dedicated dictionary but it 
could be uploaded in the future, so I'd keep the variable naming. What 
do you think?

Thank you for your review,

Cheers

Giacomo

[0001-gnu-Add-hunspell-dict-it-it.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Mon, 30 Nov 2020 23:29:01 GMT) Full text and rfc822 format available.

Message #14 received at 44457 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: 44457 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add hunspell-dict-it-it.
Date: Tue, 1 Dec 2020 00:28:15 +0100
Hi,

I'm leaving here a friendly ping :). Thank you for your time.

Cheers,

Giacomo





Information forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Wed, 23 Dec 2020 16:31:02 GMT) Full text and rfc822 format available.

Message #17 received at 44457 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: paul <goodoldpaul <at> autistici.org>
Cc: 44457 <at> debbugs.gnu.org
Subject: Re: [bug#44457] [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Wed, 23 Dec 2020 17:29:55 +0100
Hi!

paul <goodoldpaul <at> autistici.org> skribis:

> From 17a476dd234fa4a128eb90ccc8ac9a565045bfa1 Mon Sep 17 00:00:00 2001
> From: Giacomo Leidi <goodoldpaul <at> autistici.org>
> Date: Thu, 5 Nov 2020 02:04:20 +0100
> Subject: [PATCH] gnu: Add hunspell-dict-it-it.
>
> * gnu/packages/hunspell.scm: New file;
> (hunspell-dictionary): New variable;
> (hunspell-dict-it-it): New variable.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

I’m picking up this patch as it seems to have fallen through the
cracks.  :-)

Overall it LGTM; a couple of comments below.

Apparently this is different from the Hunspell dictionaries made from
Aspell word lists that appear in (gnu packages aspell), right?

Should we name the packages differently to avoid collisions with the
existing ‘hunspell-dict-*’ packages?

[...]

> +    (synopsis
> +     (string-append "Hunspell dictionary for " full-name " (" dict-name ")"))

This is recommended against as this prevents i18n:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

You can work around it by writing the string in full, as in:

  (define-public hunspell-dict-it-it
    (let ((synopsis identity))
      (hunspell-dictionary "it_IT" "Italian"
                           #:synopsis (synopsis "Hunspell dictionary for Italian")
                           #:home-page "https://libreitalia.org/"
                           #:license license:gpl3)))


> +                       #:license license:gpl3))

It wondered whether this might be ‘gpl3+’, but
<https://cgit.freedesktop.org/libreoffice/dictionaries/tree/it_IT/README_it_IT.txt>
confirms that this is “version 3 only”; all good!  :-)

Could you send an updated patch?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#44457; Package guix-patches. (Wed, 23 Dec 2020 19:16:02 GMT) Full text and rfc822 format available.

Message #20 received at 44457 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44457 <at> debbugs.gnu.org
Subject: Re: [bug#44457] [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Wed, 23 Dec 2020 20:15:11 +0100
[Message part 1 (text/plain, inline)]
Hi Ludo’ !

On 12/23/20 5:29 PM, Ludovic Courtès wrote:
> Hi!
>
> paul <goodoldpaul <at> autistici.org> skribis:
>
>>  From 17a476dd234fa4a128eb90ccc8ac9a565045bfa1 Mon Sep 17 00:00:00 2001
>> From: Giacomo Leidi <goodoldpaul <at> autistici.org>
>> Date: Thu, 5 Nov 2020 02:04:20 +0100
>> Subject: [PATCH] gnu: Add hunspell-dict-it-it.
>>
>> * gnu/packages/hunspell.scm: New file;
>> (hunspell-dictionary): New variable;
>> (hunspell-dict-it-it): New variable.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> I’m picking up this patch as it seems to have fallen through the
> cracks.  :-)
Definitely not a problem but still thanks a lot :)
>
> Overall it LGTM; a couple of comments below.
>
> Apparently this is different from the Hunspell dictionaries made from
> Aspell word lists that appear in (gnu packages aspell), right?
>
> Should we name the packages differently to avoid collisions with the
> existing ‘hunspell-dict-*’ packages?

We definitely can but if I understood correctly they are generated from 
STOW wordlists [0] which seems to contain only variants of the English 
language.

Since also the Libreoffice repository contains some of those variants, I 
was wondering, to achieve better consistency with future dictionaries, 
if it's worth either

- to migrate the duplicates to use (hunspell-dictionary) from (gnu 
packages hunspell)

- or just to use STOW for the English language and its variants and 
Libreoffice dictionaries for all the supported languages

I believe either way we should be able to avoid collisions, but maybe I 
should just rename this one dictionary and, after we reach consensus, we 
can always decide to change it back. What do you think?

Should I move this discussion to guix-devel?

>> +    (synopsis
>> +     (string-append "Hunspell dictionary for " full-name " (" dict-name ")"))
> This is recommended against as this prevents i18n:
>
>    https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

I apologize about this, I attached an updated patch.


Thank you for your time,

Cheers


Giacomo


[0]: http://wordlist.aspell.net/scowl-readme/

[0001-gnu-Add-hunspell-dict-it-it.patch (text/x-patch, attachment)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 27 Dec 2020 15:18:02 GMT) Full text and rfc822 format available.

Notification sent to paul <goodoldpaul <at> autistici.org>:
bug acknowledged by developer. (Sun, 27 Dec 2020 15:18:02 GMT) Full text and rfc822 format available.

Message #25 received at 44457-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: paul <goodoldpaul <at> autistici.org>
Cc: 44457-done <at> debbugs.gnu.org
Subject: Re: [bug#44457] [PATCH]: gnu: Add hunspell-dict-it-it.
Date: Sun, 27 Dec 2020 16:17:25 +0100
Hi,

paul <goodoldpaul <at> autistici.org> skribis:

> We definitely can but if I understood correctly they are generated
> from STOW wordlists [0] which seems to contain only variants of the
> English language.

Oh right.

> Since also the Libreoffice repository contains some of those variants,
> I was wondering, to achieve better consistency with future
> dictionaries, if it's worth either
>
> - to migrate the duplicates to use (hunspell-dictionary) from (gnu
>   packages hunspell)
>
> - or just to use STOW for the English language and its variants and
>   Libreoffice dictionaries for all the supported languages
>
> I believe either way we should be able to avoid collisions, but maybe
> I should just rename this one dictionary and, after we reach
> consensus, we can always decide to change it back. What do you think?

I think it’s fine this way, I hadn’t realized that the hunspell-dict-*
from aspell.scm were English only.

Now, I just noticed that libreoffice.scm also :-) comes with
huspell-dict-* packages, which are built from yet other sources (primary
sources it seems, rather than LibreOffice).

I’ve applied this patch, but perhaps we should now move those
dictionaries from libreoffice.scm to hunspell.scm?

Thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 25 Jan 2021 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 63 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.