GNU bug report logs - #44503
27.1; image-scroll-up and image-scroll-down

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: "Roland Winkler" <winkler@HIDDEN>; dated Sat, 7 Nov 2020 15:17:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 44503 <at> debbugs.gnu.org:


Received: (at 44503) by debbugs.gnu.org; 9 Nov 2020 20:03:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 09 15:03:30 2020
Received: from localhost ([127.0.0.1]:35635 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kcDNy-0003fW-4e
	for submit <at> debbugs.gnu.org; Mon, 09 Nov 2020 15:03:30 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44392)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <winkler@HIDDEN>) id 1kcDNx-0003fK-0X
 for 44503 <at> debbugs.gnu.org; Mon, 09 Nov 2020 15:03:29 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50033)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <winkler@HIDDEN>) id 1kcDNr-0003xv-P9
 for 44503 <at> debbugs.gnu.org; Mon, 09 Nov 2020 15:03:23 -0500
Received: from [2602:30a:2e52:d720:65b7:1416:12e7:8bfb] (port=51386
 helo=regnitz)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <winkler@HIDDEN>)
 id 1kcDNq-00014F-AD; Mon, 09 Nov 2020 15:03:22 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <41096.42019.863060.24489@HIDDEN>
Date: Mon, 9 Nov 2020 14:03:20 -0600
From: "Roland Winkler" <winkler@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#44503: 27.1; image-scroll-up and image-scroll-down
In-Reply-To: <835z6h6ved.fsf@HIDDEN>
References: <47686.12087.468202.24486@HIDDEN>
 <835z6h6ved.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 44503
Cc: 44503 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On Sat Nov 7 2020 Eli Zaretskii wrote:
> Thanks.  Can you suggest the changes to the relevant doc strings?

Digging in the sources, I realized that using raw prefix args 
includes not only image-scroll-up and image-scroll-down but also the
built-in functions scroll-up and scroll-down.  I'll try to come up
with a patch that covers all relevant doc strings.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#44503; Package emacs. Full text available.

Message received at 44503 <at> debbugs.gnu.org:


Received: (at 44503) by debbugs.gnu.org; 7 Nov 2020 15:26:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 07 10:26:10 2020
Received: from localhost ([127.0.0.1]:59084 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kbQ6U-0000Py-3y
	for submit <at> debbugs.gnu.org; Sat, 07 Nov 2020 10:26:10 -0500
Received: from eggs.gnu.org ([209.51.188.92]:47372)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kbQ6S-0000Pm-0w
 for 44503 <at> debbugs.gnu.org; Sat, 07 Nov 2020 10:26:08 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59939)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>) id 1kbQ6M-00076l-Pz
 for 44503 <at> debbugs.gnu.org; Sat, 07 Nov 2020 10:26:02 -0500
Received: from [176.228.60.248] (port=3930 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kbQ6L-0002Su-7e; Sat, 07 Nov 2020 10:26:01 -0500
Date: Sat, 07 Nov 2020 17:26:02 +0200
Message-Id: <835z6h6ved.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: "Roland Winkler" <winkler@HIDDEN>
In-Reply-To: <47686.12087.468202.24486@HIDDEN> (winkler@HIDDEN)
Subject: Re: bug#44503: 27.1; image-scroll-up and image-scroll-down
References: <47686.12087.468202.24486@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 44503
Cc: 44503 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sat, 7 Nov 2020 09:16:22 -0600
> From: "Roland Winkler" <winkler@HIDDEN>
> 
> 
> My understanding of the doc strings of image-scroll-up and
> image-scroll-down is that the argument N should be a number, nil, or
> `-'."  However, these commands use (interactive "P") with
> prefix-numeric-value inside the body of these commands.  I suggest
> to document this behavior.  (I guess it is not very clean to use
> prefix-numeric-value inside the body of these commands.  But
> changing this behavior likely will break existing code that uses
> these commands.)
> 
> I realized this when I looked at doc-view's scrolling commands
> doc-view-scroll-up-or-next-page and
> doc-view-scroll-down-or-previous-page
> that likewise use (interactive "P"), contrary, to what the
> docstrings of these commands say, and I was surprised that this
> gives a meaningful behavior.  So these docstrings probably should be
> updated, too.

Thanks.  Can you suggest the changes to the relevant doc strings?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#44503; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Nov 2020 15:16:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 07 10:16:49 2020
Received: from localhost ([127.0.0.1]:59079 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kbPxR-0000BV-4a
	for submit <at> debbugs.gnu.org; Sat, 07 Nov 2020 10:16:49 -0500
Received: from lists.gnu.org ([209.51.188.17]:38148)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <winkler@HIDDEN>) id 1kbPxQ-0000BO-4a
 for submit <at> debbugs.gnu.org; Sat, 07 Nov 2020 10:16:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:45744)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <winkler@HIDDEN>) id 1kbPxP-00029O-VI
 for bug-gnu-emacs@HIDDEN; Sat, 07 Nov 2020 10:16:47 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59817)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <winkler@HIDDEN>) id 1kbPxP-0003mH-Ls
 for bug-gnu-emacs@HIDDEN; Sat, 07 Nov 2020 10:16:47 -0500
Received: from [2602:30a:2e52:d720:65b7:1416:12e7:8bfb] (port=48280
 helo=regnitz)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <winkler@HIDDEN>) id 1kbPxO-0001er-Qw
 for bug-gnu-emacs@HIDDEN; Sat, 07 Nov 2020 10:16:47 -0500
Message-ID: <47686.12087.468202.24486@HIDDEN>
Date: Sat, 7 Nov 2020 09:16:22 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: "Roland Winkler" <winkler@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.1; image-scroll-up and image-scroll-down
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


My understanding of the doc strings of image-scroll-up and
image-scroll-down is that the argument N should be a number, nil, or
`-'."  However, these commands use (interactive "P") with
prefix-numeric-value inside the body of these commands.  I suggest
to document this behavior.  (I guess it is not very clean to use
prefix-numeric-value inside the body of these commands.  But
changing this behavior likely will break existing code that uses
these commands.)

I realized this when I looked at doc-view's scrolling commands
doc-view-scroll-up-or-next-page and
doc-view-scroll-down-or-previous-page
that likewise use (interactive "P"), contrary, to what the
docstrings of these commands say, and I was surprised that this
gives a meaningful behavior.  So these docstrings probably should be
updated, too.


In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2020-08-31 built on regnitz
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: Ubuntu 16.04.7 LTS





Acknowledgement sent to "Roland Winkler" <winkler@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#44503; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 9 Nov 2020 20:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.