GNU bug report logs - #44518
gnu: Add matterhorn.

Previous Next

To reply to this bug, email your comments to 44518 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: elaexuotee <at> wilsonb.com
To: guix-patches <at> gnu.org
Subject: gnu: Add matterhorn.
Date: Sun, 08 Nov 2020 21:53:24 +0900

[Message part 1 (text/plain, inline)]

Hey Guix,

This packages up a nice CLI client for Mattermost chat servers (a self-hosted,
libre Slack alternative).

Anyway, it's a Haskell package and ended up requiring quite a few
dependendencies along with a few version-updated alternatives to existing
packages.

The attached patch bundles all these up together, but what is the appropriate
convention in this case?

The bulk of the work is completely thanks to the hackage importer, but I did
spend quite a bit of time cleaning these up and sanity checking things.
Everything should pass the lint checks as well as indentation.

Also, for two packages, I had to disable tests. There are comments explaining
why in each case.

Let me know what you think!

[0001-gnu-Add-matterhorn.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: <elaexuotee <at> wilsonb.com>, <guix-patches <at> gnu.org>
Subject: Re: gnu: Add matterhorn.
Date: Sat, 10 Sep 2022 13:06:40 +0100

Hi,

This patch must have slipped through the cracks, but it was mentioned
on IRC today, so I decided to do a little review :)

First of all,

(1) You should have one commit per package.
(2) It's better, though not required, to use the procedure described here[1]
    to send patches, instead of using attachments. This makes it much easier
    to annotate the patch with review comments, at least here in aerc :)

[1] https://paste.sr.ht/~unmatched-paren/9114b1fa3d2088c7c71307dcae0d9e2b3620eb0c

> +    (inputs
> +     `(("ghc-random" ,ghc-random)
> +       ("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-semigroupoids" ,ghc-semigroupoids)))

You should use the "new style" of inputs:

> +    (inputs
> +     (list ghc-random
> +           ghc-quickcheck
> +           ghc-semigroupoids))

Same for any native- and propagated- inputs.

> +    (arguments
> +     `(#:cabal-revision
> +       ("3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))

There's also a new arguments style:

> +    (arguments
> +     (list #:cabal-revision
> +           (list "3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))

> +    (description
> +     "This library is intended to be a comprehensive solution to parsing and
> +selecting quality-indexed values in HTTP headers.  It is capable of parsing
> +both media types and language parameters from the Accept and Content header
> +families, and can be extended to match against other accept headers as well.
> +Selecting the appropriate header value is achieved by comparing a list of
> +server options against the quality-indexed values supplied by the client.")

This is a wee bit too long IMO.

    -- (

Message #11 received at 44518 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "(" <paren <at> disroot.org>, elaexuotee <at> wilsonb.com, 44518 <at> debbugs.gnu.org
Subject: Re: [bug#44518] gnu: Add matterhorn.
Date: Mon, 12 Sep 2022 18:47:39 +0200

[Message part 1 (text/plain, inline)]

On 10-09-2022 14:06, ( via Guix-patches via wrote:
>> ription
>> +     "This library is intended to be a comprehensive solution to parsing and
>> +selecting quality-indexed values in HTTP headers.  It is capable of parsing
>> +both media types and language parameters from the Accept and Content header
>> +families, and can be extended to match against other accept headers as well.
>> +Selecting the appropriate header value is achieved by comparing a list of
>> +server options against the quality-indexed values supplied by the client.")
> This is a wee bit too long IMO.
> 
>      -- (
> 

Myself, I consider the length to be about perfect -- it isn't verbosely 
worded, it is only a single paragraph and it clearly explains what it 
can do.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #14 received at 44518 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu <matf <at> disr.it>
To: 44518 <at> debbugs.gnu.org
Subject: Re: gnu: Add matterhorn.
Date: Fri, 4 Nov 2022 16:11:09 +0100

Do you receive email notifications from here, elaexuotee, and are you by any chance still an active Guix user? Matterhorn would be a great addition to Guix packages.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.