GNU bug report logs - #44605
Support MACOSX_DEPLOYMENT_TARGET=11.0

Previous Next

To reply to this bug, email your comments to 44605 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Isuru Fernando <isuruf <at> gmail.com>
To: bug-libtool <at> gnu.org
Subject: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Thu, 12 Nov 2020 13:39:14 -0600

[Message part 1 (text/plain, inline)]

Hello maintainers,

I noticed that when MACOSX_DEPLOYMENT_TARGET=11.0 is set "-Wl,-undefined"
flag is not set
because of a check in m4/libtool/m4 at
http://git.savannah.gnu.org/cgit/libtool.git/tree/m4/libtool.m4?id=b9b44533fbf7c7752ffd255c3d09cc360e24183b#n1074
that only checks for 10.*. A fix would be to check for both 10.* and 11.*

I can send a patch if you prefer.

Isuru

[Message part 2 (text/html, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Schmidt <libtool <at> ryandesign.com>
To: Isuru Fernando <isuruf <at> gmail.com>
Cc: bug-libtool <at> gnu.org
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Sun, 15 Nov 2020 10:04:23 -0600

On Nov 12, 2020, at 13:39, Isuru Fernando wrote:

> I noticed that when MACOSX_DEPLOYMENT_TARGET=11.0 is set "-Wl,-undefined" flag is not set
> because of a check in m4/libtool/m4 at http://git.savannah.gnu.org/cgit/libtool.git/tree/m4/libtool.m4?id=b9b44533fbf7c7752ffd255c3d09cc360e24183b#n1074
> that only checks for 10.*. A fix would be to check for both 10.* and 11.*
> 
> I can send a patch if you prefer.

An Apple engineer patched this problem in the MacPorts libtool port this way:

https://github.com/macports/macports-ports/blob/ecad44f48d8ccd74e7c2fbb86c6b0ad2c9856b78/devel/libtool/files/dynamic_lookup-11.patch

We have been needing to copy similar patches to many other ports since their configure scripts were infected with the problem when they were baked.

However please see my additional comments here about a change needed for PowerPC:

https://github.com/macports/macports-ports/commit/ecad44f48d8ccd74e7c2fbb86c6b0ad2c9856b78#r41264904

Hopefully someone else can look at both the original patch and my modification and come to a conclusion about what is the right fix to include in libtool.

Then hopefully a new release of libtool can be made quickly, since macOS 11 has been publicly released and this problem affects a *lot* of software.

Message #11 received at 44605 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Schmidt <libtool <at> ryandesign.com>
To: 44605 <at> debbugs.gnu.org
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Sun, 15 Nov 2020 10:05:37 -0600

On Nov 12, 2020, at 13:39, Isuru Fernando wrote:

> I noticed that when MACOSX_DEPLOYMENT_TARGET=11.0 is set "-Wl,-undefined" flag is not set
> because of a check in m4/libtool/m4 at http://git.savannah.gnu.org/cgit/libtool.git/tree/m4/libtool.m4?id=b9b44533fbf7c7752ffd255c3d09cc360e24183b#n1074
> that only checks for 10.*. A fix would be to check for both 10.* and 11.*
> 
> I can send a patch if you prefer.

An Apple engineer patched this problem in the MacPorts libtool port this way:

https://github.com/macports/macports-ports/blob/ecad44f48d8ccd74e7c2fbb86c6b0ad2c9856b78/devel/libtool/files/dynamic_lookup-11.patch

We have been needing to copy similar patches to many other ports since their configure scripts were infected with the problem when they were baked.

However please see my additional comments here about a change needed for PowerPC:

https://github.com/macports/macports-ports/commit/ecad44f48d8ccd74e7c2fbb86c6b0ad2c9856b78#r41264904

Hopefully someone else can look at both the original patch and my modification and come to a conclusion about what is the right fix to include in libtool.

Then hopefully a new release of libtool can be made quickly, since macOS 11 has been publicly released and this problem affects a *lot* of software.

Message #14 received at 44605 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Schmidt <libtool <at> ryandesign.com>
To: 44605 <at> debbugs.gnu.org
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Fri, 8 Jan 2021 11:23:50 -0600

Hearing no objections, I have modified the MacPorts patch per my earlier remarks, and I believe this is now the final patch that should be applied to upstream libtool sources:

https://github.com/macports/macports-ports/blob/fc9e323525ecd0d4fbf18eabada4c53ba415b450/devel/libtool/files/dynamic_lookup-11.patch

In case anyone is wondering about the logic being used here, the goal of this code has always been to build with "-flat_namespace -undefined suppress" when targeting Mac OS X 10.2 and earlier and to build with "-undefined dynamic_lookup" when targeting Mac OS X 10.3 and later. If the MACOSX_DEPLOYMENT_TARGET environment variable is specified, then the decision is based on that. If not, then the decision is based on $host and it follows what the default behavior would be on that host if no deployment target were specified. On PowerPC Mac OS X 10.1-10.4 (Darwin 5 through 8), the default deployment target is 10.1. On PowerPC Mac OS X 10.5 (Darwin 9) and on all OS versions on non-PowerPC architectures, the default deployment target is the first two components of the OS version (i.e. 10.4 on 10.4.x, 10.5 on 10.5.x, etc.).

Message #17 received at 44605 <at> debbugs.gnu.org (full text, mbox):

From: Brad Warren <bmw <at> eff.org>
To: "44605 <at> debbugs.gnu.org" <44605 <at> debbugs.gnu.org>
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Wed, 18 Aug 2021 17:18:16 +0000

Are there any plans to apply the patch in the thread here directly to libtool? Doing so would also fix #44684.

In addition to MacPorts continuing to use this patch, Homebrew is using a nearly identical patch at https://github.com/Homebrew/formula-patches/blob/master/libtool/dynamic_lookup-11.patch which seems to be working well.

Message #20 received at 44605 <at> debbugs.gnu.org (full text, mbox):

From: Alex Ameen <alex.ameen.tx <at> gmail.com>
To: 44605 <at> debbugs.gnu.org
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Sun, 21 Nov 2021 20:27:34 -0600

Hey sorry for the radio silence. libtool was without a maintainer for a 
bit, but I just adopted recently and have been working my way through 
the bug/patch lists.

Did y'all ever reach consensus about the effect of Ryan's addition?

-    10.[012],*|,*powerpc*)
+    10.[012],*|,*powerpc*-darwin[5-8]*)

Since I saw that the Macports and Homebrew folks both landed on 
identical patches I'll plan on merging that for now.

Thanks for your help on this.

Message #23 received at 44605 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Schmidt <libtool <at> ryandesign.com>
To: Alex Ameen <alex.ameen.tx <at> gmail.com>
Cc: 44605 <at> debbugs.gnu.org
Subject: Re: bug#44605: Support MACOSX_DEPLOYMENT_TARGET=11.0
Date: Thu, 9 Dec 2021 07:11:11 -0600

Alex,

Thanks for picking up libtool and for merging these changes.

Jeremy who authored the original patch didn't respond to my proposal (he hasn't been as active in open source software in recent years) but I stand by my version of the patch. I explained earlier in this bug report the intended behavior of the code, so if anybody sees a bug in the code such that it does not do what is intended they should speak up.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.