GNU bug report logs - #44651
[PATCH] Silence byte-compiler warning

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44651 in the body.
You can then email your comments to 44651 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Silence byte-compiler warning
Date: Sun, 15 Nov 2020 03:39:29 +0100 (CET)

[Message part 1 (text/plain, inline)]

See attached.

-- 
Sent with https://mailfence.com
Secure and private email

[0001-Silence-byte-compiler-warning.patch (text/x-diff, attachment)]

Message #8 received at 44651 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 44651 <at> debbugs.gnu.org
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
Date: Mon, 16 Nov 2020 23:46:05 +0100

Brian Leung <leungbk <at> mailfence.com> writes:

> See attached.

[...]

> * lisp/woman.el: Declare imenu-add-to-menubar.

I don't think that should be necessary?  The function in question is
autoloaded:

;;;###autoload
(defun imenu-add-to-menubar (name)

Where/when do you see this compilation warning?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 44651 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, akrl <at> sdf.org
Cc: 44651 <at> debbugs.gnu.org
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
Date: Tue, 17 Nov 2020 00:52:41 +0100 (CET)

> I don't think that should be necessary?  The function in question is
> autoloaded:
> 
> ;;;###autoload
> 
> Where/when do you see this compilation warning?

I noticed this on the feature/native-comp branch, after invoking `helm-man-woman` and having woman.el native-compiled asynchronously. I don't have the log.

I did not notice that it was autoloaded. Andrea, are you aware of any issues that the native-comp branch may have with this kind of thing (autoloaded functions defined in files that do not necessarily get REQUIRE-d)? If not, maybe we can just ignore my patch.

Thanks,
Brian

> ----------------------------------------
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Sent: Mon Nov 16 23:46:05 CET 2020
> To: Brian Leung <leungbk <at> mailfence.com>
> Cc: <44651 <at> debbugs.gnu.org>
> Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
> 
> 
> Brian Leung <leungbk <at> mailfence.com> writes:
> 
> > See attached.
> 
> [...]
> 
> > * lisp/woman.el: Declare imenu-add-to-menubar.
> 
> I don't think that should be necessary?  The function in question is
> autoloaded:
> 
> ;;;###autoload
> (defun imenu-add-to-menubar (name)
> 
> Where/when do you see this compilation warning?
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no


-- 
Sent with https://mailfence.com
Secure and private email

Message #16 received at 44651 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 44651 <at> debbugs.gnu.org, akrl <at> sdf.org
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
Date: Tue, 17 Nov 2020 01:58:00 +0100

Brian Leung <leungbk <at> mailfence.com> writes:

> I did not notice that it was autoloaded. Andrea, are you aware of any
> issues that the native-comp branch may have with this kind of thing
> (autoloaded functions defined in files that do not necessarily get
> REQUIRE-d)? If not, maybe we can just ignore my patch.

I'm getting the same with a number of functions on the native-comp branch:

In end of data:
woman.el:4615:1: Warning: the function ‘imenu-add-to-menubar’ might not be
    defined at runtime.

This function is in lisp/loaddefs.el, though.

Other examples:

In end of data:
calc-units.el:2171:1: Warning: the following functions might not be defined at
    runtime: math-is-multiple, math-simplify, math-to-simple-fraction


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 44651 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: 44651 <at> debbugs.gnu.org, akrl <at> sdf.org
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
Date: Mon, 14 Dec 2020 18:15:54 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I'm getting the same with a number of functions on the native-comp branch:
>
> In end of data:
> woman.el:4615:1: Warning: the function ‘imenu-add-to-menubar’ might not be
>     defined at runtime.

This was fixed recently on the native-comp branch, so I'm closing this
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.