GNU bug report logs - #44651
[PATCH] Silence byte-compiler warning

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Brian Leung <leungbk@HIDDEN>; Keywords: patch moreinfo; dated Sun, 15 Nov 2020 02:40:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 44651 <at> debbugs.gnu.org:


Received: (at 44651) by debbugs.gnu.org; 16 Nov 2020 23:52:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 16 18:52:54 2020
Received: from localhost ([127.0.0.1]:57790 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1keoIo-0005x2-35
	for submit <at> debbugs.gnu.org; Mon, 16 Nov 2020 18:52:54 -0500
Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:60886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leungbk@HIDDEN>) id 1keoIk-0005wk-Cz
 for 44651 <at> debbugs.gnu.org; Mon, 16 Nov 2020 18:52:52 -0500
Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36])
 by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id CBAAA942;
 Tue, 17 Nov 2020 00:52:43 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com;
 s=20160819-nLV10XS2; t=1605570763;
 bh=cBAnxdxPOhv7sZ5L7dnrfzo1XOGhYvK3XtNvLprmC/o=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From;
 b=oF0kHfs6EjbKaJxnK3aJLocdTVVDbNtG9OM4JfpJnw3IbwL4o0aFcjSWY45FBb6iY
 bGEjaiHn+5sQG64U+93YaQsoALCO5CkVaGEmnIlyprZLxzanT0IIybN+RCaeCpgXVj
 Lxmxw0NvDCTF9TdtmmZ6QLTeIz7GdRArTlkRiabjWmry17hb6x8Voz/Yd7PRoQtFWS
 hiND07FyLuDkV/5SihZzI+OkGe+Cfs6awHAZt9mFmvCDDIPaNys4KkGV3i1RPdpjFF
 Bt7gWwqDiUwYaK17DbvlKhym4fYR0DZjj+TMfmgEO3fF1rK7cyq/4p+3D7PJSg/zZK
 EXgPRhaYUPFAQ==
Date: Tue, 17 Nov 2020 00:52:41 +0100 (CET)
From: Brian Leung <leungbk@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>, akrl@HIDDEN
Message-ID: <153788253.769854.1605570761798@HIDDEN>
In-Reply-To: <87zh3gudhu.fsf@HIDDEN>
References: <2132208036.623612.1605407968985@HIDDEN>
 <87zh3gudhu.fsf@HIDDEN>
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3
X-Mailer: ContactOffice Mail
X-ContactOffice-Account: com:225491745
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 44651
Cc: 44651 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Brian Leung <leungbk@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> I don't think that should be necessary?  The function in question is
> autoloaded:
>=20
> ;;;###autoload
>=20
> Where/when do you see this compilation warning?

I noticed this on the feature/native-comp branch, after invoking `helm-man-=
woman` and having woman.el native-compiled asynchronously. I don't have the=
 log.

I did not notice that it was autoloaded. Andrea, are you aware of any issue=
s that the native-comp branch may have with this kind of thing (autoloaded =
functions defined in files that do not necessarily get REQUIRE-d)? If not, =
maybe we can just ignore my patch.

Thanks,
Brian

> ----------------------------------------
> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Sent: Mon Nov 16 23:46:05 CET 2020
> To: Brian Leung <leungbk@HIDDEN>
> Cc: <44651 <at> debbugs.gnu.org>
> Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
>=20
>=20
> Brian Leung <leungbk@HIDDEN> writes:
>=20
> > See attached.
>=20
> [...]
>=20
> > * lisp/woman.el: Declare imenu-add-to-menubar.
>=20
> I don't think that should be necessary?  The function in question is
> autoloaded:
>=20
> ;;;###autoload
> (defun imenu-add-to-menubar (name)
>=20
> Where/when do you see this compilation warning?
>=20
> --=20
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no


--=C2=A0
Sent with https://mailfence.com
Secure and private email




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#44651; Package emacs. Full text available.
Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 44651 <at> debbugs.gnu.org:


Received: (at 44651) by debbugs.gnu.org; 16 Nov 2020 22:46:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 16 17:46:20 2020
Received: from localhost ([127.0.0.1]:57643 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kenGN-0005MG-KO
	for submit <at> debbugs.gnu.org; Mon, 16 Nov 2020 17:46:19 -0500
Received: from quimby.gnus.org ([95.216.78.240]:39964)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kenGL-0005GI-HI
 for 44651 <at> debbugs.gnu.org; Mon, 16 Nov 2020 17:46:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=1Zegq1cMmOxBEU71zbiOj2UR8F0KkDYZJO+62dgPMGs=; b=gAvKNugnCFAF2On2MPWvVfHfI/
 rxNBNCkFxwduvxSkrZUs8Pqkn5vQcV98UZh4Jn+yUl0+VBZtW3d7B4s9exCGRkk5IDn1oJcqhuGud
 9DzDRJZjLsiegK40wxPYefwhq2ys+kRArTS52jwT41GGD45oBkzSJLq0NdivOc4JeqSk=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1kenGA-0006jJ-PR; Mon, 16 Nov 2020 23:46:11 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Brian Leung <leungbk@HIDDEN>
Subject: Re: bug#44651: [PATCH] Silence byte-compiler warning
References: <2132208036.623612.1605407968985@HIDDEN>
X-Now-Playing: Various's _Amchitka (2)_: "Joni Mitchell - The Circle Game"
Date: Mon, 16 Nov 2020 23:46:05 +0100
In-Reply-To: <2132208036.623612.1605407968985@HIDDEN> (Brian Leung's
 message of "Sun, 15 Nov 2020 03:39:29 +0100 (CET)")
Message-ID: <87zh3gudhu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Brian Leung <leungbk@HIDDEN> writes: > See attached.
 [...] Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 44651
Cc: 44651 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Brian Leung <leungbk@HIDDEN> writes:

> See attached.

[...]

> * lisp/woman.el: Declare imenu-add-to-menubar.

I don't think that should be necessary?  The function in question is
autoloaded:

;;;###autoload
(defun imenu-add-to-menubar (name)

Where/when do you see this compilation warning?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#44651; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 Nov 2020 02:39:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 14 21:39:42 2020
Received: from localhost ([127.0.0.1]:52330 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ke7x8-0007ic-NA
	for submit <at> debbugs.gnu.org; Sat, 14 Nov 2020 21:39:42 -0500
Received: from lists.gnu.org ([209.51.188.17]:33922)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leungbk@HIDDEN>) id 1ke7x4-0007iQ-An
 for submit <at> debbugs.gnu.org; Sat, 14 Nov 2020 21:39:40 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50314)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leungbk@HIDDEN>)
 id 1ke7x4-0006Qx-3Z
 for bug-gnu-emacs@HIDDEN; Sat, 14 Nov 2020 21:39:38 -0500
Received: from wilbur.contactoffice.com ([212.3.242.68]:60844)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leungbk@HIDDEN>)
 id 1ke7x1-0005YF-In
 for bug-gnu-emacs@HIDDEN; Sat, 14 Nov 2020 21:39:37 -0500
Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36])
 by wilbur.contactoffice.com (Postfix) with ESMTP id 49187AA6
 for <bug-gnu-emacs@HIDDEN>; Sun, 15 Nov 2020 03:39:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com;
 s=20160819-nLV10XS2; t=1605407971;
 bh=WLAQAW31cQD+ONR3ceDv2PNQ9MHImr1X3qirQFeU1bI=;
 h=Date:Subject:Reply-To:From:To:From;
 b=IiSreXoKmh6dWk7/IpjT8p2MhmRiFy1z3fVp8o0q4jyO1f3bdgEMLX6FtOsCAmmDd
 gzWaVr95O42zl4z4IEVpegk3KCuQbHQouM3i4nmZPqAnpK4ngn254XDqXFUxykzycU
 jB03iNT9ofMpYThKfuJEVawqT3iqvpSJHqUmfKDQPNwytu1ZfeZlaaKRiwsWR2fJfM
 IP3FZWXTgxWHG1BZDB5WPPNwP1Di4wOafQnweJopSZyWtaPRN26cXp84MjxxP08RWK
 Vp3yw5UAaRAUuVhAEjUg9fVVCH50WIw2e9+1H3KNZFV+K28EVYKrZevZ/xcHTimMAm
 bfHrAOprqabFw==
Date: Sun, 15 Nov 2020 03:39:29 +0100 (CET)
Message-ID: <2132208036.623612.1605407968985@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; 
 boundary="----=_Part_623600_1736456432.1605407961413"
Subject: [PATCH] Silence byte-compiler warning
X-Priority: 3
From: Brian Leung <leungbk@HIDDEN>
To: bug-gnu-emacs@HIDDEN
X-Mailer: ContactOffice Mail
X-ContactOffice-Account: com:225491745
Received-SPF: pass client-ip=212.3.242.68; envelope-from=leungbk@HIDDEN;
 helo=wilbur.contactoffice.com
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 21:39:31
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Brian Leung <leungbk@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

------=_Part_623600_1736456432.1605407961413
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

See attached.

--=C2=A0
Sent with https://mailfence.com
Secure and private email
------=_Part_623600_1736456432.1605407961413
Content-Type: text/x-diff; charset=us-ascii; 
	name=0001-Silence-byte-compiler-warning.patch
Content-Transfer-Encoding: 7bit
Content-Description: File Attachment:
 0001-Silence-byte-compiler-warning.patch
Content-Disposition: attachment; 
	filename=0001-Silence-byte-compiler-warning.patch

From a958f4a95cd4e16a14c371e1046cbc5cd81a63fb Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@HIDDEN>
Date: Sat, 14 Nov 2020 18:36:09 -0800
Subject: [PATCH] ; Silence byte-compiler warning

* lisp/woman.el: Declare imenu-add-to-menubar.
---
 lisp/woman.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/woman.el b/lisp/woman.el
index 96ae7fe579..ebc679a8fc 100644
--- a/lisp/woman.el
+++ b/lisp/woman.el
@@ -1914,6 +1914,8 @@ woman-mode
   (let ((inhibit-read-only t))
     (Man-highlight-references 'WoMan-xref-man-page)))
 
+(declare-function imenu-add-to-menubar "imenu")
+
 (defun woman-imenu (&optional redraw)
   "Add a \"Contents\" menu to the menubar.
 Optional argument REDRAW, if non-nil, forces mode line to be updated."
-- 
2.29.2


------=_Part_623600_1736456432.1605407961413--




Acknowledgement sent to Brian Leung <leungbk@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#44651; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 17 Nov 2020 00:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.