GNU bug report logs - #44722
[PATCH] gnu: web: add uriparser

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44722 in the body.
You can then email your comments to 44722 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lspangler <lspangler <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: web: add uriparser
Date: Wed, 18 Nov 2020 13:48:42 +0000

[Message part 1 (text/plain, inline)]

From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
From: Lane Spangler <lspangler <at> protonmail.com>
Date: Tue, 17 Nov 2020 17:50:06 +0100
Subject: [PATCH] gnu: web: add uriparser

---
gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index edb7bd5da1..d79877c78a 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -111,6 +111,7 @@
#:use-module (gnu packages gnupg)
#:use-module (gnu packages golang)
#:use-module (gnu packages gperf)
+ #:use-module (gnu packages graphviz)
#:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
#:use-module (gnu packages guile-xyz)
@@ -7747,3 +7748,30 @@ solution for any project's interface needs:
(description "gmnisrv is a simple Gemini protocol server written in C.")
(license (list license:gpl3+
license:bsd-3))))) ;; for ini.c and ini.h
+
+(define-public uriparser
+ (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
+ (revision "1")]
+ (package
+ (name "uriparser")
+ (version (git-version "0.9.4" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/uriparser/uriparser")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13spkcsi8p5732bviy41y8dv5aw4vg83gqdclbsb9ayfbr2ybjx0"))))
+ (build-system cmake-build-system)
+ (native-inputs `(("gtest" ,googletest)
+ ("doxygen" ,doxygen)
+ ("graphviz" ,graphviz)))
+ (synopsis "Strictly RFC 3986 compliant URI parsing and handling
+ library written in C89")
+ (description "uriparser is a strictly RFC 3986 compliant URI
+ parsing and handling library written in C89 (\"ANSI C\").
+uriparser is cross-platform, fast, and supports Unicode")
+ (home-page "https://uriparser.github.io/")
+ (license license:bsd-3))))
--
2.29.2

[Message part 2 (text/html, inline)]

Message #8 received at 44722 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: lspangler <lspangler <at> protonmail.com>
Cc: 44722 <at> debbugs.gnu.org
Subject: Re: [bug#44722] [PATCH] gnu: web: add uriparser
Date: Thu, 26 Nov 2020 23:19:17 +0100

Hello Lane,

lspangler <lspangler <at> protonmail.com> skribis:

> From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
> From: Lane Spangler <lspangler <at> protonmail.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: add uriparser
>
> ---
> gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

It looks like the patch was mangled on the way.  Could you send it
as an attachment or using ‘git send-email’?

Some minor issues below:

> +(define-public uriparser
> +  (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
> +        (revision "1")]

Normally we pick upstream releases.  If there’s a good reason to pick
this commit rather than the latest release, could you please add a
comment above it explaining why?

Nitpick: Please use only regular parentheses, for consistency.

> +      (synopsis "Strictly RFC 3986 compliant URI parsing and handling
> + library written in C89")

What about making it shorter: “RFC 3986 compliant URI parsing and
handling library”?

> +      (description "uriparser is a strictly RFC 3986 compliant URI
> + parsing and handling library written in C89 (\"ANSI C\").
> +uriparser is cross-platform, fast, and supports Unicode")

I think you can omit “cross-platform” since that’s not relevant from a
Guix user standpoint.  Please add a period at the end of the sentence.

Could you send an updated patch?

Thanks!

Ludo’.

Message #11 received at 44722 <at> debbugs.gnu.org (full text, mbox):

From: lspangler <lspangler <at> protonmail.com>
To: "44722 <at> debbugs.gnu.org" <44722 <at> debbugs.gnu.org>
Subject: (No Subject)
Date: Tue, 08 Dec 2020 17:57:36 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo,

Thanks for reviewing! I've made the suggested changes in the attached patch.

[Message part 2 (text/html, inline)]

[0001-gnu-web-Add-uriparser.patch (text/x-patch, attachment)]

Message #16 received at 44722-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: lspangler <lspangler <at> protonmail.com>
Cc: "44722 <at> debbugs.gnu.org" <44722-done <at> debbugs.gnu.org>
Subject: Re: [bug#44722] (No Subject)
Date: Wed, 23 Dec 2020 17:14:47 +0100

Hi,

lspangler <lspangler <at> protonmail.com> skribis:

> From d3aedc37d0970b38464c69e66263473f19565dd9 Mon Sep 17 00:00:00 2001
> From: lsp <lsp <at> ableton.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: Add uriparser
>
> ---
>  gnu/packages/web.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

I added a commit log and applied.  Thanks and apologies for the delay!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.