GNU bug report logs - #44745
tests/lint.scm fails building guix with guile-2.2

Previous Next

To reply to this bug, email your comments to 44745 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: bug-guix <at> gnu.org
Subject: tests/lint.scm fails building guix with guile-2.2
Date: Thu, 19 Nov 2020 16:35:42 -0800

[Message part 1 (text/plain, inline)]

I'm exploring building with guile 2.2 because guile-gnutls built with
guile 3.0 is only available in experimental, and even there, missing for
arm64.

From tests/lint.log:

test-name: archival: missing content
location: /build/guix-EdK9LP/guix-1.2.0~rc2/tests/lint.scm:921
source:
+ (test-assert
+   "archival: missing content"
+   (let* ((origin
+            (origin
+              (method url-fetch)
+              (uri "http://example.org/foo.tgz")
+              (sha256 (make-bytevector 32))))
+          (warnings
+            (with-http-server
+              '((404 "Not archived."))
+              (parameterize
+                ((%swh-base-url (%local-url)))
+                (check-archival
+                  (dummy-package "x" (source origin)))))))
+     (warning-contains? "not archived" warnings)))
actual-value: #f
actual-error:
+ (keyword-argument-error
+   #<procedure http-request (uri #:key body port method version keep-alive? headers decode-body? streaming? request)>
+   "Unrecognized keyword"
+   ()
+   (#:verify-certificate?))
result: FAIL


I haven't tried reproducing this without the Debian patches applied
which liberally sprinkle the test suites with:

  (unless (network-reachable?  (test-skip 1))

... but if you can spot a likely issue, I'd be happy to test it. :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 44745 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 44745 <at> debbugs.gnu.org
Subject: Re: bug#44745: tests/lint.scm fails building guix with guile-2.2
Date: Fri, 20 Nov 2020 10:32:25 +0100

Hi Vagrant,

On Thu, 19 Nov 2020 at 16:35, Vagrant Cascadian <vagrant <at> debian.org> wrote:

> test-name: archival: missing content
> location: /build/guix-EdK9LP/guix-1.2.0~rc2/tests/lint.scm:921
> source:
> + (test-assert
> +   "archival: missing content"
> +   (let* ((origin
> +            (origin
> +              (method url-fetch)
> +              (uri "http://example.org/foo.tgz")
> +              (sha256 (make-bytevector 32))))
> +          (warnings
> +            (with-http-server
> +              '((404 "Not archived."))
> +              (parameterize
> +                ((%swh-base-url (%local-url)))
> +                (check-archival
> +                  (dummy-package "x" (source origin)))))))
> +     (warning-contains? "not archived" warnings)))
> actual-value: #f
> actual-error:
> + (keyword-argument-error
> +   #<procedure http-request (uri #:key body port method version keep-alive? headers decode-body? streaming? request)>
> +   "Unrecognized keyword"
> +   ()
> +   (#:verify-certificate?))
> result: FAIL
>

I remember issues fixed by 722ad41c44a499d2250c79527ef7d069ca728de0
which maybe introduce a regression for Guile 2.2.

--8<---------------cut here---------------start------------->8---
+;; XXX: Work around a bug in Guile 3.0.2 where #:verify-certificate? would
+;; be ignored (<https://bugs.gnu.org/40486>).
+(define* (http-get* uri #:rest rest)
+  (apply http-request uri #:method 'GET rest))
+(define* (http-post* uri #:rest rest)
--8<---------------cut here---------------end--------------->8---

Maybe it is related.


All the best,
simon

Message #11 received at 44745 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 44745 <at> debbugs.gnu.org
Subject: Re: bug#44745: tests/lint.scm fails building guix with guile-2.2
Date: Fri, 20 Nov 2020 12:47:45 +0100

Hi,

zimoun <zimon.toutoune <at> gmail.com> skribis:

> I remember issues fixed by 722ad41c44a499d2250c79527ef7d069ca728de0
> which maybe introduce a regression for Guile 2.2.
>
> +;; XXX: Work around a bug in Guile 3.0.2 where #:verify-certificate? would
> +;; be ignored (<https://bugs.gnu.org/40486>).
> +(define* (http-get* uri #:rest rest)
> +  (apply http-request uri #:method 'GET rest))
> +(define* (http-post* uri #:rest rest)
>
> Maybe it is related.

Yeah, #:verify-certificate? is new in 3.0.x:

  https://git.savannah.gnu.org/cgit/guile.git/tree/NEWS#n599

Vagrant, perhaps the simplest option for you would be to skip these
tests.  There’s no rush but I think we’ll remove 2.2 support in the
not-too-distant future.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.