GNU bug report logs - #44882
[PATCH] gnu: ruby-solargraph: Update to 0.39.17 and add two dependencies

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Tomás Ortín Fernández <tomasortin@HIDDEN>; Keywords: patch; dated Thu, 26 Nov 2020 10:03:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 44882 <at> debbugs.gnu.org:


Received: (at 44882) by debbugs.gnu.org; 28 Dec 2020 01:17:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 27 20:17:33 2020
Received: from localhost ([127.0.0.1]:33914 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kthAD-0007sy-1Q
	for submit <at> debbugs.gnu.org; Sun, 27 Dec 2020 20:17:33 -0500
Received: from m4s11.vlinux.de ([83.151.27.109]:52518 helo=bjoernhoefling.de)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bjoern.hoefling@HIDDEN>)
 id 1kthAA-0007qS-IE
 for 44882 <at> debbugs.gnu.org; Sun, 27 Dec 2020 20:17:31 -0500
Received: from alma-ubu (p57b52b0b.dip0.t-ipconnect.de [87.181.43.11])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by bjoernhoefling.de (Postfix) with ESMTPSA id C0E003F9B0;
 Mon, 28 Dec 2020 02:17:28 +0100 (CET)
Date: Mon, 28 Dec 2020 02:17:27 +0100
From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= <bjoern.hoefling@HIDDEN>
To: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] Dependencies issues
Message-ID: <20201228021727.059906f7@alma-ubu>
In-Reply-To: <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
 <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/ClOq8A2l6g7/mAPjixQg_kf"; protocol="application/pgp-signature"
X-Spam-Score: 0.4 (/)
X-Debbugs-Envelope-To: 44882
Cc: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>,
 44882 <at> debbugs.gnu.org, Leo Famulari <leo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--Sig_/ClOq8A2l6g7/mAPjixQg_kf
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Tom=C3=A1s,

On Sat, 28 Nov 2020
09:53:20 +0100 Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez via Guix-patches via
<guix-patches@HIDDEN> wrote:

> I have realized this patch isn't correct. I hadn't tested it on a
> clean environment before. Solargraph requires Rubocop 0.52 (!). In
> fact, the current version of Solargraph doesn't currently work,
> either: there are version issues with Rubocop and with ruby-thor.

Can you explain what you mean by that? What problems do you see?

When I look at the Gem's page at

https://rubygems.org/gems/solargraph/versions/0.40.0

I see that Solargraph needs rubocop >=3D 0.52 (NOT specific to 0.52). For
thor, it needs ~>1.0. As we have 1.0.1, that should be fine.

I tried to build the 0.40.0 version of Solargraph (had to add the
kramdown-parser-gfm and kramdown-parser dependencies) and at least I
was able to start it with the command:

solargraph socket

I'm not using an editor/IDE that makes use of Solargraph, so I don't
see any problems here. Do you see more?

@Leo: I'm fine with your updated patches, except with this question and
that there are newer versions of ruby-benchmark and ruby-solargraph.


Thanks,

Bj=C3=B6rn

--Sig_/ClOq8A2l6g7/mAPjixQg_kf
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCX+kyJwAKCRC/KGy2WT5f
/WsNAJkB+DY/RreK77+975HtotMGSzc5VQCgkiEaFW0doCnLrL4A9KsY4kiw+tU=
=5GTr
-----END PGP SIGNATURE-----

--Sig_/ClOq8A2l6g7/mAPjixQg_kf--




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Dec 2020 01:17:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 27 20:17:40 2020
Received: from localhost ([127.0.0.1]:33917 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kthAK-0007tI-CX
	for submit <at> debbugs.gnu.org; Sun, 27 Dec 2020 20:17:40 -0500
Received: from lists.gnu.org ([209.51.188.17]:36304)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bjoern.hoefling@HIDDEN>)
 id 1kthAG-0007t9-IA
 for submit <at> debbugs.gnu.org; Sun, 27 Dec 2020 20:17:37 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33206)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <bjoern.hoefling@HIDDEN>)
 id 1kthAE-00008A-Rt
 for guix-patches@HIDDEN; Sun, 27 Dec 2020 20:17:36 -0500
Received: from m4s11.vlinux.de ([83.151.27.109]:47610 helo=bjoernhoefling.de)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bjoern.hoefling@HIDDEN>)
 id 1kthAB-0007GO-Iu
 for guix-patches@HIDDEN; Sun, 27 Dec 2020 20:17:33 -0500
Received: from alma-ubu (p57b52b0b.dip0.t-ipconnect.de [87.181.43.11])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by bjoernhoefling.de (Postfix) with ESMTPSA id C0E003F9B0;
 Mon, 28 Dec 2020 02:17:28 +0100 (CET)
Date: Mon, 28 Dec 2020 02:17:27 +0100
From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= <bjoern.hoefling@HIDDEN>
To: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] Dependencies issues
Message-ID: <20201228021727.059906f7@alma-ubu>
In-Reply-To: <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
 <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/ClOq8A2l6g7/mAPjixQg_kf"; protocol="application/pgp-signature"
Received-SPF: none client-ip=83.151.27.109;
 envelope-from=bjoern.hoefling@HIDDEN; helo=bjoernhoefling.de
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.398,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>,
 44882 <at> debbugs.gnu.org, Leo Famulari <leo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--Sig_/ClOq8A2l6g7/mAPjixQg_kf
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Tom=C3=A1s,

On Sat, 28 Nov 2020
09:53:20 +0100 Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez via Guix-patches via
<guix-patches@HIDDEN> wrote:

> I have realized this patch isn't correct. I hadn't tested it on a
> clean environment before. Solargraph requires Rubocop 0.52 (!). In
> fact, the current version of Solargraph doesn't currently work,
> either: there are version issues with Rubocop and with ruby-thor.

Can you explain what you mean by that? What problems do you see?

When I look at the Gem's page at

https://rubygems.org/gems/solargraph/versions/0.40.0

I see that Solargraph needs rubocop >=3D 0.52 (NOT specific to 0.52). For
thor, it needs ~>1.0. As we have 1.0.1, that should be fine.

I tried to build the 0.40.0 version of Solargraph (had to add the
kramdown-parser-gfm and kramdown-parser dependencies) and at least I
was able to start it with the command:

solargraph socket

I'm not using an editor/IDE that makes use of Solargraph, so I don't
see any problems here. Do you see more?

@Leo: I'm fine with your updated patches, except with this question and
that there are newer versions of ruby-benchmark and ruby-solargraph.


Thanks,

Bj=C3=B6rn

--Sig_/ClOq8A2l6g7/mAPjixQg_kf
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCX+kyJwAKCRC/KGy2WT5f
/WsNAJkB+DY/RreK77+975HtotMGSzc5VQCgkiEaFW0doCnLrL4A9KsY4kiw+tU=
=5GTr
-----END PGP SIGNATURE-----

--Sig_/ClOq8A2l6g7/mAPjixQg_kf--




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at 44882 <at> debbugs.gnu.org:


Received: (at 44882) by debbugs.gnu.org; 4 Dec 2020 19:56:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 04 14:56:24 2020
Received: from localhost ([127.0.0.1]:45919 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1klHBo-00038Q-7A
	for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:56:24 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:36003)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1klHBm-000387-N7
 for 44882 <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:56:23 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id ACD8D75A;
 Fri,  4 Dec 2020 14:56:16 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Fri, 04 Dec 2020 14:56:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=L41pFrlIiXmWuhAFo6E7Uj+HIdNYvGMWwTxAX71jgAY=; b=buMVxBG2lh0v
 zVdinvpcp6ALFCMDHJXipKwP+r39TB/lKsjB0T12hydc6cSwQcvh56Q1PZFrjz6z
 8A++W3Y/CKDXzJGNfcMySkUzV6WpFWSylWS5TB7HYx85IAWlNXbUjv4/zzkQKZsD
 J2jyiFodbDg4CsP6Y7SRTMMyCGN+etc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=L41pFrlIiXmWuhAFo6E7Uj+HIdNYvGMWwTxAX71jg
 AY=; b=MWF5GI8hykeR8vdCINf3PmAhi2JjNdtmGOFRP2PMxyOxPRx0vAwHnN5Wg
 Ss/tsvevaaArL3Kanb+OM+XMCMEanaC1AjXnB/0EozvAj0S+tb6Rf1zA5D8VZSdT
 FsMjFtWzS6cFqKtO+r3nywx5/IuxlTeLo4FR0lSvKhAoCKD3hLi76WesjM6jd614
 /jjc8RZvMRGVTprGSVWHmDq6azS/YV/+75rdbcGJWPljxUK4/uWKdflYS+yORGy7
 NiV/Tje/SphUElhrBmAej8OisjE7zpt4tNzFDCVCTdFh+a5mmNAVwYn/vPI94hTq
 KRJ2BsG8p6YeFn2dJUhnrazEKWXAg==
X-ME-Sender: <xms:X5TKX8sf-TCf7UGlwPzno1Mv0kef3GA7v8V4FH0FpE38MXmJd8D2fg>
 <xme:X5TKX5cHvU2K5NVmtvJm0ol-p2B1NfGBG4FASmRaeM2S0hLElHaLOvKEOk5pIVWe6
 ghvGND5xlynm1Erkw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeikedgudefudcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho
 ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg
 htthgvrhhnpeeuueegudfgvdfgveeuvdeludelfeejhfeggfejtefggeekudekhfdvfeel
 jeehgfenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg
 eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm
 vg
X-ME-Proxy: <xmx:X5TKX3w94taokMSHHKlZe0VCvkgewdz9xmvAQikeVAKchGMPFCjbbg>
 <xmx:X5TKX_MBxTyDLnEURvxvRtc32-IB0bs5lS-dqLk3WFxB2JukVb_vKw>
 <xmx:X5TKX8_q6aFxG0gzeaIOKoZ6TZ8oinshk0U_gttlNvSA90mEni_Oaw>
 <xmx:YJTKX1L2q768Bi62ztbC6zD7z48Ope4rdCFU1wV7opS7xvdp_fIE5A>
Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net
 [73.141.127.146])
 by mail.messagingengine.com (Postfix) with ESMTPA id C966E240059;
 Fri,  4 Dec 2020 14:56:15 -0500 (EST)
Date: Fri, 4 Dec 2020 14:56:14 -0500
From: Leo Famulari <leo@HIDDEN>
To: =?iso-8859-1?Q?Tom=E1s_Ort=EDn_Fern=E1ndez?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] Dependencies issues
Message-ID: <X8qUXq1paMFJwt2V@HIDDEN>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
 <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 44882
Cc: 44882 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sat, Nov 28, 2020 at 09:53:20AM +0100, Toms Ortn Fernndez via Guix-patches via wrote:
> I have realized this patch isn't correct. I hadn't tested it on a clean environment before.
> Solargraph requires Rubocop 0.52 (!). In fact, the current version of Solargraph doesn't currently work, either: there are version issues with Rubocop and with ruby-thor.

Okay, thanks for the followup email.

> I need a more-or-less current Solargraph and Rubocop, that's why I have been updating some packages, but I realize now I wasn't doing it properly and that I'm getting tangled into a web of dependencies issues.
> 
> How should I proceed? Clearly Rubocop should be updated, but I don't know how to keep Solargraph working and how to figure out which packages will need to be updated or checked in case they need an older version of Rubocop.

It's not clear to me exactly what is wrong, so I can't give specific
advice. If Solargraph is not currently working, you don't need to "keep
it working" while doing other work, right?

To check what packages will be rebuilt if the Rubocop package changes,
you can use `guix refresh --list-dependents ruby-rubocop`. Building and
testing the packages listed by that command will allow you to test the
impact of any changes to ruby-rubocop.

Currently, our ruby-rubocop package is at version 0.88.0. We don't
usually downgrade packages, but you can add another package based on the
earlier version 0.52. For example, something like this (untested!):

------
(define-public ruby-rubocop-0.52
  (package
    (inherit ruby-rubocop)
    (version "0.52")
    (source (origin [...]))))
------

... then use ruby-rubocop-0.52 as an input to the Solargraph package.

In general, dealing with complex dependency graphs while updating
packages is hard, but Guix makes it easier. I would start at the top of
the graph: try building the new Solargraph, see which dependencies are
too old, update them, repeat. Once Solargraph is working, you can use
`guix refresh --list-dependents` for each changed package, fix any
breakage, and so on.

Does that make sense? Please don't hesitate to keep asking for advice,
here or on our Freenode IRC channel #guix




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 19:56:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 04 14:56:24 2020
Received: from localhost ([127.0.0.1]:45921 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1klHBo-00038S-Gf
	for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:56:24 -0500
Received: from lists.gnu.org ([209.51.188.17]:34772)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1klHBl-00038B-D5
 for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:56:23 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:52836)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1klHBk-0003qn-KB
 for guix-patches@HIDDEN; Fri, 04 Dec 2020 14:56:21 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43493)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1klHBi-0006hh-D4
 for guix-patches@HIDDEN; Fri, 04 Dec 2020 14:56:20 -0500
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id ACD8D75A;
 Fri,  4 Dec 2020 14:56:16 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Fri, 04 Dec 2020 14:56:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=L41pFrlIiXmWuhAFo6E7Uj+HIdNYvGMWwTxAX71jgAY=; b=buMVxBG2lh0v
 zVdinvpcp6ALFCMDHJXipKwP+r39TB/lKsjB0T12hydc6cSwQcvh56Q1PZFrjz6z
 8A++W3Y/CKDXzJGNfcMySkUzV6WpFWSylWS5TB7HYx85IAWlNXbUjv4/zzkQKZsD
 J2jyiFodbDg4CsP6Y7SRTMMyCGN+etc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=L41pFrlIiXmWuhAFo6E7Uj+HIdNYvGMWwTxAX71jg
 AY=; b=MWF5GI8hykeR8vdCINf3PmAhi2JjNdtmGOFRP2PMxyOxPRx0vAwHnN5Wg
 Ss/tsvevaaArL3Kanb+OM+XMCMEanaC1AjXnB/0EozvAj0S+tb6Rf1zA5D8VZSdT
 FsMjFtWzS6cFqKtO+r3nywx5/IuxlTeLo4FR0lSvKhAoCKD3hLi76WesjM6jd614
 /jjc8RZvMRGVTprGSVWHmDq6azS/YV/+75rdbcGJWPljxUK4/uWKdflYS+yORGy7
 NiV/Tje/SphUElhrBmAej8OisjE7zpt4tNzFDCVCTdFh+a5mmNAVwYn/vPI94hTq
 KRJ2BsG8p6YeFn2dJUhnrazEKWXAg==
X-ME-Sender: <xms:X5TKX8sf-TCf7UGlwPzno1Mv0kef3GA7v8V4FH0FpE38MXmJd8D2fg>
 <xme:X5TKX5cHvU2K5NVmtvJm0ol-p2B1NfGBG4FASmRaeM2S0hLElHaLOvKEOk5pIVWe6
 ghvGND5xlynm1Erkw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeikedgudefudcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho
 ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg
 htthgvrhhnpeeuueegudfgvdfgveeuvdeludelfeejhfeggfejtefggeekudekhfdvfeel
 jeehgfenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg
 eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm
 vg
X-ME-Proxy: <xmx:X5TKX3w94taokMSHHKlZe0VCvkgewdz9xmvAQikeVAKchGMPFCjbbg>
 <xmx:X5TKX_MBxTyDLnEURvxvRtc32-IB0bs5lS-dqLk3WFxB2JukVb_vKw>
 <xmx:X5TKX8_q6aFxG0gzeaIOKoZ6TZ8oinshk0U_gttlNvSA90mEni_Oaw>
 <xmx:YJTKX1L2q768Bi62ztbC6zD7z48Ope4rdCFU1wV7opS7xvdp_fIE5A>
Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net
 [73.141.127.146])
 by mail.messagingengine.com (Postfix) with ESMTPA id C966E240059;
 Fri,  4 Dec 2020 14:56:15 -0500 (EST)
Date: Fri, 4 Dec 2020 14:56:14 -0500
From: Leo Famulari <leo@HIDDEN>
To: =?iso-8859-1?Q?Tom=E1s_Ort=EDn_Fern=E1ndez?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] Dependencies issues
Message-ID: <X8qUXq1paMFJwt2V@HIDDEN>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
 <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@HIDDEN;
 helo=wout4-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 44882 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Sat, Nov 28, 2020 at 09:53:20AM +0100, Toms Ortn Fernndez via Guix-patches via wrote:
> I have realized this patch isn't correct. I hadn't tested it on a clean environment before.
> Solargraph requires Rubocop 0.52 (!). In fact, the current version of Solargraph doesn't currently work, either: there are version issues with Rubocop and with ruby-thor.

Okay, thanks for the followup email.

> I need a more-or-less current Solargraph and Rubocop, that's why I have been updating some packages, but I realize now I wasn't doing it properly and that I'm getting tangled into a web of dependencies issues.
> 
> How should I proceed? Clearly Rubocop should be updated, but I don't know how to keep Solargraph working and how to figure out which packages will need to be updated or checked in case they need an older version of Rubocop.

It's not clear to me exactly what is wrong, so I can't give specific
advice. If Solargraph is not currently working, you don't need to "keep
it working" while doing other work, right?

To check what packages will be rebuilt if the Rubocop package changes,
you can use `guix refresh --list-dependents ruby-rubocop`. Building and
testing the packages listed by that command will allow you to test the
impact of any changes to ruby-rubocop.

Currently, our ruby-rubocop package is at version 0.88.0. We don't
usually downgrade packages, but you can add another package based on the
earlier version 0.52. For example, something like this (untested!):

------
(define-public ruby-rubocop-0.52
  (package
    (inherit ruby-rubocop)
    (version "0.52")
    (source (origin [...]))))
------

... then use ruby-rubocop-0.52 as an input to the Solargraph package.

In general, dealing with complex dependency graphs while updating
packages is hard, but Guix makes it easier. I would start at the top of
the graph: try building the new Solargraph, see which dependencies are
too old, update them, repeat. Once Solargraph is working, you can use
`guix refresh --list-dependents` for each changed package, fix any
breakage, and so on.

Does that make sense? Please don't hesitate to keep asking for advice,
here or on our Freenode IRC channel #guix




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at 44882 <at> debbugs.gnu.org:


Received: (at 44882) by debbugs.gnu.org; 4 Dec 2020 19:44:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 04 14:44:26 2020
Received: from localhost ([127.0.0.1]:45911 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1klH0D-0000m5-OX
	for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:44:26 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43727)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1klH06-0000le-6N
 for 44882 <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:44:18 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 561A482C;
 Fri,  4 Dec 2020 14:44:11 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Fri, 04 Dec 2020 14:44:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqgg4=; b=uZSkgwnj7A6Y
 fOP2o3A+5NqW8eIn+SUv5go+4/8pnvN+UzOVMTy6+ThQDTxB9pqqtcGC/YyvtkYo
 0xeacYDfxPN2dP2NOL6UbF+xdnMbcaFZzFiJiMLmgjNLlR5KQSZhjifqLU8DL70t
 GHBSJoXGTAoo19hy3ZfDQM4LRFcDbZU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqg
 g4=; b=RtVCPwheQME2/+h/No8Rdtcev7CEL6BMABdD3yl0qxdHDCPLZHGXlZgvs
 /KJ45fMjCm4JzDml17RqlQuhV2m7Msf6rC8SNjQOvDXopNaJ8oLRh5qndwpeWge7
 SH5wWGYMcHBnuarMOgitXkMdxHiz4poyy0c4aQx1FxNAyp5aDnSyyszXmZxXhYjR
 TRUGXHGiSB1WBxFcbuRaaIGK0y9IwhXzYNg2CQQ4Aa+aF31uAvyDlBoWNVRNt7Xw
 D9LitmRCpAXXS06RevTfJyPuYZx99/oQFrmDcjiGx41Go5RrwEtZi/khH7iEWNMG
 V0FyApmCdhdKa5v5mNAdcTaIojr/Q==
X-ME-Sender: <xms:ipHKXzHnf2CwYeTnuYzORqQidOFk-yaGu024cbBIu3mk-pfcCgGIwA>
 <xme:ipHKXzZ3zM8R4bgvpH6nRMCMeQd1I3ZrB5PmGyqgbIjs0Xvm4iFIuyc1HUHhZtNhs
 zQufZfS5-bqR_wPoA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeikedguddvkecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggugfgjsehmkeerredttddunecuhfhrohhmpefnvgho
 ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg
 htthgvrhhnpeevjeelhfejvdekvefgkefguedtgfekudfgteevffejfeelvdfgjeetueet
 teffffenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg
 eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm
 vg
X-ME-Proxy: <xmx:ipHKX_wdD0PhQQBN_nNFiZlLNQYV3JEERn3lFsX6a9m2euBbQd-RRw>
 <xmx:ipHKX9Sjsie-W9sqMkXl8XfelIY4QFJoX54yF8CGLq8WnQuhYSTr9g>
 <xmx:ipHKX0KicNnG7Rzry2ZJoWoK5DuyC0Fj24OjBwjGQCGHqvyqyFX54A>
 <xmx:ipHKX3DN-W33VrlKXLER1WiC_kVm9YDZebflAAkh60PfuxEvTlWCrw>
Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net
 [73.141.127.146])
 by mail.messagingengine.com (Postfix) with ESMTPA id 72480108005B;
 Fri,  4 Dec 2020 14:44:10 -0500 (EST)
Date: Fri, 4 Dec 2020 14:44:08 -0500
From: Leo Famulari <leo@HIDDEN>
To: =?iso-8859-1?Q?Tom=E1s_Ort=EDn_Fern=E1ndez?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] [PATCH] gnu: ruby-solargraph: Update to 0.39.17 and
 add two dependencies
Message-ID: <X8qRiPJsUlT/MjU/@jasmine.lan>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="v0pLRUu/sp2Bh2wb"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 44882
Cc: 44882 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--v0pLRUu/sp2Bh2wb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Thu, Nov 26, 2020 at 11:02:11AM +0100, Toms Ortn Fernndez via Guix-patches via wrote:
> * gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17.
> * gnu/packages/ruby.scm (ruby-e2mmap): New variable.
> * gnu/packages/ruby.scm (ruby-benchmark): New variable.

Thanks! I read your followup email but I'm also replying with some
advice about this patch.

First, this patch should be split into 3 patches. Each new package
should be added in its own patch, and then the solargraph update should
be the third patch.

> +(define-public ruby-e2mmap
> +  (package
> +    (name "ruby-e2mmap")
> +    (version "0.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "e2mmap" version))
> +       (sha256
> +        (base32
> +         "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5"))))
> +    (build-system ruby-build-system)
> +    (propagated-inputs
> +     `(("bundler" ,bundler)))

Is this 'bundler' really used? If so, is it used only at build time? In
that case, it would be a native input.

I checked that the built ruby-e2mmap doesn't keep a reference to
bundler, and thus wouldn't be able to find it at run-time:

------
$ guix gc --references $(./pre-inst-env guix build --no-grafts ruby-e2mmap)          
/gnu/store/8ql9jjzl8q291ghsxlkm1wn5bpdvgcqw-ruby-2.6.5
/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16
------

> +    (description
> +     "Module for defining custom exceptions with specific messages.")

Descriptions should be "complete sentences". For example, this could be
written as "This package provides a Ruby module for defining custom
exceptions with specific messages."

I've attached a revised patchset to show what I mean. I was going to
push these revised patches until I read your followup message.

--v0pLRUu/sp2Bh2wb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: attachment; filename=solargraph-patches
Content-Transfer-Encoding: 8bit

From 50a2b025fade3fc2a305cd78d1611c516fe47510 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:16:15 -0500
Subject: [PATCH 1/3] gnu: Add ruby-e2mmap.

* gnu/packages/ruby.scm (ruby-e2mmap): New variable.
---
 gnu/packages/ruby.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 8fc228f6ed..939a686114 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -23,6 +23,7 @@
 ;;; Copyright  2020 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright  2020 Nicolas Goaziou <mail@HIDDEN>
 ;;; Copyright  2020 Michael Rohleder <mike@HIDDEN>
+;;; Copyright  2020 Toms Ortn Fernndez <tomasortin@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11637,6 +11638,26 @@ checking.")
     (home-page "https://solargraph.org/")
     (license license:expat)))
 
+(define-public ruby-e2mmap
+  (package
+    (name "ruby-e2mmap")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "e2mmap" version))
+       (sha256
+        (base32
+         "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ;; There is a rakefile but no tests
+    (synopsis "Define custom exceptions for Ruby")
+    (description "This package provides a Ruby module for defining custom
+exceptions with specific messages.")
+    (home-page "https://github.com/ruby/e2mmap")
+    (license license:bsd-2)))
+
 (define-public ruby-wayback-machine-downloader
   (package
     (name "ruby-wayback-machine-downloader")
-- 
2.29.2


From d1868eddf03ae24fc7ffbeb920e95a06838f6a8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:16:49 -0500
Subject: [PATCH 2/3] gnu: Add ruby-benchmark.

* gnu/packages/ruby.scm (ruby-benchmark): New variable.
---
 gnu/packages/ruby.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 939a686114..bc1ca15d67 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -11658,6 +11658,24 @@ exceptions with specific messages.")
     (home-page "https://github.com/ruby/e2mmap")
     (license license:bsd-2)))
 
+(define-public ruby-benchmark
+  (package
+    (name "ruby-benchmark")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "benchmark" version))
+       (sha256
+        (base32
+         "0jadlpsl504ql436a6bx8ihp0bkg3rvxg7fbi4r1bmra3cqz0h88"))))
+    (build-system ruby-build-system)
+    (synopsis "Performance benchmarking for Ruby")
+    (description "This package provides methods for benchmarking Ruby code,
+giving detailed reports on the time taken for each task.")
+    (home-page "https://github.com/ruby/benchmark")
+    (license license:bsd-2)))
+
 (define-public ruby-wayback-machine-downloader
   (package
     (name "ruby-wayback-machine-downloader")
-- 
2.29.2


From 9c8dd05ef67013b4599be78e21976b618b4d7e97 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:17:09 -0500
Subject: [PATCH 3/3] gnu: ruby-solargraph: Update to 0.39.17.

* gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17.
[propagated-inputs]: Add ruby-benchmark and ruby-e2mmap.
---
 gnu/packages/ruby.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index bc1ca15d67..146263e0af 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -11587,19 +11587,20 @@ application.")
 (define-public ruby-solargraph
   (package
     (name "ruby-solargraph")
-    (version "0.36.0")
+    (version "0.39.17")
     (source
      (origin
        (method url-fetch)
        (uri (rubygems-uri "solargraph" version))
        (sha256
         (base32
-         "0b93xzkgd1h06da9gdnwivj1mzbil8lc072y2838dy6i7bxgpy9i"))))
+         "06fby6dpq1jcq30x8ladig4dvz8j2pxd08mkrad3d41jx33zd2hg"))))
     (build-system ruby-build-system)
     (propagated-inputs
      `(("ruby-backport" ,ruby-backport)
        ("bundler" ,bundler)
-       ("ruby-htmlentities" ,ruby-htmlentities)
+       ("ruby-benchmark" ,ruby-benchmark)
+       ("ruby-e2mmap" ,ruby-e2mmap)
        ("ruby-jaro-winkler" ,ruby-jaro-winkler)
        ("ruby-maruku" ,ruby-maruku)
        ("ruby-nokogiri" ,ruby-nokogiri)
-- 
2.29.2


--v0pLRUu/sp2Bh2wb--




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 19:44:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 04 14:44:25 2020
Received: from localhost ([127.0.0.1]:45909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1klH08-0000ly-0X
	for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:44:25 -0500
Received: from lists.gnu.org ([209.51.188.17]:52610)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1klH05-0000ll-D0
 for submit <at> debbugs.gnu.org; Fri, 04 Dec 2020 14:44:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50162)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1klH04-00075L-T2
 for guix-patches@HIDDEN; Fri, 04 Dec 2020 14:44:17 -0500
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:58549)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1klH01-0003JG-6l
 for guix-patches@HIDDEN; Fri, 04 Dec 2020 14:44:16 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 561A482C;
 Fri,  4 Dec 2020 14:44:11 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Fri, 04 Dec 2020 14:44:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqgg4=; b=uZSkgwnj7A6Y
 fOP2o3A+5NqW8eIn+SUv5go+4/8pnvN+UzOVMTy6+ThQDTxB9pqqtcGC/YyvtkYo
 0xeacYDfxPN2dP2NOL6UbF+xdnMbcaFZzFiJiMLmgjNLlR5KQSZhjifqLU8DL70t
 GHBSJoXGTAoo19hy3ZfDQM4LRFcDbZU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqg
 g4=; b=RtVCPwheQME2/+h/No8Rdtcev7CEL6BMABdD3yl0qxdHDCPLZHGXlZgvs
 /KJ45fMjCm4JzDml17RqlQuhV2m7Msf6rC8SNjQOvDXopNaJ8oLRh5qndwpeWge7
 SH5wWGYMcHBnuarMOgitXkMdxHiz4poyy0c4aQx1FxNAyp5aDnSyyszXmZxXhYjR
 TRUGXHGiSB1WBxFcbuRaaIGK0y9IwhXzYNg2CQQ4Aa+aF31uAvyDlBoWNVRNt7Xw
 D9LitmRCpAXXS06RevTfJyPuYZx99/oQFrmDcjiGx41Go5RrwEtZi/khH7iEWNMG
 V0FyApmCdhdKa5v5mNAdcTaIojr/Q==
X-ME-Sender: <xms:ipHKXzHnf2CwYeTnuYzORqQidOFk-yaGu024cbBIu3mk-pfcCgGIwA>
 <xme:ipHKXzZ3zM8R4bgvpH6nRMCMeQd1I3ZrB5PmGyqgbIjs0Xvm4iFIuyc1HUHhZtNhs
 zQufZfS5-bqR_wPoA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeikedguddvkecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggugfgjsehmkeerredttddunecuhfhrohhmpefnvgho
 ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg
 htthgvrhhnpeevjeelhfejvdekvefgkefguedtgfekudfgteevffejfeelvdfgjeetueet
 teffffenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg
 eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm
 vg
X-ME-Proxy: <xmx:ipHKX_wdD0PhQQBN_nNFiZlLNQYV3JEERn3lFsX6a9m2euBbQd-RRw>
 <xmx:ipHKX9Sjsie-W9sqMkXl8XfelIY4QFJoX54yF8CGLq8WnQuhYSTr9g>
 <xmx:ipHKX0KicNnG7Rzry2ZJoWoK5DuyC0Fj24OjBwjGQCGHqvyqyFX54A>
 <xmx:ipHKX3DN-W33VrlKXLER1WiC_kVm9YDZebflAAkh60PfuxEvTlWCrw>
Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net
 [73.141.127.146])
 by mail.messagingengine.com (Postfix) with ESMTPA id 72480108005B;
 Fri,  4 Dec 2020 14:44:10 -0500 (EST)
Date: Fri, 4 Dec 2020 14:44:08 -0500
From: Leo Famulari <leo@HIDDEN>
To: =?iso-8859-1?Q?Tom=E1s_Ort=EDn_Fern=E1ndez?= via Guix-patches via
 <guix-patches@HIDDEN>
Subject: Re: [bug#44882] [PATCH] gnu: ruby-solargraph: Update to 0.39.17 and
 add two dependencies
Message-ID: <X8qRiPJsUlT/MjU/@jasmine.lan>
References: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="v0pLRUu/sp2Bh2wb"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@HIDDEN;
 helo=wout4-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 44882 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


--v0pLRUu/sp2Bh2wb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Thu, Nov 26, 2020 at 11:02:11AM +0100, Toms Ortn Fernndez via Guix-patches via wrote:
> * gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17.
> * gnu/packages/ruby.scm (ruby-e2mmap): New variable.
> * gnu/packages/ruby.scm (ruby-benchmark): New variable.

Thanks! I read your followup email but I'm also replying with some
advice about this patch.

First, this patch should be split into 3 patches. Each new package
should be added in its own patch, and then the solargraph update should
be the third patch.

> +(define-public ruby-e2mmap
> +  (package
> +    (name "ruby-e2mmap")
> +    (version "0.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "e2mmap" version))
> +       (sha256
> +        (base32
> +         "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5"))))
> +    (build-system ruby-build-system)
> +    (propagated-inputs
> +     `(("bundler" ,bundler)))

Is this 'bundler' really used? If so, is it used only at build time? In
that case, it would be a native input.

I checked that the built ruby-e2mmap doesn't keep a reference to
bundler, and thus wouldn't be able to find it at run-time:

------
$ guix gc --references $(./pre-inst-env guix build --no-grafts ruby-e2mmap)          
/gnu/store/8ql9jjzl8q291ghsxlkm1wn5bpdvgcqw-ruby-2.6.5
/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16
------

> +    (description
> +     "Module for defining custom exceptions with specific messages.")

Descriptions should be "complete sentences". For example, this could be
written as "This package provides a Ruby module for defining custom
exceptions with specific messages."

I've attached a revised patchset to show what I mean. I was going to
push these revised patches until I read your followup message.

--v0pLRUu/sp2Bh2wb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: attachment; filename=solargraph-patches
Content-Transfer-Encoding: 8bit

From 50a2b025fade3fc2a305cd78d1611c516fe47510 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:16:15 -0500
Subject: [PATCH 1/3] gnu: Add ruby-e2mmap.

* gnu/packages/ruby.scm (ruby-e2mmap): New variable.
---
 gnu/packages/ruby.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 8fc228f6ed..939a686114 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -23,6 +23,7 @@
 ;;; Copyright  2020 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright  2020 Nicolas Goaziou <mail@HIDDEN>
 ;;; Copyright  2020 Michael Rohleder <mike@HIDDEN>
+;;; Copyright  2020 Toms Ortn Fernndez <tomasortin@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11637,6 +11638,26 @@ checking.")
     (home-page "https://solargraph.org/")
     (license license:expat)))
 
+(define-public ruby-e2mmap
+  (package
+    (name "ruby-e2mmap")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "e2mmap" version))
+       (sha256
+        (base32
+         "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ;; There is a rakefile but no tests
+    (synopsis "Define custom exceptions for Ruby")
+    (description "This package provides a Ruby module for defining custom
+exceptions with specific messages.")
+    (home-page "https://github.com/ruby/e2mmap")
+    (license license:bsd-2)))
+
 (define-public ruby-wayback-machine-downloader
   (package
     (name "ruby-wayback-machine-downloader")
-- 
2.29.2


From d1868eddf03ae24fc7ffbeb920e95a06838f6a8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:16:49 -0500
Subject: [PATCH 2/3] gnu: Add ruby-benchmark.

* gnu/packages/ruby.scm (ruby-benchmark): New variable.
---
 gnu/packages/ruby.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 939a686114..bc1ca15d67 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -11658,6 +11658,24 @@ exceptions with specific messages.")
     (home-page "https://github.com/ruby/e2mmap")
     (license license:bsd-2)))
 
+(define-public ruby-benchmark
+  (package
+    (name "ruby-benchmark")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "benchmark" version))
+       (sha256
+        (base32
+         "0jadlpsl504ql436a6bx8ihp0bkg3rvxg7fbi4r1bmra3cqz0h88"))))
+    (build-system ruby-build-system)
+    (synopsis "Performance benchmarking for Ruby")
+    (description "This package provides methods for benchmarking Ruby code,
+giving detailed reports on the time taken for each task.")
+    (home-page "https://github.com/ruby/benchmark")
+    (license license:bsd-2)))
+
 (define-public ruby-wayback-machine-downloader
   (package
     (name "ruby-wayback-machine-downloader")
-- 
2.29.2


From 9c8dd05ef67013b4599be78e21976b618b4d7e97 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?=
 <tomasortin@HIDDEN>
Date: Fri, 4 Dec 2020 14:17:09 -0500
Subject: [PATCH 3/3] gnu: ruby-solargraph: Update to 0.39.17.

* gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17.
[propagated-inputs]: Add ruby-benchmark and ruby-e2mmap.
---
 gnu/packages/ruby.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index bc1ca15d67..146263e0af 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -11587,19 +11587,20 @@ application.")
 (define-public ruby-solargraph
   (package
     (name "ruby-solargraph")
-    (version "0.36.0")
+    (version "0.39.17")
     (source
      (origin
        (method url-fetch)
        (uri (rubygems-uri "solargraph" version))
        (sha256
         (base32
-         "0b93xzkgd1h06da9gdnwivj1mzbil8lc072y2838dy6i7bxgpy9i"))))
+         "06fby6dpq1jcq30x8ladig4dvz8j2pxd08mkrad3d41jx33zd2hg"))))
     (build-system ruby-build-system)
     (propagated-inputs
      `(("ruby-backport" ,ruby-backport)
        ("bundler" ,bundler)
-       ("ruby-htmlentities" ,ruby-htmlentities)
+       ("ruby-benchmark" ,ruby-benchmark)
+       ("ruby-e2mmap" ,ruby-e2mmap)
        ("ruby-jaro-winkler" ,ruby-jaro-winkler)
        ("ruby-maruku" ,ruby-maruku)
        ("ruby-nokogiri" ,ruby-nokogiri)
-- 
2.29.2


--v0pLRUu/sp2Bh2wb--




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at 44882 <at> debbugs.gnu.org:


Received: (at 44882) by debbugs.gnu.org; 28 Nov 2020 08:53:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 28 03:53:36 2020
Received: from localhost ([127.0.0.1]:46928 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kivz6-0004cE-J5
	for submit <at> debbugs.gnu.org; Sat, 28 Nov 2020 03:53:36 -0500
Received: from mout-p-102.mailbox.org ([80.241.56.152]:33192)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tomasortin@HIDDEN>) id 1kivz1-0004bw-48
 for 44882 <at> debbugs.gnu.org; Sat, 28 Nov 2020 03:53:35 -0500
Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Cjldc3jKNzQlX1
 for <44882 <at> debbugs.gnu.org>; Sat, 28 Nov 2020 09:53:24 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-transfer-encoding:content-language:content-type
 :content-type:mime-version:date:date:message-id:subject:subject
 :from:from:received; s=mail20150812; t=1606553601; bh=/WM1GmnXoz
 4hsEssQNXFqlGD509ZqNSmvIgLxEReJhM=; b=VaVrQM23vi/KgwnkLBZh/mil9U
 meQMKkkX5VxMgwuzmiFnKpgE4c0q5Ziz0WCm6Nhr0E9uzm0PKAoTS/H47+DbqlXG
 93IqaOdfrNcGUcED3d/nF1dEKr+eyUWUM19adGVLqHgWpgZLKrBT+6+lnhGWyDSR
 gD447kiWFNlbhI70mDSFKv53czT4LII4u9AjEzxJt4rlH/QrZX8tZmTGtO10RRuU
 D+WOJzvIhe67kxqenyQhQvVKFpLhHtSAsz4CtciL9I35UebTUF3WLyi5ZR1Xo4tB
 LSKCzw9dtNhpOububAjunIcsc/10w2aXdQe1JAogyKQbBp2kCPpSdFWrbrZg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1606553602;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=/WM1GmnXoz4hsEssQNXFqlGD509ZqNSmvIgLxEReJhM=;
 b=A3+SdtBBNOrUVK0U9S5CGQAVEDVoOel7vdx7zWOl/2dZ5rq4BSDrEHIacbh+ZsKFjZXYYX
 BnKR6skPGuHnd9XF0/fZaN3nvo94AfmpoeeyYro9WbkhlZv9RpI6xiCNeNM5jCmRb68ZtA
 3AK6NGmJ80FrzOD4tj1FQY0qg/T96uKnZXT/JLvZwRJDVt2tz6Kt0dWRYO+4Kl4KEARbd9
 DW8oL4vgNvDXANgsBLnHiV249YBLckkkDPVFpN16xHE2fLf6rd9/cgBFUrfLKsEPJTzXph
 qUgnalICtcbbHTpggkclHOfJeDwzoiHygjvsuAOTcw7rPt9Zx9to+m99B9tSMg==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
 by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172])
 (amavisd-new, port 10030)
 with ESMTP id HcR2rm-02E88 for <44882 <at> debbugs.gnu.org>;
 Sat, 28 Nov 2020 09:53:21 +0100 (CET)
To: 44882 <at> debbugs.gnu.org
From: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>
Subject: Dependencies issues
Message-ID: <ff11ad2f-aa74-64db-d7ba-820e4b8fdd81@HIDDEN>
Date: Sat, 28 Nov 2020 09:53:20 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -1.86 / 15.00 / 15.00
X-Rspamd-Queue-Id: 8C666665
X-Rspamd-UID: 4172fd
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 44882
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

I have realized this patch isn't correct. I hadn't tested it on a clean environment before.
Solargraph requires Rubocop 0.52 (!). In fact, the current version of Solargraph doesn't currently work, either: there are version issues with Rubocop and with ruby-thor.

I need a more-or-less current Solargraph and Rubocop, that's why I have been updating some packages, but I realize now I wasn't doing it properly and that I'm getting tangled into a web of dependencies issues.

How should I proceed? Clearly Rubocop should be updated, but I don't know how to keep Solargraph working and how to figure out which packages will need to be updated or checked in case they need an older version of Rubocop.

I'm quite new to all of this, so sorry if I'm not doing things how I'm supposed to!

Tomás




Information forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 26 Nov 2020 10:02:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 26 05:02:27 2020
Received: from localhost ([127.0.0.1]:38495 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kiE6c-00076h-N2
	for submit <at> debbugs.gnu.org; Thu, 26 Nov 2020 05:02:26 -0500
Received: from lists.gnu.org ([209.51.188.17]:39782)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tomasortin@HIDDEN>) id 1kiE6b-00076a-7x
 for submit <at> debbugs.gnu.org; Thu, 26 Nov 2020 05:02:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37172)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tomasortin@HIDDEN>)
 id 1kiE6a-0002bd-Vt
 for guix-patches@HIDDEN; Thu, 26 Nov 2020 05:02:25 -0500
Received: from mout-p-101.mailbox.org ([80.241.56.151]:53680)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <tomasortin@HIDDEN>)
 id 1kiE6X-0008I6-9e
 for guix-patches@HIDDEN; Thu, 26 Nov 2020 05:02:24 -0500
Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4ChYG26D6JzQl8x
 for <guix-patches@HIDDEN>; Thu, 26 Nov 2020 11:02:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-transfer-encoding:content-language:content-type
 :content-type:mime-version:date:date:message-id:subject:subject
 :from:from:received; s=mail20150812; t=1606384932; bh=sokVaDqmkv
 nLLI2g2F87xrHHgCcCyMO5XyDoCgfTGKQ=; b=R8zJAfWBEJCESosznxM14GciZV
 Vi+biqh3xEk0dkHnh166uK9zDrsDSWcauMxswPgmeW+rYFFRNVeRV/noKUR3C/nE
 VJ7r7pI/kN/pnKBC8uBgn8nZiL8XPtu/FFPVC5Kgahl6W5hZOLgt+qNlaLMmKM9l
 fNyY6Ab+uGRd/Wgv+2uPPCEWmfrx1BxO/Pl1ej1aCU0xph/CSqlLD32S6EwVeuio
 S8Ps8+ItTlXGvP6G/5eNgJb2KR3zBrgnvdQ5eexKkWkQA0ZZdSY8UKT0E54XlOKv
 k7wN8K5j/GdlQ/XZkoG87CyRjYOr8QTSUKVu1AY/T4kzbKoutMzJtK8VcLfA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1606384936;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=/3aFhxvNy+If6+GObb372Shce2j52K1LSUz0bzy3+m0=;
 b=vJvjY6XlCx3SnnUnaT/VnzGM5V3lInroseYV+0OZ/aAhHJ7DNJLk0Ow+uuEpDOUtm7uy/v
 AI8qqH5pZziEosqA8170cXWorWGbRLwPVCJtwQLQvB5U+VqXp6L90sFaFZE6Z+fT88rfIo
 4FG+jSv9v2ElCSj7Z7blxPltEAt9Vwc5SUZVmeDjX3TvY/RSTWKmGvT86thc1CKjh+5MjJ
 Ducy74Qh2xP1cvYVO2bc6fu6CqDeV/Af7Szx+Ci79gEnJ5R6dZzi/42aymT3jbDrDnxQfF
 ij6nnfbYQUBTfjfoVRouHq2d9ErvKkV3OGvHW2hHPb8x0kwMmshoEthwLSKxhA==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
 by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de
 [80.241.56.117]) (amavisd-new, port 10030)
 with ESMTP id 1v583XGK2BH3 for <guix-patches@HIDDEN>;
 Thu, 26 Nov 2020 11:02:12 +0100 (CET)
To: guix-patches@HIDDEN
From: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>
Subject: [PATCH] gnu: ruby-solargraph: Update to 0.39.17 and add two
 dependencies
Message-ID: <55bea941-e029-69b7-0603-5548567659ef@HIDDEN>
Date: Thu, 26 Nov 2020 11:02:11 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -7.59 / 15.00 / 15.00
X-Rspamd-Queue-Id: 9B01A183D
X-Rspamd-UID: 231948
Received-SPF: pass client-ip=80.241.56.151;
 envelope-from=tomasortin@HIDDEN; helo=mout-p-101.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17.
* gnu/packages/ruby.scm (ruby-e2mmap): New variable.
* gnu/packages/ruby.scm (ruby-benchmark): New variable.
---
gnu/packages/ruby.scm | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 47 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 2753403834..71a970e2b8 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright © 2020 Nicolas Goaziou <mail@HIDDEN>
 ;;; Copyright © 2020 Michael Rohleder <mike@HIDDEN>
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11587,19 +11588,20 @@ application.")
 (define-public ruby-solargraph
   (package
     (name "ruby-solargraph")
-    (version "0.36.0")
+    (version "0.39.17")
     (source
      (origin
        (method url-fetch)
        (uri (rubygems-uri "solargraph" version))
        (sha256
         (base32
-         "0b93xzkgd1h06da9gdnwivj1mzbil8lc072y2838dy6i7bxgpy9i"))))
+         "06fby6dpq1jcq30x8ladig4dvz8j2pxd08mkrad3d41jx33zd2hg"))))
     (build-system ruby-build-system)
     (propagated-inputs
      `(("ruby-backport" ,ruby-backport)
        ("bundler" ,bundler)
-       ("ruby-htmlentities" ,ruby-htmlentities)
+       ("ruby-benchmark" ,ruby-benchmark)
+       ("ruby-e2mmap" ,ruby-e2mmap)
        ("ruby-jaro-winkler" ,ruby-jaro-winkler)
        ("ruby-maruku" ,ruby-maruku)
        ("ruby-nokogiri" ,ruby-nokogiri)
@@ -11638,6 +11640,48 @@ checking.")
     (home-page "https://solargraph.org/")
     (license license:expat)))
 
+(define-public ruby-e2mmap
+  (package
+    (name "ruby-e2mmap")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "e2mmap" version))
+       (sha256
+        (base32
+         "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5"))))
+    (build-system ruby-build-system)
+    (propagated-inputs
+     `(("bundler" ,bundler)))
+    (arguments
+     `(#:tests? #f)) ;; There is a rakefile but no tests
+    (synopsis
+     "Module for defining custom exceptions with specific messages")
+    (description
+     "Module for defining custom exceptions with specific messages.")
+    (home-page "https://github.com/ruby/e2mmap")
+    (license license:bsd-2)))
+
+(define-public ruby-benchmark
+  (package
+    (name "ruby-benchmark")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "benchmark" version))
+       (sha256
+        (base32
+         "0jadlpsl504ql436a6bx8ihp0bkg3rvxg7fbi4r1bmra3cqz0h88"))))
+    (build-system ruby-build-system)
+    (synopsis "Performance benchmarking library")
+    (description
+     "Provides methods for benchmarking Ruby code, giving detailed reports on
+the time taken for each task.")
+    (home-page "https://github.com/ruby/benchmark")
+    (license license:bsd-2)))
+
 (define-public ruby-wayback-machine-downloader
   (package
     (name "ruby-wayback-machine-downloader")




Acknowledgement sent to Tomás Ortín Fernández <tomasortin@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#44882; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 28 Dec 2020 01:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.