GNU bug report logs -
#44892
[PATCH] build: qt-build-system: Preserve existing variables when wrapping programs.
Previous Next
Reported by: Timotej Lazar <timotej.lazar <at> araneo.si>
Date: Thu, 26 Nov 2020 20:02:01 UTC
Severity: normal
Tags: patch
Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44892 in the body.
You can then email your comments to 44892 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#44892
; Package
guix-patches
.
(Thu, 26 Nov 2020 20:02:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Timotej Lazar <timotej.lazar <at> araneo.si>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Thu, 26 Nov 2020 20:02:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
This ensures that any additional plugin and icon directories installed in the
profile are found by the wrapped program.
* guix/build/qt-build-system.scm (variables-for-wrapping): Use prefix instead
of = for wrap-program.
---
Hi,
The qt-wrap phase sets environment variables (including XDG_DATA_DIRS
and QT_PLUGIN_PATH) to ensure that required plugin and data directories
are found at runtime. The current code uses = for wrap-program, which
overrides any existing settings for those variables and prevents Qt from
finding additional plugins and icons installed in the user’s profile.
For instance, this prevented qpdfview from picking up the icon theme set
by LXQt.
This patch prepends paths to environment variables instead of overriding
them, so that any paths that are already set are also searched. I used
prefix instead of suffix so that the paths required by the program
itself are considered first.
I think but am not sure that this is the right approach. There are ~170
packages using qt-build-system, including some KDE libs that many other
packages depend on, so this should probably be applied to staging. I
checked that the patch works for a small sample of packages (kmines,
lyx, quaternion, quassel, qpdfview, scantailor and zeal). Unfortunately
I can’t easily rebuild KDE to test everything.
Thanks!
Timotej
guix/build/qt-build-system.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/build/qt-build-system.scm b/guix/build/qt-build-system.scm
index 005157b0a4..93f512b5d6 100644
--- a/guix/build/qt-build-system.scm
+++ b/guix/build/qt-build-system.scm
@@ -60,7 +60,7 @@
(lambda (var-to-wrap) (not (null? (last var-to-wrap))))
(map
(lambda (var-spec)
- `(,(first var-spec) = ,(collect-sub-dirs base-directories (last var-spec))))
+ `(,(first var-spec) prefix ,(collect-sub-dirs base-directories (last var-spec))))
(list
;; these shall match the search-path-specification for Qt and KDE
;; libraries
--
2.29.2
Reply sent
to
Hartmut Goebel <h.goebel <at> crazy-compilers.com>
:
You have taken responsibility.
(Mon, 11 Jan 2021 16:07:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Timotej Lazar <timotej.lazar <at> araneo.si>
:
bug acknowledged by developer.
(Mon, 11 Jan 2021 16:07:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 44892-close <at> debbugs.gnu.org (full text, mbox):
This patch has been superseded by http://issues.guix.gnu.org/45784 and
following, esp. http://issues.guix.gnu.org/45785
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 09 Feb 2021 12:24:13 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 68 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.