GNU bug report logs - #44893
`guix deploy` doesn't recognize option --dry-run

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44893 in the body.
You can then email your comments to 44893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: `guix deploy` doesn't recognize option --dry-run
Date: Thu, 26 Nov 2020 13:11:33 -0700

--dry-run is an option listed in `guix deploy --help` but when I try it, 
it isn't recognized:

$ guix deploy --dry-run deploy.scm
guix deploy: error: dry-run: unrecognized option

Message #8 received at 44893 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 44893 <at> debbugs.gnu.org
Subject: Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
Date: Sat, 28 Nov 2020 11:48:44 +0100

Dear,

Thank you for the report.

On Thu, 26 Nov 2020 at 13:11, Jesse Gibbons <jgibbons2357 <at> gmail.com> wrote:
> --dry-run is an option listed in `guix deploy --help` but when I try it, 
> it isn't recognized:
>
> $ guix deploy --dry-run deploy.scm
> guix deploy: error: dry-run: unrecognized option

Yeah, it is because ’show-build-options-help’ is used.  I am not using
“guix deploy” and the question is: are all the build options working?

The build options of ’show-build-options-help’ are:

  -L, --load-path=DIR    prepend DIR to the package module search path
  -K, --keep-failed      keep build tree of failed builds
  -k, --keep-going       keep going when some of the derivations fail
  -n, --dry-run          do not build the derivations
      --fallback         fall back to building when the substituter fails
      --no-substitutes   build instead of resorting to pre-built substitutes
      --substitute-urls=URLS
                         fetch substitute from URLS if they are authorized
      --no-grafts        do not graft packages
      --no-offload       do not attempt to offload builds
      --max-silent-time=SECONDS
                         mark the build as failed after SECONDS of silence
      --timeout=SECONDS  mark the build as failed after SECONDS of activity
      --rounds=N         build N times in a row to detect non-determinism
  -c, --cores=N          allow the use of up to N CPU cores for the build
  -M, --max-jobs=N       allow at most N build jobs
      --debug=LEVEL      produce debugging output at LEVEL

The relevant piece of code is:

--8<---------------cut here---------------start------------->8---
      (with-status-verbosity (assoc-ref opts 'verbosity)
        (with-store store
          (set-build-options-from-command-line store opts)
          (with-build-handler (build-notifier #:use-substitutes?
                                              (assoc-ref opts 'substitutes?)
                                              #:verbosity
                                              (assoc-ref opts 'verbosity))
            (parameterize ((%graft? (assq-ref opts 'graft?)))
              (map/accumulate-builds store
                                     (cut deploy-machine* store <>)
                                     machines))))))))
--8<---------------cut here---------------end--------------->8---

So most of them should work, could you confirm?


What --dry-run should do in the case of “guix deploy”?


All the best,
simon

Message #13 received at 44893 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 44893 <at> debbugs.gnu.org
Subject: Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
Date: Sat, 05 Dec 2020 15:24:19 +0100

[Message part 1 (text/plain, inline)]

Hi,

We can make this change:

[Message part 2 (text/x-patch, inline)]

diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm
index 0725fba54b..d9371b3d4a 100644
--- a/guix/scripts/deploy.scm
+++ b/guix/scripts/deploy.scm
@@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n"))
           (with-build-handler (build-notifier #:use-substitutes?
                                               (assoc-ref opts 'substitutes?)
                                               #:verbosity
-                                              (assoc-ref opts 'verbosity))
+                                              (assoc-ref opts 'verbosity)
+                                              #:dry-run?
+                                              (assoc-ref opts 'dry-run?))
             (parameterize ((%graft? (assq-ref opts 'graft?)))
               (map/accumulate-builds store
                                      (cut deploy-machine* store <>)

[Message part 3 (text/plain, inline)]

It may not be the kind of “dry run” that users have in mind for ‘guix
deploy’, as you note zimoun, but that’s probably better than nothing.

Thoughts?

Ludo’.

Message #18 received at 44893-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44893-done <at> debbugs.gnu.org, Jesse Gibbons <jgibbons2357 <at> gmail.com>,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
Date: Mon, 25 Jul 2022 08:31:50 -0400

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> We can make this change:
>
> diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm
> index 0725fba54b..d9371b3d4a 100644
> --- a/guix/scripts/deploy.scm
> +++ b/guix/scripts/deploy.scm
> @@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n"))
>            (with-build-handler (build-notifier #:use-substitutes?
>                                                (assoc-ref opts 'substitutes?)
>                                                #:verbosity
> -                                              (assoc-ref opts 'verbosity))
> +                                              (assoc-ref opts 'verbosity)
> +                                              #:dry-run?
> +                                              (assoc-ref opts 'dry-run?))
>              (parameterize ((%graft? (assq-ref opts 'graft?)))
>                (map/accumulate-builds store
>                                       (cut deploy-machine* store <>)
>
>
> It may not be the kind of “dry run” that users have in mind for ‘guix
> deploy’, as you note zimoun, but that’s probably better than nothing.
>
> Thoughts?

I see such a fix was pushed as ff94f9dfde; closing!

Thank you,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.