GNU bug report logs - #44913
[PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44913 in the body.
You can then email your comments to 44913 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomás Ortín Fernández <tomasortin <at> mailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0.
Date: Fri, 27 Nov 2020 23:22:44 +0100

* gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0.
---
gnu/packages/ruby.scm | 25 +++++--------------------
1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ae2da01f63..fc69f4db05 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -6823,32 +6823,17 @@ inspired by the Sinatra microframework style of specifying actions:
 (define-public ruby-rubocop-ast
   (package
     (name "ruby-rubocop-ast")
-    (version "0.3.0")
+    (version "1.2.0")
     (source
      (origin
-       (method git-fetch)               ;no test suite in distributed gem
-       (uri (git-reference
-             (url "https://github.com/rubocop-hq/rubocop-ast")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (rubygems-uri "rubocop-ast" version))
        (sha256
         (base32
-         "1ycf6qcj8nbzk2js72priim4642lkn56w5kbny1nlryjkckxgm04"))))
+         "0q0kdi89ad7dd1xmzrdf5ikk32bllzr68hf4x8fd7azcv5jnch2l"))))
     (build-system ruby-build-system)
     (arguments
-     `(#:test-target "spec"
-       #:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'disable-bundler
-                    (lambda _
-                      (substitute* "Rakefile"
-                        (("Bundler\\.setup.*") "nil\n"))
-                      #t))
-                  (replace 'replace-git-ls-files
-                    (lambda _
-                      (substitute* "rubocop-ast.gemspec"
-                        (("`git ls-files(.*)`" _ files)
-                         (format #f "`find ~a -type f| sort`" files)))
-                      #t)))))
+     '(#:tests? #f)) ; tests not included in gem
     (native-inputs
      `(("ruby-bump" ,ruby-bump)
        ("ruby-rspec" ,ruby-rspec)))

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tomás Ortín Fernández via Guix-patches via
 <guix-patches <at> gnu.org>
Cc: 44913 <at> debbugs.gnu.org
Subject: Re: [bug#44913] [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0.
Date: Fri, 4 Dec 2020 19:01:33 -0500

On Fri, Nov 27, 2020 at 11:22:44PM +0100, Tomás Ortín Fernández via Guix-patches via wrote:
> * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0.

Thanks!

>      (source
>       (origin
> -       (method git-fetch)               ;no test suite in distributed gem
> -       (uri (git-reference
> -             (url "https://github.com/rubocop-hq/rubocop-ast")
> -             (commit (string-append "v" version))))
> -       (file-name (git-file-name name version))
> +       (method url-fetch)
> +       (uri (rubygems-uri "rubocop-ast" version))
>         (sha256
>          (base32
> -         "1ycf6qcj8nbzk2js72priim4642lkn56w5kbny1nlryjkckxgm04"))))
> +         "0q0kdi89ad7dd1xmzrdf5ikk32bllzr68hf4x8fd7azcv5jnch2l"))))
>      (build-system ruby-build-system)
>      (arguments
> -     `(#:test-target "spec"
> -       #:phases (modify-phases %standard-phases
> -                  (add-after 'unpack 'disable-bundler
> -                    (lambda _
> -                      (substitute* "Rakefile"
> -                        (("Bundler\\.setup.*") "nil\n"))
> -                      #t))
> -                  (replace 'replace-git-ls-files
> -                    (lambda _
> -                      (substitute* "rubocop-ast.gemspec"
> -                        (("`git ls-files(.*)`" _ files)
> -                         (format #f "`find ~a -type f| sort`" files)))
> -                      #t)))))
> +     '(#:tests? #f)) ; tests not included in gem

The commit message should describe the changes to the code.

For example, I might write it this way:

------
gnu: ruby-rubocop-ast: Update to 1.2.0.

* gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0.
[source]: Fetch source from rubygems.
[arguments]: Remove obsolete 'disable-bundler' phase. Skip the test suite.
------

This helps communicate your intentions to reviewers (and everyone else).

For example, why does the patch remove the 'disable-bundler' phase? If that
phase is no longer needed, it helps to describe it as obsolete in the commit
message.

The code comment about why the tests are skipped is really useful, for the same
reason. But we can't add comments about code that is removed :)

Does that make sense? Can you send a revised patch with a complete commit
message? It's fine to copy what I wrote if it is accurate.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Tomás Ortín Fernández via Guix-patches via
 <guix-patches <at> gnu.org>
Cc: Tomás Ortín Fernández <tomasortin <at> mailbox.org>,
 44913-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#44913] [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0.
Date: Thu, 25 Feb 2021 23:53:37 +0100

[Message part 1 (text/plain, inline)]

On Fri, 27 Nov 2020 23:22:44 +0100
Tomás Ortín Fernández via Guix-patches via <guix-patches <at> gnu.org> wrote:

> * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0.

This package was updated to 1.4.1 in commit

6e3a85192ca48a749858c8c7f128c5ec59c2ff89

Closing this patch.

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.