GNU bug report logs - #44924
guix build u-boot-pinebook --with-git-url failed due to "source" in C_INCLUDE_PATH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44924 in the body.
You can then email your comments to 44924 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: bug-guix <at> gnu.org
Subject: guix build u-boot-pinebook --with-git-url failed due to "source" in
 C_INCLUDE_PATH
Date: Sat, 28 Nov 2020 22:58:49 +0800

Running:
  guix build u-boot-pinebook \
    --with-git-url=u-boot-pinebook=https://github.com/u-boot/u-boot

Would fail with "fatal error: asm/string.h: No such file or directory".

And it's caused by the first entry in C_INCLUDE_PATH, which is
"/gnu/store/xxx-u-boot-xxx/include".

I think we should filter out "source" in `set-paths` of the
`gnu-build-system`.

Message #8 received at 44924 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 44924 <at> debbugs.gnu.org
Subject: Re: bug#44924: guix build u-boot-pinebook --with-git-url failed due
 to "source" in C_INCLUDE_PATH
Date: Thu, 03 Dec 2020 17:58:03 +0100

Hi,

宋文武 <iyzsong <at> outlook.com> skribis:

> Running:
>   guix build u-boot-pinebook \
>     --with-git-url=u-boot-pinebook=https://github.com/u-boot/u-boot
>
> Would fail with "fatal error: asm/string.h: No such file or directory".
>
> And it's caused by the first entry in C_INCLUDE_PATH, which is
> "/gnu/store/xxx-u-boot-xxx/include".

Why don’t we have that problem when omitting ‘--with-git-url’?

> I think we should filter out "source" in `set-paths` of the
> `gnu-build-system`.

Yes, sounds like a good idea.  We can do it in ‘core-updates’.

Thanks,
Ludo’.

Message #11 received at 44924 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44924 <at> debbugs.gnu.org
Subject: Re: bug#44924: guix build u-boot-pinebook --with-git-url failed due
 to "source" in C_INCLUDE_PATH
Date: Sat, 05 Dec 2020 11:50:01 +0800

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> 宋文武 <iyzsong <at> outlook.com> skribis:
>
>> Running:
>>   guix build u-boot-pinebook \
>>     --with-git-url=u-boot-pinebook=https://github.com/u-boot/u-boot
>>
>> Would fail with "fatal error: asm/string.h: No such file or directory".
>>
>> And it's caused by the first entry in C_INCLUDE_PATH, which is
>> "/gnu/store/xxx-u-boot-xxx/include".
>
> Why don’t we have that problem when omitting ‘--with-git-url’?

When not use git, source is a tarball, not a directory, so it's ignored
by "set-paths".

>
>> I think we should filter out "source" in `set-paths` of the
>> `gnu-build-system`.
>
> Yes, sounds like a good idea.  We can do it in ‘core-updates’.

Here is patch:

[0001-build-system-gnu-Remove-the-source-directory-from-se.patch (text/x-patch, inline)]

From 77283132c6eeeb75900afad5782b989ceee1506a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong <at> member.fsf.org>
Date: Sat, 5 Dec 2020 11:35:37 +0800
Subject: [PATCH] build-system/gnu: Remove the source directory from search
 paths.

Fixes <https://issues.guix.gnu.org/44924>.

* guix/build/gnu-build-system.scm (set-paths): Delete 'source' from
'input-directories'.
---
 guix/build/gnu-build-system.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index 5f08b9d6ac..f9e6f5013d 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -72,7 +72,9 @@ See https://reproducible-builds.org/specs/source-date-epoch/."
                     (search-paths '()) (native-search-paths '())
                     #:allow-other-keys)
   (define input-directories
-    (match inputs
+    ;; The "source" input can be a directory, but we don't want it for search
+    ;; paths.  See <https://issues.guix.gnu.org/44924>.
+    (match (alist-delete "source" inputs)
       (((_ . dir) ...)
        dir)))
 
-- 
2.29.1

[Message part 3 (text/plain, inline)]

Thanks!

Message #14 received at 44924 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 44924 <at> debbugs.gnu.org
Subject: Re: bug#44924: guix build u-boot-pinebook --with-git-url failed due
 to "source" in C_INCLUDE_PATH
Date: Mon, 07 Dec 2020 10:08:53 +0100

Hi,

宋文武 <iyzsong <at> outlook.com> skribis:

> From 77283132c6eeeb75900afad5782b989ceee1506a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong <at> member.fsf.org>
> Date: Sat, 5 Dec 2020 11:35:37 +0800
> Subject: [PATCH] build-system/gnu: Remove the source directory from search
>  paths.
>
> Fixes <https://issues.guix.gnu.org/44924>.
>
> * guix/build/gnu-build-system.scm (set-paths): Delete 'source' from
> 'input-directories'.
> ---
>  guix/build/gnu-build-system.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

LGTM!

You can push it right away to ‘core-updates’, but since it triggers a
full rebuild, now’s a good time to push another change that triggers a
full rebuild.  :-)

Thanks,
Ludo’.

Message #19 received at 44924-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44924-done <at> debbugs.gnu.org
Subject: Re: bug#44924: guix build u-boot-pinebook --with-git-url failed due
 to "source" in C_INCLUDE_PATH
Date: Mon, 07 Dec 2020 18:50:11 +0800

> LGTM!
>
> You can push it right away to ‘core-updates’, but since it triggers a
> full rebuild, now’s a good time to push another change that triggers a
> full rebuild.  :-)
>

Pushed bravely, thank you!

Message #28 received at 44924 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 44924 <at> debbugs.gnu.org, GNU Debbugs <control <at> debbugs.gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH v2 core-updates] build: gnu-build-system: Remove source from
 native inputs.
Date: Tue, 06 Dec 2022 22:07:15 -0500

[Message part 1 (text/plain, inline)]

Hi again,

Here's a v2, which guards against a #f native-inputs (when no
cross-compiling).

[0001-build-gnu-build-system-Remove-source-from-native-inp.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Thanks,
Maxim

Message #33 received at 44924-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: 44924-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#44924: guix build u-boot-pinebook --with-git-url failed due
 to "source" in C_INCLUDE_PATH
Date: Wed, 07 Dec 2022 09:50:32 -0500

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi again,
>
> Here's a v2, which guards against a #f native-inputs (when no
> cross-compiling).

Pushed to core-updates with commit 6454208222.

Closing!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.