GNU bug report logs - #44940
[PATCH 1/4] gnu: Add go-github-com-nwidger-jsoncolor.

Previous Next

Package: guix-patches;

Reported by: Joseph LaFreniere <joseph <at> lafreniere.xyz>

Date: Sun, 29 Nov 2020 05:00:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44940 in the body.
You can then email your comments to 44940 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Joseph LaFreniere <joseph <at> lafreniere.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 29 Nov 2020 05:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/4] gnu: Add go-github-com-nwidger-jsoncolor.
Date: Sat, 28 Nov 2020 22:58:58 -0600
[Message part 1 (text/plain, inline)]
Patch file attached.

--
Joseph LaFreniere
[0001-gnu-Add-go-github-com-nwidger-jsoncolor.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: 44940 <at> debbugs.gnu.org
Cc: Joseph LaFreniere <joseph <at> lafreniere.xyz>, guix-patches <at> gnu.org
Subject: [PATCH 2/4] gnu: go-github-com-mattn-go-colorable: Update to 0.1.8.
Date: Sat, 28 Nov 2020 23:08:00 -0600
* gnu/packages/golang.scm (go-github-com-mattn-go-colorable): Update to 0.1.8.
---
 gnu/packages/golang.scm | 48 ++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72f43efd8a..cb7fe6e3bb 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1965,32 +1965,30 @@ terminal.")
     (license license:expat)))
 
 (define-public go-github-com-mattn-go-colorable
-  (let ((commit "efa589957cd060542a26d2dd7832fd6a6c6c3ade")
-        (revision "0"))
-    (package
-      (name "go-github-com-mattn-go-colorable")
-      (version (git-version "0.0.0" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/mattn/go-colorable")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "0kshi4hvm0ayrsxqxy0599iv81kryhd2fn9lwjyczpj593cq069r"))))
-      (build-system go-build-system)
-      (native-inputs
-       `(("go-github-com-mattn-go-isatty"
-          ,go-github-com-mattn-go-isatty)))
-      (arguments
-       '(#:import-path "github.com/mattn/go-colorable"))
-      (home-page "https://github.com/mattn/go-colorable")
-      (synopsis "Handle ANSI color escapes on Windows")
-      (description "This package provides @code{colorable}, a module that
+  (package
+    (name "go-github-com-mattn-go-colorable")
+    (version "0.1.8")
+    (home-page "https://github.com/mattn/go-colorable")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0q34zqwbnls72md8q8mhj368s7p3i4xspvs3rk8fs76s0pn7dr2l"))))
+    (build-system go-build-system)
+    (native-inputs
+     `(("go-github-com-mattn-go-isatty"
+        ,go-github-com-mattn-go-isatty)))
+    (arguments
+     '(#:import-path "github.com/mattn/go-colorable"))
+    (synopsis "Handle ANSI color escapes on Windows")
+    (description "This package provides @code{colorable}, a module that
 makes it possible to handle ANSI color escapes on Windows.")
-      (license license:expat))))
+    (license license:expat)))
 
 (define-public go-github-com-mattn-go-pointer
   (let ((commit "a0a44394634f41e4992b173b24f14fecd3318a67")
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: 44940 <at> debbugs.gnu.org
Cc: Joseph LaFreniere <joseph <at> lafreniere.xyz>, guix-patches <at> gnu.org
Subject: [PATCH 3/4] gnu: Add go-github-com-tomnomnom-gron.
Date: Sat, 28 Nov 2020 23:08:01 -0600
* gnu/packages/golang.scm (go-github-com-tomnomnom-gron): New variable.
---
 gnu/packages/golang.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index cb7fe6e3bb..a4f0c80ce9 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1135,6 +1135,46 @@ Features include:
 optimized for performance yet simple to use.")
       (license license:expat))))
 
+(define-public go-github-com-tomnomnom-gron
+  (package
+    (name "go-github-com-tomnomnom-gron")
+    (version "0.6.0")
+    (home-page "https://github.com/tomnomnom/gron")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "05f3w4zr15wd7xk75l12y5kip4gnv719a2x9w2hy23q3pnss9wk0"))))
+    (build-system go-build-system)
+    (arguments
+     (let ((import-path "github.com/tomnomnom/gron"))
+       `(#:import-path ,import-path
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'check 'remove-non-source
+             (lambda _
+               (for-each (lambda (dir)
+                           (delete-file-recursively
+                            (string-append "src/" ,import-path dir)))
+                         '("/docs" "/script" "/testdata"))
+               #t))))))
+    (inputs
+     `(("github.com/fatih/color" ,go-github-com-fatih-color)
+       ("github.com/mattn/go-colorable" ,go-github-com-mattn-go-colorable)
+       ("github.com/mattn/go-isatty" ,go-github-com-mattn-go-isatty)
+       ("github.com/nwidger/jsoncolor" ,go-github-com-nwidger-jsoncolor)
+       ("github.com/pkg/errors" ,go-github-com-pkg-errors)))
+    (synopsis "Transform JSON to make it easier to grep")
+    (description
+     "This package transforms JSON into discrete assignments to make it easier
+to use line-based tools such as grep to search for what you want and see the
+absolute \"path\" to it.")
+    (license license:expat)))
+
 (define-public go-github-com-tv42-httpunix
   (let ((commit "2ba4b9c3382c77e7b9ea89d00746e6111d142a22")
         (revision "0"))
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:03 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: 44940 <at> debbugs.gnu.org
Cc: Joseph LaFreniere <joseph <at> lafreniere.xyz>, guix-patches <at> gnu.org
Subject: [PATCH 4/4] gnu: Add gron.
Date: Sat, 28 Nov 2020 23:08:02 -0600
* gnu/packages/golang.scm (gron): New variable.
---
 gnu/packages/golang.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a4f0c80ce9..2b4de0cd4f 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1175,6 +1175,8 @@ to use line-based tools such as grep to search for what you want and see the
 absolute \"path\" to it.")
     (license license:expat)))
 
+(define-public gron go-github-com-tomnomnom-gron)
+
 (define-public go-github-com-tv42-httpunix
   (let ((commit "2ba4b9c3382c77e7b9ea89d00746e6111d142a22")
         (revision "0"))
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:04 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 29 Nov 2020 05:09:04 GMT) Full text and rfc822 format available.

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Wed, 23 Dec 2020 16:08:01 GMT) Full text and rfc822 format available.

Notification sent to Joseph LaFreniere <joseph <at> lafreniere.xyz>:
bug acknowledged by developer. (Wed, 23 Dec 2020 16:08:01 GMT) Full text and rfc822 format available.

Message #28 received at 44940-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Joseph LaFreniere <joseph <at> lafreniere.xyz>
Cc: 44940-done <at> debbugs.gnu.org
Subject: Re: [bug#44940] [PATCH 2/4] gnu: go-github-com-mattn-go-colorable:
 Update to 0.1.8.
Date: Wed, 23 Dec 2020 17:07:31 +0100
Hi,

Joseph LaFreniere <joseph <at> lafreniere.xyz> skribis:

> * gnu/packages/golang.scm (go-github-com-mattn-go-colorable): Update to 0.1.8.

Applied.

> * gnu/packages/golang.scm (go-github-com-tomnomnom-gron): New variable.

Applied, but I changed the ‘name’ field to ‘gron’, as is commonly done
for applications.

> * gnu/packages/golang.scm (gron): New variable.

This patch has no effect; perhaps what you wanted is for the package
name to be ‘gron’, like I did above?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#44940; Package guix-patches. (Sun, 27 Dec 2020 20:21:01 GMT) Full text and rfc822 format available.

Message #31 received at 44940-done <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Joseph LaFreniere <joseph <at> lafreniere.xyz>, 44940-done <at> debbugs.gnu.org
Subject: Re: [bug#44940] [PATCH 2/4] gnu: go-github-com-mattn-go-colorable:
 Update to 0.1.8.
Date: Sun, 27 Dec 2020 14:20:07 -0600
Ludovic Courtès <ludo <at> gnu.org> writes:
>> * gnu/packages/golang.scm (go-github-com-tomnomnom-gron): New 
>> variable.
>
> Applied, but I changed the ‘name’ field to ‘gron’, as is 
> commonly done
> for applications.

Noted.  I had originally provided the full, Go package-style name 
in the event that gron were ever used as a dependency by another 
Go package.

>> * gnu/packages/golang.scm (gron): New variable.
>
> This patch has no effect; perhaps what you wanted is for the 
> package
> name to be ‘gron’, like I did above?

Yes, that was my intent.

Thank you for merging!

--
Joseph LaFreniere




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 25 Jan 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 62 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.