GNU bug report logs - #44957
Pidgin

Previous Next

Package: guix-patches;

Reported by: Raghav Gururajan <rg <at> raghavgururajan.name>

Date: Mon, 30 Nov 2020 00:56:02 UTC

Severity: normal

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44957 in the body.
You can then email your comments to 44957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 30 Nov 2020 00:56:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Nov 2020 00:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Subject: Pidgin
Date: Sun, 29 Nov 2020 19:54:59 -0500

[Message part 1 (text/plain, inline)]
Hello Guix!

This patch series is to make Pidgin awesome again for users.

Objectives:
[1] Clean up package-definition.
[2] Package missing inputs to Guix and add them to pidgin.
[3] Enable missing features.
[4] Upgrade to 2.14.X
[5] Enable A/V support.

Regards,
RG.

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-Add-meanwhile.patch (text/x-patch, attachment)]
[0004-gnu-Add-silc-toolkit.patch (text/x-patch, attachment)]
[0005-gnu-Add-libgadu.patch (text/x-patch, attachment)]
[0006-gnu-Add-libgnt.patch (text/x-patch, attachment)]
[0007-gnu-pidgin-Enable-some-features.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 30 Nov 2020 03:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 44957 <at> debbugs.gnu.org
Subject: [PIDGIN]: v2
Date: Sun, 29 Nov 2020 22:46:12 -0500

[Message part 1 (text/plain, inline)]
Revised patch-set.

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-Add-meanwhile.patch (text/x-patch, attachment)]
[0004-gnu-Add-silc-toolkit.patch (text/x-patch, attachment)]
[0005-gnu-Add-libgadu.patch (text/x-patch, attachment)]
[0006-gnu-Add-libgnt.patch (text/x-patch, attachment)]
[0007-gnu-pidgin-Enable-some-features.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[0009-gnu-pidgin-Enable-MultiMedia-and-A-V-support.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 30 Nov 2020 06:24:01 GMT) Full text and rfc822 format available.

Message #11 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 44957 <at> debbugs.gnu.org
Subject: [PIDGIN]: v3
Date: Mon, 30 Nov 2020 01:22:44 -0500

[Message part 1 (text/plain, inline)]
Patch-set v3

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-Add-meanwhile.patch (text/x-patch, attachment)]
[0004-gnu-Add-silc-toolkit.patch (text/x-patch, attachment)]
[0005-gnu-Add-libgadu.patch (text/x-patch, attachment)]
[0006-gnu-Add-libgnt.patch (text/x-patch, attachment)]
[0007-gnu-pidgin-Enable-some-features.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[0009-gnu-pidgin-Enable-MultiMedia-and-A-V-support.patch (text/x-patch, attachment)]
[0010-gnu-libotr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0011-gnu-libotr-Update-license.patch (text/x-patch, attachment)]
[0012-gnu-pidgin-otr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0013-gnu-pidgin-otr-Update-license.patch (text/x-patch, attachment)]
[0014-gnu-pidgin-otr-Add-some-inputs.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 30 Nov 2020 09:17:01 GMT) Full text and rfc822 format available.

Message #14 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [bug#44957] [PIDGIN]: v3
Date: Mon, 30 Nov 2020 10:16:45 +0100

[Message part 1 (text/plain, inline)]
Could you add author, date etc to b/gnu/packages/patches/pidgin-vv-gst.patch ?

[Message part 2 (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 30 Nov 2020 23:46:02 GMT) Full text and rfc822 format available.

Message #17 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [bug#44957] [PIDGIN]: v3
Date: Mon, 30 Nov 2020 18:45:23 -0500

[Message part 1 (text/plain, inline)]
Hi Danny!

> Could you add author, date etc to b/gnu/packages/patches/pidgin-vv-gst.patch ?

I used the upstream patch 
(https://keep.imfreedom.org/pidgin/pidgin/rev/39ac50435cfb). But the 
upstream does not use git. So I was unable to get the patch in 
'format-patch' way and only in 'diff' way. Is it okay if mention the 
author and date in commit message and/or as comment inside package 
definition?

Regards,
RG.


[OpenPGP_signature (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Tue, 01 Dec 2020 22:44:01 GMT) Full text and rfc822 format available.

Message #20 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 44957 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PIDGIN]: v4
Date: Tue, 1 Dec 2020 17:42:39 -0500

[Message part 1 (text/plain, inline)]
@Danny

I have include the author, date and url inside the patch. :-)

Regards,
RG.

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-Add-meanwhile.patch (text/x-patch, attachment)]
[0004-gnu-Add-silc-toolkit.patch (text/x-patch, attachment)]
[0005-gnu-Add-libgadu.patch (text/x-patch, attachment)]
[0006-gnu-Add-libgnt.patch (text/x-patch, attachment)]
[0007-gnu-pidgin-Enable-some-features.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[0009-gnu-pidgin-Enable-MultiMedia-and-A-V-support.patch (text/x-patch, attachment)]
[0010-gnu-libotr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0011-gnu-libotr-Update-license.patch (text/x-patch, attachment)]
[0012-gnu-pidgin-otr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0013-gnu-pidgin-otr-Update-license.patch (text/x-patch, attachment)]
[0014-gnu-pidgin-otr-Add-some-inputs.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Mon, 28 Dec 2020 17:52:01 GMT) Full text and rfc822 format available.

Message #23 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [PIDGIN]: v4
Date: Mon, 28 Dec 2020 18:50:58 +0100

[Message part 1 (text/plain, inline)]
Hi RG,

applied patches 4,5,6 (the ones adding packages).

The other patches (especially patch 2) currently do not apply to guix master,
with or without cosmetic changes.  Please update those.

[Message part 2 (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Wed, 30 Dec 2020 21:10:02 GMT) Full text and rfc822 format available.

Message #26 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [PIDGIN]: v4
Date: Wed, 30 Dec 2020 16:08:49 -0500

[Message part 1 (text/plain, inline)]
Hi Danny!

> applied patches 4,5,6 (the ones adding packages).

Thanks!

> The other patches (especially patch 2) currently do not apply to guix master,
> with or without cosmetic changes.  Please update those.

Please find the updated patches attached with this email.

Regards,
RG.

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-pidgin-Enable-some-features.patch (text/x-patch, attachment)]
[0004-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[0005-gnu-pidgin-Enable-MultiMedia-and-A-V-support.patch (text/x-patch, attachment)]
[0006-gnu-libotr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0007-gnu-libotr-Update-license.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-otr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0009-gnu-pidgin-otr-Update-license.patch (text/x-patch, attachment)]
[0010-gnu-pidgin-otr-Add-some-inputs.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Thu, 31 Dec 2020 00:55:01 GMT) Full text and rfc822 format available.

Message #29 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [PIDGIN]: v4
Date: Thu, 31 Dec 2020 01:54:49 +0100

[Message part 1 (text/plain, inline)]
Hi RG,

please, when enabling features, add one feature per patch here and mention the
feature by name per patch.

Also, please keep in mind the issues raised in '"questionable changes" commits'
mailing list thread.

[Message part 2 (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#44957; Package guix-patches. (Thu, 31 Dec 2020 05:38:01 GMT) Full text and rfc822 format available.

Message #32 received at 44957 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 44957 <at> debbugs.gnu.org
Subject: Re: [PIDGIN]: v4
Date: Thu, 31 Dec 2020 00:37:19 -0500

[Message part 1 (text/plain, inline)]
Hi Danny!

> please, when enabling features, add one feature per patch here and mention the
> feature by name per patch.

Please find the revised patch attached with this email.

> Also, please keep in mind the issues raised in '"questionable changes" commits'
> mailing list thread.

Yes, I have not removed any comments or moved the fields around. I will 
soon be not doing cosmetic changes at all, as I am working on my OCD.

Regards,
RG.

[0001-gnu-pidgin-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0002-gnu-pidgin-Re-arrange-inputs-in-alphabetical-order.patch (text/x-patch, attachment)]
[0003-gnu-pidgin-Add-missing-inputs.patch (text/x-patch, attachment)]
[0004-gnu-pidgin-Enable-support-for-mono.patch (text/x-patch, attachment)]
[0005-gnu-pidgin-Enable-meanwhile.patch (text/x-patch, attachment)]
[0006-gnu-pidgin-Enable-CAP.patch (text/x-patch, attachment)]
[0007-gnu-pidgin-Enable-SILC-protocol-support.patch (text/x-patch, attachment)]
[0008-gnu-pidgin-Enable-support-for-Tcl.patch (text/x-patch, attachment)]
[0009-gnu-pidgin-Enable-support-for-Tk.patch (text/x-patch, attachment)]
[0010-gnu-pidgin-Upgrade-to-2.14.1.patch (text/x-patch, attachment)]
[0011-gnu-pidgin-Enable-Gadu-Gadu-protocol-support.patch (text/x-patch, attachment)]
[0012-gnu-pidgin-Enable-MultiMedia-and-A-V-support.patch (text/x-patch, attachment)]
[0013-gnu-libotr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0014-gnu-libotr-Update-license.patch (text/x-patch, attachment)]
[0015-gnu-pidgin-otr-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]
[0016-gnu-pidgin-otr-Update-license.patch (text/x-patch, attachment)]
[0017-gnu-pidgin-otr-Add-some-inputs.patch (text/x-patch, attachment)]
Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Sun, 03 Jan 2021 16:31:01 GMT) Full text and rfc822 format available.
Notification sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
bug acknowledged by developer. (Sun, 03 Jan 2021 16:31:01 GMT) Full text and rfc822 format available.

Message #37 received at 44957-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 44957-done <at> debbugs.gnu.org
Subject: Re: [PIDGIN]: v4
Date: Sun, 3 Jan 2021 17:30:44 +0100

[Message part 1 (text/plain, inline)]
Hi RG,

pushed to guix master.

Thanks!

[Message part 2 (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 01 Feb 2021 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 78 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.