GNU bug report logs - #45015
[mumi] 44964 cannot be displayed

Previous Next

Package: mumi;

Reported by: Ricardo Wurmus <rekado <at> elephly.net>

Date: Wed, 2 Dec 2020 20:27:02 UTC

Severity: normal

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45015 in the body.
You can then email your comments to 45015 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Wed, 02 Dec 2020 20:27:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ricardo Wurmus <rekado <at> elephly.net>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 02 Dec 2020 20:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: bug-guix <at> gnu.org
Subject: [mumi] 44964 cannot be displayed
Date: Wed, 02 Dec 2020 21:26:25 +0100
Display of issue 44964 fails because the email address is not properly
split.

--8<---------------cut here---------------start------------->8---
GET /44964
In mumi/web/server.scm:
     33:9  9 (handler _ _)
In mumi/web/controller.scm:
   122:24  8 (_ _)
In mumi/web/view/html.scm:
    358:2  7 (issue-page #<<bug-status> num: 44964 archived: #f bloâ¦> â¦)
In unknown file:
           6 (filter #<procedure 7f19e5295440 at mumi/web/view/htmlâ¦> â¦)
In mumi/web/view/html.scm:
   363:24  5 (_ _)
In mumi/messages.scm:
    142:8  4 (internal-message? _)
In unknown file:
           3 (_ #<procedure 7f174074bfe0 at ice-9/boot-9.scm:792:28â¦> â¦)
In mumi/messages.scm:
     88:6  2 (sender _)
In unknown file:
           1 (car "Jorge P. de Morais Neto <jorge+list <at> disroot.org>")
In ice-9/boot-9.scm:
  1669:16  0 (raise-exception _ #:continuable? _)
--8<---------------cut here---------------end--------------->8---


-- 
Ricardo




Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Fri, 04 Dec 2020 06:00:02 GMT) Full text and rfc822 format available.

Message #8 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 45015 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [mumi] 44964 cannot be displayed
Date: Fri, 04 Dec 2020 06:59:49 +0100
Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
problem, which I suspect might be a bug in guile-email.

For some reason “Jorge P. de Morais Neto <jorge+list <at> disroot.org>” is
not split up into name and address parts but remains a single string.

-- 
Ricardo




Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Fri, 04 Dec 2020 06:13:02 GMT) Full text and rfc822 format available.

Message #11 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>, 45015 <at> debbugs.gnu.org
Subject: Re: bug#45015: [mumi] 44964 cannot be displayed
Date: Fri, 04 Dec 2020 11:41:55 +0530
[Message part 1 (text/plain, inline)]
Hi,

This is likely a bug in guile-email. It shouldn't have returned the
unparsed From address. It was likely triggered by "Jorge P. de Morais
Neto <jorge+list <at> disroot.org>" being an invalid address. The period
character is not allowed in the name and should have been quoted like
"\"Jorge P. de Morais Neto\" <jorge+list <at> disroot.org>". I will
investigate and come up with some fix within 24 hours.

Meanwhile, do CC me or guile-email <at> systemreboot.net on anything
guile-email related. That would help me take note sooner. I found this
bug report almost by chance.

Thanks,
Arun
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Fri, 04 Dec 2020 07:28:01 GMT) Full text and rfc822 format available.

Message #14 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 45015 <at> debbugs.gnu.org
Subject: Re: bug#45015: [mumi] 44964 cannot be displayed
Date: Fri, 04 Dec 2020 08:27:18 +0100
Arun Isaac <arunisaac <at> systemreboot.net> writes:

> This is likely a bug in guile-email. It shouldn't have returned the
> unparsed From address. It was likely triggered by "Jorge P. de Morais
> Neto <jorge+list <at> disroot.org>" being an invalid address. The period
> character is not allowed in the name and should have been quoted like
> "\"Jorge P. de Morais Neto\" <jorge+list <at> disroot.org>". I will
> investigate and come up with some fix within 24 hours.

Thank you!

> Meanwhile, do CC me or guile-email <at> systemreboot.net on anything
> guile-email related. That would help me take note sooner. I found this
> bug report almost by chance.

You found it just in time.  I only just put you on Cc after I became
convinced that this might be a parser failure.

-- 
Ricardo




Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Fri, 04 Dec 2020 19:38:01 GMT) Full text and rfc822 format available.

Message #17 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>, 45015 <at> debbugs.gnu.org
Subject: Re: [mumi] 44964 cannot be displayed
Date: Sat, 05 Dec 2020 01:06:52 +0530
[Message part 1 (text/plain, inline)]
> For some reason “Jorge P. de Morais Neto <jorge+list <at> disroot.org>” is
> not split up into name and address parts but remains a single string.

I have fixed this bug in the latest guile-email master, and added
tests to prevent regression. See
https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
and
https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37

I thought “Jorge P. de Morais Neto <jorge+list <at> disroot.org>” was an
invalid email address due to the period character, but apparently it is
supported by the obsolete addressing specification of RFC5322 (see
https://tools.ietf.org/html/rfc5322#section-4). I hadn't implemented the
obsolete parts of the specification until now.

> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
> problem, which I suspect might be a bug in guile-email.

guile-email should guarantee the parsed From header is an alist of the
appropriate form. So, I vote for reverting this commit, thus reducing
complexity on mumi's end. But, I understand that guile-email is not yet
doing a great job of providing these strong guarantees.

Cheers!
[signature.asc (application/pgp-signature, inline)]

bug closed, send any further explanations to 45015 <at> debbugs.gnu.org and Ricardo Wurmus <rekado <at> elephly.net> Request was from Arun Isaac <arunisaac <at> systemreboot.net> to control <at> debbugs.gnu.org. (Sun, 06 Dec 2020 04:41:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Sun, 06 Dec 2020 11:31:02 GMT) Full text and rfc822 format available.

Message #22 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 45015 <at> debbugs.gnu.org
Subject: Re: [mumi] 44964 cannot be displayed
Date: Sun, 06 Dec 2020 12:30:08 +0100
Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> For some reason “Jorge P. de Morais Neto <jorge+list <at> disroot.org>” is
>> not split up into name and address parts but remains a single string.
>
> I have fixed this bug in the latest guile-email master, and added
> tests to prevent regression. See
> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
> and
> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37

Thank you!  You are always very fast and thorough; I appreciate this a lot!

>> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
>> problem, which I suspect might be a bug in guile-email.
>
> guile-email should guarantee the parsed From header is an alist of the
> appropriate form. So, I vote for reverting this commit, thus reducing
> complexity on mumi's end.

I agree.  I wasn’t sure how difficult it would be to fix it in
guile-email, so I added the workaround just in case it takes longer.
I’ll upgrade and revert that commit soon.

-- 
Ricardo




Information forwarded to bug-guix <at> gnu.org:
bug#45015; Package guix. (Sun, 06 Dec 2020 11:51:03 GMT) Full text and rfc822 format available.

Message #25 received at 45015 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 45015 <at> debbugs.gnu.org
Subject: Re: [mumi] 44964 cannot be displayed
Date: Sun, 06 Dec 2020 17:20:48 +0530
[Message part 1 (text/plain, inline)]
>> I have fixed this bug in the latest guile-email master, and added
>> tests to prevent regression. See
>> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
>> and
>> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37
>
> Thank you!  You are always very fast and thorough; I appreciate this a
> lot!

Thank you, I really appreciate the acknowledgement! :-)
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 03 Jan 2021 12:24:04 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Felix Lechner <felix.lechner <at> lease-up.com> to control <at> debbugs.gnu.org. (Fri, 23 Feb 2024 13:25:05 GMT) Full text and rfc822 format available.

bug reassigned from package 'guix' to 'mumi'. Request was from Felix Lechner <felix.lechner <at> lease-up.com> to control <at> debbugs.gnu.org. (Fri, 23 Feb 2024 13:25:05 GMT) Full text and rfc822 format available.

bug archived. Request was from Felix Lechner <felix.lechner <at> lease-up.com> to control <at> debbugs.gnu.org. (Fri, 23 Feb 2024 13:25:05 GMT) Full text and rfc822 format available.

This bug report was last modified 34 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.