GNU bug report logs - #45028
[PATCH] offload: Print warning in context.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45028 in the body.
You can then email your comments to 45028 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] offload: Print warning in context.
Date: Thu, 3 Dec 2020 20:52:37 +0100

[Message part 1 (text/plain, inline)]

Hi Guix, attached is a patch to add context to the warning about the
system field. When offloading, we get this message if we haven't
updated our machines.scm:

guix offload: warning: The 'system' field is deprecated, please use
'systems' instead.

and it's not clear what system field this message is refering to
(especially for me, since I simply re-enabled offloading after a few
months by copying my old backup machines.scm).

Now the message is:

/etc/guix/machines.scm:9:6: warning: The 'system' field is deprecated,
please use 'systems' instead.

which directs the user to the right file, and line (so if you have many
offload machines, you know where to fix).

Since the message comes from the daemon, you need to run the daemon
from your guix checkout to test the patch.

[0001-offload-Print-warning-in-context.patch (text/x-patch, attachment)]

Message #8 received at 45028 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 45028 <at> debbugs.gnu.org
Subject: Re: [bug#45028] [PATCH] offload: Print warning in context.
Date: Mon, 14 Dec 2020 09:41:08 +0100

Hi Julien,

Julien Lepiller <julien <at> lepiller.eu> skribis:

> From d29c55f67c63c6fe49a4febd7999640a0dab2a55 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Thu, 3 Dec 2020 20:22:50 +0100
> Subject: [PATCH] offload: Print warning in context.
>
> * guix/scripts/offload.scm (build-machine): Add `location` field.
> (build-machine-system): Print location with warning.

LGTM!

Thanks,
Ludo’.

Message #13 received at 45028-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45028-done <at> debbugs.gnu.org
Subject: Re: [bug#45028] [PATCH] offload: Print warning in context.
Date: Tue, 15 Dec 2020 15:04:53 +0100

Pushed as 954e4cf6a4cc67701dff8d089e8e02861e3b36c2, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.