GNU bug report logs - #45058
Duplicate inputs with Crate importer

Previous Next

To reply to this bug, email your comments to 45058 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: bug-guix <at> gnu.org
Subject: Duplicate inputs with Crate importer
Date: Sat, 05 Dec 2020 22:03:45 +0100

Hello,

I noticed the Crate importer sometimes returns duplicate inputs. For
example

    guix import crate bat

returns

    ...
    (arguments
      `(#:cargo-inputs
        (("rust-ansi-colours" ,rust-ansi-colours-1)
         ("rust-ansi-term" ,rust-ansi-term-0.12)
         ("rust-atty" ,rust-atty-0.2)
         ("rust-clap" ,rust-clap-2)
         ("rust-clap" ,rust-clap-2)
         ...

Regards,
-- 
Nicolas Goaziou

Message #8 received at 45058 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 45058 <at> debbugs.gnu.org
Subject: Re: bug#45058: Duplicate inputs with Crate importer
Date: Wed, 9 Dec 2020 10:38:13 +0200

[Message part 1 (text/plain, inline)]

On Sat, Dec 05, 2020 at 10:03:45PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> I noticed the Crate importer sometimes returns duplicate inputs. For
> example
> 
>     guix import crate bat
> 
> returns
> 
>     ...
>     (arguments
>       `(#:cargo-inputs
>         (("rust-ansi-colours" ,rust-ansi-colours-1)
>          ("rust-ansi-term" ,rust-ansi-term-0.12)
>          ("rust-atty" ,rust-atty-0.2)
>          ("rust-clap" ,rust-clap-2)
>          ("rust-clap" ,rust-clap-2)
>          ...

As noted here¹ rust-clap-2 is listed as both a dependency and a
build-dependency. For the sake of completeness, there are also packages
which require the same crate+version for cargo-dev-input and a looser
version requirement for cargo-input. It seems worthwhile to deduplicate
the cargo-inputs, since it's a combination of 'dependencies' and 'build
dependencies', but I'm not sure about removing duplicates when they
appear in both cargo-inputs and cargo-development-inputs.


¹ https://crates.io/crates/bat

> 
> Regards,
> -- 
> Nicolas Goaziou
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.