GNU bug report logs - #45127
28.0.50; wdired + dired-hide-details-mode toggling?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45127 in the body.
You can then email your comments to 45127 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 08 Dec 2020 22:34:16 +0100

Hello,

My wishlist proposal is: may we allow to toggle
`dired-hide-details-mode' in a wdired buffer (currently an error is
signaled in this case)?  I ask because (1) seems this would work out of
the box, and (2) it may be useful, e.g. because I started with hidden
details, already have performed some changes, and see that I need to
change something in the details also.  Or I have long filenames and thus
want to hide details although I have already switched to wdired.

Anyway, the implementation of d-h-details-mode only seems to toggle some
invisibility spec, and thus I expect no problems (will try it out
privately in the meantime).

I guess we would need a new key for it, since the binding for toggling,
"(", is bound to self-insert-command in a wdired buffer.  C-c ( maybe?

TIA,

Michael.


In GNU Emacs 28.0.50 (build 20, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0)
 of 2020-12-08 built on drachen
Repository revision: 9965fc635f54cabc9da7a234356eeed4c1fc7257
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux bullseye/sid

Message #8 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>, 45127 <at> debbugs.gnu.org
Subject: RE: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 8 Dec 2020 14:18:14 -0800 (PST)

FWIW, I don't see this problem with Emacs 27.1
or earlier on MS Windows.

Perhaps it's a regression for Emacs > 27?
Or perhaps it's platform-dependent?  (Windows
uses `ls-lisp'; dunno whether that makes any
difference, but I don't expect it would.)

Message #11 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 45127 <at> debbugs.gnu.org
Subject: Re: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 08 Dec 2020 23:28:00 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

> FWIW, I don't see this problem with Emacs 27.1
> or earlier on MS Windows.

d-h-details-mode has this test since it had been added:

#+begin_src emacs-lisp
(unless (derived-mode-p 'dired-mode)
    (error "Not a Dired buffer"))
#+end_src

Does your wdired buffer fulfill (derived-mode-p 'dired-mode)?


Thanks,

Michael.

Message #14 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 45127 <at> debbugs.gnu.org
Subject: RE: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 8 Dec 2020 14:45:36 -0800 (PST)

> Does your wdired buffer fulfill (derived-mode-p 'dired-mode)?

No.  That sexp returns nil.

Message #17 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 45127 <at> debbugs.gnu.org
Subject: Re: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 08 Dec 2020 23:47:09 +0100

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> #+begin_src emacs-lisp
> (unless (derived-mode-p 'dired-mode)
>     (error "Not a Dired buffer"))
> #+end_src

And it also seems that wdired-mode never was derived from dired-mode.
So I wonder why it works for you.  Or maybe you just misunderstood what
I tried to suggest?


Thanks,

Michael.

Message #20 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 45127 <at> debbugs.gnu.org
Subject: RE: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 8 Dec 2020 14:57:44 -0800 (PST)

> And it also seems that wdired-mode never was derived from dired-mode.
> So I wonder why it works for you.  Or maybe you just misunderstood what
> I tried to suggest?

All I tried was `emacs -Q', then Dired, then `C-x C-q',
then evaluate (derived-mode-p 'dired-mode), which
returned nil.

I used Emacs 26.3 and 27.1.  Maybe the test you show
was introduced after 27.1?  Where do you see that test?

(FWIW, I can't imagine why `wdired-mode' would ever be
derived from `dired-mode'.)

Message #23 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 45127 <at> debbugs.gnu.org
Subject: Re: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Wed, 09 Dec 2020 00:49:21 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

> All I tried was `emacs -Q', then Dired, then `C-x C-q',
> then evaluate (derived-mode-p 'dired-mode), which
> returned nil.

But you also said "FWIW, I don't see this problem with Emacs 27.1",
i.e. you said you don't see the error this is about.

> I used Emacs 26.3 and 27.1.  Maybe the test you show
> was introduced after 27.1?  Where do you see that test?

It's the first expression in the body of `dired-hide-details-mode' and
has been there since `dired-hide-details-mode' had been added 8 years
ago AFAICT.

Regards,

Michael.

Message #26 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 45127 <at> debbugs.gnu.org
Subject: RE: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Tue, 8 Dec 2020 16:15:32 -0800 (PST)

> > All I tried was `emacs -Q', then Dired, then `C-x C-q',
> > then evaluate (derived-mode-p 'dired-mode), which
> > returned nil.
> 
> But you also said "FWIW, I don't see this problem with Emacs 27.1",
> i.e. you said you don't see the error this is about.

Yes.  But I was wrong.

I was using `(', not `M-x dired-hide-details-mode'.
Which means I was never using it when already in
`wdired-mode'.

If I use `M-x dired-hide-details-mode' when in `wdired-mode'
I see the error you reported.

Sorry for the noise.

I was first using `(' and then turning on `wdired-mode',
not turning on `wdired-mode' and then using
`M-x dired-hide-details-mode'.

(And I was evaling `(derived-mode-p 'dired-mode)' in
`wired-mode' - which returns nil.)

Message #29 received at 45127 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 45127 <at> debbugs.gnu.org
Subject: Re: bug#45127: 28.0.50; wdired + dired-hide-details-mode toggling?
Date: Fri, 28 Jan 2022 15:56:39 +0100

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> My wishlist proposal is: may we allow to toggle
> `dired-hide-details-mode' in a wdired buffer (currently an error is
> signaled in this case)?  I ask because (1) seems this would work out of
> the box, and (2) it may be useful, e.g. because I started with hidden
> details, already have performed some changes, and see that I need to
> change something in the details also.  Or I have long filenames and thus
> want to hide details although I have already switched to wdired.
>
> Anyway, the implementation of d-h-details-mode only seems to toggle some
> invisibility spec, and thus I expect no problems (will try it out
> privately in the meantime).
>
> I guess we would need a new key for it, since the binding for toggling,
> "(", is bound to self-insert-command in a wdired buffer.  C-c ( maybe?

I tried it out for a bit, and it seems to work without any problems, so
I lifted the dired-mode restriction and added the key binding in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.