GNU bug report logs - #45193
Wrapper of Qt programs doesn't extend existing environment variable

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Reported by: Zhu Zihao <all_but_last@HIDDEN>; dated Sat, 12 Dec 2020 09:13:01 UTC; Maintainer for guix is bug-guix@HIDDEN.

Message received at 45193 <at> debbugs.gnu.org:


Received: (at 45193) by debbugs.gnu.org; 17 Dec 2020 11:36:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 17 06:36:02 2020
Received: from localhost ([127.0.0.1]:34889 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kprZi-0003Z4-1e
	for submit <at> debbugs.gnu.org; Thu, 17 Dec 2020 06:36:02 -0500
Received: from mail-m975.mail.163.com ([123.126.97.5]:59902)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <all_but_last@HIDDEN>) id 1kprZc-0003Yg-Kf
 for 45193 <at> debbugs.gnu.org; Thu, 17 Dec 2020 06:36:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
 s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=9hKov
 Mex/O3MjC3SmUjGrR8zzZSUY2q1OqPqhRrPlGQ=; b=JIJ3oz6SERVKfIw/mOuLF
 y5UBrtGKcgdq7gmooRAdKVzKlmxNvMqhz0qQ1k4CWVDjic0/AvTlTIPF9IwyJfca
 qJO7NiO1/NZ5Vr9M8dsk1uFCXCNk2ZJVs6blmYN7/+3e7Dws1+4X7g29yNf6ubyI
 MYHOll+HgzJzstAQhtt+lA=
Received: from asus-laptop (unknown [27.39.89.162])
 by smtp5 (Coremail) with SMTP id HdxpCgDn78OUQttfML0GFw--.2210S2;
 Thu, 17 Dec 2020 19:35:49 +0800 (CST)
References: <86wnxns81f.fsf@HIDDEN> <87im94ru9t.fsf@HIDDEN>
User-agent: mu4e 1.4.13; emacs 27.1
From: Zhu Zihao <all_but_last@HIDDEN>
To: Mark H Weaver <mhw@HIDDEN>
Subject: Re: bug#45193: Wrapper of Qt programs doesn't extend existing
 environment variable
In-reply-to: <87im94ru9t.fsf@HIDDEN>
Date: Thu, 17 Dec 2020 19:35:43 +0800
Message-ID: <86mtycbr74.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-CM-TRANSID: HdxpCgDn78OUQttfML0GFw--.2210S2
X-Coremail-Antispam: 1Uf129KBjvdXoWrZFW7Gr13ZF4UAw1ftFWfGrg_yoW3tFb_Cr
 n2vFWDGw1DZw17tF13JFsIyr90ga92qry2grZIgw42yr1vq3WUW3yvkF9xtF17W3ZrJw4x
 Grn2y3y3tr9xujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUj9qXtUUUUU==
X-Originating-IP: [27.39.89.162]
X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbB8Q39r12MYTk9mwAAsB
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45193
Cc: 45193 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


I try to read and understand how wrap-qt-program in qt-utils.scm works.
When building QT program, Guix builder populates qt related environment
variable, and wrap-qt-program just record it into wrapper.

However, the wrap behaviour in qt-build-system is quite different, it
search all inputs and mark them should be included in envvar definition
if correspond directory exists.

Another difference is, wrap-qt-program will include the directory of
output in envvar but qt-build-system won't do.

I'm not sure whether we need to include output, and don't know recording
build time environment follows reproducible build rule or not. Maybe we
need an expert on Qt programming/packaging to give us some hints? :(

=2D-=20
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIsEARYIADMWIQTUepyLKuOQW1Y9kTW+QrNSqfaCHwUCX9tCjxUcYWxsX2J1dF9s
YXN0QDE2My5jb20ACgkQvkKzUqn2gh+c9QD/cKZ3Z87d5HzgwiulltcgE5bxbrOC
aC2JBT2UTQoPZj4A/iKIPczjj0odC0PBGA/G34p0wwwpeITqLk8YG2aaapIL
=QvdP
-----END PGP SIGNATURE-----
--=-=-=--





Information forwarded to bug-guix@HIDDEN:
bug#45193; Package guix. Full text available.

Message received at 45193 <at> debbugs.gnu.org:


Received: (at 45193) by debbugs.gnu.org; 15 Dec 2020 01:51:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 14 20:51:14 2020
Received: from localhost ([127.0.0.1]:54956 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kozUg-0006Ns-FO
	for submit <at> debbugs.gnu.org; Mon, 14 Dec 2020 20:51:14 -0500
Received: from mail-m972.mail.163.com ([123.126.97.2]:49272)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <all_but_last@HIDDEN>) id 1kozUd-0006Nb-Ku
 for 45193 <at> debbugs.gnu.org; Mon, 14 Dec 2020 20:51:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
 s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=nM9R7
 4BFAuVLgnoeFWscUHtH+2w1ld376YiEtBwJxVc=; b=Lf8d2uQ9vvGFPTRaT2BYs
 sbbJ+gfEu+O6CnHxj7K/Tnt1IsoTSW/65AUveOxeEsHp5VIywrt52btgEYOXl5Us
 MQaKOP7JgkJ4GQoz1lgczuHnmnrY1LeBuH//+n1Hm45pIWwExF9BeUljK5Qb4SJl
 5DnJaerd0mBrGIMAsSP4Xg=
Received: from asus-laptop (unknown [112.93.141.84])
 by smtp2 (Coremail) with SMTP id GtxpCgCnr++HFthfhXAAFQ--.54930S2;
 Tue, 15 Dec 2020 09:51:04 +0800 (CST)
References: <86wnxns81f.fsf@HIDDEN> <87im94ru9t.fsf@HIDDEN>
User-agent: mu4e 1.4.13; emacs 27.1
From: Zhu Zihao <all_but_last@HIDDEN>
To: Mark H Weaver <mhw@HIDDEN>
Subject: Re: bug#45193: Wrapper of Qt programs doesn't extend existing
 environment variable
In-reply-to: <87im94ru9t.fsf@HIDDEN>
Date: Tue, 15 Dec 2020 09:50:57 +0800
Message-ID: <86a6ufon0e.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-CM-TRANSID: GtxpCgCnr++HFthfhXAAFQ--.54930S2
X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73
 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxU2byCDUUUU
X-Originating-IP: [112.93.141.84]
X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTwn7r1sGW9Su8QAAsf
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45193
Cc: 45193 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Mark H Weaver writes:

> I agree with your analysis.  Would you like to propose a patch and test
> it as thoroughly as you can?

I just saw a patch posted by somebody on debbugs.

https://issues.guix.gnu.org/45221

Maybe we can go there to improve his patch and we don't have to write it
from scratch.

=2D-=20
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIsEARYIADMWIQTUepyLKuOQW1Y9kTW+QrNSqfaCHwUCX9gWgRUcYWxsX2J1dF9s
YXN0QDE2My5jb20ACgkQvkKzUqn2gh8q2AEA/xdIjQFf7w+vxJnedbHTb86YUwEI
BazknMFrqpcOV2sBAKuOWFHYpoeRJ3sKX+Z6f9n8fZEylpuARfa6xhu2BwsJ
=NxHx
-----END PGP SIGNATURE-----
--=-=-=--





Information forwarded to bug-guix@HIDDEN:
bug#45193; Package guix. Full text available.

Message received at 45193 <at> debbugs.gnu.org:


Received: (at 45193) by debbugs.gnu.org; 14 Dec 2020 20:46:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 14 15:46:23 2020
Received: from localhost ([127.0.0.1]:54685 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1koujf-0004Is-0h
	for submit <at> debbugs.gnu.org; Mon, 14 Dec 2020 15:46:23 -0500
Received: from world.peace.net ([64.112.178.59]:32884)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@HIDDEN>) id 1koujd-0004DC-Kg
 for 45193 <at> debbugs.gnu.org; Mon, 14 Dec 2020 15:46:21 -0500
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mhw@HIDDEN>)
 id 1koujX-0003kQ-RP; Mon, 14 Dec 2020 15:46:15 -0500
From: Mark H Weaver <mhw@HIDDEN>
To: Zhu Zihao <all_but_last@HIDDEN>, 45193 <at> debbugs.gnu.org
Subject: Re: bug#45193: Wrapper of Qt programs doesn't extend existing
 environment variable
In-Reply-To: <86wnxns81f.fsf@HIDDEN>
References: <86wnxns81f.fsf@HIDDEN>
Date: Mon, 14 Dec 2020 15:45:23 -0500
Message-ID: <87im94ru9t.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45193
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Zhu Zihao <all_but_last@HIDDEN> writes:

> Reproduce steps:
>
>    guix environment --ad-hoc qbittorrent && cat $GUIX_ENVIRONMENT/bin/qbittorrent
>
>
> We can see the wrapper generated in qt-build-system doesn't extend
> existing environment variable. Instead, it overrides them.
>
> It was discussed in
> https://lists.gnu.org/archive/html/guix-devel/2019-12/msg00117.html one
> year ago. This's not a trivial issue because using input method in Qt
> program requires an qt plugin(XIM doesn't work here) which is managed by
> QT_PLUGIN_PATH.
>
> We should change following functions:
>
> 1. guix/build/qt-build-system.scm(wrap-all-programs)
> 2. guix/build/qt-utils.scm(wrap-qt-program)
>
> It's ideal to make wrap-all-programs use wrap-qt-program internally and
> we don't need to maintain two copy of wrap code.

I agree with your analysis.  Would you like to propose a patch and test
it as thoroughly as you can?

     Regards,
       Mark




Information forwarded to bug-guix@HIDDEN:
bug#45193; Package guix. Full text available.

Message received at 45193 <at> debbugs.gnu.org:


Received: (at 45193) by debbugs.gnu.org; 12 Dec 2020 09:20:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 12 04:20:29 2020
Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ko14m-0003i0-JH
	for submit <at> debbugs.gnu.org; Sat, 12 Dec 2020 04:20:29 -0500
Received: from mail-m972.mail.163.com ([123.126.97.2]:40658)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <all_but_last@HIDDEN>) id 1ko14h-0003hn-Is
 for 45193 <at> debbugs.gnu.org; Sat, 12 Dec 2020 04:20:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
 s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=VUsfL
 wWE1n8DnfhptkcWBLeVOKg6ROfS+2U/CY8T3hI=; b=VymMCPwfCOEfUHmvKr7+N
 m1fJiBJat4y7Czw1g0ZXEftTDpAAgVQhJWI5p/zEd+glH0vp7hDUhYTztoeGX676
 4qkpNtKaKhzA2xbCrNGXXzP9U0AxBpBGSmPwAWpkXUbRBF9RBor8bnH+0QeXXjF6
 HiA196rD8268LhebcPQPNE=
Received: from asus-laptop (unknown [27.39.89.114])
 by smtp2 (Coremail) with SMTP id GtxpCgC3Rbo2i9RfojStEw--.18548S2;
 Sat, 12 Dec 2020 17:19:50 +0800 (CST)
References: <86wnxns81f.fsf@HIDDEN>
 <handler.45193.B.160776432713396.ack <at> debbugs.gnu.org>
User-agent: mu4e 1.4.13; emacs 27.1
From: Zhu Zihao <all_but_last@HIDDEN>
To: 45193 <at> debbugs.gnu.org
Subject: Re: bug#45193: Acknowledgement (Wrapper of Qt programs doesn't
 extend existing environment variable)
In-reply-to: <handler.45193.B.160776432713396.ack <at> debbugs.gnu.org>
Date: Sat, 12 Dec 2020 17:19:50 +0800
Message-ID: <867dpns7nt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-CM-TRANSID: GtxpCgC3Rbo2i9RfojStEw--.18548S2
X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73
 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUeYFCDUUUU
X-Originating-IP: [27.39.89.114]
X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiKRj4r1XlytI2LwAAsX
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45193
Cc: david@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


In guix/build/qt-utils.scm:24:11

(define (wrap-qt-program out program)
  (define (suffix env-var path)
           ^^^^^
           I can't understand this, if you want to do a suffix wrap, you
           should do it in "wrap-program"(e.g. `("XDG_DATA_DIRS" suffix
           (,vars))), it will generate bash codes to do the job. If you
           use Guile code here, it'll capture build time environment
           variable values.

=2D-=20
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEE7NCVzXX6efyusptG1SOVn+xGFqYFAl/UizYVHGFsbF9idXRf
bGFzdEAxNjMuY29tAAoJENUjlZ/sRhamIPEH/RJ3UhPLosXAgr0vII7nYAJsXIBv
+a3V32VMWKrzvddA5StHHs6+MTeRMTZUM6OPl/KHBTTr331kZ17n/G/aX7bTDJUx
0opmwyyFCNVVOZ+cNwJihfjB6p6ZNd8XOBaiQhAvQRPUxuU+jSm0zPI4Cmv7sddR
jck3yQThOvB0wkr8MObRy5fl5zLncWsD2j1H67Xqn93VswUkG7IJo4b1z8IhN2q4
mAwTwzIFAMlJ9PCiOT/d1+TR/65VSffcdFo2IUBPrJG0gBS0I0FLX3ZBAouW7ZS2
tWKhGYOusgdCe8cg8E8rKf+RTEKx4iZXJOF4vd5ynJ77pPre21xMcd0Ffns=
=06cg
-----END PGP SIGNATURE-----
--=-=-=--





Information forwarded to bug-guix@HIDDEN:
bug#45193; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Dec 2020 09:12:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 12 04:12:07 2020
Received: from localhost ([127.0.0.1]:43922 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ko0wh-0003U0-AV
	for submit <at> debbugs.gnu.org; Sat, 12 Dec 2020 04:12:07 -0500
Received: from lists.gnu.org ([209.51.188.17]:49794)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <all_but_last@HIDDEN>) id 1ko0wc-0003Tq-Uh
 for submit <at> debbugs.gnu.org; Sat, 12 Dec 2020 04:12:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38332)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <all_but_last@HIDDEN>)
 id 1ko0wc-0007PB-3o
 for bug-guix@HIDDEN; Sat, 12 Dec 2020 04:12:02 -0500
Received: from mail-m972.mail.163.com ([123.126.97.2]:43762)
 by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)
 (Exim 4.90_1) (envelope-from <all_but_last@HIDDEN>)
 id 1ko0wW-00009s-OH
 for bug-guix@HIDDEN; Sat, 12 Dec 2020 04:12:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
 s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=Jbgy2
 ndfhfbtp/hYW/9p9gK+czPmRMqN5p03nw4F49A=; b=ZN5PAV+lPMFVz27tg+mmU
 W68htkzJkTv57urg6A6ki+75SZTdYY33iiqMApLTbfI3GR7O99QLFCk+t8ZWLQ7N
 pUe6IkVQpxmTAoiaSctBllWIzxT/stZ4YXN+qb7f6hw3I3jerHtVdyH2VlDhc7cH
 IeVZnGmyegveYCd0KPY4kk=
Received: from asus-laptop (unknown [27.39.89.114])
 by smtp2 (Coremail) with SMTP id GtxpCgAHRL1QidRf2lOsEw--.7783S2;
 Sat, 12 Dec 2020 17:11:44 +0800 (CST)
User-agent: mu4e 1.4.13; emacs 27.1
From: Zhu Zihao <all_but_last@HIDDEN>
To: bug-guix@HIDDEN
Subject: Wrapper of Qt programs doesn't extend existing environment variable
Date: Sat, 12 Dec 2020 17:11:40 +0800
Message-ID: <86wnxns81f.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-CM-TRANSID: GtxpCgAHRL1QidRf2lOsEw--.7783S2
X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr4rurWruFy8KryxXFWrZrb_yoWfJrX_Ar
 97AFZ5Jr4vq392qr43Za1rCrWDGayagryxtw1DXrnIgr98Zws8u3yvgrnrZa4xAFsrKayf
 uaya9r17t34agjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8OzVUUUUUU==
X-Originating-IP: [27.39.89.114]
X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiFBH4r1aD8V4TQQAAs6
Received-SPF: pass client-ip=123.126.97.2; envelope-from=all_but_last@HIDDEN;
 helo=mail-m972.mail.163.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Reproduce steps:

   guix environment --ad-hoc qbittorrent && cat $GUIX_ENVIRONMENT/bin/qbitt=
orrent


We can see the wrapper generated in qt-build-system doesn't extend
existing environment variable. Instead, it overrides them.

It was discussed in
https://lists.gnu.org/archive/html/guix-devel/2019-12/msg00117.html one
year ago. This's not a trivial issue because using input method in Qt
program requires an qt plugin(XIM doesn't work here) which is managed by
QT_PLUGIN_PATH.

We should change following functions:

1. guix/build/qt-build-system.scm(wrap-all-programs)
2. guix/build/qt-utils.scm(wrap-qt-program)

It's ideal to make wrap-all-programs use wrap-qt-program internally and
we don't need to maintain two copy of wrap code.



=2D-=20
Retrieve my PGP public key: https://meta.sr.ht/~citreu.pgp

Zihao

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEE7NCVzXX6efyusptG1SOVn+xGFqYFAl/UiUwVHGFsbF9idXRf
bGFzdEAxNjMuY29tAAoJENUjlZ/sRhamT1cH/3vyhdTvFkvTSefggL3zWgAa6nda
uYqWCgzpXLo6zSrYiamYG8/T0VQrlDsfAwOzMNTxXjdWGl8+Jct7aRp+hUiUPegO
nw/aHmlbXCx2XQJJ2W1ZaiFP+m5yr2irPGvUuvKfbR/93/g4/dWC84tHu55jxE90
ViqY6zHsipIcshtd5tBOmoo2lGihvOml+U7Bybt0D8b8aDJleTUEnTy/qd+7qFzi
/5IxTE18duJkqnun1GuY3WFwq7TN6/bbIkZ8Srp88w3FA4Ci4K3ia8/3zfoXJOab
sU2ZoMS3/6PeYxMLLIgWL8juWGEWS3xcmoXXIRdkfySVpenTAvMnf1TDx/k=
=0r0D
-----END PGP SIGNATURE-----
--=-=-=--





Acknowledgement sent to Zhu Zihao <all_but_last@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#45193; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 17 Dec 2020 11:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.