GNU bug report logs -
#45232
[PATCH] gnu: Add python-pdftotext.
Previous Next
Reported by: Z572 <873216071 <at> qq.com>
Date: Mon, 14 Dec 2020 06:05:02 UTC
Severity: normal
Tags: patch
Done: Efraim Flashner <efraim <at> flashner.co.il>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45232 in the body.
You can then email your comments to 45232 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#45232
; Package
guix-patches
.
(Mon, 14 Dec 2020 06:05:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Z572 <873216071 <at> qq.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 14 Dec 2020 06:05:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[python-pdftotext.patch (text/x-patch, attachment)]
diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index a06f351aae..817c6a27c8 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -21,6 +21,7 @@
;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Zheng Junjie <873216071 <at> qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -309,6 +310,25 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
Poppler PDF rendering library.")
(license license:lgpl2.1+)))
+(define python-pdftotext
+ (package
+ (name "python-pdftotext")
+ (version "2.1.5")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "pdftotext" version))
+ (sha256
+ (base32
+ "19la1cw1hmkcr8big04gm2dd5fw0y0z97g930aiy29s1gaqbiblq"))))
+ (build-system python-build-system)
+ (propagated-inputs
+ `(("poppler" ,poppler)))
+ (home-page "https://github.com/jalan/pdftotext")
+ (synopsis "Simple PDF text extraction")
+ (description "Simple PDF text extraction")
+ (license license:expat)))
+
(define-public libharu
(package
(name "libharu")
Information forwarded
to
guix-patches <at> gnu.org
:
bug#45232
; Package
guix-patches
.
(Mon, 21 Dec 2020 09:08:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 45232 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
This looks good, I've been looking for more options for viewing test
from PDFs. A couple of comments inline in the patch:
On Mon, Dec 14, 2020 at 11:34:41AM +0800, Z572 wrote:
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index a06f351aae..817c6a27c8 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -21,6 +21,7 @@
> ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
> ;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
> ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2020 Zheng Junjie <873216071 <at> qq.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -309,6 +310,25 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
> Poppler PDF rendering library.")
> (license license:lgpl2.1+)))
>
> +(define python-pdftotext
This should be define-public, otherwise we won't be able to find the
package. Also, this looks like you can rename it to just pdftotext, the
python part of the name doesn't look necessary to me.
> + (package
> + (name "python-pdftotext")
> + (version "2.1.5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "pdftotext" version))
> + (sha256
> + (base32
> + "19la1cw1hmkcr8big04gm2dd5fw0y0z97g930aiy29s1gaqbiblq"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("poppler" ,poppler)))
This shouldn't be propagated. If the output references poppler than a
regular input is fine. If it doesn't then the source should be patched
to use the package from the store.
> + (home-page "https://github.com/jalan/pdftotext")
> + (synopsis "Simple PDF text extraction")
> + (description "Simple PDF text extraction")
This should be a full sentence.
> + (license license:expat)))
> +
> (define-public libharu
> (package
> (name "libharu")
>
>
>
--
Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#45232
; Package
guix-patches
.
(Thu, 31 Dec 2020 16:23:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 45232 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Sorry, I missed this email. This is a new patch.
[0001-gnu-Add-python-pdftotext.patch (text/x-patch, attachment)]
Reply sent
to
Efraim Flashner <efraim <at> flashner.co.il>
:
You have taken responsibility.
(Sat, 02 Jan 2021 18:45:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Z572 <873216071 <at> qq.com>
:
bug acknowledged by developer.
(Sat, 02 Jan 2021 18:45:01 GMT)
Full text and
rfc822 format available.
Message #16 received at 45232-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Thanks! Patch pushed.
--
Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 31 Jan 2021 12:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 84 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.