GNU bug report logs - #45285
[PATCH] gnu: Add ark.

Previous Next

Package: guix-patches;

Reported by: Z572 <873216071 <at> qq.com>

Date: Thu, 17 Dec 2020 05:13:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45285 in the body.
You can then email your comments to 45285 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#45285; Package guix-patches. (Thu, 17 Dec 2020 05:13:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Z572 <873216071 <at> qq.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 17 Dec 2020 05:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ark.
Date: Thu, 17 Dec 2020 13:11:59 +0800
[Message part 1 (text/plain, inline)]
> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
> FAIL!  : ExtractTest::testExtraction(extract all entries from a xar archive with path) Compared values are not the same
>    Actual   (extractedEntriesCount)        : 0
>    Expected (expectedExtractedEntriesCount): 6
>    Loc: [/tmp/guix-build-ark-20.04.1.drv-0/ark-20.04.1/autotests/kerfuffle/extracttest.cpp(469)]

The tests fail.

[ark.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45285; Package guix-patches. (Mon, 21 Dec 2020 15:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 45285 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Z572 <873216071 <at> qq.com>
Cc: 45285 <at> debbugs.gnu.org
Subject: Re: [bug#45285] [PATCH] gnu: Add ark.
Date: Mon, 21 Dec 2020 16:46:52 +0100
Hi,

Z572 <873216071 <at> qq.com> skribis:

>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>> FAIL!  : ExtractTest::testExtraction(extract all entries from a xar archive with path) Compared values are not the same
>>    Actual   (extractedEntriesCount)        : 0
>>    Expected (expectedExtractedEntriesCount): 6
>>    Loc: [/tmp/guix-build-ark-20.04.1.drv-0/ark-20.04.1/autotests/kerfuffle/extracttest.cpp(469)]
>
> The tests fail.

What you paste above sounds like there could be a real issue with some
archive formats, which may be a core issue for this archiving tool.

Could you investigate a bit and/or get in touch with upstream to see if
they can provide guidance?

> +    (home-page "https://apps.kde.org/en/ark")
> +    (synopsis "Archiving Tool")
> +    (description "Graphical file compression/decompression utility with support
> +for multiple formats.")

Please expound a bit and write pull sentences, as explained at:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Could you send an updated patch once you know more about the issue
evidenced by the test suite?

Thanks in advance!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#45285; Package guix-patches. (Wed, 23 Dec 2020 06:07:01 GMT) Full text and rfc822 format available.

Message #11 received at 45285 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: 45285 <at> debbugs.gnu.org
Subject: Re: bug#45285: [PATCH] gnu: Add ark.
Date: Wed, 23 Dec 2020 14:06:30 +0800
[Message part 1 (text/plain, inline)]
Hi,

Ludovic Courtès <ludo <at> gnu.org> skribis:

>>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>>> FAIL!  : ExtractTest::testExtraction(extract all entries from a xar archive with path) Compared values are not the same
>>>    Actual   (extractedEntriesCount)        : 0
>>>    Expected (expectedExtractedEntriesCount): 6
>>>    Loc: [/tmp/guix-build-ark-20.04.1.drv-0/ark-20.04.1/autotests/kerfuffle/extracttest.cpp(469)]
>>
>> The tests fail.
>
> What you paste above sounds like there could be a real issue with some
> archive formats, which may be a core issue for this archiving tool.
>
> Could you investigate a bit and/or get in touch with upstream to see if
> they can provide guidance?

I think this is guix libarchive's problem, it doesn't support xar format because it
needs to input OpenSSL, EXPAT, And XML2.
See libarchive-3.4.2.tar.xz!libarchive-3.4.2/configure :

-----+------------------------------------------------------------------------------
L1546|  --without-openssl       Don't build support for mtree and xar hashes through
L1547|                          openssl
L1548|  --without-xml2          Don't build support for xar through libxml2
L1549|  --without-expat         Don't build support for xar through expat
-----+------------------------------------------------------------------------------

It's new patch.

[ark.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Z572.

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Fri, 16 Jul 2021 04:10:02 GMT) Full text and rfc822 format available.

Notification sent to Z572 <873216071 <at> qq.com>:
bug acknowledged by developer. (Fri, 16 Jul 2021 04:10:02 GMT) Full text and rfc822 format available.

Message #16 received at 45285-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Z572 <873216071 <at> qq.com>
Cc: 45285-done <at> debbugs.gnu.org
Subject: Re: bug#45285: [PATCH] gnu: Add ark.
Date: Fri, 16 Jul 2021 00:09:44 -0400
Hello,

Z572 <873216071 <at> qq.com> writes:

> Hi,
>
> Ludovic Courtès <ludo <at> gnu.org> skribis:
>
>>>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>>>> QWARN  : ExtractTest::testExtraction(extract all entries from a xar archive with path) ark.libarchive: Could not open the archive: Unrecognized archive format
>>>> FAIL!  : ExtractTest::testExtraction(extract all entries from a xar archive with path) Compared values are not the same
>>>>    Actual   (extractedEntriesCount)        : 0
>>>>    Expected (expectedExtractedEntriesCount): 6
>>>>    Loc: [/tmp/guix-build-ark-20.04.1.drv-0/ark-20.04.1/autotests/kerfuffle/extracttest.cpp(469)]
>>>
>>> The tests fail.
>>
>> What you paste above sounds like there could be a real issue with some
>> archive formats, which may be a core issue for this archiving tool.
>>
>> Could you investigate a bit and/or get in touch with upstream to see if
>> they can provide guidance?
>
> I think this is guix libarchive's problem, it doesn't support xar format because it
> needs to input OpenSSL, EXPAT, And XML2.
> See libarchive-3.4.2.tar.xz!libarchive-3.4.2/configure :
>
> -----+------------------------------------------------------------------------------
> L1546|  --without-openssl       Don't build support for mtree and xar hashes through
> L1547|                          openssl
> L1548|  --without-xml2          Don't build support for xar through libxml2
> L1549|  --without-expat         Don't build support for xar through expat
> -----+------------------------------------------------------------------------------
>
> It's new patch.

Thanks for the update!

I've moved it to the (gnu packages kde-utils) module, dropped the
unnecessary lz4 input, moved the propagated inputs to inputs and wrapped
the command line tools using wrap-program in a phase, tested that it
could run and open a tarball, and applied as commit 4094d12df1.

Thank you for the contribution!

Closing.

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 13 Aug 2021 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.