GNU bug report logs - #45293
[PATCH] gnu: Add skim.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45293 in the body.
You can then email your comments to 45293 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add skim.
Date: Thu, 17 Dec 2020 21:10:02 +0800

[0001-gnu-Add-rust-tuikit-0.4.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-timer-0.2.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-fuzzy-matcher-0.3.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-defer-drop-1.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-beef-0.4.patch (text/x-patch, attachment)]

[0006-gnu-Add-skim.patch (text/x-patch, attachment)]

Message #8 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Z572 <873216071 <at> qq.com>
Cc: 45293 <at> debbugs.gnu.org
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Sun, 24 Jan 2021 10:46:07 -0800

Hello,

I made some patches for skim also. Yours look good but there are some
extras not installed. In particular the manpages, vim plugins and shell
completions are missing. Can you add something like the following to the
#:phases part of the arguments?

(modify-phases %standard-phases
  (add-after 'install 'install-extras
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (bin (string-append out "/bin"))
             (share (string-append out "/share"))
             (man (string-append out "/share/man"))
             (vimfiles (string-append share "/vim/vimfiles/plugin"))
             (bash-completion (string-append share "/bash-completions/completions"))
             (zsh-site (string-append share "/zsh/site-functions"))
             (fish-vendor (string-append share "/fish/vendor-completions.d")))
        ;; Binaries
        (for-each
         (lambda (binary) (install-file binary bin))
         (find-files "bin"))
        (mkdir-p share)
        ;; Manpages
        (copy-recursively "man" man)
        ;; Vim plugins
        (mkdir-p vimfiles)
        (copy-recursively "plugin" vimfiles)
        ;; Completions
        (mkdir-p bash-completion)
        (copy-file
         "shell/completion.bash"
         (string-append bash-completion "/skim"))
        (copy-file
         "shell/key-bindings.bash"
         (string-append bash-completion "/skim-bindings"))
        (mkdir-p zsh-site)
        (copy-file
         "shell/completion.zsh"
         (string-append zsh-site "/_skim"))
        (copy-file
         "shell/key-bindings.zsh"
         (string-append zsh-site "/_skim-bindings"))
        (mkdir-p fish-vendor)
        (copy-file
         "shell/key-bindings.fish"
         (string-append fish-vendor "/skim-bindings.fish"))))))

Thanks!

John

Message #11 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45293 <at> debbugs.gnu.org
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Mon, 25 Jan 2021 17:21:24 +0800

[Message part 1 (text/plain, inline)]

This is new patch.

[0001-gnu-Add-rust-tuikit-0.4.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-defer-drop-1.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-beef-0.4.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-skim-0.9.patch (text/x-patch, attachment)]

Message #14 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Z572 <873216071 <at> qq.com>
Cc: 45293 <45293 <at> debbugs.gnu.org>
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Mon, 25 Jan 2021 07:10:05 -0800

[Message part 1 (text/plain, inline)]

     
 

 Ah! Looks good!    One last thing I think you should do is move rust-skim to rust-apps.scm and rename to just skim. You may also want to deprecate the versions called rust-skim.  
 

 
Thanks again!
 

 
John
     

[Message part 2 (text/html, inline)]

Message #17 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45293 <at> debbugs.gnu.org
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Tue, 26 Jan 2021 00:15:23 +0800

[0001-gnu-Move-rust-skim-to-rust-apps.patch (text/x-patch, attachment)]

[0002-gnu-Rename-rust-skim-to-skim.patch (text/x-patch, attachment)]

Message #20 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Z572 <873216071 <at> qq.com>
Cc: 45293 <45293 <at> debbugs.gnu.org>
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Mon, 25 Jan 2021 08:20:52 -0800

[Message part 1 (text/plain, inline)]

     Can you rename rust-skim to skim (both variable name and package name) please?    I think ideally you should also remove the old rust-skim versions from crates-io.scm if no other packages depend on it.    Can also you also squash the commit doing the move and rename into the commit adding skim please? 

 
Thanks!
 

 
John
     

[Message part 2 (text/html, inline)]

Message #23 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 45293 <at> debbugs.gnu.org
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Tue, 26 Jan 2021 01:08:12 +0800

[Message part 1 (text/plain, inline)]

rust-rustyline-6 need skim-0.7

[0001-gnu-Add-skim.patch (text/x-patch, attachment)]

Message #26 received at 45293 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Z572 <873216071 <at> qq.com>
Cc: 45293 <at> debbugs.gnu.org, nicolo <at> nixo.xyz
Subject: Re: bug#45293: [PATCH] gnu: Add skim.
Date: Fri, 29 Jan 2021 08:35:47 -0800

Looks good! I don't have commit access, but this should be ready to go
when someone looks at it. I have cc'd Nicolò to see if they can merge
this.

Message #31 received at 45293-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: Z572 <873216071 <at> qq.com>, 45293-done <at> debbugs.gnu.org
Subject: Re: [bug#45293] [PATCH] gnu: Add skim.
Date: Fri, 05 Feb 2021 22:23:46 +0100

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> Looks good! I don't have commit access, but this should be ready to go
> when someone looks at it. I have cc'd Nicolò to see if they can merge
> this.

I improved the commit messages and pushed. Thanks to Zheng Junjie for
the patches and to you for the review.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.