GNU bug report logs - #45330
28.0.50; debbugs-gnu: Can't select reports before having started Gnus

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45330 in the body.
You can then email your comments to 45330 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
Date: Sun, 20 Dec 2020 05:53:18 +0100

Hi,

sorry if I had already reported this and a fix is on the way.  Or had it
been fixed and has reappeared, or even my fault this time?

I'm doing something like

  (debbugs-gnu-search "debbugs" '((subject . "debbugs")) nil nil nil)

and when I hit RET over a bug's line I get this error:

| Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
|   gnus-summary-goto-subject(0)
|   gnus-summary-last-subject()
|   gnus-summary-highlight-line()
|   gnus-summary-insert-line([0 "" "" "05 Apr 2001 23:33:09 +0400" "" "" 0 0 "" nil] 0 nil t 90 t nil "" nil 1)
|   gnus-update-summary-mark-positions()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#36903" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#36903" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#36903" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#36903" (nndoc "/tmp/gnus-temp-group-lGIifE" (nndoc-article-type mbox)) nil (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((36903) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((36903) (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(36903 ((cache_time . 1608439370.59222) (last_modified . 1573129444) (done . "Eric Abrahamsen <eric <at> ericabrahamsen.net>") (summary) (forwarded) (source . "unknown") (log_modified . 1573129444) (blockedby) (found_versions "27.0.50") (fixed_versions) (subject . "27.0.50; gnus registry vs. debbugs") (archived . t) (affects) (package "emacs") (location . "archive") (originator . "Michael Heerdegen <michael_heerdegen <at> web.de>") (date . 1564816382) (severity . "normal") (owner) (keywords) (fixed) (found (item (key . "27.0.50") (value))) (bug_num . 36903) (fixed_date) (id . 36903) (tags) (unarchived) (msgid . "<87pnlmen9q.fsf <at> web.de>") (pending . "done") (blocks) (found_date) (mergedwith)) nil)
|   debbugs-gnu-select-report()
|   funcall-interactively(debbugs-gnu-select-report)
|   call-interactively(debbugs-gnu-select-report nil nil)
|   command-execute(debbugs-gnu-select-report)

Annoying.  When I had started Gnus before, this doesn't happen.

TIA,

Michael.

Message #8 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 21 Dec 2020 05:56:15 +0100

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> sorry if I had already reported this and a fix is on the way.  Or had it
> been fixed and has reappeared, or even my fault this time?
>
> I'm doing something like
>
>   (debbugs-gnu-search "debbugs" '((subject . "debbugs")) nil nil nil)
>
> and when I hit RET over a bug's line I get this error:
>
> | Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
> |   gnus-summary-goto-subject(0)
> |   gnus-summary-last-subject()
> |   gnus-summary-highlight-line()
> |   gnus-summary-insert-line([0 "" "" "05 Apr 2001 23:33:09 +0400" ""
> | "" 0 0 "" nil] 0 nil t 90 t nil "" nil 1)
> |   gnus-update-summary-mark-positions()

I think this should be fixed on the trunk now -- can you check?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 21 Dec 2020 08:10:27 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I think this should be fixed on the trunk now -- can you check?

Ok, thanks.  Yes, good, though, now I get (deja vu again):

| Debugger entered--Lisp error: (cl-no-applicable-method registry-lookup nil ("<84k479sz16.fsf <at> aol.com>"))
|   signal(cl-no-applicable-method (registry-lookup nil ("<84k479sz16.fsf <at> aol.com>")))
|   cl-no-applicable-method(#s(cl--generic registry-lookup ((1 #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"])) (0 #s(cl--generic-generalizer eieio--generic-generalizer 50 cl--generic-struct-tag #[385 "\1\301N\302\1!\10>\205\21\0\303\304\305\3!\"\207" [cl-struct-eieio--class-tags cl--class type-of mapcar eieio--class-name eieio--class-precedence-list] 7 "\n\n(fn TAG &rest _)"]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"]))) (#s(cl--generic-method (registry-db t) nil nil #[(db keys) "\303\10\301\"\31\304\305\306\307\n\"\")\207" [db data keys eieio-oref delq nil mapcar #[(k) "\302\10\11\"\205\15\0\10\302\10\11\"D\207" [k data gethash] 4]] 5 "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell."])) nil) nil ("<84k479sz16.fsf <at> aol.com>"))
|   apply(cl-no-applicable-method #s(cl--generic registry-lookup ((1 #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"])) (0 #s(cl--generic-generalizer eieio--generic-generalizer 50 cl--generic-struct-tag #[385 "\1\301N\302\1!\10>\205\21\0\303\304\305\3!\"\207" [cl-struct-eieio--class-tags cl--class type-of mapcar eieio--class-name eieio--class-precedence-list] 7 "\n\n(fn TAG &rest _)"]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"]))) (#s(cl--generic-method (registry-db t) nil nil #[(db keys) "\303\10\301\"\31\304\305\306\307\n\"\")\207" [db data keys eieio-oref delq nil mapcar #[(k) "\302\10\11\"\205\15\0\10\302\10\11\"D\207" [k data gethash] 4]] 5 "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell."])) nil) (nil ("<84k479sz16.fsf <at> aol.com>")))
|   #f(compiled-function (&rest args) #<bytecode 0x306e3026b507eed>)(nil ("<84k479sz16.fsf <at> aol.com>"))
|   apply(#f(compiled-function (&rest args) #<bytecode 0x306e3026b507eed>) nil ("<84k479sz16.fsf <at> aol.com>"))
|   registry-lookup(nil ("<84k479sz16.fsf <at> aol.com>"))
|   gnus-registry-get-or-make-entry("<84k479sz16.fsf <at> aol.com>" nil)
|   gnus-registry-get-id-key("<84k479sz16.fsf <at> aol.com>" mark)
|   gnus-user-format-function-M([2 "bug#10000: 24.0.91; Gnus gnus-get-function error" "nyc4bos <at> aol.com" #("Tue, 08 Nov 2011 23:25:09 -0500" 0 1 (gnus-time (20154 165))) "<84k479sz16.fsf <at> aol.com>" nil -1 119 nil ((To . "10000 <at> debbugs.gnu.org"))])
|   (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)
|   (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation))
|   (progn (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)) (put-text-property (point) (progn (insert (format "%-23s" (let* ((val ...) (need ...)) (if (> need 0) (concat nil val ...) val)))) (point)) 'mouse-face gnus-mouse-face) (insert "   ") (add-text-properties (point) (progn (insert gnus-tmp-subject-or-nil) (point)) (cons 'face (cons (list 'font-lock-variable-name-face 'default) '(gnus-face t)))) (insert "\n"))
|   eval((progn (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)) (put-text-property (point) (progn (insert (format "%-23s" (let* (... ...) (if ... ... val)))) (point)) 'mouse-face gnus-mouse-face) (insert "   ") (add-text-properties (point) (progn (insert gnus-tmp-subject-or-nil) (point)) (cons 'face (cons (list 'font-lock-variable-name-face 'default) '(gnus-face t)))) (insert "\n")))
|   gnus-summary-prepare-threads((([2 "bug#10000: 24.0.91; Gnus gnus-get-function error" "nyc4bos <at> aol.com" #("Tue, 08 Nov 2011 23:25:09 -0500" 0 1 (gnus-time (20154 165))) "<84k479sz16.fsf <at> aol.com>" nil -1 119 nil ((To . "10000 <at> debbugs.gnu.org"))] ([3 "bug#10000: 24.0.91; Gnus gnus-get-function error" "Lars Magne Ingebrigtsen <larsi <at> gnus.org>" "Sat, 07 Jan 2012 00:34:39 +0100" "<m3boqg5rsg.fsf <at> stories.gnus.org>" "<84k479sz16.fsf <at> aol.com>" -1 21 nil ((Cc . "10000 <at> debbugs.gnu.org") (To . "nyc4bos <at> aol.com"))])) ([4 "control message for bug #10000" "Lars Magne Ingebrigtsen <larsi <at> gnus.org>" #("Sat, 07 Jan 2012 00:34:43 +0100" 0 1 (gnus-time (20231 34067))) "<m3aa605rsc.fsf <at> stories.gnus.org>" nil -1 6 nil ((To . "control <at> debbugs.gnu.org, 10000 <at> debbugs.gnu.org"))]) ([1 "Status: 24.0.91; Gnus gnus-get-function error" "bug#10000 <10000 <at> debbugs.gnu.org>" #("Mon, 21 Dec 2020 07:03:37 +0000" 0 1 (gnus-time (24544 18633))) "fake+none+nndoc+ephemeral:bug#10000+1" nil -1 9 nil ((To . "bug#10000 <10000 <at> debbugs.gnu.org>"))])))
|   gnus-summary-prepare()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#10000" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#10000" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#10000" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#10000" (nndoc "/tmp/gnus-temp-group-hZ7CcZ" (nndoc-article-type mbox)) nil (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((10000) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((10000) (#<buffer *Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(10000 ((cache_time . 1608534206.8331993) (msgid . "<84k479sz16.fsf <at> aol.com>") (package "emacs" "gnus") (forwarded) (owner) (tags "notabug") (found_versions "24.0.91") (fixed_date) (fixed_versions) (mergedwith) (last_modified . 1328358242) (done . "Lars Magne Ingebrigtsen <larsi <at> gnus.org>") (found_date) (affects) (location . "archive") (originator . "nyc4bos <at> aol.com") (found (item (key . "24.0.91") (value))) (source . "unknown") (keywords "notabug") (subject . "24.0.91; Gnus gnus-get-function error") (bug_num . 10000) (pending . "done") (id . 10000) (blocks) (summary) (log_modified . 1328358242) (fixed) (severity . "minor") (unarchived) (date . 1320812762) (archived . t) (blockedby)) nil)
|   debbugs-gnu-select-report()

I have

#+begin_src emacs-lisp
(defalias 'gnus-user-format-function-M
  'gnus-registry-article-marks-to-chars)
#+end_src

and am using it in `gnus-summary-line-format'.  Can you reproduce that
problem?


Thanks,

Michael.

Message #14 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 21 Dec 2020 08:12:31 -0800

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> I think this should be fixed on the trunk now -- can you check?
>
> Ok, thanks.  Yes, good, though, now I get (deja vu again):
>
> | Debugger entered--Lisp error: (cl-no-applicable-method
> | registry-lookup nil ("<84k479sz16.fsf <at> aol.com>"))

Yes, we've been here before, in bug 36903, and commit a81223aeaa...

Message #17 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Tue, 22 Dec 2020 08:43:15 -0800

On 12/21/20 08:12 AM, Eric Abrahamsen wrote:
> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>
>> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>>
>>> I think this should be fixed on the trunk now -- can you check?
>>
>> Ok, thanks.  Yes, good, though, now I get (deja vu again):
>>
>> | Debugger entered--Lisp error: (cl-no-applicable-method
>> | registry-lookup nil ("<84k479sz16.fsf <at> aol.com>"))
>
> Yes, we've been here before, in bug 36903, and commit a81223aeaa...

Oh hang on, it looks like that took me several tries to get right,
in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf, in
which it looks like I was confident that checking
`gnus-registry-enabled' was sufficient to ensure that the registry was
actually an object. Give me a second to figure out why that's not true.

Message #20 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Wed, 23 Dec 2020 06:23:25 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Oh hang on, it looks like that took me several tries to get right,
> in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf,

Wow...

> in which it looks like I was confident that checking
> `gnus-registry-enabled' was sufficient to ensure that the registry was
> actually an object. Give me a second to figure out why that's not
> true.

Ok, please keep me informed :-)


TIA,

Michael.

Message #23 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Wed, 23 Dec 2020 10:08:47 -0800

On 12/23/20 06:23 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Oh hang on, it looks like that took me several tries to get right,
>> in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf,
>
> Wow...

It was embarrassing.

>> in which it looks like I was confident that checking
>> `gnus-registry-enabled' was sufficient to ensure that the registry was
>> actually an object. Give me a second to figure out why that's not
>> true.
>
> Ok, please keep me informed :-)

So it's pretty clear: `gnus-registry-initialize' in effect looks like
this:

(defun gnus-registry-initialize ()
  (gnus-registry-install-hooks) -> (setq gnus-registry-enabled t)
  (if (gnus-alive-p)
      (gnus-registry-load)
    (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

So in your case `gnus-registry-enabled' is set to t, but then
`gnus-registry-load' is never called (because Gnus is neither alive, nor
loaded later).

I suppose it's still reasonable to set `gnus-registry-enabled' in this
way -- the registry is, in fact, "enabled", it simply hasn't gotten
loaded (the naming problem again!). Perhaps the formatting functions
should go back to the earlier, more explicit check of `eieio-object-p'.

Bleagh.

Eric

Message #26 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Sun, 05 Dec 2021 00:18:04 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I suppose it's still reasonable to set `gnus-registry-enabled' in this
> way -- the registry is, in fact, "enabled", it simply hasn't gotten
> loaded (the naming problem again!). Perhaps the formatting functions
> should go back to the earlier, more explicit check of `eieio-object-p'.

This was almost a year ago -- is this still failing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #31 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Sun, 05 Dec 2021 01:23:39 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
> > I suppose it's still reasonable to set `gnus-registry-enabled' in this
> > way -- the registry is, in fact, "enabled", it simply hasn't gotten
> > loaded (the naming problem again!). Perhaps the formatting functions
> > should go back to the earlier, more explicit check of `eieio-object-p'.
>
> This was almost a year ago -- is this still failing?

Yes, it still bugs me all the time.

Michael.

Message #34 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Sun, 05 Dec 2021 20:48:43 +0100

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Yes, it still bugs me all the time.

Right.  Eric, could you have a look at this again?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Sun, 05 Dec 2021 14:18:32 -0800

On 12/05/21 20:48 PM, Lars Ingebrigtsen wrote:
> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>
>> Yes, it still bugs me all the time.
>
> Right.  Eric, could you have a look at this again?

I can switch the test to be something more explicit, but how about --
bear with me here -- making `gnus-summary-line-format' a group
parameter? It's something I've been thinking about for a while. It would
be really nice to be able to give different groups different summary
appearances. And it would allow Michael and everyone else to use a
separate format string for groups like debbugs or whatnot, that are
often opened without Gnus actually being running.

WDYT?

Message #40 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 06 Dec 2021 02:14:22 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --
> bear with me here -- making `gnus-summary-line-format' a group
> parameter? It's something I've been thinking about for a while. It would
> be really nice to be able to give different groups different summary
> appearances. And it would allow Michael and everyone else to use a
> separate format string for groups like debbugs or whatnot, that are
> often opened without Gnus actually being running.
>
> WDYT?

I have no strong opinion, but - why not, could be useful.  I don't think
this will spare a fix for this issue though.  Because, AFAIR this
registry -> nil thing has several reincarnations in debbugs.

Michael.

Message #43 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45330: 28.0.50;
 debbugs-gnu: Can't select reports before having started Gnus
Date: Sun, 05 Dec 2021 17:29:25 -0800

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>> bear with me here -- making `gnus-summary-line-format' a group
>> parameter? It's something I've been thinking about for a while. It would
>> be really nice to be able to give different groups different summary
>> appearances. And it would allow Michael and everyone else to use a
>> separate format string for groups like debbugs or whatnot, that are
>> often opened without Gnus actually being running.
>>
>> WDYT?
>
> I have no strong opinion, but - why not, could be useful.  I don't think
> this will spare a fix for this issue though.  Because, AFAIR this
> registry -> nil thing has several reincarnations in debbugs.

But we could probably provide a default option value for debbugs groups,
so that most users wouldn't even realize that they had a different
format value for those groups.

Message #46 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 06 Dec 2021 06:46:59 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --
> bear with me here -- making `gnus-summary-line-format' a group
> parameter? It's something I've been thinking about for a while. It would
> be really nice to be able to give different groups different summary
> appearances. And it would allow Michael and everyone else to use a
> separate format string for groups like debbugs or whatnot, that are
> often opened without Gnus actually being running.
>
> WDYT?

Uhm...  I think it sounds like a surprising feature.  People set that
variable from hooks, I think, and I think that's fine without getting
group parameters involved.

And I'm rather doubtful that this will fix the problems Michael are
experiencing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #49 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45330: 28.0.50;
 debbugs-gnu: Can't select reports before having started Gnus
Date: Mon, 06 Dec 2021 10:06:24 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>> bear with me here -- making `gnus-summary-line-format' a group
>> parameter? It's something I've been thinking about for a while. It would
>> be really nice to be able to give different groups different summary
>> appearances. And it would allow Michael and everyone else to use a
>> separate format string for groups like debbugs or whatnot, that are
>> often opened without Gnus actually being running.
>>
>> WDYT?
>
> Uhm...  I think it sounds like a surprising feature.  People set that
> variable from hooks, I think, and I think that's fine without getting
> group parameters involved.

Huh, that's odd, and something I hadn't considered. I wonder if the
hooks would end up running after the group parameter setting. If so, I
don't see why current configurations wouldn't simply continue to work as
they have.

> And I'm rather doubtful that this will fix the problems Michael are
> experiencing.

In debbugs groups or what have you, he would use a summary line format
that didn't include registry-specific functions, only data that was
available by default in the summary buffer.

Message #52 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Mon, 06 Dec 2021 22:29:36 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> > And I'm rather doubtful that this will fix the problems Michael are
> > experiencing.
>
> In debbugs groups or what have you, he would use a summary line format
> that didn't include registry-specific functions, only data that was
> available by default in the summary buffer.

This happens to me with the default summary line setting:

| Debugger entered--Lisp error: (cl-no-applicable-method registry-lookup nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   signal(cl-no-applicable-method (registry-lookup nil ("fake+none+nndoc+ephemeral:bug#10000+1")))
|   cl-no-applicable-method(#s(cl--generic :name registry-lookup :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>))) (0 #s(cl--generic-generalizer :name eieio--generic-generalizer :priority 50 :tagcode-function cl--generic-struct-tag :specializers-function #f(compiled-function (tag &rest _) #<bytecode 0x1cd368c028c72f80>)) #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>)))) :method-table (#s(cl--generic-method :specializers (registry-db t) :qualifiers nil :uses-cnm nil :function #f(compiled-function (db keys) "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell." #<bytecode 0x182de2023f4e54c4>))) :options nil) nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   apply(cl-no-applicable-method #s(cl--generic :name registry-lookup :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>))) (0 #s(cl--generic-generalizer :name eieio--generic-generalizer :priority 50 :tagcode-function cl--generic-struct-tag :specializers-function #f(compiled-function (tag &rest _) #<bytecode 0x1cd368c028c72f80>)) #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>)))) :method-table (#s(cl--generic-method :specializers (registry-db t) :qualifiers nil :uses-cnm nil :function #f(compiled-function (db keys) "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell." #<bytecode 0x182de2023f4e54c4>))) :options nil) (nil ("fake+none+nndoc+ephemeral:bug#10000+1")))
|   #f(compiled-function (&rest args) #<bytecode -0x1412675842721fe9>)(nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   apply(#f(compiled-function (&rest args) #<bytecode -0x1412675842721fe9>) nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   registry-lookup(nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   gnus-registry-get-or-make-entry("fake+none+nndoc+ephemeral:bug#10000+1" nil)
|   gnus-registry-get-id-key("fake+none+nndoc+ephemeral:bug#10000+1" group)
|   gnus-registry-register-message-ids()
|   run-hooks(gnus-summary-prepare-hook)
|   gnus-run-hooks(gnus-summary-prepare-hook)
|   gnus-summary-prepare()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#10000" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#10000" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#10000" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#10000" (nndoc "/tmp/gnus-temp-group-QMKNt6" (nndoc-article-type mbox)) nil (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((10000) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((10000) (#<buffer *Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(10000 ((cache_time . 1638825937.3608027) (severity . "minor") (tags "notabug") (found_versions "24.0.91") (found_date) (forwarded) (blocks) (affects) (pending . "done") (found (item (key . "24.0.91") (value))) (fixed) (originator . "nyc4bos <at> aol.com") (date . 1320812762) (archived . t) (id . 10000) (source . "unknown") (bug_num . 10000) (fixed_date) (location . "archive") (owner) (keywords "notabug") (done . "Lars Magne Ingebrigtsen <larsi <at> gnus.org>") (summary) (subject . "24.0.91; Gnus gnus-get-function error") (log_modified . 1328358242) (fixed_versions) (unarchived) (package "emacs" "gnus") (mergedwith) (msgid . "<84k479sz16.fsf <at> aol.com>") (blockedby) (last_modified . 1328358242)) nil)
|   debbugs-gnu-select-report()
|   funcall-interactively(debbugs-gnu-select-report)
|   command-execute(debbugs-gnu-select-report)

Ok, still with the rest of my config.  But it seems, unfortunately, that
it's not that trivial.

Michael.

Message #55 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45330: 28.0.50;
 debbugs-gnu: Can't select reports before having started Gnus
Date: Mon, 06 Dec 2021 13:45:14 -0800

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> > And I'm rather doubtful that this will fix the problems Michael are
>> > experiencing.
>>
>> In debbugs groups or what have you, he would use a summary line format
>> that didn't include registry-specific functions, only data that was
>> available by default in the summary buffer.
>
> This happens to me with the default summary line setting:

Guess I didn't refresh my memory as fully as I thought! I was still
remembering this as a summary-line-format issue. I've pushed an
additional guard onto `gnus-registry-register-message-ids', I expect
this will fix it.

Message #58 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Tue, 07 Dec 2021 00:01:15 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Guess I didn't refresh my memory as fully as I thought! I was still
> remembering this as a summary-line-format issue. I've pushed an
> additional guard onto `gnus-registry-register-message-ids', I expect
> this will fix it.

Works for me, thanks!

Of course the `gnus-registry-article-marks-to-chars' (and the such)
problem remains.

Wouldn't it make sense to replace the `gnus-registry-enabled' checks
with a function call (gnus-registry-enabled-p) that would not only check
the variable but also the existence of the database, just like in your
installed patch?

TIA,

Michael.

Message #61 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Sun, 12 Dec 2021 03:46:01 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --

Please let's not forget about this again.

What has yet to be done to fix this issue?


Regards,

Michael.

Message #64 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Thu, 23 Dec 2021 14:42:04 -0800

[Message part 1 (text/plain, inline)]

On 12/12/21 03:46 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>
> Please let's not forget about this again.
>
> What has yet to be done to fix this issue?

Okay, dang it, here we go. Having thought about it, it seems like the
solutions might be simpler than I thought. `gnus-registry-initialize'
looks like this:

(defun gnus-registry-initialize ()
  "Initialize the Gnus registry."
  (interactive)
  (gnus-message 5 "Initializing the registry")
  (gnus-registry-install-hooks) => sets gnus-registry-enabled = t
  (gnus-registry-install-shortcuts)
  (if (gnus-alive-p)
      (gnus-registry-load)
    (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

It makes no sense to set `gnus-registry-enabled' to t when we haven't
fully loaded the registry. How about we move
`gnus-registry-install-hooks' and `gnus-registry-install-shortcuts' into
`gnus-registry-load', after the actual loading, a la the attached patch?
Does this solve the problems you're seeing?

Eric

[gnusregistryguard.diff (text/x-patch, attachment)]

Message #67 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Fri, 31 Dec 2021 19:55:57 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

>  How about we move `gnus-registry-install-hooks' and
> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
> actual loading, a la the attached patch?  Does this solve the problems
> you're seeing?

I can't tell whether your solution is appropriate but it indeed seems to
fix my problem!  I'll leave your patch installed and report back should
I see any downside.

Thanks,

Michael.

Message #70 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Fri, 31 Dec 2021 12:43:05 -0800

On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

Great, thanks. I can't imagine any downside, since the code is still
guaranteed to run, and the flag is set only if the initialization is
completed. Even if you weren't seeing erroneous behavior, I would still
think this was an appropriate refactor.

But yes, let's let it sit for a bit and see.

Message #75 received at 45330-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330-done <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Wed, 12 Jan 2022 15:06:47 -0800

On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

I looked back over the code and made some more rearrangements, I hope
really protecting various state variables behind the successful loading
of the registry. Please re-open if I've gotten anything wrong.

Thanks,
Eric

Message #78 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Wed, 12 Jan 2022 15:07:46 -0800

On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
we should have just been checking the existence of `gnus-registry-db',
but I think it's too late to remove that boolean now.

Message #81 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Thu, 13 Jan 2022 13:43:45 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
> we should have just been checking the existence of `gnus-registry-db',
> but I think it's too late to remove that boolean now.

It's not used so often.  And it makes things unnecessarily mixed-up.  My
gut feeling says you should give it a try.

Anyway, thanks for fixing this bug.

Michael.

Message #84 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45330: 28.0.50;
 debbugs-gnu: Can't select reports before having started Gnus
Date: Thu, 13 Jan 2022 11:42:08 -0800

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
>> we should have just been checking the existence of `gnus-registry-db',
>> but I think it's too late to remove that boolean now.
>
> It's not used so often.  And it makes things unnecessarily mixed-up.  My
> gut feeling says you should give it a try.

Hmm, I suppose an obsolete variable alias wouldn't hurt, I doubt
anyone's trying to do anything with `gnus-registry-enabled' besides
checking it for truthiness.

Message #87 received at 45330 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 45330 <at> debbugs.gnu.org
Subject: Re: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before
 having started Gnus
Date: Thu, 13 Jan 2022 22:54:43 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Hmm, I suppose an obsolete variable alias wouldn't hurt, I doubt
> anyone's trying to do anything with `gnus-registry-enabled' besides
> checking it for truthiness.

Yes - preferably with a mention of what to use instead (which will
anyway be more likely what the user really wants, I guess).

Regards,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.