GNU bug report logs - #45374
[PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45374 in the body.
You can then email your comments to 45374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Doe <dftxbs3e <at> free.fr>
To: guix-patches <at> gnu.org
Cc: John Doe <dftxbs3e <at> free.fr>
Subject: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.
Date: Tue, 22 Dec 2020 23:21:27 +0100

* gnu/packages/freedesktop.scm (udisks):
[inputs]: Add dosfstools.
[arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with
wrapper.
---
 gnu/packages/freedesktop.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 3c4ad57a15..1104a07955 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.")
     (inputs
      `(("acl" ,acl)
        ("cryptsetup" ,cryptsetup)
+       ("dosfstools" ,dosfstools)
        ("libatasmart" ,libatasmart)
        ("libblockdev" ,libblockdev)
        ("libgudev" ,libgudev)
@@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.")
              (let ((out   (assoc-ref outputs "out"))
                    (utils (assoc-ref inputs "util-linux"))
                    (cryptsetup (assoc-ref inputs "cryptsetup"))
+                   (dosfstools (assoc-ref inputs "dosfstools"))
                    (parted (assoc-ref inputs "parted")))
                (wrap-program (string-append out "/libexec/udisks2/udisksd")
                  `("PATH" ":" prefix
@@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.")
                     ;; cryptsetup is required for setting encrypted
                     ;; partitions, e.g. in gnome-disks
                     ,(string-append cryptsetup "/sbin")
+                    ;; Required to format FAT file systems in gnome-disks
+                    ,(string-append dosfstools "/sbin")
                     "/run/current-system/profile/bin"
                     "/run/current-system/profile/sbin")))
                #t))))))
-- 
2.29.2

Message #8 received at 45374 <at> debbugs.gnu.org (full text, mbox):

From: dftxbs3e <dftxbs3e <at> free.fr>
To: 45374 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.
Date: Tue, 22 Dec 2020 23:44:29 +0100

[Message part 1 (text/plain, inline)]

Looks like there has already been some discussion about this: 
https://issues.guix.gnu.org/41247

So what do we do?

Patch libblockdev to use full paths or give it to udisksd's
environment?

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 45374-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: dftxbs3e <dftxbs3e <at> free.fr>
Cc: 45374-done <at> debbugs.gnu.org
Subject: Re: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with
 wrapper.
Date: Sun, 02 Jun 2024 21:35:04 -0400

Hi,

dftxbs3e <dftxbs3e <at> free.fr> writes:

> Looks like there has already been some discussion about this: 
> https://issues.guix.gnu.org/41247
>
> So what do we do?
>
> Patch libblockdev to use full paths or give it to udisksd's
> environment?

I think patching libblockdev is the better solution.  I'm applying
Sarah's patches which added dosfstools as an input and did the patching,
so we should be covered.

Closing.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.