GNU bug report logs - #45376
28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45376 in the body.
You can then email your comments to 45376 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "gliao.tw <at> pm.me" <gliao.tw <at> pm.me>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Cc: "emacs-devel <at> gnu.org" <emacs-devel <at> gnu.org>
Subject: 28.0.50;
 [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
Date: Wed, 23 Dec 2020 01:59:42 +0000

[Message part 1 (text/plain, inline)]

Hi,

I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.

The first attachment shows the `ls` command output under eshell loaded from elc, while the second attachment shows the same command, but much stranger output under eshell loaded from eln.

I have tested/complied the last updated code on Linux/x86-64, Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all the test cases generate the same weird output from `ls` under eln-loaded eshell.

This issue does not happen on the code based at or before commit f244c21902

Thanks,
Kiong-Ge.

[eshell-use-byte-code.png (image/png, attachment)]

[eshell-use-native-comp-eln.png (image/png, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: gliao.tw <at> pm.me
Cc: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Re: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell
 loaded from eln
Date: Wed, 23 Dec 2020 07:51:54 +0000

"gliao.tw <at> pm.me" <gliao.tw <at> pm.me> writes:

> Hi,
>
> I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
>
> The first attachment shows the `ls` command output under eshell loaded
> from elc, while the second attachment shows the same command, but much
> stranger output under eshell loaded from eln.
>
> I have tested/complied the last updated code on Linux/x86-64,
> Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> the test cases generate the same weird output from `ls` under
> eln-loaded eshell.
>
> This issue does not happen on the code based at or before commit f244c21902
>
> Thanks,
> Kiong-Ge.

Hi Kiong-Ge,

yep, I've merged a lot of stuff into the value/type inference logic so
this is certanly related.

The offending function is `eshell-ls-find-column-lengths', I'll have a
look.

Thanks for reporting

  Andrea

PS leaving out emacs-devel to avoid cross posting

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: gliao.tw <at> pm.me, 45376 <at> debbugs.gnu.org
Subject: Re: bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output
 in eshell loaded from eln
Date: Wed, 23 Dec 2020 15:27:29 +0000

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> "gliao.tw <at> pm.me" <gliao.tw <at> pm.me> writes:
>
>> Hi,
>>
>> I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
>>
>> The first attachment shows the `ls` command output under eshell loaded
>> from elc, while the second attachment shows the same command, but much
>> stranger output under eshell loaded from eln.
>>
>> I have tested/complied the last updated code on Linux/x86-64,
>> Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
>> the test cases generate the same weird output from `ls` under
>> eln-loaded eshell.
>>
>> This issue does not happen on the code based at or before commit f244c21902
>>
>> Thanks,
>> Kiong-Ge.
>
> Hi Kiong-Ge,
>
> yep, I've merged a lot of stuff into the value/type inference logic so
> this is certanly related.
>
> The offending function is `eshell-ls-find-column-lengths', I'll have a
> look.

Hi Kiong-Ge,

as of ffcd490cb4 is working for me, could you give it a try?

Just remember you might need to clean the eln-cache folder to have
eshell freshly recompiled.

Thanks!

  Andrea

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "gliao.tw <at> pm.me" <gliao.tw <at> pm.me>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Re: 28.0.50;
 [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
Date: Wed, 23 Dec 2020 15:34:48 +0000

Indeed. On f244c21902, I got

~ $ (eshell-ls-find-column-lengths (list (list "dd" "kk") (list "rr" "uue")))
([4 4]
 ("dd" "kk")
 ("rr" "uue"))

but on 	433ae7b0a5cedbcd7b0a1daf12846e38f00fd111, I got

~ $ (eshell-ls-find-column-lengths (list (list "dd" "kk") (list "rr" "uue")))
([4 0]
 ("dd" "kk")
 ("dd" "kk"))





‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, December 23, 2020 1:51 AM, Andrea Corallo <akrl <at> sdf.org> wrote:

> %22gliao.tw <at> pm.me">--protonSignature--"gliao.tw <at> pm.me" gliao.tw <at> pm.me writes:
>
> > Hi,
> > I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
> > The first attachment shows the `ls` command output under eshell loaded
> > from elc, while the second attachment shows the same command, but much
> > stranger output under eshell loaded from eln.
> > I have tested/complied the last updated code on Linux/x86-64,
> > Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> > the test cases generate the same weird output from `ls` under
> > eln-loaded eshell.
> > This issue does not happen on the code based at or before commit f244c21902
> > Thanks,
> > Kiong-Ge.
>
> Hi Kiong-Ge,
>
> yep, I've merged a lot of stuff into the value/type inference logic so
> this is certanly related.
>
> The offending function is `eshell-ls-find-column-lengths', I'll have a
> look.
>
> Thanks for reporting
>
> Andrea
>
> PS leaving out emacs-devel to avoid cross posting

Message #20 received at 45376 <at> debbugs.gnu.org (full text, mbox):

From: "gliao.tw <at> pm.me" <gliao.tw <at> pm.me>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: "Andrea Corallo via \"Bug reports for GNU Emacs,
 the Swiss army knife of text editors\"" <bug-gnu-emacs <at> gnu.org>,
 "45376 <at> debbugs.gnu.org" <45376 <at> debbugs.gnu.org>
Subject: Re: bug#45376: 28.0.50;
 [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
Date: Wed, 23 Dec 2020 17:10:39 +0000

Hi Andrea,

I can confirm that this issue is resolved by commit ffcd490cb4 on the following platforms (all using GCC 10.2):

Linux (Debian testing) Amd64 and Arm64
FreeBSD 12.2 Amd64, gcc build from ports
Windows/Msys2 as 2020-12-16

I believe we can close this bug now.

Thanks,
Gong-Yi.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, December 23, 2020 9:27 AM, Andrea Corallo <akrl <at> sdf.org> wrote:

> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" bug-gnu-emacs <at> gnu.org writes:
>
> > "gliao.tw <at> pm.me" gliao.tw <at> pm.me writes:
> >
> > > Hi,
> > > I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
> > > The first attachment shows the `ls` command output under eshell loaded
> > > from elc, while the second attachment shows the same command, but much
> > > stranger output under eshell loaded from eln.
> > > I have tested/complied the last updated code on Linux/x86-64,
> > > Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> > > the test cases generate the same weird output from `ls` under
> > > eln-loaded eshell.
> > > This issue does not happen on the code based at or before commit f244c21902
> > > Thanks,
> > > Kiong-Ge.
> >
> > Hi Kiong-Ge,
> > yep, I've merged a lot of stuff into the value/type inference logic so
> > this is certanly related.
> > The offending function is `eshell-ls-find-column-lengths', I'll have a
> > look.
>
> Hi Kiong-Ge,
>
> as of ffcd490cb4 is working for me, could you give it a try?
>
> Just remember you might need to clean the eln-cache folder to have
> eshell freshly recompiled.
>
> Thanks!
>
> Andrea

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: gliao.tw <at> pm.me
Cc: "Andrea Corallo via \"Bug reports for GNU Emacs,  the Swiss army knife
 of text editors\"" <bug-gnu-emacs <at> gnu.org>,
 "45376-done <at> debbugs.gnu.org" <45376 <at> debbugs.gnu.org>
Subject: Re: bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output
 in eshell loaded from eln
Date: Wed, 23 Dec 2020 18:51:15 +0000

"gliao.tw <at> pm.me" <gliao.tw <at> pm.me> writes:

> Hi Andrea,
>
> I can confirm that this issue is resolved by commit ffcd490cb4 on the following platforms (all using GCC 10.2):
>
> Linux (Debian testing) Amd64 and Arm64
> FreeBSD 12.2 Amd64, gcc build from ports
> Windows/Msys2 as 2020-12-16
>
> I believe we can close this bug now.
>
> Thanks,
> Gong-Yi.

Very nice, closing then.

Thanks!

  Andrea

Message #32 received at 45376 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: gliao.tw <at> pm.me, 45376 <at> debbugs.gnu.org
Subject: Re: bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output
 in eshell loaded from eln
Date: Fri, 25 Dec 2020 06:59:37 +0100

Andrea Corallo <akrl <at> sdf.org> writes:

> Very nice, closing then.

The bug was apparently not closed?  :-)  So I'm doing that now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 45376 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: gliao.tw <at> pm.me, 45376 <at> debbugs.gnu.org
Subject: Re: bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output
 in eshell loaded from eln
Date: Fri, 25 Dec 2020 08:01:32 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Very nice, closing then.
>
> The bug was apparently not closed?  :-)  So I'm doing that now.

Ops, thanks :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.