GNU bug report logs - #45454
27.1; Help for EIEIO constructors has two consecutive spaces

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45454 in the body.
You can then email your comments to 45454 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; Help for EIEIO constructors has two consecutive spaces
Date: Sun, 27 Dec 2020 11:50:23 +0000

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: David Engster <dengste <at> eml.cc>
Severity: minor
Tags: patch

For non-autoloaded EIEIO constructor functions,
eieio-help-constructor will output two consecutive spaces.

[0001-Do-not-output-two-spaces-for-non-autoloaded-object-c.patch (text/x-patch, inline)]

From 8f1b42ed9fb6a7f935c12a8caac6958d90c79eb6 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt <tim <at> tim-landscheidt.de>
Date: Thu, 25 Jan 2018 02:55:44 +0000
Subject: [PATCH] ; Do not output two spaces for non-autoloaded object
 constructor functions

* lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
to avoid two spaces for non-autoloaded object constructor functions.

Copyright-paperwork-exempt: yes
---
 lisp/emacs-lisp/eieio-opt.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/eieio-opt.el b/lisp/emacs-lisp/eieio-opt.el
index 59af7e12d2..3b222b9312 100644
--- a/lisp/emacs-lisp/eieio-opt.el
+++ b/lisp/emacs-lisp/eieio-opt.el
@@ -136,9 +136,9 @@ eieio-help-constructor
 	  (def (symbol-function ctr)))
       (goto-char (point-min))
       (prin1 ctr)
-      (insert (format " is an %s object constructor function"
+      (insert (format " is an %sobject constructor function"
 		      (if (autoloadp def)
-			  "autoloaded"
+			  "autoloaded "
 			"")))
       (when (and (autoloadp def)
 		 (null location))
-- 
2.26.2

Message #8 received at 45454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: david engster <dengste <at> eml.cc>, 45454 <at> debbugs.gnu.org
Subject: Re: bug#45454: 27.1; Help for EIEIO constructors has two
 consecutive spaces
Date: Mon, 28 Dec 2020 00:39:52 +0100

Tim Landscheidt <tim <at> tim-landscheidt.de> writes:

> * lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
> to avoid two spaces for non-autoloaded object constructor functions.
>
> Copyright-paperwork-exempt: yes

Looks good to me; I've applied this to Emacs 28.

This is your fifth tiny change to Emacs, but looking over the other
changes, I think we're still below the limit.

But this means that you're cumulatively getting close to the maximum
before the FSF needs copyright assignment papers for your changes to
Emacs.  Would you be willing to sign such papers now to expedite
applying any further patches from you in the future?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 45454 <at> debbugs.gnu.org (full text, mbox):

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 45454 <at> debbugs.gnu.org
Subject: Re: bug#45454: 27.1; Help for EIEIO constructors has two
 consecutive spaces
Date: Tue, 29 Dec 2020 16:11:15 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

>> * lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
>> to avoid two spaces for non-autoloaded object constructor functions.

>> Copyright-paperwork-exempt: yes

> Looks good to me; I've applied this to Emacs 28.

> This is your fifth tiny change to Emacs, but looking over the other
> changes, I think we're still below the limit.

> But this means that you're cumulatively getting close to the maximum
> before the FSF needs copyright assignment papers for your changes to
> Emacs.  Would you be willing to sign such papers now to expedite
> applying any further patches from you in the future?

Yes; in 2018, I (IIRC unpromptedly) started the process
(gnu.org #1268668), but I think it got stuck.

Message #18 received at 45454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: 45454 <at> debbugs.gnu.org
Subject: Re: bug#45454: 27.1; Help for EIEIO constructors has two
 consecutive spaces
Date: Wed, 30 Dec 2020 03:53:16 +0100

Tim Landscheidt <tim <at> tim-landscheidt.de> writes:

> Yes; in 2018, I (IIRC unpromptedly) started the process
> (gnu.org #1268668), but I think it got stuck.

Hm.  Did it get stuck on the FSF side or because of something else?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 45454 <at> debbugs.gnu.org (full text, mbox):

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 45454 <at> debbugs.gnu.org
Subject: Re: bug#45454: 27.1; Help for EIEIO constructors has two
 consecutive spaces
Date: Wed, 30 Dec 2020 05:59:49 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

>> Yes; in 2018, I (IIRC unpromptedly) started the process
>> (gnu.org #1268668), but I think it got stuck.

> Hm.  Did it get stuck on the FSF side or because of something else?

I don't know.  The last mail I got was an acknowledgement
from Theodore Teah on February 20, 2018 saying (with regard
to the scan of my signed assignment form which initially was
too large to send by mail): "I downloaded without problem
and it's crystal.  What can I say we all have our limits and
some might be a bit too low :) Thank you.  I'll get it back
to you shortly."

But I'm happy to sign the form again.

Message #24 received at 45454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: 45454 <at> debbugs.gnu.org
Subject: Re: bug#45454: 27.1; Help for EIEIO constructors has two
 consecutive spaces
Date: Thu, 31 Dec 2020 04:35:11 +0100

Tim Landscheidt <tim <at> tim-landscheidt.de> writes:

> I don't know.  The last mail I got was an acknowledgement
> from Theodore Teah on February 20, 2018 saying (with regard
> to the scan of my signed assignment form which initially was
> too large to send by mail): "I downloaded without problem
> and it's crystal.  What can I say we all have our limits and
> some might be a bit too low :) Thank you.  I'll get it back
> to you shortly."

Oops.  I'll ping the copyright clerk and see what's up.

> But I'm happy to sign the form again.

Hopefully that won't be necessary.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.