GNU bug report logs - #45462
28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45462 in the body.
You can then email your comments to 45462 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauricio Collares <mauricio <at> collares.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [feature/native-comp] trailing backslashes in
 comp-eln-load-path are required but shouldn't
Date: Sun, 27 Dec 2020 12:00:01 -0300

Steps to reproduce

1) Add "~/test" to comp-eln-load-path.
2) Native-compile file.el.

Expected result: The file gets written to
~/test/28.0.50-arch-hash/filename.eln.

Actual result: The file gets written to
~/test28.0.50-arch-hash/filename.eln.

Arguably comp-eln-load-path should behave the same as load-path and
always treat its entries as directories.

Message #8 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mauricio Collares <mauricio <at> collares.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Sun, 27 Dec 2020 17:23:37 +0000

Mauricio Collares <mauricio <at> collares.org> writes:

> Steps to reproduce
>
> 1) Add "~/test" to comp-eln-load-path.
> 2) Native-compile file.el.
>
> Expected result: The file gets written to
> ~/test/28.0.50-arch-hash/filename.eln.
>
> Actual result: The file gets written to
> ~/test28.0.50-arch-hash/filename.eln.
>
> Arguably comp-eln-load-path should behave the same as load-path and
> always treat its entries as directories.

Hi Mauricio,

ee53560c8c should fix this, please have a try.

Thanks for reporting.

  Andrea

Message #11 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Mauricio Collares <mauricio <at> collares.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Mon, 04 Jan 2021 21:35:09 -0300

Andrea Corallo <akrl <at> sdf.org> writes:
> Hi Mauricio,
>
> ee53560c8c should fix this, please have a try.
>
> Thanks for reporting.
>
>   Andrea

Hi Andrea,

First of all, happy new year!

I tested it and your fix is working well. Many thanks for the prompt
response and sorry for the delay in verifying it.

Best,
Mauricio

Message #16 received at 45462-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mauricio Collares <mauricio <at> collares.org>
Cc: 45462-done <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Tue, 05 Jan 2021 09:34:22 +0000

Mauricio Collares <mauricio <at> collares.org> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>> Hi Mauricio,
>>
>> ee53560c8c should fix this, please have a try.
>>
>> Thanks for reporting.
>>
>>   Andrea
>
> Hi Andrea,
>
> First of all, happy new year!

happy new year! :)

> I tested it and your fix is working well. Many thanks for the prompt
> response and sorry for the delay in verifying it.

Nice, closing then.

Thanks!

  Andrea

Message #19 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Mauricio Collares <mauricio <at> collares.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Thu, 14 Jan 2021 10:56:22 -0300

Andrea Corallo <akrl <at> sdf.org> writes:
> Hi Mauricio,
>
> ee53560c8c should fix this, please have a try.
>
> Thanks for reporting.
>
>   Andrea

Hi Andrea,

As I mentioned before, previous tests worked fine. However, while
debugging #45854, I saw this problem again today. A minimized testcase:

* file1.el:

(require 'file2)
(provide 'file1)

* file2.el:

(advice-add 'top-level :before 'identity)
(provide 'file2)

Then the command

emacs --batch -Q --eval "(add-to-list 'load-path \"~\")" --eval "(setq comp-eln-load-path '(\"~/eln\"))" -f batch-native-compile ~/file1.el

compiles file1 to ~/eln/28.0.50-host-arch/ (as expected) but compiles
the trampoline to ~/eln28.0.50-host-arch/.

Best,
Mauricio

Message #24 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mauricio Collares <mauricio <at> collares.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Thu, 14 Jan 2021 14:17:23 +0000

Mauricio Collares <mauricio <at> collares.org> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>> Hi Mauricio,
>>
>> ee53560c8c should fix this, please have a try.
>>
>> Thanks for reporting.
>>
>>   Andrea
>
> Hi Andrea,
>
> As I mentioned before, previous tests worked fine. However, while
> debugging #45854, I saw this problem again today. A minimized testcase:

I see where the issue is, should be an easy fix, I'll look into it this
evening.

Reopening this.

  Andrea

Message #27 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mauricio Collares <mauricio <at> collares.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Thu, 14 Jan 2021 21:43:50 +0000

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Mauricio Collares <mauricio <at> collares.org> writes:
>
>> Andrea Corallo <akrl <at> sdf.org> writes:
>>> Hi Mauricio,
>>>
>>> ee53560c8c should fix this, please have a try.
>>>
>>> Thanks for reporting.
>>>
>>>   Andrea
>>
>> Hi Andrea,
>>
>> As I mentioned before, previous tests worked fine. However, while
>> debugging #45854, I saw this problem again today. A minimized testcase:
>
> I see where the issue is, should be an easy fix, I'll look into it this
> evening.
>
> Reopening this.

Hi Mauricio,

f1efac1f9e should fix this, could you give it a try?

Thanks

  Andrea

Message #30 received at 45462 <at> debbugs.gnu.org (full text, mbox):

From: Mauricio Collares <mauricio <at> collares.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 45462 <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Mon, 18 Jan 2021 09:17:30 -0300

Andrea Corallo <akrl <at> sdf.org> writes:
>
> Hi Mauricio,
>
> f1efac1f9e should fix this, could you give it a try?
>
> Thanks
>
>   Andrea

I tested 883d937320 and I can confirm this bug is fixed. Thanks!

Best,
Mauricio

Message #35 received at 45462-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mauricio Collares <mauricio <at> collares.org>
Cc: 45462-done <at> debbugs.gnu.org
Subject: Re: bug#45462: 28.0.50; [feature/native-comp] trailing backslashes
 in comp-eln-load-path are required but shouldn't
Date: Mon, 18 Jan 2021 12:36:38 +0000

Mauricio Collares <mauricio <at> collares.org> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>>
>> Hi Mauricio,
>>
>> f1efac1f9e should fix this, could you give it a try?
>>
>> Thanks
>>
>>   Andrea
>
> I tested 883d937320 and I can confirm this bug is fixed. Thanks!

closing

Thanks!

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.