GNU bug report logs - #45523
[PATCH 0/2] Update for frrouting & add libyang

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45523 in the body.
You can then email your comments to 45523 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] Update for frrouting & add libyang
Date: Tue, 29 Dec 2020 11:17:54 +0100

The updated Frrouting needed some adaptations:

- packaging CESNET's libyang
- adding some dependencies (libcap, libyang, pcre for libyang)

I was not sure if I should have made pcre a
propagated-input in libyang instead of adding
it to frrouting or something like that.

I used the BSD-3 license for libyang, this should
be checked as I am not sure this is the right one.

Any feedback ?

-- 
Vincent Legoll

Message #8 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 45523 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add libyang
Date: Tue, 29 Dec 2020 11:20:30 +0100

* gnu/packages/networking.scm (libyang): New variable.
---
 gnu/packages/networking.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 30b17da069..0b19ab87d0 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -3509,6 +3509,33 @@ libraries and instead utilizing features provided by the Linux kernel to the
 maximum extent possible.")
     (license license:lgpl2.1+)))
 
+(define-public libyang
+  (package
+    (name "libyang")
+    (version "1.0.184")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/CESNET/libyang")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "00vzka0bdlx1znd06fb0ps0szigdm2x96bpdfx220x79jr9qywhx"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DENABLE_BUILD_TESTS=ON" "-DENABLE_LYD_PRIV=ON")))
+    (inputs `(("pcre" ,pcre)))
+    (native-inputs `(("cmocka" ,cmocka)
+                     ("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/CESNET/libyang")
+    (synopsis "YANG data modelling language library")
+    (description "libyang is a YANG data modelling language parser and toolkit
+written (and providing API) in C.  Current implementation covers YANG 1.0 (RFC
+6020) as well as YANG 1.1 (RFC 7950).")
+    (license license:bsd-3)))
+
 (define-public batctl
   (package
    (name "batctl")
-- 
2.29.2

Message #11 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 45523 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 2/2] gnu: frrouting: Update to 7.5.
Date: Tue, 29 Dec 2020 11:20:31 +0100

* gnu/packages/networking.scm (frrouting): Update to 7.5.
[inputs]: Add libyang, libcap & pcre.
---
 gnu/packages/networking.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 0b19ab87d0..f149f41c45 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -3426,7 +3426,7 @@ communication.")
 (define-public frrouting
   (package
     (name "frrouting")
-    (version "6.0.2")
+    (version "7.5")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/FRRouting/frr/releases/"
@@ -3434,11 +3434,14 @@ communication.")
                                   ".tar.xz"))
               (sha256
                (base32
-                "0xfrvi62w8qlh46f504ka0skb7pm0g0p8vmdng4w90gsbirlzpdd"))))
+                "1a27wvxmc51sr0kchy0hjfpv19imlgrr3s9k48lik9k01g71yrdr"))))
     (build-system gnu-build-system)
     (inputs
      `(("c-ares" ,c-ares)
        ("json-c" ,json-c)
+       ("libcap" ,libcap)
+       ("libyang" ,libyang)
+       ("pcre" ,pcre)
        ("readline" ,readline)))
     (native-inputs
      `(("perl" ,perl)
-- 
2.29.2

Message #14 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45523 <at> debbugs.gnu.org
Subject: Re: [bug#45523] [PATCH 0/2] Update for frrouting & add libyang
Date: Wed, 30 Dec 2020 19:11:58 -0500

On Tue, Dec 29, 2020 at 11:17:54AM +0100, Vincent Legoll wrote:
> I was not sure if I should have made pcre a
> propagated-input in libyang instead of adding
> it to frrouting or something like that.

libyang includes pcre in the Requires.private field of libyang.pc.
According to the 'package reference' section of the Guix manual,
inputs should be propagated in this case:

https://guix.gnu.org/manual/en/html_node/package-Reference.html

> I used the BSD-3 license for libyang, this should
> be checked as I am not sure this is the right one.

(guix licenses) includes links to authoritative sources on licenses:

https://git.savannah.gnu.org/cgit/guix.git/tree/guix/licenses.scm#n167

You can check the package's LICENSE file against those resources.

Message #17 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 45523 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add libyang
Date: Tue,  5 Jan 2021 11:57:27 +0100

* gnu/packages/networking.scm (libyang): New variable.
---
 gnu/packages/networking.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index fad917a7c0..fec0341147 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -3508,6 +3508,33 @@ libraries and instead utilizing features provided by the Linux kernel to the
 maximum extent possible.")
     (license license:lgpl2.1+)))
 
+(define-public libyang
+  (package
+    (name "libyang")
+    (version "1.0.184")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/CESNET/libyang")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "00vzka0bdlx1znd06fb0ps0szigdm2x96bpdfx220x79jr9qywhx"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DENABLE_BUILD_TESTS=ON" "-DENABLE_LYD_PRIV=ON")))
+    (propagated-inputs `(("pcre" ,pcre)))
+    (native-inputs `(("cmocka" ,cmocka)
+                     ("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/CESNET/libyang")
+    (synopsis "YANG data modelling language library")
+    (description "libyang is a YANG data modelling language parser and toolkit
+written (and providing API) in C.  Current implementation covers YANG 1.0 (RFC
+6020) as well as YANG 1.1 (RFC 7950).")
+    (license license:bsd-3)))
+
 (define-public batctl
   (package
    (name "batctl")
-- 
2.29.2

Message #20 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 45523 <at> debbugs.gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH 2/2] gnu: frrouting: Update to 7.5.
Date: Tue,  5 Jan 2021 11:57:28 +0100

* gnu/packages/networking.scm (frrouting): Update to 7.5.
[inputs]: Add libyang, libcap & pcre.
---
 gnu/packages/networking.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index fec0341147..affab5c7e6 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -3425,7 +3425,7 @@ communication.")
 (define-public frrouting
   (package
     (name "frrouting")
-    (version "6.0.2")
+    (version "7.5")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/FRRouting/frr/releases/"
@@ -3433,11 +3433,13 @@ communication.")
                                   ".tar.xz"))
               (sha256
                (base32
-                "0xfrvi62w8qlh46f504ka0skb7pm0g0p8vmdng4w90gsbirlzpdd"))))
+                "1a27wvxmc51sr0kchy0hjfpv19imlgrr3s9k48lik9k01g71yrdr"))))
     (build-system gnu-build-system)
     (inputs
      `(("c-ares" ,c-ares)
        ("json-c" ,json-c)
+       ("libcap" ,libcap)
+       ("libyang" ,libyang)
        ("readline" ,readline)))
     (native-inputs
      `(("perl" ,perl)
-- 
2.29.2

Message #23 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 45523 <at> debbugs.gnu.org
Subject: new patch set
Date: Tue, 5 Jan 2021 12:00:32 +0100

The latet patch set removed pcre from
frrouting's inputs and modified libyang
to propagate this input.

The BSD-3 License should be the right
one in fact. As is is a Modified 3-clause
BSD.

Tchuss

-- 
Vincent Legoll

Message #26 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45523 <at> debbugs.gnu.org
Subject: Re: [bug#45523] [PATCH 1/2] gnu: Add libyang
Date: Sat, 20 Feb 2021 13:49:10 -0500

On Tue, Jan 05, 2021 at 11:57:27AM +0100, Vincent Legoll wrote:
> * gnu/packages/networking.scm (libyang): New variable.

> +    (home-page "https://github.com/CESNET/libyang")
> +    (synopsis "YANG data modelling language library")
> +    (description "libyang is a YANG data modelling language parser and toolkit
> +written (and providing API) in C.  Current implementation covers YANG 1.0 (RFC
> +6020) as well as YANG 1.1 (RFC 7950).")

I don't really understand what this package does but, I wonder if
networking.scm is the right place for it?

Message #29 received at 45523 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 45523 <at> debbugs.gnu.org
Subject: Re: [bug#45523] [PATCH 1/2] gnu: Add libyang
Date: Sat, 20 Feb 2021 20:02:01 +0100

Hello,

On Sat, Feb 20, 2021 at 7:49 PM Leo Famulari <leo <at> famulari.name> wrote:
> I don't really understand what this package does

Neither do I, you should have noticed I don't really know what
I'm doing. Kind of a monkey packager I guess :-)

I hope that's not too frightening.

> but, I wonder if networking.scm is the right place for it?

This looks related to Network Configuration Protocol
(NETCONF), and I had to find a place for it, so I chose
to put it near its user...

WDYT ?

-- 
Vincent Legoll

Message #34 received at 45523-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45523-done <at> debbugs.gnu.org
Subject: Re: [bug#45523] [PATCH 1/2] gnu: Add libyang
Date: Sat, 20 Feb 2021 18:04:31 -0500

On Sat, Feb 20, 2021 at 08:02:01PM +0100, Vincent Legoll wrote:
> Neither do I, you should have noticed I don't really know what
> I'm doing. Kind of a monkey packager I guess :-)
> 
> I hope that's not too frightening.

No worries, everybody starts at the beginning!

> This looks related to Network Configuration Protocol
> (NETCONF), and I had to find a place for it, so I chose
> to put it near its user...
> 
> WDYT ?

Alright, makes sense.

I pushed as 55fddf93079fa6e75bbe2d748c6abf8b5897d2c3 after updating
libyang to the latest (thanks to `guix lint` for letting me know about a
new release) and making sure that frrouting still builds.

Sorry these patches took so long to get in...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.