GNU bug report logs - #45524
[PATCH] gnu: tigervnc-client: Update to 1.11.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45524 in the body.
You can then email your comments to 45524 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Tue, 29 Dec 2020 11:35:57 +0100

* gnu/packages/vnc.scm (tigervnc-client): Update to 1.11.0.
[inputs]: Add pixman.
---
 gnu/packages/vnc.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/vnc.scm b/gnu/packages/vnc.scm
index ab89bad7aa..9aac5dfea8 100644
--- a/gnu/packages/vnc.scm
+++ b/gnu/packages/vnc.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,13 +42,14 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg))
 
 (define-public tigervnc-client
-  (let ((commit "920d9c4d6562ecabf79497bc901d50522d4bc661"))
+  (let ((commit "540bfc3278e396321124d4b18a798ac2bc18b6ca"))
     (package
       (name "tigervnc-client")
-      (version (git-version "1.10.1" "1" commit))
+      (version (git-version "1.11.0" "0" commit))
       (source (origin
                 (method git-fetch)
                 (uri
@@ -56,7 +58,7 @@
                   (commit commit)))
                 (sha256
                  (base32
-                  "1lp6mxl5dqlkrzx0q145jzgpbwvhsni3fj6x9ngf8v5s63x82q1p"))
+                  "1bg79ahr4mzy48ak0caxy3ckdsxmhpchypggaz6lxjjk92hgsz91"))
                 (file-name (git-file-name name version))))
       (build-system cmake-build-system)
       (arguments
@@ -80,7 +82,8 @@
          ("libxext" ,libxext)
          ("libxtst" ,libxtst)
          ("libxrandr" ,libxrandr)
-         ("libxdamage" ,libxdamage)))
+         ("libxdamage" ,libxdamage)
+         ("pixman" ,pixman)))
       (home-page "https://tigervnc.org/")
       (synopsis "High-performance, platform-neutral
 implementation of VNC (client)")
-- 
2.29.2

Message #10 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45524-done <at> debbugs.gnu.org
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Wed, 30 Dec 2020 03:04:39 -0500

On Tue, Dec 29, 2020 at 11:35:57AM +0100, Vincent Legoll wrote:
> * gnu/packages/vnc.scm (tigervnc-client): Update to 1.11.0.
> [inputs]: Add pixman.

Thanks!

> -  (let ((commit "920d9c4d6562ecabf79497bc901d50522d4bc661"))
> +  (let ((commit "540bfc3278e396321124d4b18a798ac2bc18b6ca"))

> +      (version (git-version "1.11.0" "0" commit))

I noticed that this commit was the 1.11.0 release tag, so I changed it
to use (version "1.11.0")

Pushed as 776c700aafb380ffc72f10cc463c6dfeb35dd7c1

Message #13 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 45524-done <at> debbugs.gnu.org
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Wed, 30 Dec 2020 16:55:36 +0100

On Wed, Dec 30, 2020 at 9:04 AM Leo Famulari <leo <at> famulari.name> wrote:
> I noticed that this commit was the 1.11.0 release tag, so I changed it
> to use (version "1.11.0")

Yes, I hesitated just doing so myself...

> Pushed as 776c700aafb380ffc72f10cc463c6dfeb35dd7c1

Thanks

-- 
Vincent Legoll

Message #16 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45524-done <at> debbugs.gnu.org
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Wed, 30 Dec 2020 15:17:24 -0500

On Wed, Dec 30, 2020 at 04:55:36PM +0100, Vincent Legoll wrote:
> On Wed, Dec 30, 2020 at 9:04 AM Leo Famulari <leo <at> famulari.name> wrote:
> > I noticed that this commit was the 1.11.0 release tag, so I changed it
> > to use (version "1.11.0")
> 
> Yes, I hesitated just doing so myself...

Feel free in the future :)

In general, it's always welcome to simplify the packages.

Message #19 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45524-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Fri, 01 Jan 2021 12:09:09 +0300

[Message part 1 (text/plain, inline)]

Hello,

I reverted the update to 1.11.0, because it breaks tigervnc-server
(missing /gnu/store/...-tigervnc-server-1.11.0/bin/tigervnc-server
binary).

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 45524-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Fri, 01 Jan 2021 12:47:26 +0300

[Message part 1 (text/plain, inline)]

Unfortunately, upstream breaks users scripts by intention without
warnings in the previos stable release 1.10.1 about deprecating ‘bin’
directory for ‘vncserver’ in next release, and mention this in release
news [1]:

  vncserver has gotten a major redesign to be compatible with modern
  distributions

[1] https://github.com/TigerVNC/tigervnc/releases/tag/v1.11.0

Apologies for missing that.  I reverted the package downgrade to 1.10.1.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 45524-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Vincent Legoll <vincent.legoll <at> gmail.com>, 45524-done <at> debbugs.gnu.org
Subject: Re: [bug#45524] [PATCH] gnu: tigervnc-client: Update to 1.11.0.
Date: Fri, 1 Jan 2021 13:46:27 -0500

On Fri, Jan 01, 2021 at 12:47:26PM +0300, Oleg Pykhalov wrote:
> Unfortunately, upstream breaks users scripts by intention without
> warnings in the previos stable release 1.10.1 about deprecating ‘bin’
> directory for ‘vncserver’ in next release, and mention this in release
> news [1]:
> 
>   vncserver has gotten a major redesign to be compatible with modern
>   distributions
> 
> [1] https://github.com/TigerVNC/tigervnc/releases/tag/v1.11.0
> 
> Apologies for missing that.  I reverted the package downgrade to 1.10.1.

Thanks for paying attention and taking care of it!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.