GNU bug report logs - #45558
[PATCH] Add js_of_ocaml

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45558 in the body.
You can then email your comments to 45558 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add js_of_ocaml
Date: Wed, 30 Dec 2020 20:22:57 +0100

[Message part 1 (text/plain, inline)]

Dear guix,

I finally got js_of_ocaml packaged. I'm not sure I did everything
correctly (especially indentation, but also how to make non-4.07
packages, and whether the package should have multiple outputs
corresponding to the opam packages), so do not hesitate to sendfeedback. 

Best regards,

divoplade

[0001-gnu-Add-ocaml-compiler-libs.patch (text/x-patch, attachment)]

[0002-gnu-Add-ocaml-stdio.patch (text/x-patch, attachment)]

[0003-gnu-add-ocaml-ppxlib.patch (text/x-patch, attachment)]

[0004-gnu-Add-ocaml-graphics.patch (text/x-patch, attachment)]

[0005-gnu-Add-ocaml-js-of-ocaml.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: divoplade <d <at> divoplade.fr>
Cc: 45558 <at> debbugs.gnu.org, 47769 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45558] [PATCH] Add js_of_ocaml
Date: Mon, 03 May 2021 12:38:13 +0000

[Message part 1 (text/plain, inline)]

Hi divoplade,

divoplade <d <at> divoplade.fr> writes:

> I finally got js_of_ocaml packaged.

Thank you!

> I'm not sure I did everything correctly (especially indentation

There do seem to be some indentation issues. Have you seen the 
section "Formatting Code" in the Guix manual? There is also a 
little script in the guix repository that will automatically 
indent a package definition.

Also your commit logs don't seem to be exactly in the required 
format. For example: "gnu: add ocaml-ppxlib" should be "gnu: Add 
ocaml-ppxlib.". Check the section "Submitting Patches" in the Guix 
manual and also the commit history for examples.

There are also some things that the linter discovers. For example 
you can omit the ".git" suffix for GitHub sources or that 
pkg-config is not needed in ocaml-graphics. You can run `git lint 
PACKAGE` too see what the linter has to say (and maybe should do 
that for modified package definitions).

> , but also how to make non-4.07 packages

This looks ok.

I submitted a series of patches that does this for many OCaml 
packages including the ones included in your series 
(https://issues.guix.gnu.org/47768). I'm sorry I should have 
included your work in my patch series instead of duplicating.

Maybe a small difference is that the patches in #47769 include a 
more recent version of ocaml-ppxlib (and the required version of 
ocaml-migrate-parsetree).

I have updated your patches for ocaml-graphics and js_of_ocaml so 
that they can be applied on #47769. Some changes in the attached 
patches:

ocaml-graphics:
- Use version 5.1.1 instead of 5.1.0 (5.1.1 was released after you 
 submitted the patches)
- Remove unnecessary inputs
- Change git-reference url to homepage (GitHub without the ".git" 
 suffix)
- Minor changes to description too make linter happy

ocaml-js-of-ocaml:
- Set home-page to https://ocsigen.org/js_of_ocaml/
- Use version 3.9.0 instead of 3.8.0 (again released after you 
 submitted the patches)
- Enable source maps by including ocaml-yojson as input
- Enable tests (this requires ocaml-ppx-expect, 
 ocaml-ppx-variants-conv, ocaml-variantslib and an updated 
 version of ocaml-num)

[0001-gnu-Add-ocaml-graphics.patch (text/x-patch, attachment)]

[0002-gnu-Add-ocaml-variantslib.patch (text/x-patch, attachment)]

[0003-gnu-Add-ocaml-ppx-variants-conv.patch (text/x-patch, attachment)]

[0004-gnu-Add-ocaml-ppx-expect.patch (text/x-patch, attachment)]

[0005-gnu-ocaml-num-Update-to-1.4.patch (text/x-patch, attachment)]

[0006-gnu-Add-ocaml-js-of-ocaml.patch (text/x-patch, attachment)]

[Message part 8 (text/plain, inline)]

Best regards,
pukkamustard

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 45558 <at> debbugs.gnu.org, 47769 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45558] [PATCH] Add js_of_ocaml
Date: Tue, 04 May 2021 11:10:17 +0200

Hello,

Thank you for the interest in this issue. I realize I opened it at a
rather inconvenient time, so I guess it ended up on the bottom of the
pile for quite some time.

Le lundi 03 mai 2021 à 12:38 +0000, pukkamustard a écrit :
> I submitted a series of patches that does this for many OCaml 
> packages including the ones included in your series 
> (https://issues.guix.gnu.org/47768).

The situation is quite complex to me, please bear with me. If I
understand correctly, you pushed a lot of ocaml updates last month,
making some of the changes I made in december somewhat obsolete. Right?

So, now, I should your modified 5 patches in this issue on top of the
37 patches in the other issue to get js-of-ocaml. Is it correct?

At this rate, if it is possible, maybe you could just append these 5 to
the other issue, it would be easier to track.

What do you think?

I didn’t detect indentation problems by running ./etc/indent-code.el;
even if other packages in the module have some indentation problems.

Message #22 received at 45558-done <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: divoplade <d <at> divoplade.fr>
Cc: 45558-done <at> debbugs.gnu.org, 47768 <at> debbugs.gnu.org
Subject: Re: [bug#45558] [PATCH] Add js_of_ocaml
Date: Mon, 10 May 2021 05:18:53 +0000

Hi divoplade,

divoplade <d <at> divoplade.fr> writes:

[...]

> So, now, I should your modified 5 patches in this issue on top 
> of the
> 37 patches in the other issue to get js-of-ocaml. Is it correct?
>
> At this rate, if it is possible, maybe you could just append 
> these 5 to
> the other issue, it would be easier to track.
>
> What do you think?

Yeah, that makes sense. I just submitted a V2 of #47768 
(https://issues.guix.gnu.org/47768) that includes your patches for 
js_of_ocaml, merging the issues.

Closing this issue in favor of #47769.

-pukkamustard

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.