GNU bug report logs - #45565
[PATCH 0/2] Add more r-mlr3 add-ons

Previous Next

Package: guix-patches;

Reported by: Wiktor Żelazny <wz <at> freeshell.de>

Date: Thu, 31 Dec 2020 12:51:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45565 in the body.
You can then email your comments to 45565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#45565; Package guix-patches. (Thu, 31 Dec 2020 12:51:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Wiktor Żelazny <wz <at> freeshell.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 31 Dec 2020 12:51:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wiktor Żelazny <wz <at> freeshell.de>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add more r-mlr3 add-ons
Date: Thu, 31 Dec 2020 13:46:08 +0100
A false alarm yesterday regarding the r-mlr3pipelines determinism. I
confused the derivation hash with the build hash. As for r-mlr3ordinal,
the linter reported

./gnu/packages/cran.scm:25616:15: r-mlr3ordinal <at> 0.1.0-9000-0.9febac9: the source file name should contain the package name

I don’t know what “source file name” is referenced here, so I’m
submitting the definition as it is.

Wiktor Żelazny (2):
  gnu: Add r-mlr3pipelines.
  gnu: Add r-mlr3ordinal.

 gnu/packages/cran.scm | 62 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)


base-commit: 67497e20890348ebbd41612e2582b1745a80fec5
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#45565; Package guix-patches. (Thu, 31 Dec 2020 12:54:01 GMT) Full text and rfc822 format available.

Message #8 received at 45565 <at> debbugs.gnu.org (full text, mbox):

From: Wiktor Żelazny <wz <at> freeshell.de>
To: 45565 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add r-mlr3ordinal.
Date: Thu, 31 Dec 2020 13:53:41 +0100
* gnu/packages/cran.scm (r-mlr3ordinal): New variable.
---
 gnu/packages/cran.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 0837ddaf87..f429bd06fa 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -25606,3 +25606,34 @@ Operations exist for data preprocessing, model fitting, and ensemble learning.
 Graphs can themselves be treated as @code{mlr3} Learners and can therefore be
 resampled, benchmarked, and tuned.")
     (license license:lgpl3)))
+
+(define-public r-mlr3ordinal
+  (let ((commit "9febac983b11b7b1f477e5cf0212e5999cd2ed44")
+        (revision "0"))
+    (package
+      (name "r-mlr3ordinal")
+      (version (git-version "0.1.0-9000" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/mlr-org/mlr3ordinal")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1icfhz1pjm0mlsn2y60gsrbk31b2p7xmpx3xsg7639rcgdb5f9gl"))))
+      (build-system r-build-system)
+      (propagated-inputs
+       `(("r-checkmate" ,r-checkmate)
+         ("r-data-table" ,r-data-table)
+         ("r-mlr3" ,r-mlr3)
+         ("r-mlr3misc" ,r-mlr3misc)
+         ("r-mlr3pipelines" ,r-mlr3pipelines)
+         ("r-nloptr" ,r-nloptr)
+         ("r-ordinal" ,r-ordinal)
+         ("r-paradox" ,r-paradox)
+         ("r-r6" ,r-r6)))
+      (home-page "https://mlr3ordinal.mlr-org.com/")
+      (synopsis "Ordinal Regression for @code{mlr3}")
+      (description "This package extends @code{mlr3} with support for
+performing ordinal regression.")
+      (license license:expat))))
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#45565; Package guix-patches. (Thu, 31 Dec 2020 12:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 45565 <at> debbugs.gnu.org (full text, mbox):

From: Wiktor Żelazny <wz <at> freeshell.de>
To: 45565 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add r-mlr3pipelines.
Date: Thu, 31 Dec 2020 13:53:40 +0100
* gnu/packages/cran.scm (r-mlr3pipelines): New variable.
---
 gnu/packages/cran.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 40f8e82c34..0837ddaf87 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -25575,3 +25575,34 @@ tuning, e.g. Grid Search, Random Search, or Simulated Annealing.  Various
 termination criteria can be set and combined.  The class @code{AutoTuner} provides a
 convenient way to perform nested resampling in combination with @code{mlr3}.")
     (license license:lgpl3)))
+
+(define-public r-mlr3pipelines
+  (package
+    (name "r-mlr3pipelines")
+    (version "0.3.2")
+    (source (origin
+              (method url-fetch)
+              (uri (cran-uri "mlr3pipelines" version))
+              (sha256
+               (base32
+                "1x738b312mcvb0dif88sv4nlh3y6i47q0wagc5ggyh1hnqjiz71y"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-backports" ,r-backports)
+       ("r-checkmate" ,r-checkmate)
+       ("r-data-table" ,r-data-table)
+       ("r-digest" ,r-digest)
+       ("r-lgr" ,r-lgr)
+       ("r-mlr3" ,r-mlr3)
+       ("r-mlr3misc" ,r-mlr3misc)
+       ("r-paradox" ,r-paradox)
+       ("r-r6" ,r-r6)
+       ("r-withr" ,r-withr)))
+    (home-page "https://mlr3pipelines.mlr-org.com/")
+    (synopsis "Preprocessing Operators and Pipelines for @code{mlr3}")
+    (description "@code{mlr3pipelines} enriches @code{mlr3} with a diverse
+set of pipelining operators (PipeOps) that can be composed into graphs.
+Operations exist for data preprocessing, model fitting, and ensemble learning.
+Graphs can themselves be treated as @code{mlr3} Learners and can therefore be
+resampled, benchmarked, and tuned.")
+    (license license:lgpl3)))
-- 
2.29.2





Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Fri, 31 Dec 2021 19:24:01 GMT) Full text and rfc822 format available.

Notification sent to Wiktor Żelazny <wz <at> freeshell.de>:
bug acknowledged by developer. (Fri, 31 Dec 2021 19:24:01 GMT) Full text and rfc822 format available.

Message #16 received at 45565-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Wiktor Żelazny <wz <at> freeshell.de>
Cc: 45565-done <at> debbugs.gnu.org
Subject: Re: [bug#45565] [PATCH 0/2] Add more r-mlr3 add-ons
Date: Fri, 31 Dec 2021 20:20:53 +0100
Hi Wiktor,

I’m terribly sorry for the delay.  These two patches are fine and
slipped through the cracks.  I updated the packages to the new input
style and pushed them to the “master” branch.

> As for r-mlr3ordinal, the linter reported
>
> ./gnu/packages/cran.scm:25616:15: r-mlr3ordinal <at> 0.1.0-9000-0.9febac9: the source file name should contain the package name
>
> I don’t know what “source file name” is referenced here, so I’m
> submitting the definition as it is.

This is due to the use of git-reference; you need to provide “file-name”
to give a name to the source checkout.  I did this when I applied your
patches.

Thanks for these patches!

-- 
Ricardo




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 29 Jan 2022 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.