GNU bug report logs - #45598
[PATCH] Add nord-theme

Previous Next

Package: guix-patches;

Reported by: Ellis Kenyo <me <at> elken.dev>

Date: Fri, 1 Jan 2021 15:00:02 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45598 in the body.
You can then email your comments to 45598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Fri, 01 Jan 2021 15:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ellis Kenyo <me <at> elken.dev>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 01 Jan 2021 15:00:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ellis Kenyo <me <at> elken.dev>
To: guix-patches <at> gnu.org
Cc: Ellis Kenyo <me <at> elken.dev>
Subject: [PATCH] Add nord-theme
Date: Fri,  1 Jan 2021 14:20:14 +0000
---
 gnu/packages/gnome-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 2eb08da50f..8de59dac2e 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -649,3 +649,28 @@ language specification for the Language Server Protocol (LSP).  This tool is
 used in text editing environments to provide a complete and integrated
 feature-set for programming Vala effectively.")
     (license license:lgpl2.1+)))
+
+(define-public nord-theme
+  (let ((commit "07d764c5ebd5706e73d2e573f1a983e37b318915")
+	(revision "0"))
+  (package
+   (name "nord-theme")
+   (version (git-version "1.9.0" revision commit))
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+	   (url "https://github.com/EliverLara/Nordic")
+	   (commit commit)))
+     (sha256
+      (base32
+       "0y2s9d6h1b195s6afp1gb5rb1plfslkpbw2brd30a9d66wfvsqk0"))
+     (file-name (git-file-name name version))))
+   (build-system copy-build-system)
+   (arguments
+    `(#:install-plan
+      `(("." "share/themes/nord" #:exclude ("README.md" "LICENSE" "Art/" "package.json" "package-lock.json" "Gulpfile.js")))))
+   (home-page "https://github.com/EliverLara/Nordic")
+   (synopsis "Dark Gtk3.20+ theme created using the awesome Nord color pallete.")
+   (description "Nordic is a Gtk3.20+ theme created using the awesome Nord color pallete.")
+   (license license:gpl3))))
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sat, 02 Jan 2021 03:00:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ellis Kenyo <me <at> elken.dev>,
 Ellis Kenyo via Guix-patches <guix-patches <at> gnu.org>
Cc: 45598 <at> debbugs.gnu.org
Subject: Re: [bug#45598] [PATCH] Add nord-theme
Date: Fri, 1 Jan 2021 21:59:08 -0500
On Fri, Jan 01, 2021 at 02:20:14PM +0000, Ellis Kenyo via Guix-patches via wrote:
> +(define-public nord-theme

Thanks!

> +	   (url "https://github.com/EliverLara/Nordic")

Should it be called "nordic-theme" instead? That seems to be the name
they picked.




Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sat, 02 Jan 2021 03:00:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sat, 02 Jan 2021 07:15:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ellis Kenyő <me <at> elken.dev>
To: Leo Famulari <leo <at> famulari.name>
Cc: 45598 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45598] [PATCH] Add nord-theme
Date: Sat, 02 Jan 2021 05:38:23 +0000
[Message part 1 (text/plain, inline)]
The original theme it's based on is called "Nord" and that's the expectation from a user perspective, I'm not quite sure why they renamed it.

On 2 Jan 2021, 03:05, at 03:05, Leo Famulari <leo <at> famulari.name> wrote:
>On Fri, Jan 01, 2021 at 02:20:14PM +0000, Ellis Kenyo via Guix-patches
>via wrote:
>> +(define-public nord-theme
>
>Thanks!
>
>> +	   (url "https://github.com/EliverLara/Nordic")
>
>Should it be called "nordic-theme" instead? That seems to be the name
>they picked.
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sat, 02 Jan 2021 07:15:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sun, 03 Jan 2021 23:35:01 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ellis Kenyő <me <at> elken.dev>
Cc: 45598 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45598] [PATCH] Add nord-theme
Date: Sun, 3 Jan 2021 18:34:01 -0500
On Sat, Jan 02, 2021 at 05:38:23AM +0000, Ellis Kenyő wrote:
> The original theme it's based on is called "Nord" and that's the expectation from a user perspective, I'm not quite sure why they renamed it.

Sorry to be a stickler but we usually use upstream names. We might make
exceptions if other distros rename it as well, or if there is some
widely used interface with the other name.

Is that the case? If so, we can call it nord-theme. Otherwise we'll use
nordic-theme.




Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Sun, 03 Jan 2021 23:35:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Mon, 04 Jan 2021 02:03:01 GMT) Full text and rfc822 format available.

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ellis Kenyő <me <at> elken.dev>
To: Leo Famulari <leo <at> famulari.name>
Cc: 45598 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45598] [PATCH] Add nord-theme
Date: Mon, 04 Jan 2021 02:02:17 +0000
[Message part 1 (text/plain, inline)]
I don't mind either way so I'm happy to have it merged as nordic! ☺️

On 3 Jan 2021, 23:40, at 23:40, Leo Famulari <leo <at> famulari.name> wrote:
>On Sat, Jan 02, 2021 at 05:38:23AM +0000, Ellis Kenyő wrote:
>> The original theme it's based on is called "Nord" and that's the
>expectation from a user perspective, I'm not quite sure why they
>renamed it.
>
>Sorry to be a stickler but we usually use upstream names. We might make
>exceptions if other distros rename it as well, or if there is some
>widely used interface with the other name.
>
>Is that the case? If so, we can call it nord-theme. Otherwise we'll use
>nordic-theme.
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#45598; Package guix-patches. (Mon, 04 Jan 2021 02:03:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Mon, 04 Jan 2021 02:41:01 GMT) Full text and rfc822 format available.

Notification sent to Ellis Kenyo <me <at> elken.dev>:
bug acknowledged by developer. (Mon, 04 Jan 2021 02:41:01 GMT) Full text and rfc822 format available.

Message #34 received at 45598-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ellis Kenyő <me <at> elken.dev>
Cc: 45598-done <at> debbugs.gnu.org
Subject: Re: [bug#45598] [PATCH] Add nord-theme
Date: Sun, 3 Jan 2021 21:40:45 -0500
On Mon, Jan 04, 2021 at 02:02:17AM +0000, Ellis Kenyő wrote:
> I don't mind either way so I'm happy to have it merged as nordic! ☺️

Okay! Pushed as fdfc1c81ba018dd808b0dfd9827a73262c716808 with the name
"nordic-theme.

Thanks!

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=fdfc1c81ba018dd808b0dfd9827a73262c716808




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 01 Feb 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 84 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.