GNU bug report logs - #45604
[PATCH 0/1] Add magic-enum package

Previous Next

Package: guix-patches;

Reported by: Anadon <joshua.r.marshall.1991 <at> gmail.com>

Date: Sat, 2 Jan 2021 00:52:01 UTC

Severity: normal

Tags: patch

Merged with 45730, 45731, 45850, 45851, 45852, 45853

Done: Leo Prikler <leo.prikler <at> student.tugraz.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45604 in the body.
You can then email your comments to 45604 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 02 Jan 2021 00:52:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 02 Jan 2021 00:52:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 0/1] Add magic-enum package
Date: Fri,  1 Jan 2021 19:51:44 -0500
Magic-enum is a C++17 header-only library for support of static
reflection on enums.

Josh Marshall (1):
  Added magic-enum header-only library as a package.

 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 02 Jan 2021 00:53:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 1/1] Added magic-enum header-only library as a package.
Date: Fri,  1 Jan 2021 19:51:45 -0500
From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>

---
 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..ff10a4247b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic.  This implementation
 provides a number of utilities to make coding with expected cleaner.")
     (home-page "https://tl.tartanllama.xyz/")
     (license license:cc0)))
+
+(define-public magic-enum
+    (package
+      (name "magic-enum")
+      (version "0.7.2")
+      (home-page "https://github.com/Neargye/magic_enum")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit (string-append "v" version))))
+                (sha256
+                 (base32
+                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
+                (modules '((guix build utils)))))
+      (build-system cmake-build-system)
+
+      (inputs
+       `(("gcc" ,gcc-10)))
+      (synopsis "Header-only C++17 library for reflection for enums")
+      (description "Static reflection for enums (to string, from string,
+iteration) for modern C++, work with any enum type without any macro or
+boilerplate code")
+      (license license:expat)))
-- 
2.29.2





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Mon, 04 Jan 2021 13:07:02 GMT) Full text and rfc822 format available.

Message #11 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Anadon <joshua.r.marshall.1991 <at> gmail.com>
Cc: 45604 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] Added magic-enum header-only library as a package.
Date: Mon, 04 Jan 2021 14:06:14 +0100
Hello Anadon,

I have not yet built your package (because I'm currently also handling
another patch), but since you've requested review over at guix-devel,
I'll have a go at it.
For the future please note, that a delay of 2 days does not mean we
haven't noticed you at all.  The manual has the following to say for
committers:
> For anything else, please post to <guix-patches <at> gnu.org> and leave
> time for a review, without committing anything (*note Submitting
> Patches::).  If you didn’t receive any reply after two weeks, and if
> you’re confident, it’s OK to commit.

Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Ehh, somehow the commit message and everything is missing here.  Is
that intended or just misconfigured?

> ---
>  gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..ff10a4247b 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic.  This implementation
>  provides a number of utilities to make coding with expected
> cleaner.")
>      (home-page "https://tl.tartanllama.xyz/")
>      (license license:cc0)))
> +
> +(define-public magic-enum
> +    (package
> +      (name "magic-enum")
> +      (version "0.7.2")
> +      (home-page "https://github.com/Neargye/magic_enum")
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url home-page)
> +                      (commit (string-append "v" version))))
> +                (sha256
> +                 (base32
> +                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
> +                (modules '((guix build utils)))))
> +      (build-system cmake-build-system)
> +
> +      (inputs
> +       `(("gcc" ,gcc-10)))
The home-page claims, that it works with GCC>=9.  Have you encountered
any issues with gcc-9 instead?
> +      (synopsis "Header-only C++17 library for reflection for
> enums")
I feel as though that could be worded better.
> +      (description "Static reflection for enums (to string, from
> string,
> +iteration) for modern C++, work with any enum type without any macro
> or
> +boilerplate code")
Descriptions should be complete sentences and end with a period.
> +      (license license:expat)))

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Mon, 04 Jan 2021 22:01:01 GMT) Full text and rfc822 format available.

Message #14 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 45604 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] Added magic-enum header-only library as a package.
Date: Mon, 4 Jan 2021 16:59:42 -0500
[Message part 1 (text/plain, inline)]
Sorry, one more thing I missed in the documentation was the waiting
period.  The commit message missing is probably a misconfiguration.  I can
change to gcc-9, I just defaulted to the newest since the default was too
old.  That description is a verbatim copy of their description.

I'll fix these up, then issue another patch series.







On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler <leo.prikler <at> student.tugraz.at>
wrote:

> Hello Anadon,
>
> I have not yet built your package (because I'm currently also handling
> another patch), but since you've requested review over at guix-devel,
> I'll have a go at it.
> For the future please note, that a delay of 2 days does not mean we
> haven't noticed you at all.  The manual has the following to say for
> committers:
> > For anything else, please post to <guix-patches <at> gnu.org> and leave
> > time for a review, without committing anything (*note Submitting
> > Patches::).  If you didn’t receive any reply after two weeks, and if
> > you’re confident, it’s OK to commit.
>
> Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> > From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
> Ehh, somehow the commit message and everything is missing here.  Is
> that intended or just misconfigured?
>
> > ---
> >  gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> > index 00e006928e..ff10a4247b 100644
> > --- a/gnu/packages/cpp.scm
> > +++ b/gnu/packages/cpp.scm
> > @@ -807,3 +807,27 @@ code will be mixed in with the actual
> > programming logic.  This implementation
> >  provides a number of utilities to make coding with expected
> > cleaner.")
> >      (home-page "https://tl.tartanllama.xyz/")
> >      (license license:cc0)))
> > +
> > +(define-public magic-enum
> > +    (package
> > +      (name "magic-enum")
> > +      (version "0.7.2")
> > +      (home-page "https://github.com/Neargye/magic_enum")
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url home-page)
> > +                      (commit (string-append "v" version))))
> > +                (sha256
> > +                 (base32
> > +                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> > sv2"))
> > +                (modules '((guix build utils)))))
> > +      (build-system cmake-build-system)
> > +
> > +      (inputs
> > +       `(("gcc" ,gcc-10)))
> The home-page claims, that it works with GCC>=9.  Have you encountered
> any issues with gcc-9 instead?
> > +      (synopsis "Header-only C++17 library for reflection for
> > enums")
> I feel as though that could be worded better.
> > +      (description "Static reflection for enums (to string, from
> > string,
> > +iteration) for modern C++, work with any enum type without any macro
> > or
> > +boilerplate code")
> Descriptions should be complete sentences and end with a period.
> > +      (license license:expat)))
>
> Regards,
> Leo
>
>
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Tue, 05 Jan 2021 20:40:02 GMT) Full text and rfc822 format available.

Message #17 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Cc: 45604 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] Added magic-enum header-only library as a package.
Date: Tue, 05 Jan 2021 21:39:40 +0100
Hello Josh,
Am Montag, den 04.01.2021, 16:59 -0500 schrieb Josh Marshall:
> Sorry, one more thing I missed in the documentation was the waiting
> period.  The commit message missing is probably a misconfiguration. 
> I can change to gcc-9, I just defaulted to the newest since the
> default was too old.  That description is a verbatim copy of their
> description.
W.r.t. the description you should probably come up with words of your
own.  The upstream one doesn't appear all that usable.

For the record, gcc should likely also be a native-input, given that
it'll be used for compilation and testing.

> I'll fix these up, then issue another patch series.
Don't forget to set --to, --cc and --reroll-count when you do ;)
Otherwise you might inadvertently open up new issues which will at
least confuse the bug tracker.

Regards,
Leo

> On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler <
> leo.prikler <at> student.tugraz.at> wrote:
> > Hello Anadon,
> > 
> > I have not yet built your package (because I'm currently also
> > handling
> > another patch), but since you've requested review over at guix-
> > devel,
> > I'll have a go at it.
> > For the future please note, that a delay of 2 days does not mean we
> > haven't noticed you at all.  The manual has the following to say
> > for
> > committers:
> > > For anything else, please post to <guix-patches <at> gnu.org> and
> > leave
> > > time for a review, without committing anything (*note Submitting
> > > Patches::).  If you didn’t receive any reply after two weeks, and
> > if
> > > you’re confident, it’s OK to commit.
> > 
> > Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> > > From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
> > Ehh, somehow the commit message and everything is missing here.  Is
> > that intended or just misconfigured?
> > 
> > > ---
> > >  gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> > >  1 file changed, 24 insertions(+)
> > > 
> > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> > > index 00e006928e..ff10a4247b 100644
> > > --- a/gnu/packages/cpp.scm
> > > +++ b/gnu/packages/cpp.scm
> > > @@ -807,3 +807,27 @@ code will be mixed in with the actual
> > > programming logic.  This implementation
> > >  provides a number of utilities to make coding with expected
> > > cleaner.")
> > >      (home-page "https://tl.tartanllama.xyz/")
> > >      (license license:cc0)))
> > > +
> > > +(define-public magic-enum
> > > +    (package
> > > +      (name "magic-enum")
> > > +      (version "0.7.2")
> > > +      (home-page "https://github.com/Neargye/magic_enum")
> > > +      (source (origin
> > > +                (method git-fetch)
> > > +                (uri (git-reference
> > > +                      (url home-page)
> > > +                      (commit (string-append "v" version))))
> > > +                (sha256
> > > +                 (base32
> > > +                 
> > "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> > > sv2"))
> > > +                (modules '((guix build utils)))))
> > > +      (build-system cmake-build-system)
> > > +
> > > +      (inputs
> > > +       `(("gcc" ,gcc-10)))
> > The home-page claims, that it works with GCC>=9.  Have you
> > encountered
> > any issues with gcc-9 instead?
> > > +      (synopsis "Header-only C++17 library for reflection for
> > > enums")
> > I feel as though that could be worded better.
> > > +      (description "Static reflection for enums (to string, from
> > > string,
> > > +iteration) for modern C++, work with any enum type without any
> > macro
> > > or
> > > +boilerplate code")
> > Descriptions should be complete sentences and end with a period.
> > > +      (license license:expat)))
> > 
> > Regards,
> > Leo
> > 





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 09 Jan 2021 02:42:03 GMT) Full text and rfc822 format available.

Message #20 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 0/2] Added magic-enum header-only library as a package.
Date: Fri,  8 Jan 2021 21:40:56 -0500
Added magic-enum header-only library as a package.

Anadon (1):
  Made changes Leo on the ML suggested.

Josh Marshall (1):
  Added magic-enum header-only library as a package.

 gnu/packages/cpp.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

-- 
2.30.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 09 Jan 2021 02:42:04 GMT) Full text and rfc822 format available.

Message #23 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 2/2] Made changes Leo on the ML suggested.
Date: Fri,  8 Jan 2021 21:40:58 -0500
---
 gnu/packages/cpp.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index ff10a4247b..487639c879 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -823,11 +823,9 @@ provides a number of utilities to make coding with expected cleaner.")
                   "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
                 (modules '((guix build utils)))))
       (build-system cmake-build-system)
-
-      (inputs
-       `(("gcc" ,gcc-10)))
-      (synopsis "Header-only C++17 library for reflection for enums")
-      (description "Static reflection for enums (to string, from string,
-iteration) for modern C++, work with any enum type without any macro or
-boilerplate code")
+      (native-inputs
+       `(("gcc" ,gcc-9)))
+      (synopsis "Header-only C++17 library for reflection on enums")
+      (description "C++17 static reflection for enums, allowing functions like
+ to string, from string, and iteration.")
       (license license:expat)))
-- 
2.30.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 09 Jan 2021 02:42:04 GMT) Full text and rfc822 format available.

Message #26 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 1/2] Added magic-enum header-only library as a package.
Date: Fri,  8 Jan 2021 21:40:57 -0500
From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>

---
 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..ff10a4247b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic.  This implementation
 provides a number of utilities to make coding with expected cleaner.")
     (home-page "https://tl.tartanllama.xyz/")
     (license license:cc0)))
+
+(define-public magic-enum
+    (package
+      (name "magic-enum")
+      (version "0.7.2")
+      (home-page "https://github.com/Neargye/magic_enum")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit (string-append "v" version))))
+                (sha256
+                 (base32
+                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
+                (modules '((guix build utils)))))
+      (build-system cmake-build-system)
+
+      (inputs
+       `(("gcc" ,gcc-10)))
+      (synopsis "Header-only C++17 library for reflection for enums")
+      (description "Static reflection for enums (to string, from string,
+iteration) for modern C++, work with any enum type without any macro or
+boilerplate code")
+      (license license:expat)))
-- 
2.30.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Sat, 09 Jan 2021 07:53:01 GMT) Full text and rfc822 format available.

Message #29 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: joshua.r.marshall.1991 <at> gmail.com
Cc: 45604 <at> debbugs.gnu.org
Subject: [bug#45604] [PATCH 0/2] Added magic-enum header-only library as a
 package.
Date: Sat, 09 Jan 2021 08:51:57 +0100
Hello Anadon,

three nitpicks:
1. You should squash the changes into the original commit.
2. The commit message(s) is/are still missing.
3. Please pick one name for your contributions.

Otherwise LGTM,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Thu, 14 Jan 2021 02:18:03 GMT) Full text and rfc822 format available.

Message #32 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 0/1] New package 'magic-enum'
Date: Wed, 13 Jan 2021 21:17:10 -0500
Added a simple package definition for the C++17 header only library
'magic-enum'.

Anadon (1):
  Added a package definition for the C++17 header only library
    'magic-enum'.

 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.27.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Thu, 14 Jan 2021 02:18:03 GMT) Full text and rfc822 format available.

Message #35 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 1/1] Added a package definition for the C++17 header only
 library 'magic-enum'.
Date: Wed, 13 Jan 2021 21:17:11 -0500
gnu/packages/cpp.scm: Added the package definition.
---
 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..ff10a4247b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic.  This implementation
 provides a number of utilities to make coding with expected cleaner.")
     (home-page "https://tl.tartanllama.xyz/")
     (license license:cc0)))
+
+(define-public magic-enum
+    (package
+      (name "magic-enum")
+      (version "0.7.2")
+      (home-page "https://github.com/Neargye/magic_enum")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit (string-append "v" version))))
+                (sha256
+                 (base32
+                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
+                (modules '((guix build utils)))))
+      (build-system cmake-build-system)
+
+      (inputs
+       `(("gcc" ,gcc-10)))
+      (synopsis "Header-only C++17 library for reflection for enums")
+      (description "Static reflection for enums (to string, from string,
+iteration) for modern C++, work with any enum type without any macro or
+boilerplate code")
+      (license license:expat)))
-- 
2.27.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Thu, 14 Jan 2021 02:37:03 GMT) Full text and rfc822 format available.

Message #38 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 0/1] New package 'magic-enum'
Date: Wed, 13 Jan 2021 21:36:29 -0500
Added a simple package definition for the C++17 header only library
'magic-enum'.

Anadon (1):
  Added a package definition for the C++17 header only library
    'magic-enum'.

 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.27.0





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Thu, 14 Jan 2021 02:37:03 GMT) Full text and rfc822 format available.

Message #41 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45604 <at> debbugs.gnu.org, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH 1/1] Added a package definition for the C++17 header only
 library 'magic-enum'.
Date: Wed, 13 Jan 2021 21:36:30 -0500
gnu/packages/cpp.scm: Added the package definition.
---
 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..673867dbd2 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic.  This implementation
 provides a number of utilities to make coding with expected cleaner.")
     (home-page "https://tl.tartanllama.xyz/")
     (license license:cc0)))
+
+(define-public magic-enum
+    (package
+      (name "magic-enum")
+      (version "0.7.2")
+      (home-page "https://github.com/Neargye/magic_enum")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit (string-append "v" version))))
+                (sha256
+                 (base32
+                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
+                (modules '((guix build utils)))))
+      (build-system cmake-build-system)
+
+      (inputs
+       `(("gcc" ,gcc-9)))
+      (synopsis "C++17 header only library for compile time reflection of enums")
+      (description "C++17 header only library which offers static reflection
+of enums, with to string, from string, and iteration, and related
+functionality.")
+      (license license:expat)))
-- 
2.27.0





Merged 45604 45730 45731 45850 45851 45852 45853. Request was from Leo Prikler <leo.prikler <at> student.tugraz.at> to control <at> debbugs.gnu.org. (Thu, 14 Jan 2021 10:04:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Thu, 14 Jan 2021 12:00:02 GMT) Full text and rfc822 format available.

Message #46 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Anadon <joshua.r.marshall.1991 <at> gmail.com>
Cc: 45604 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] Added a package definition for the C++17 header
 only library 'magic-enum'.
Date: Thu, 14 Jan 2021 12:59:49 +0100
Hello Anadon,

I was prepared to overlook some formal errors and push this with some
slight adjustment, but my package build failed, so I'll have to make
you adjust it once again.

Am Mittwoch, den 13.01.2021, 21:36 -0500 schrieb Anadon:
> gnu/packages/cpp.scm: Added the package definition.
The commit message for this package should be (minus indentation)

    gnu: Add magic-enum.
    
    * gnu/packages/cpp.scm (magic-enum): New variable.

to keep with the already established style.

You don't need to send a cover letter for a single patch.  Also, don't
include guix-patches in your follow-up messages, but do CC me. 
Additionally, it'd be nice if you used --reroll-count, but I'll sort
things out.

> ---
>  gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..673867dbd2 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic.  This implementation
>  provides a number of utilities to make coding with expected
> cleaner.")
>      (home-page "https://tl.tartanllama.xyz/")
>      (license license:cc0)))
> +
> +(define-public magic-enum
> +    (package
> +      (name "magic-enum")
> +      (version "0.7.2")
> +      (home-page "https://github.com/Neargye/magic_enum")
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url home-page)
> +                      (commit (string-append "v" version))))
Missing (file-name (git-file-name name version)).
This is needed with git-references as otherwise it'll just be named
"git-checkout", which isn't very helpful.
> +                (sha256
> +                 (base32
> +                  "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
After I recently cleaned my checkout completely (unrelated bytecode
troubles), this hash does not match up the one I get with `guix build'.

r:sha256 hash mismatch for /gnu/store/ajxz311mls8ybih8cify2lcwnwkqd1wy-
git-checkout:
  expected hash: 0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2
  actual hash:   07j5zdf3vkliwrcv6k663k35akn7qp23794sz2mnvkj9hbv9s8cx

Did something change upstream? 
> +                (modules '((guix build utils)))))
modules should only be needed if you have a snippet.

> +      (build-system cmake-build-system)
> +
> +      (inputs
> +       `(("gcc" ,gcc-9)))
Should probably be native-inputs.
> +      (synopsis "C++17 header only library for compile time
> reflection of enums")
> +      (description "C++17 header only library which offers static
> reflection
> +of enums, with to string, from string, and iteration, and related
> +functionality.")
> +      (license license:expat)))

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45604; Package guix-patches. (Wed, 20 Jan 2021 04:10:02 GMT) Full text and rfc822 format available.

Message #49 received at 45604 <at> debbugs.gnu.org (full text, mbox):

From: Anadon <joshua.r.marshall.1991 <at> gmail.com>
To: 45604 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at, Anadon <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH] gnu: Add magic-enum.
Date: Tue, 19 Jan 2021 23:09:24 -0500
* gnu/packages/cpp.scm (magic-enum): Added the package definition.
---
 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..012640171a 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic.  This implementation
 provides a number of utilities to make coding with expected cleaner.")
     (home-page "https://tl.tartanllama.xyz/")
     (license license:cc0)))
+
+(define-public magic-enum
+    (package
+      (name "magic-enum")
+      (version "0.7.2")
+      (home-page "https://github.com/Neargye/magic_enum")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit (string-append "v" version))))
+                (sha256
+                 (base32
+                  "07j5zdf3vkliwrcv6k663k35akn7qp23794sz2mnvkj9hbv9s8cx"))
+                (file-name (git-file-name name version))))
+      (build-system cmake-build-system)
+
+      (native-inputs
+       `(("gcc" ,gcc-9)))
+      (synopsis "C++17 header only library for compile time reflection of enums")
+      (description "C++17 header only library which offers static reflection
+of enums, with to string, from string, and iteration, and relate324    d
+functionality.")
+      (license license:expat)))
-- 
2.30.0





Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:01 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:01 GMT) Full text and rfc822 format available.

Message #54 received at 45604-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Anadon <joshua.r.marshall.1991 <at> gmail.com>, 45604-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add magic-enum.
Date: Wed, 20 Jan 2021 09:14:14 +0100
Pushed with some slight changes in the description.  Thanks!





Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:01 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:02 GMT) Full text and rfc822 format available.

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:03 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:03 GMT) Full text and rfc822 format available.

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 20 Jan 2021 08:15:03 GMT) Full text and rfc822 format available.

Notification sent to Anadon <joshua.r.marshall.1991 <at> gmail.com>:
bug acknowledged by developer. (Wed, 20 Jan 2021 08:15:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 17 Feb 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 39 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.