GNU bug report logs - #45606
[PATCH] Modify comint-read-input-ring to skip uninteresting text

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45606 in the body.
You can then email your comments to 45606 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Bug Gnu Emacs <bug-gnu-emacs <at> gnu.org>
Cc: mjbauer95 <at> gmail.com
Subject: [PATCH] Modify comint-read-input-ring to skip uninteresting text
Date: Sat, 2 Jan 2021 04:56:54 +0100 (CET)

[Message part 1 (text/plain, inline)]

I made the attached changes to handle zsh's history on Emacs' master branch.

This is a follow-up to Matthew Bauer's commit f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh's extended_history. Matthew, would you confirm that these patches are OK?

Thanks,
Brian

-- 
Sent with https://mailfence.com
Secure and private email

[0001-shell-mode-use-.zsh_history-as-a-history-file.patch (text/x-diff, attachment)]

[0002-comint-read-input-ring-Use-comint-buffer-s-ring-file.patch (text/x-diff, attachment)]

[0003-comint-read-input-ring-skip-over-the-comint-input-ri.patch (text/x-diff, attachment)]

[0004-comint-read-input-ring-Tidy.patch (text/x-diff, attachment)]

Message #8 received at 45606 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <leungbk <at> mailfence.com>
Cc: mjbauer95 <at> gmail.com, 45606 <at> debbugs.gnu.org
Subject: Re: bug#45606: [PATCH] Modify comint-read-input-ring to skip
 uninteresting text
Date: Mon, 11 Jan 2021 16:43:20 +0100

Brian Leung <leungbk <at> mailfence.com> writes:

> I made the attached changes to handle zsh's history on Emacs' master branch.
>
> This is a follow-up to Matthew Bauer's commit
> f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh's
> extended_history. Matthew, would you confirm that these patches are
> OK?

I'm not Matthew, but it looks OK to me (and didn't seem to break
anything when testing the patch), so I've pushed it to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 45606 <at> debbugs.gnu.org (full text, mbox):

From: Matthew Bauer <mjbauer95 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, 45606 <at> debbugs.gnu.org, 
 Brian Leung <leungbk <at> mailfence.com>
Subject: Re: bug#45606: [PATCH] Modify comint-read-input-ring to skip
 uninteresting text
Date: Mon, 11 Jan 2021 21:44:59 -0600

[Message part 1 (text/plain, inline)]

Sorry for the delay. Looks good to me too!

On Mon, Jan 11, 2021 at 9:43 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Brian Leung <leungbk <at> mailfence.com> writes:
>
> > I made the attached changes to handle zsh's history on Emacs' master
> branch.
> >
> > This is a follow-up to Matthew Bauer's commit
> > f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh's
> > extended_history. Matthew, would you confirm that these patches are
> > OK?
>
> I'm not Matthew, but it looks OK to me (and didn't seem to break
> anything when testing the patch), so I've pushed it to Emacs 28.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.