GNU bug report logs - #45638
gnu: Add nomacs photo lounge.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45638 in the body.
You can then email your comments to 45638 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: gnu: Add nomacs photo lounge.
Date: Sun, 3 Jan 2021 22:38:59 +0100

[Message part 1 (text/plain, inline)]

Hi,
I have added a package for the Nomacs Image viewer. It is built with
plugins but not with HEIF or PSD support. I tried creating a package for
the libqpsd package but was unable to get the qt plugin to appear in the
right location. It seems to build fine with `./pre-inst-env guix build
--rounds=2 nomacs` so hopefully its good enough for inclusion despite these
missing features.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-nomacs-photo-lounge.patch (text/x-patch, attachment)]

Message #8 received at 45638 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>
Cc: 45638 <at> debbugs.gnu.org
Subject: Re: gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 10:43:06 +0100

Hi Rovanion,

Am Sonntag, den 03.01.2021, 22:38 +0100 schrieb Rovanion Luckey:
> It is built with plugins but not with HEIF or PSD support. I tried 
> +    (synopsis "Image viewer for all common formats including RAW and
> PSD.")
Ehm, that's kinda false advertisement then 😉

> +    (inputs `(("plugins"    ,(origin (method git-fetch)
> +                                     (uri (git-reference
> +                                           (url "
> https://github.com/nomacs/nomacs-plugins")
> +                                           (commit "3.16")))
> +                                     (sha256 (base32
> "1cpdwhfvaxm970nwdc1hc13848a85pqqi176m9xpa3krla9qskml"))))
> +              ("exiv2"      ,exiv2)
> +              ("libraw"     ,libraw)
> +              ("libtiff"    ,libtiff)
> +              ("opencv"     ,opencv)
> +              ("python"     ,python-wrapper)
> +              ("quazip"     ,quazip)
> +              ("qtbase"     ,qtbase)
> +              ("qtsvg"      ,qtsvg)
> +              ("qtlinguist" ,qttools)))
Please use a new line after (inputs and don't try to line up the
columns.
You may want to use ,(version-major+minor version) for the plugins
commit, if it's known that the two will always be bumped together.  But
using "3.16" as you did is also fine.

> +    (description "Nomacs is a free, open source image viewer, which
> supports multiple platforms. You can use it for viewing all common
> image formats including RAW and psd images.
> +
> +Nomacs features semi-transparent widgets that display additional
> information such as thumbnails, metadata or histogram. It is able to
> browse images in zip or MS Office files which can be extracted to a
> directory. Metadata stored with the image can be displayed and you
> can add notes to images. A thumbnail preview of the current folder is
> included as well as a file explorer panel which allows switching
> between folders. Within a directory you can apply a file filter, so
> that only images are displayed whose filenames have a certain string
> or match a regular expression. Activating the cache allows for
> instantly switching between images.
> +
> +Nomacs includes image manipulation methods for adjusting brightness,
> contrast, saturation, hue, gamma, exposure. It has a pseudo color
> function which allows creating false color images. A unique feature
> of Nomacs is the synchronization of multiple instances. With this
> feature you can easily compare images by zooming and/or panning at
> the exactly same position or even by overlaying them with different
> opacity.
> +Nomacs is licensed under the GNU General Public License v3 and
> available for Windows, Linux, FreeBSD, Mac, and OS/2.")
fill-column is 78, also the description is still too long.  Try to
compact it a bit.

Otherwise LGTM.

Regards,
Leo

Message #11 received at 45638 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 45638 <at> debbugs.gnu.org
Subject: Re: gnu: Add nomacs photo lounge.
Date: Mon, 4 Jan 2021 12:47:47 +0100

[Message part 1 (text/plain, inline)]

Den mån 4 jan. 2021 kl 10:43 skrev Leo Prikler <
leo.prikler <at> student.tugraz.at>:

> Ehm, that's kinda false advertisement then 😉
>
 Advertisement modified in the attached patch.

Please use a new line after (inputs and don't try to line up the
> columns.
>
Ahw, but I like my aligned columns. Oh well, modified.


> You may want to use ,(version-major+minor version) for the plugins
> commit, if it's known that the two will always be bumped together.  But
> using "3.16" as you did is also fine.
>
The plugins get tagged very irregurarily.

fill-column is 78, also the description is still too long.  Try to
> compact it a bit.
>
Compacted.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-nomacs-photo-lounge.patch (text/x-patch, attachment)]

Message #14 received at 45638 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>
Cc: 45638 <at> debbugs.gnu.org
Subject: Re: gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 13:33:57 +0100

Hi Rovanion,
Am Montag, den 04.01.2021, 12:47 +0100 schrieb Rovanion Luckey:
> Den mån 4 jan. 2021 kl 10:43 skrev Leo Prikler <
> leo.prikler <at> student.tugraz.at>:
> > Ehm, that's kinda false advertisement then 😉
> 
>  Advertisement modified in the attached patch.
Thanks.  I've done a little rewording on top.

> > Please use a new line after (inputs and don't try to line up the
> > columns.
> 
> Ahw, but I like my aligned columns. Oh well, modified.
Sure, but aligning leads to much noise when adding inputs.
 
> > You may want to use ,(version-major+minor version) for the plugins
> > commit, if it's known that the two will always be bumped together. 
> > But
> > using "3.16" as you did is also fine.
> 
> The plugins get tagged very irregurarily.
Nvm then.

> > fill-column is 78, also the description is still too long.  Try to
> > compact it a bit.
> 
> Compacted.
Thanks.
I'm about to push that commit with some slight cosmetic changes, but
I've come to see, that #:tests? are #f.  Is there a reason for this?

Regards,
Leo

Message #17 received at 45638 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 45638 <at> debbugs.gnu.org
Subject: Re: gnu: Add nomacs photo lounge.
Date: Mon, 4 Jan 2021 13:55:23 +0100

[Message part 1 (text/plain, inline)]

>
> I'm about to push that commit with some slight cosmetic changes, but
> I've come to see, that #:tests? are #f.  Is there a reason for this?
>

Mistake left from when I redid the build a large number of times and didn't
want to sit through half an hour of tests each time. It should be set to
true before pushing (or the line removed).

[Message part 2 (text/html, inline)]

Message #22 received at 45638-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>
Cc: 45638-done <at> debbugs.gnu.org
Subject: Re: gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 15:10:32 +0100

Hi Rovanion,
Am Montag, den 04.01.2021, 13:55 +0100 schrieb Rovanion Luckey:
> > I'm about to push that commit with some slight cosmetic changes,
> > but
> > I've come to see, that #:tests? are #f.  Is there a reason for
> > this?
> 
> Mistake left from when I redid the build a large number of times and
> didn't want to sit through half an hour of tests each time. It should
> be set to true before pushing (or the line removed). 
It turns out, that there is no test target, so apparently you did the
right thing.
I've applied my cosmetic changes, fixed up the commit message and
pushed it as 08f35b9b6ca635f439bc2b01965aeb73e7ec282d.  Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.