GNU bug report logs -
#45645
Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
Previous Next
Reported by: luhux <luhux <at> outlook.com>
Date: Mon, 4 Jan 2021 02:08:02 UTC
Severity: normal
Done: Leo Prikler <leo.prikler <at> student.tugraz.at>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45645 in the body.
You can then email your comments to 45645 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-guix <at> gnu.org
:
bug#45645
; Package
guix
.
(Mon, 04 Jan 2021 02:08:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
luhux <luhux <at> outlook.com>
:
New bug report received and forwarded. Copy sent to
bug-guix <at> gnu.org
.
(Mon, 04 Jan 2021 02:08:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Sorry for submitting the wrong patch.
Recently, when I checked the sdcv source code, I found that this environment variable does not support multiple paths and is separated by colons.
```
const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
std::string data_dir;
if (!opt_data_dir) {
if (!only_data_dir) {
if (stardict_data_dir)
data_dir = stardict_data_dir;
else
data_dir = "/usr/share/stardict/dic";
}
} else {
data_dir = get_impl(opt_data_dir);
}
```
Please revoke the content of this commit.
luhux
Information forwarded
to
bug-guix <at> gnu.org
:
bug#45645
; Package
guix
.
(Mon, 04 Jan 2021 14:16:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 45645 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>
>
> Sorry for submitting the wrong patch.
>
> Recently, when I checked the sdcv source code, I found that this environment variable does not support multiple paths and is separated by colons.
>
>
> ```
> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
> std::string data_dir;
> if (!opt_data_dir) {
> if (!only_data_dir) {
> if (stardict_data_dir)
> data_dir = stardict_data_dir;
> else
> data_dir = "/usr/share/stardict/dic";
> }
> } else {
> data_dir = get_impl(opt_data_dir);
> }
>
> ```
>
> Please revoke the content of this commit.
>
> luhux
>
Do you have an easy test case? Something like 'guix environment --ad-hoc
sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
is it looking for, just one directory?
--
Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#45645
; Package
guix
.
(Fri, 26 Mar 2021 09:30:03 GMT)
Full text and
rfc822 format available.
Message #11 received at 45645 <at> debbugs.gnu.org (full text, mbox):
Hi,
On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>> ```
>> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>> std::string data_dir;
>> if (!opt_data_dir) {
>> if (!only_data_dir) {
>> if (stardict_data_dir)
>> data_dir = stardict_data_dir;
>> else
>> data_dir = "/usr/share/stardict/dic";
>> }
>> } else {
>> data_dir = get_impl(opt_data_dir);
>> }
>>
>> ```
>>
>> Please revoke the content of this commit.
I am not seeing a commit reverting
7dd1a2174a8376c521dcf271e3b76f64096074fe. Am I correct?
> Do you have an easy test case? Something like 'guix environment --ad-hoc
> sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> is it looking for, just one directory?
Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
proper fix or is it let as it is?
In order to close this. :-)
Cheers,
simon
Information forwarded
to
bug-guix <at> gnu.org
:
bug#45645
; Package
guix
.
(Mon, 29 Mar 2021 13:16:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 45645 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote:
> Hi,
>
> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>
> >> ```
> >> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
> >> std::string data_dir;
> >> if (!opt_data_dir) {
> >> if (!only_data_dir) {
> >> if (stardict_data_dir)
> >> data_dir = stardict_data_dir;
> >> else
> >> data_dir = "/usr/share/stardict/dic";
> >> }
> >> } else {
> >> data_dir = get_impl(opt_data_dir);
> >> }
> >>
> >> ```
> >>
> >> Please revoke the content of this commit.
>
> I am not seeing a commit reverting
> 7dd1a2174a8376c521dcf271e3b76f64096074fe. Am I correct?
That's right, I didn't end up reverting it.
> > Do you have an easy test case? Something like 'guix environment --ad-hoc
> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> > is it looking for, just one directory?
>
> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
> proper fix or is it let as it is?
>
> In order to close this. :-)
I suppose we could revert it for now. I don't know of any dictionaries
that it would currently use and according to the bug report it isn't
working as expected. I was hoping to get it working but moved on to
other things.
>
> Cheers,
> simon
Thanks for finding this forgotten bug. luhux, if you have any
suggestions I'd be happy to continue working on it.
--
Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#45645
; Package
guix
.
(Wed, 09 Jun 2021 21:55:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 45645 <at> debbugs.gnu.org (full text, mbox):
Hi,
On Mon, 29 Mar 2021 at 16:15, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote:
>> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim <at> flashner.co.il> wrote:
>> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>>
>> >> ```
>> >> const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>> >> std::string data_dir;
>> >> if (!opt_data_dir) {
>> >> if (!only_data_dir) {
>> >> if (stardict_data_dir)
>> >> data_dir = stardict_data_dir;
>> >> else
>> >> data_dir = "/usr/share/stardict/dic";
>> >> }
>> >> } else {
>> >> data_dir = get_impl(opt_data_dir);
>> >> }
>> >>
>> >> ```
>> >>
>> >> Please revoke the content of this commit.
>>
>> I am not seeing a commit reverting
>> 7dd1a2174a8376c521dcf271e3b76f64096074fe. Am I correct?
>
> That's right, I didn't end up reverting it.
>
>> > Do you have an easy test case? Something like 'guix environment --ad-hoc
>> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
>> > is it looking for, just one directory?
>>
>> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
>> proper fix or is it let as it is?
>>
>> In order to close this. :-)
>
> I suppose we could revert it for now. I don't know of any dictionaries
> that it would currently use and according to the bug report it isn't
> working as expected. I was hoping to get it working but moved on to
> other things.
The commit 7dd1a2174a8376c521dcf271e3b76f64096074fe is not reverted.
Let revert and close this bug report. Or add a comment in
gnu/packages/dictionaries.scm and close this bug report. :-)
Cheers,
simon
Reply sent
to
Leo Prikler <leo.prikler <at> student.tugraz.at>
:
You have taken responsibility.
(Thu, 10 Jun 2021 06:48:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
luhux <luhux <at> outlook.com>
:
bug acknowledged by developer.
(Thu, 10 Jun 2021 06:48:02 GMT)
Full text and
rfc822 format available.
Message #22 received at 45645-done <at> debbugs.gnu.org (full text, mbox):
Commit has successfully been revoked.
Thanks!
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 08 Jul 2021 11:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 263 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.