GNU bug report logs - #45714
[PATCH 0/1] Fix extension

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45714 in the body.
You can then email your comments to 45714 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Fix extension
Date: Thu,  7 Jan 2021 15:12:36 +0100

Dear,

Simple fix of bug#45709.  The 'search-patch' function returns #f which breaks
the pattern matching.  Another solution is 'let+if' instead of the 'match'.

http://issues.guix.gnu.org/issue/45709

All the best,
simon


zimoun (1):
  ui: Fix extensions.

 guix/ui.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


base-commit: 0d3f2716a8b8b64fc4126e1f3e987e05cb9f6bac
-- 
2.29.2

Message #8 received at 45714 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 45714 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 1/1] ui: Fix extensions.
Date: Thu,  7 Jan 2021 15:15:03 +0100

Fixes <http://bugs.gnu.org/45709>.

* guix/ui.scm: (run-guix-command): Fix.
---
 guix/ui.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 7f52518023..bd504c68da 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2019, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
-;;; Copyright © 2019 Simon Tournier <zimon.toutoune <at> gmail.com>
+;;; Copyright © 2019, 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2020 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;;
@@ -2133,11 +2133,11 @@ found."
           (lambda ()
             (match (search-path (extension-directories)
                                 (format #f "~a.scm" command))
+              (#f
+               (throw 'misc-error))
               (file
-               (load file)
-               (resolve-interface `(guix extensions ,command)))
-              (_
-               (throw 'misc-error))))
+                (load file)
+                (resolve-interface `(guix extensions ,command)))))
           (lambda _
             (format (current-error-port)
                     (G_ "guix: ~a: command not found~%") command)
-- 
2.29.2

Message #13 received at 45714-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 45714-done <at> debbugs.gnu.org
Subject: Re: [bug#45714] [PATCH 1/1] ui: Fix extensions.
Date: Thu, 07 Jan 2021 18:13:16 +0100

zimoun <zimon.toutoune <at> gmail.com> writes:

> Fixes <http://bugs.gnu.org/45709>.
>
> * guix/ui.scm: (run-guix-command): Fix.

Applied, thanks!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.