GNU bug report logs - #45720
28.0.50; fill-region-as-paragraph with long unbreakable lines

Message received at 45720 <at> debbugs.gnu.org:

Received: (at 45720) by debbugs.gnu.org; 7 Jun 2022 14:55:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 07 10:55:19 2022
Received: from localhost ([127.0.0.1]:41138 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nyabn-0001vq-VM
	for submit <at> debbugs.gnu.org; Tue, 07 Jun 2022 10:55:18 -0400
Received: from quimby.gnus.org ([95.216.78.240]:54816)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1nyabm-0001vH-8Z
 for 45720 <at> debbugs.gnu.org; Tue, 07 Jun 2022 10:55:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=DQ5ctzGiXuyZuI6TBPo38OVULr9RPykgkKvH6a+um+o=; b=gIopr/3KbYko8FFDHoi7hSgmhi
 ziqgmJ7vx4wFbtCpI66f5ZsguVzdiumqcWWsot7DLpsFSTJ3ou5Orjefe4ozJc2pz8Ok5LyKFySMz
 gd4Jc45xRNFfnGc169i4wkyD9S5V6f1AfauME4gmL3tInPRcQCT0FxC1ck4NyMJTkGEc=;
Received: from [84.212.220.105] (helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1nyabe-00048q-6a
 for 45720 <at> debbugs.gnu.org; Tue, 07 Jun 2022 16:54:56 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: 45720 <at> debbugs.gnu.org
Subject: Re: bug#45720: 28.0.50; fill-region-as-paragraph with long
 unbreakable lines
References: <87y232r0ee.fsf@HIDDEN>
X-Now-Playing: The Wake's _Harmony & Singles_: "Here Comes Everybody"
Date: Tue, 07 Jun 2022 16:54:53 +0200
In-Reply-To: <87y232r0ee.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Wed,
 26 Jan 2022 16:18:17 +0100")
Message-ID: <875ylcfrr6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Lars Ingebrigtsen <larsi@HIDDEN> writes: > reopen 45720
 > tags 45720 - fixed patch > quit This was reopened because of: 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 45720
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> reopen 45720
> tags 45720 - fixed patch
> quit

This was reopened because of:

commit c9524819eaf4e561a184b04dfca7e42970dc8809
Author:     Lars Ingebrigtsen <larsi@HIDDEN>
AuthorDate: Wed Jan 26 16:17:49 2022 +0100
Commit:     Lars Ingebrigtsen <larsi@HIDDEN>
CommitDate: Wed Jan 26 16:20:05 2022 +0100

    Partially revert a fill-region-as-paragraph regression
    
    * lisp/textmodes/fill.el (fill-region-as-paragraph): Revert
    e186af261 (bug#53537), because it leads to regressions.  (But
    leave tests in place.)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at 45720 <at> debbugs.gnu.org:

Received: (at 45720) by debbugs.gnu.org; 10 Jan 2021 14:07:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 10 09:07:01 2021
Received: from localhost ([127.0.0.1]:53494 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kybMz-0006Tw-7X
	for submit <at> debbugs.gnu.org; Sun, 10 Jan 2021 09:07:01 -0500
Received: from quimby.gnus.org ([95.216.78.240]:41366)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kybMx-0006TZ-9Z
 for 45720 <at> debbugs.gnu.org; Sun, 10 Jan 2021 09:06:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=9SXImkjduIrGQ1S8tBoxIlM6Z/mBN8jJ4SkMekNsw10=; b=aclyZm2ppi9IbtgyMHUSaNaYkn
 g2IiayGfBMuGm8qGfUmzsjmePBQx83rjTJdRxRuAKXrVAfz1cITf9cr7cGXDqtHd/BK5T5TyzFLU8
 Fh9B4f3XWAnlcZZCvy/1WuiKIRFH+Rr+2cr7y7SzwCQhJjOmSIGD87j0/GpNU8SdaVuI=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1kybMo-0007Y7-CC; Sun, 10 Jan 2021 15:06:52 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Roland Winkler" <winkler@HIDDEN>
Subject: Re: bug#45720: 28.0.50; fill-region-as-paragraph with long
 unbreakable lines
References: <40659.67204.506971.24567@HIDDEN>
X-Now-Playing: Joy Division's _Substance_: "Transmission"
Date: Sun, 10 Jan 2021 15:06:49 +0100
In-Reply-To: <40659.67204.506971.24567@HIDDEN> (Roland Winkler's
 message of "Thu, 7 Jan 2021 17:52:51 -0600")
Message-ID: <87eeisubra.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: "Roland Winkler" <winkler@HIDDEN> writes: > Then put point
 on letter `b' of the following line and run M-x foo > > aaa =
 baaaaaaaaaaaaaaaaaaaaaaaaaaaa
 > > This fills the line as > > aaa = > baaaaaaaaaaaaaaaaaaaaaaaaaaaa > >
 The line break int [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45720
Cc: 45720 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

"Roland Winkler" <winkler@HIDDEN> writes:

> Then put point on letter `b' of the following line and run M-x foo
>
> aaa =   baaaaaaaaaaaaaaaaaaaaaaaaaaaa
>
> This fills the line as
>
> aaa =
>         baaaaaaaaaaaaaaaaaaaaaaaaaaaa
>
> The line break introduced here does not make sense.  The line should
> be kept what it was.

Yup.  Looking at the code, this looked suspiciously easy to fix.
However, there's absolutely no tests for this stuff, so my confidence
that I didn't break anything here is pretty low.  I've added a couple
tests (based on your test case) and pushed it to the trunk, though.  Let
me know whether it works in your real cases or not:

> Command `foo' is really the essence of bibtex-fill-field-bounds in
> textmodes/bibtex.el that uses fill-region-as-paragraph to fill the
> fields of BibTeX entries.  If the field holds a URL, it may happen
> more easily that the value of the field is a string that goes beyond
> fill-column and that fill-region-as-paragraph cannot break into
> words.  I haven't tried to construct a yet more minimalistic version
> of this problem.

Or whether this breaks something else, and if it does, please do feel
free to add more tests to test/lisp/textmodes/fill-tests.el.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 7 Jan 2021 23:53:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 07 18:53:19 2021
Received: from localhost ([127.0.0.1]:48907 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kxf5i-0008Cd-VV
	for submit <at> debbugs.gnu.org; Thu, 07 Jan 2021 18:53:19 -0500
Received: from lists.gnu.org ([209.51.188.17]:52266)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <winkler@HIDDEN>) id 1kxf5f-0008CU-GS
 for submit <at> debbugs.gnu.org; Thu, 07 Jan 2021 18:53:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36564)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <winkler@HIDDEN>) id 1kxf5f-00051h-6y
 for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2021 18:53:15 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42077)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <winkler@HIDDEN>) id 1kxf5f-0002oX-0P
 for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2021 18:53:15 -0500
Received: from [2602:30a:2e52:d720:65b7:1416:12e7:8bfb] (port=36200
 helo=regnitz)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <winkler@HIDDEN>) id 1kxf5e-0005zu-LR
 for bug-gnu-emacs@HIDDEN; Thu, 07 Jan 2021 18:53:14 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <40659.67204.506971.24567@HIDDEN>
Date: Thu, 7 Jan 2021 17:52:51 -0600
From: "Roland Winkler" <winkler@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 28.0.50; fill-region-as-paragraph with long unbreakable lines
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


In emacs -Q evaluate

(defun foo (pos)
  (interactive "d")
  (let* ((beg (line-beginning-position))
         (end (line-end-position))
         (fill-prefix (make-string (- pos beg) ?\s))
         ;; `fill-column' is too small to accomodate the current line
         (fill-column (- end beg 10)))
    (fill-region-as-paragraph beg end nil nil pos)))

Then put point on letter `b' of the following line and run M-x foo

aaa =   baaaaaaaaaaaaaaaaaaaaaaaaaaaa

This fills the line as

aaa =
        baaaaaaaaaaaaaaaaaaaaaaaaaaaa

The line break introduced here does not make sense.  The line should
be kept what it was.

Command `foo' is really the essence of bibtex-fill-field-bounds in
textmodes/bibtex.el that uses fill-region-as-paragraph to fill the
fields of BibTeX entries.  If the field holds a URL, it may happen
more easily that the value of the field is a string that goes beyond
fill-column and that fill-region-as-paragraph cannot break into
words.  I haven't tried to construct a yet more minimalistic version
of this problem.



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9, cairo version 1.14.6)
 of 2021-01-03 built on regnitz
Repository revision: 20ad0cc03b73f6576ece195bb16878415c313d45
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: Ubuntu 16.04.7 LTS