GNU bug report logs - #45721
Telegram Desktop

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45721 in the body.
You can then email your comments to 45721 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Subject: Telegram Desktop
Date: Thu, 7 Jan 2021 19:20:04 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

This patch-series is for adding Telegram-Desktop application and its 
dependencies to Guix.

Regards,
RG.

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-libtgvoip-Add-support-for-pkg-config.patch (text/x-patch, attachment)]

[0014-gnu-libtgvoip-Remove-obsolete-patches.patch (text/x-patch, attachment)]

[0015-gnu-libtgvoip-Remove-obsolete-phase.patch (text/x-patch, attachment)]

[0016-gnu-libtgvoip-Bootstrap-the-source.patch (text/x-patch, attachment)]

[0017-gnu-libtgvoip-Disable-static-libraries.patch (text/x-patch, attachment)]

[0018-gnu-libtgvoip-Enable-audio-callback-feature.patch (text/x-patch, attachment)]

[0019-gnu-libtgvoip-Update-home-page.patch (text/x-patch, attachment)]

Message #8 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v2)
Date: Thu, 7 Jan 2021 19:44:20 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-libtgvoip-Add-support-for-pkg-config.patch (text/x-patch, attachment)]

[0014-gnu-libtgvoip-Remove-obsolete-patches.patch (text/x-patch, attachment)]

[0015-gnu-libtgvoip-Remove-obsolete-phase.patch (text/x-patch, attachment)]

[0016-gnu-libtgvoip-Bootstrap-the-source.patch (text/x-patch, attachment)]

[0017-gnu-libtgvoip-Disable-static-libraries.patch (text/x-patch, attachment)]

[0018-gnu-libtgvoip-Enable-audio-callback-feature.patch (text/x-patch, attachment)]

[0019-gnu-libtgvoip-Update-home-page.patch (text/x-patch, attachment)]

[0020-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #11 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v3)
Date: Mon, 11 Jan 2021 22:12:34 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-libtgvoip-Add-support-for-pkg-config.patch (text/x-patch, attachment)]

[0014-gnu-libtgvoip-Remove-obsolete-patches.patch (text/x-patch, attachment)]

[0015-gnu-libtgvoip-Remove-obsolete-phase.patch (text/x-patch, attachment)]

[0016-gnu-libtgvoip-Bootstrap-the-source.patch (text/x-patch, attachment)]

[0017-gnu-libtgvoip-Disable-static-libraries.patch (text/x-patch, attachment)]

[0018-gnu-libtgvoip-Enable-audio-callback-feature.patch (text/x-patch, attachment)]

[0019-gnu-libtgvoip-Update-home-page.patch (text/x-patch, attachment)]

[0020-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0021-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #14 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v4)
Date: Mon, 11 Jan 2021 22:27:23 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-libtgvoip-Add-support-for-pkg-config.patch (text/x-patch, attachment)]

[0014-gnu-libtgvoip-Remove-obsolete-patches.patch (text/x-patch, attachment)]

[0015-gnu-libtgvoip-Remove-obsolete-phase.patch (text/x-patch, attachment)]

[0016-gnu-libtgvoip-Bootstrap-the-source.patch (text/x-patch, attachment)]

[0017-gnu-libtgvoip-Disable-static-libraries.patch (text/x-patch, attachment)]

[0018-gnu-libtgvoip-Enable-audio-callback-feature.patch (text/x-patch, attachment)]

[0019-gnu-libtgvoip-Update-home-page.patch (text/x-patch, attachment)]

[0020-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0021-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #17 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v5)
Date: Wed, 13 Jan 2021 17:13:31 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0014-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #20 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v6)
Date: Thu, 14 Jan 2021 00:39:00 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-hime.patch (text/x-patch, attachment)]

[0005-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0006-gnu-hime-Enable-chewing-support.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0010-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0013-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0014-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #23 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v7)
Date: Thu, 14 Jan 2021 01:41:59 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0013-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #26 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v8)
Date: Thu, 14 Jan 2021 05:38:39 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0013-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

Message #29 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 11:08:26 -0500

[Message part 1 (text/plain, inline)]

[0015-gnu-Add-nextcloud-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0013-gnu-Add-tdesktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #32 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: [bug#45721] Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 18:15:59 +0100

There's nextcloud inside those telegram-desktop patches

Message #35 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 45721 <at> debbugs.gnu.org
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 19:04:35 +0100

Hi Raghav,

congratulations on getting a working Telegram Desktop.  I haven't yet
built this version on my own, but I want to comment on the patches a
little.

Am Freitag, den 15.01.2021, 11:08 -0500 schrieb Raghav Gururajan:
> * gnu/packages/cpp.scm (gsl): New variable.
> * gnu/packages/patches/gsl-gtest.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
LGTM, but there seem to be whitespace issues.  Any idea?

>  (define-module (gnu packages fcitx)
> -  #:use-module ((guix licenses) #:select (gpl2+))
> +  #:use-module (guix licenses)
Personal nitpick, but those should likely be prefixed with license:
To keep backwards-compatibility, you can (define gpl2+ license:gpl2+)
inside the module.

> * gnu/packages/language.scm (libchewing): New variable.
LGTM.

> +         (add-after 'unpack 'patch-std
> +           (lambda _
> +             (substitute* '("configure" "Makefile")
> +               (("17")
> +                "11"))
> +             #t))
Is there a less broad way of doing this?  E.g. replacing c++-17 by c++-
11?

> +        (git-reference
> +         (url "https://github.com/hamonikr/nimf.git")
> +         (commit
> +          (string-append "nimf-" version))))
FWIW there seems to also exist an older version over at
https://gitlab.com/nimf-i18n/nimf
Would it be worth packaging that?

> +    (synopsis "Korean input method framework")
> +    (description "Nimf is a lightweight, fast and extensible input
> method
> +framework.")
In my opinion the synopsis should be "Lightweight input method
framework" and the description should mention, that this specific fork
has a special focus on Korean.

> * gnu/packages/cmake.scm (cmake-shared): New variable.
LGTM, albeit admittedly weird.

> +    (synopsis "Material Decoration for Qt")
> +    (description "MaterialDecoration is the client-side decoration
> for Qt
> +applications on Wayland.")
It's not "the", just "a".  Usually such projects describe Material
Design in some way, but apparently it has come to a point where just
throwing around the word "Material" is enough.

> +    (description "Range-v3 is the range library for
> C++14/17/20.  This code was
> +the basis of a formal proposal to add range support to the C++
> standard library.")
I find the following more useful:
> [range-v3 is] an extension of the Standard Template Library that
> makes its iterators and algorithms more powerful by making them
> composable.  Unlike other range-like solutions which, seek to do away
> with iterators, in range-v3 ranges are an abstration layer on top of
> iterators.

> +    (license
> +     (list
> +      ;; Dual-Licensed
> +      license:expat
> +      license:ncsa))))
It appears, that this library carries a few more (free) licenses with
it.  Perhaps this needs to be revised?

> * gnu/packages/cpp.scm (rlottie): New variable.
LGTM.

> * gnu/packages/qt.scm (qt5ct): New variable.
LGTM.

> +(define-public tg_owt
> +  (package
> +    (name "tg_owt")
> +    (version "0.0.0")
Use a proper version.  Packages, that build directly from git without
any tagged versions usually have a preamble of 
  (let ((commit <hash>) 
        (revision <number))
    (package ...))

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/desktop-app/tg_owt.git")
> +         (commit "fa86fcc")
> +         (recursive? #t)))
Is there a way of making this checkout non-recursive?  I know you've
made that change in accordance to an upstream recommendation, but one
ought to look at it a little closer. 

> +    (inputs
> +     `(("abseil-cpp" ,abseil-cpp)
> +       ("alsa" ,alsa-lib)
> +       ("ffmpeg" ,ffmpeg)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libsrtp" ,libsrtp)
> +       ("libvpx" ,libvpx)
> +       ;; ("libyuv" ,libyuv)
> +       ("openh264" ,openh264)
> +       ("openssl" ,openssl)
> +       ("opus" ,opus)
> +       ("protobuf" ,protobuf)
> +       ("pulseaudio" ,pulseaudio)
> +       ("rnnoise" ,rnnoise)))
It seems that some of those inputs are also found as third_party/
libraries.  Can you remove their respective sources from the package?

> +    (synopsis "WebRTC build for Telegram")
> +    (description "TG_OWT is the packaged build of WebRTC, for its
> use in
> +Telegram-Desktop application.")
I really don't like that synopsis and description.  Granted, upstream
offers little to work with, but there ought to be a better way of
phrasing this.

By the way, it would appear we already have some WebRTC stuff packaged,
but no direct "webrtc" package (which I guess is normal, given that it
is a protocol and not an individual piece of software).  How tightly is
Telegram coupled to this specific implementation?  Would there be a way
of replacing it with something else (kinda like our udev/eudev
situation)?

> * gnu/packages/telegram.scm: New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/telegram.scm (tdesktop): New variable.
Would there be a way of moving this into another module, e.g. (gnu
packages messaging)?

Regards,
Leo

Message #38 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 45721 <at> debbugs.gnu.org
Subject: Re: [bug#45721] Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 16:22:34 -0500

Hi Nicolò!

> There's nextcloud inside those telegram-desktop patches

Oops! I must have attached it by mistake.

Regards,
RG.

Message #41 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: Telegram Desktop (v10)
Date: Sat, 16 Jan 2021 19:05:30 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #44 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 19:19:01 -0500

Hi Leo!

> congratulations on getting a working Telegram Desktop.  I haven't yet
> built this version on my own, but I want to comment on the patches a
> little.

Thanks! Couldn't have done without your help. :-)

> LGTM, but there seem to be whitespace issues.  Any idea?

Those are from the patch file taken from upstream. The pack-def is clean.

> Personal nitpick, but those should likely be prefixed with license:
> To keep backwards-compatibility, you can (define gpl2+ license:gpl2+)
> inside the module.

Hmm. I think we have to make changes to all pack-def in this module. As 
the licenses doesn't use prefix. Can be a separate task.

> LGTM.

Cool!

> Is there a less broad way of doing this?  E.g. replacing c++-17 by c++-
> 11?

Updated in v10.

> FWIW there seems to also exist an older version over at
> https://gitlab.com/nimf-i18n/nimf
> Would it be worth packaging that?

Hmm, not sure. I can package it later though.

> In my opinion the synopsis should be "Lightweight input method
> framework" and the description should mention, that this specific fork
> has a special focus on Korean.

Updated in v10.

> LGTM, albeit admittedly weird.

Haha, yeah.

> It's not "the", just "a".  Usually such projects describe Material
> Design in some way, but apparently it has come to a point where just
> throwing around the word "Material" is enough.

Updated in v10.

> I find the following more useful:
> [range-v3 is] an extension of the Standard Template Library that
> makes its iterators and algorithms more powerful by making them
> composable.  Unlike other range-like solutions which, seek to do away
> with iterators, in range-v3 ranges are an abstration layer on top of
> iterators.

Updated in v10.

> It appears, that this library carries a few more (free) licenses with
> it.  Perhaps this needs to be revised?

Updated in v10.

> LGTM.

Cool!

> LGTM.

Cool!

> Use a proper version.  Packages, that build directly from git without
> any tagged versions usually have a preamble of
>    (let ((commit <hash>)
>          (revision <number))
>      (package ...))

Updated in v10.

> Is there a way of making this checkout non-recursive?  I know you've
> made that change in accordance to an upstream recommendation, but one
> ought to look at it a little closer.

Not sure, but we need the sub-modules any way for build.

> It seems that some of those inputs are also found as third_party/
> libraries.  Can you remove their respective sources from the package?

Updated in v10.

> I really don't like that synopsis and description.  Granted, upstream
> offers little to work with, but there ought to be a better way of
> phrasing this.

Updated in v10.

> By the way, it would appear we already have some WebRTC stuff packaged,
> but no direct "webrtc" package (which I guess is normal, given that it
> is a protocol and not an individual piece of software).  How tightly is
> Telegram coupled to this specific implementation?  Would there be a way
> of replacing it with something else (kinda like our udev/eudev
> situation)?

Nah, telegram made a hard fork. There are some telegram-specific classes 
and objects.

> Would there be a way of moving this into another module, e.g. (gnu
> packages messaging)?

I first tried there, but the was circular dependency. So moved it to 
separate module. We can also move telegram-related stuff like tg_owt 
etc, to this module in the future.

Thank you so much for reviewing. :-)

Regards,
RG.

Message #47 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v11)
Date: Sat, 16 Jan 2021 19:29:58 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #50 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v9)
Date: Sun, 17 Jan 2021 01:36:37 +0100

Hi Raghav,

Am Samstag, den 16.01.2021, 19:19 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > congratulations on getting a working Telegram Desktop.  I haven't
> > yet
> > built this version on my own, but I want to comment on the patches
> > a
> > little.
> 
> Thanks! Couldn't have done without your help. :-)
> 
> > LGTM, but there seem to be whitespace issues.  Any idea?
> 
> Those are from the patch file taken from upstream. The pack-def is
> clean.
Nvm then.

> > Personal nitpick, but those should likely be prefixed with license:
> > To keep backwards-compatibility, you can (define gpl2+
> > license:gpl2+)
> > inside the module.
> 
> Hmm. I think we have to make changes to all pack-def in this module.
> As 
> the licenses doesn't use prefix. Can be a separate task.
Again, you can (define gpl2+ license:gpl2+) at the start of the module,
so that existing definitions can be kept the same, but your packages
adhere to the license: style.

> > LGTM.
> 
> Cool!
> 
> > Is there a less broad way of doing this?  E.g. replacing c++-17 by
> > c++-
> > 11?
> 
> Updated in v10.
Yes, okay.

> > In my opinion the synopsis should be "Lightweight input method
> > framework" and the description should mention, that this specific
> > fork
> > has a special focus on Korean.
> 
> Updated in v10.
Already discussed that one in IRC.

> > LGTM, albeit admittedly weird.
> 
> Haha, yeah.
> 
> > It's not "the", just "a".  Usually such projects describe Material
> > Design in some way, but apparently it has come to a point where
> > just
> > throwing around the word "Material" is enough.
> 
> Updated in v10.
Okay.

> > I find the following more useful:
> > [range-v3 is] an extension of the Standard Template Library that
> > makes its iterators and algorithms more powerful by making them
> > composable.  Unlike other range-like solutions which, seek to do
> > away
> > with iterators, in range-v3 ranges are an abstration layer on top
> > of
> > iterators.
> 
> Updated in v10.
Thanks.

> > It appears, that this library carries a few more (free) licenses
> > with
> > it.  Perhaps this needs to be revised?
> 
> Updated in v10.
Seems okay, I also saw you double-checking in IRC.

> > Use a proper version.  Packages, that build directly from git
> > without
> > any tagged versions usually have a preamble of
> >    (let ((commit <hash>)
> >          (revision <number))
> >      (package ...))
> 
> Updated in v10.
Use full commit hashes please.

> > Is there a way of making this checkout non-recursive?  I know
> > you've
> > made that change in accordance to an upstream recommendation, but
> > one
> > ought to look at it a little closer.
> 
> Not sure, but we need the sub-modules any way for build.
Perhaps, but it seems kinda weird, that this package gets special
treatment in how we accept anything else it might pull in.

> > It seems that some of those inputs are also found as third_party/
> > libraries.  Can you remove their respective sources from the
> > package?
> 
> Updated in v10.
I don't particularly agree with the way this has been solved in v10. 
Do we really need to keep around custom forks and old versions?  Can we
not instead patch tg_owt?

> > I really don't like that synopsis and description.  Granted,
> > upstream
> > offers little to work with, but there ought to be a better way of
> > phrasing this.
> 
> Updated in v10.
Yep, that sounds better.

> > By the way, it would appear we already have some WebRTC stuff
> > packaged,
> > but no direct "webrtc" package (which I guess is normal, given that
> > it
> > is a protocol and not an individual piece of software).  How
> > tightly is
> > Telegram coupled to this specific implementation?  Would there be a
> > way
> > of replacing it with something else (kinda like our udev/eudev
> > situation)?
> 
> Nah, telegram made a hard fork. There are some telegram-specific
> classes 
> and objects.
Fair enough.

> > Would there be a way of moving this into another module, e.g. (gnu
> > packages messaging)?
> 
> I first tried there, but the was circular dependency. So moved it to 
> separate module. We can also move telegram-related stuff like tg_owt 
> etc, to this module in the future.
That would make sense in my opinion.

Regards,
Leo

Message #53 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v12)
Date: Sat, 16 Jan 2021 20:04:42 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #56 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v9)
Date: Sat, 16 Jan 2021 20:10:09 -0500

Hi Leo!

> Again, you can (define gpl2+ license:gpl2+) at the start of the module,
> so that existing definitions can be kept the same, but your packages
> adhere to the license: style.

Updated in v12, as per discussed in IRC.

> Use full commit hashes please.

Updated in v12.

> Perhaps, but it seems kinda weird, that this package gets special
> treatment in how we accept anything else it might pull in.

There are existing packages in guix that uses recursive. But your 
concern is valid. May be we can update git-fetch in guix to have an 
option for fetching only specific/mentioned sub-modules.

> I don't particularly agree with the way this has been solved in v10.
> Do we really need to keep around custom forks and old versions?  Can we
> not instead patch tg_owt?

The situation is same as with tg_owt. They made custom changes in the 
fork. Like unique foo::bar.

Regards,
RG.

Message #59 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v13)
Date: Sat, 16 Jan 2021 20:52:24 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #62 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v13)
Date: Sun, 17 Jan 2021 13:13:07 +0100

Hi,

Am Samstag, den 16.01.2021, 20:52 -0500 schrieb Raghav Gururajan:
> * gnu/packages/fcitx.scm (fcitx-qt5): New variable.
LGTM.

> +      (version
> +       (git-version "1" revision commit))
You can still use "0" or "0.0.0" for the base version.

> +           (add-after 'unpack 'delete-thirdparty
> +             (lambda _
> +               (with-directory-excursion "src/third_party"
> +                 (for-each delete-file-recursively
> +                           ;; [1] Keep Abseil-CPP, LibSRTP, LibVPx,
> LibYuv,
> +                           ;; OpenH264, PFFFT, RnNoise and UsrSCTP.
> +                           ;; [2] Tg_owt uses custom fork of Abseil-
> CPP,
> +                           ;; LibSRTP, OpenH264 and RnNoise.
> +                           ;; [3] Tg_owt uses specific
> version/commit of LibVPx,
> +                           ;; which is different from one available
> in Guix.
> +                           ;; [4] LibYuv, PFFFT and UsrSCTP aren't
> available.
> +                           (list
> +                            "yasm")))
I forgot to mention this, but this should be a snippet, perhaps even a
computed origin.
Also, as it has been noted in your Nextcloud patch (IIRC), you should
formulate this in terms of what to keep.
E.g. 
  '(;; custom forks of existing packages
    ;; the forks are incompatible with what we have in Guix
    "abseil-cpp" "libsrtp" "openh264" "rnnoise" 
    ;; XXX: packages currently lacking a description
    "pffft" "usrsctp")

> +           (add-after 'delete-thirdparty 'copy-inputs
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +               (let* ((libvpx-from (assoc-ref inputs "libvpx"))
> +                      (libyuv-from (assoc-ref inputs "libyuv"))
> +                      (libvpx-to (string-append (getcwd)
> +                                                "/src/third_party/li
> bvpx/source/libvpx"))
> +                      (libyuv-to (string-append (getcwd)
> +                                                "/src/third_party/li
> byuv")))
> +                 (copy-recursively libvpx-from libvpx-to)
> +                 (copy-recursively libyuv-from libyuv-to))
> +               #t)))))
Should be after unpack (see above), otherwise LGTM.

> +         ("libvpx"
> +          ,(origin
> +             (method git-fetch)
> +             (uri
> +              (git-reference
> +               (url "https://chromium.googlesource.com/webm/libvpx")
> +               (commit "5b63f0f")))
> +             (file-name
> +              (git-file-name "libvpx" version))
> +             (sha256
> +              (base32
> "1psvxaddihlw1k5n0anxif3qli6zyw2sa2ywn6mkb8six9myrp68"))))
> +         ("libyuv"
> +          ,(origin
> +             (method git-fetch)
> +             (uri
> +              (git-reference
> +               (url "https://chromium.googlesource.com/libyuv/libyuv
> ")
> +               (commit "ad89006")))
> +             (file-name
> +              (git-file-name "libyuv" version))
> +             (sha256
> +              (base32
> "01knnk4h247rq536097n9n3s3brxlbby3nv3ppdgsqfda3k159ll"))))
Use long hashes.  Also, try to make things work with the nearest
release.  You might also want to package them individually as "libvpx-
for-telegram-desktop" etc. if everything else fails, see stepmania as
an example with a custom ffmpeg.

As per our discussion in IRC, this should be part of the telegram
module.

Regards,
Leo

Message #65 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Subject: Telegram Desktop (v14)
Date: Sun, 17 Jan 2021 09:43:16 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg_owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-GSL.patch (text/x-patch, attachment)]

Message #68 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v13)
Date: Sun, 17 Jan 2021 09:49:22 -0500

Hi Leo!

> You can still use "0" or "0.0.0" for the base version.
Updated in v14.

> I forgot to mention this, but this should be a snippet, perhaps even a
> computed origin.
> Also, as it has been noted in your Nextcloud patch (IIRC), you should
> formulate this in terms of what to keep.
> E.g.
>    '(;; custom forks of existing packages
>      ;; the forks are incompatible with what we have in Guix
>      "abseil-cpp" "libsrtp" "openh264" "rnnoise"
>      ;; XXX: packages currently lacking a description
>      "pffft" "usrsctp")

Updated in v14.

> Should be after unpack (see above), otherwise LGTM.

Updated in v14.

> Use long hashes.  Also, try to make things work with the nearest
> release.  You might also want to package them individually as "libvpx-
> for-telegram-desktop" etc. if everything else fails, see stepmania as
> an example with a custom ffmpeg.

Updated hashes in v14. Regarding individually packaging, its not worth 
the time for this project. The upstream is planning on re-work their 
tdesktop, libtgvoip, tgcalls and tg_owt. So there might be no tg_owt in 
near future.

> As per our discussion in IRC, this should be part of the telegram
> module.

Moved in v14.

Regards,
RG.

Message #71 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: [PATCH v15] Add Telegram Desktop.
Date: Sun, 17 Jan 2021 20:08:41 +0100

[Message part 1 (text/plain, inline)]

Hi Raghav and everyone else listening on this topic,

this was supposed to be a short set of mostly cosmetic changes before
pushing your patch, but alas, I discovered, that gsl actually conflicts
with an existing package.  I've verified, that Telegram still runs with
the changes I've made and I don't think I have anything else to add,
but someone else should look over these patches once again to make sure
that I didn't overlook anything.

Also there's the question as to whether Telegram Desktop actually runs
under QtWayland.  If someone would be willing to check, that'd be very
nice.

Regards,
Leo

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

Message #74 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: [PATCH v15] Add Telegram Desktop.
Date: Sun, 17 Jan 2021 16:59:15 -0500

Hi Leo!

> this was supposed to be a short set of mostly cosmetic changes before
> pushing your patch, but alas, I discovered, that gsl actually conflicts
> with an existing package.  I've verified, that Telegram still runs with
> the changes I've made and I don't think I have anything else to add,
> but someone else should look over these patches once again to make sure
> that I didn't overlook anything.

Thank you!

Regards,
RG.

Message #77 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: [PATCH v16] Add Telegram Desktop.
Date: Tue, 19 Jan 2021 11:11:55 +0100

[Message part 1 (text/plain, inline)]

Thanks to pineapples in IRC for figuring out what was missing for Emoji
support and verifying, that it launches in Wayland.  This will
hopefully be the last patch set for Telegram Desktop before it can be
upstreamed.

Regards,
Leo

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

Message #80 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v17)
Date: Wed, 20 Jan 2021 05:41:11 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #83 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v17)
Date: Wed, 20 Jan 2021 12:07:36 +0100

Hi Raghav,

Am Mittwoch, den 20.01.2021, 05:41 -0500 schrieb Raghav Gururajan:
> +       ;; Client applications must provide their own API-ID and API-
> HASH,
> +       ;; see also <https://core.telegram.org/api/obtaining_api_id>;
> .
> +       ;; In case, that the credentials below fail to work, contact
> +       ;;   Raghav Gururajan <rg <at> raghavgururajan.name>
> +       (list
> +        "-DTDESKTOP_API_ID=2791056"
> +        "-DTDESKTOP_API_HASH=582d6d0b44f7a2de949e99271fd8b3f2")
You're sadly missing the packaged font thing, that pineapples
mentioned.  Try this:
>        #:configure-flags
>        (list
>         ;; Client applications must provide their own API-ID and API-
> HASH,
>         ;; see also <https://core.telegram.org/api/obtaining_api_id>;
> .
>         ;; In case, that the credentials below fail to work, contact
>         ;;   Raghav Gururajan <rg <at> raghavgururajan.name>
>         "-DTDESKTOP_API_ID=2791056"
>         "-DTDESKTOP_API_HASH=582d6d0b44f7a2de949e99271fd8b3f2"
>         ;; Use bundled fonts as fallback.
>         "-DDESKTOP_APP_USE_PACKAGED_FONTS=OFF")

> +         (add-after 'unpack 'copy-inputs
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((to (string-append (getenv "TEMP") "/source"))
Should (getcwd) or "source" not suffice as to?

> +       ("lib_base"
> +        ,(origin
> +           (method git-fetch)
> +           (uri
> +            (git-reference
> +             (url "https://github.com/desktop-app/lib_base.git")
> +             (commit "81df0d0b7842be2b6c88f93dfa136b8efea4c9ad")))
> +           (file-name
> +            (git-file-name "lib_base" version))
> +           (sha256
> +            (base32
> "0ikddprjnjvg0ic8jr2886xq0f18syp587q6z2kci9xmdnvjl217"))))
> +       [...]
Use the naming-scheme "<package>-for-telegram-desktop" and similarly
(git-file-name "<package>-for-telegram-desktop" version).  Substitute
underlines with hyphens in the input and file names.
> +       ("libtgvoip" [...])
> +       ("rlottie" [...])
> +       ("tgcalls" [...])
Likewise.

Also strip the "Signed-Off-By" line from commits, that you've amended
since, so as to not inadvertently confuse anyone.  For this patch set,
that's just 0013.

Regards,
Leo

Message #86 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v18)
Date: Wed, 20 Jan 2021 07:29:55 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #89 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v17)
Date: Wed, 20 Jan 2021 07:32:04 -0500

Hi Leo!

> You're sadly missing the packaged font thing, that pineapples
> mentioned.  Try this:

Updated in v18.

> Should (getcwd) or "source" not suffice as to?

Nah! it didn't work.

> Use the naming-scheme "<package>-for-telegram-desktop" and similarly
> (git-file-name "<package>-for-telegram-desktop" version).  Substitute
> underlines with hyphens in the input and file names.
> [...]
> Likewise.

Updated in v18.

> Also strip the "Signed-Off-By" line from commits, that you've amended
> since, so as to not inadvertently confuse anyone.  For this patch set,
> that's just 0013.

Updated in v18.

Regards,
RG.

Message #92 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v19)
Date: Wed, 20 Jan 2021 08:49:09 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #95 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v20)
Date: Wed, 20 Jan 2021 09:42:46 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #98 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v20)
Date: Wed, 20 Jan 2021 16:10:02 +0100

Am Mittwoch, den 20.01.2021, 09:42 -0500 schrieb Raghav Gururajan:
> +             (let* ((to (getcwd))
> +                    (cmake-helpers (assoc-ref inputs "cmake-helpers-
> for-telegram-desktop"))
> +                    (codegen (assoc-ref inputs "codegen"))
> +                    (lib-base (assoc-ref inputs "lib-base-for-
> telegram-desktop"))
> +                    (lib-crl (assoc-ref inputs "lib-crl-for-
> telegram-desktop"))
> +                    (lib-lottie (assoc-ref inputs "lib-lottie-for-
> telegram-desktop"))
> +                    (lib-qr (assoc-ref inputs "lib-qr-for-telegram-
> desktop"))
> +                    (lib-rlottie (assoc-ref inputs "lib-rlottie-for-
> telegram-desktop"))
> +                    (lib-rpl (assoc-ref inputs "lib-rpl-for-
> telegram-desktop"))
> +                    (lib-spellcheck (assoc-ref inputs "lib-
> spellcheck-for-telegram-desktop"))
> +                    (lib-storage (assoc-ref inputs "lib-storage-for-
> telegram-desktop"))
> +                    (lib-tl (assoc-ref inputs "lib-tl-for-telegram-
> desktop"))
> +                    (lib-ui (assoc-ref inputs "lib-ui-for-telegram-
> desktop"))
> +                    (lib-webrtc (assoc-ref inputs "lib-webrtc-for-
> telegram-desktop"))
> +                    (libtgvoip (assoc-ref inputs "libtgvoip-for-
> telegram-desktop"))
> +                    (rlottie (assoc-ref inputs "rlottie-for-
> telegram-desktop"))
> +                    (tgcalls (assoc-ref inputs "tgcalls-for-
> telegram-desktop")))
> +               (copy-recursively
> +                cmake-helpers
> +                (string-append to "/cmake"))
> +               (copy-recursively
> +                codegen
> +                (string-append to "/Telegram/codegen"))
> +               (copy-recursively
> +                lib-base
> +                (string-append to "/Telegram/lib_base"))
> +               (copy-recursively
> +                lib-crl
> +                (string-append to "/Telegram/lib_crl"))
> +               (copy-recursively
> +                lib-lottie
> +                (string-append to "/Telegram/lib_lottie"))
> +               (copy-recursively
> +                lib-qr
> +                (string-append to "/Telegram/lib_qr"))
> +               (copy-recursively
> +                lib-rlottie
> +                (string-append to "/Telegram/lib_rlottie"))
> +               (copy-recursively
> +                lib-rpl
> +                (string-append to "/Telegram/lib_rpl"))
> +               (copy-recursively
> +                lib-spellcheck
> +                (string-append to "/Telegram/lib_spellcheck"))
> +               (copy-recursively
> +                lib-storage
> +                (string-append to "/Telegram/lib_storage"))
> +               (copy-recursively
> +                lib-tl
> +                (string-append to "/Telegram/lib_tl"))
> +               (copy-recursively
> +                lib-ui
> +                (string-append to "/Telegram/lib_ui"))
> +               (copy-recursively
> +                lib-webrtc
> +                (string-append to "/Telegram/lib_webrtc"))
> +               (copy-recursively
> +                libtgvoip
> +                (string-append to "/Telegram/ThirdParty/libtgvoip"))
> +               (copy-recursively
> +                rlottie
> +                (string-append to "/Telegram/ThirdParty/rlottie"))
> +               (copy-recursively
> +                tgcalls
> +                (string-append to "/Telegram/ThirdParty/tgcalls")))
You're catching up to where I am locally.
I'm writing the same as
  (for-each 
   (match-lambda 
     ((dst src) (copy-recursively src dst)))
   `(("cmake" ,(assoc-ref inputs "cmake-helpers"))
     ("Telegram/codegen" ,(assoc-ref inputs "codegen-source")
     [...]))
though in my current version I also make dst writable because I swapped
the phase ordering for some reason.

To that end, I've renamed the inputs accordingly ("<package>-source"),
while keeping the file names intact.  This might also serve as a
reminder to those unbundling them.

Regards,
Leo

Message #101 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v21)
Date: Wed, 20 Jan 2021 22:44:23 -0500

[Message part 1 (text/plain, inline)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #104 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: [PATCH v22] Add Telegram Desktop
Date: Thu, 21 Jan 2021 20:11:38 +0100

[Message part 1 (text/plain, inline)]

I cleaned up the copying code and also updated the hash (it was still
the one for the recursive checkout).  For some reason, telegram also
builds without libjpeg (do they have a local copy that I accidentally
enabled that way?)

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0013-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

Message #107 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: [PATCH v22] Add Telegram Desktop
Date: Thu, 21 Jan 2021 14:37:56 -0500

Hi Leo!

> I cleaned up the copying code and also updated the hash (it was still
> the one for the recursive checkout).  For some reason, telegram also
> builds without libjpeg (do they have a local copy that I accidentally
> enabled that way?)

Thanks! With out libjpeg as inputs, does it say 'libjpeg ... found' 
during configure phase?

Regards,
RG.

Message #110 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: [PATCH v22] Add Telegram Desktop
Date: Thu, 21 Jan 2021 20:44:16 +0100

Am Donnerstag, den 21.01.2021, 14:37 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > I cleaned up the copying code and also updated the hash (it was
> > still
> > the one for the recursive checkout).  For some reason, telegram
> > also
> > builds without libjpeg (do they have a local copy that I
> > accidentally
> > enabled that way?)
> 
> Thanks! With out libjpeg as inputs, does it say 'libjpeg ... found' 
> during configure phase?
Indeed it outputs
-- Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR) 
instead, but still succeeds.  Let's add it in regardless and try to
erase any existing copy in the sources.

Regards,
Leo

Message #113 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: [PATCH v22] Add Telegram Desktop
Date: Thu, 21 Jan 2021 14:46:26 -0500

Hi Leo!

> Indeed it outputs
> -- Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR)
> instead, but still succeeds.  Let's add it in regardless and try to
> erase any existing copy in the sources.

Yeah, if libjpeg is added as inputs, it uses it. If not, its either 
using bundled one (that we don't know of) or silently disabling some 
feature.

Regards,
RG.

Message #116 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v23)
Date: Thu, 21 Jan 2021 23:27:49 -0500

[Message part 1 (text/plain, inline)]

Phew!

[0015-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-tg-voip.patch (text/x-patch, attachment)]

[0013-gnu-Add-tg-rlottie.patch (text/x-patch, attachment)]

[0012-gnu-Add-tg-owt.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

Message #119 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v23)
Date: Fri, 22 Jan 2021 08:42:20 +0100

Hi,

Am Donnerstag, den 21.01.2021, 23:27 -0500 schrieb Raghav Gururajan:
> * gnu/packages/cpp.scm (rlottie): New variable.
I know I signed this off before, but this probably belongs in
animation.scm instead.

> +(define-public tg-rlottie
> +  (let ((commit "cbd43984ebdf783e94c8303c41385bf82aa36d5b")
> +        (revision "1"))
> +    (package
> +      (name "tg-rlottie")
> +      (version
> +       (git-version "0" revision commit))
Use the latest version previous to that commit as base.  If you can,
try to inherit from the rlottie package.
You should probably also call this "rlottie-for-telegram-desktop" in
just the variable name.

> +(define-public tg-voip
> +  (package
> +    (name "tg-voip")
> +    (version "2.4.4")
Use git-version, also call it "libtgvoip-for-telegram-desktop" as
above.
Both should also be hidden.  As an example for how to do this
"correctly", see ffmpeg-for-stepmania in video.scm

Regards,
Leo

Message #122 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v24)
Date: Wed, 27 Jan 2021 19:41:15 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-webrtc-for-telegram-desktop.patch (text/x-patch, attachment)]

[0013-gnu-Add-rlottie-for-telegram-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-libtgvoip-for-telegram-desktop.patch (text/x-patch, attachment)]

[0015-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

Message #125 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v23)
Date: Wed, 27 Jan 2021 19:41:56 -0500

Hi Leo!

> Am Donnerstag, den 21.01.2021, 23:27 -0500 schrieb Raghav Gururajan:
>> * gnu/packages/cpp.scm (rlottie): New variable.
> I know I signed this off before, but this probably belongs in
> animation.scm instead.
> 
>> +(define-public tg-rlottie
>> +  (let ((commit "cbd43984ebdf783e94c8303c41385bf82aa36d5b")
>> +        (revision "1"))
>> +    (package
>> +      (name "tg-rlottie")
>> +      (version
>> +       (git-version "0" revision commit))
> Use the latest version previous to that commit as base.  If you can,
> try to inherit from the rlottie package.
> You should probably also call this "rlottie-for-telegram-desktop" in
> just the variable name.
> 
>> +(define-public tg-voip
>> +  (package
>> +    (name "tg-voip")
>> +    (version "2.4.4")
> Use git-version, also call it "libtgvoip-for-telegram-desktop" as
> above.
> Both should also be hidden.  As an example for how to do this
> "correctly", see ffmpeg-for-stepmania in video.scm

I have made the changed in v24. :-)

Regards,
RG.

Message #128 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v24)
Date: Thu, 28 Jan 2021 08:47:19 +0100

Am Mittwoch, den 27.01.2021, 19:41 -0500 schrieb Raghav Gururajan:
> (git-version "0" revision commit)
What are the closest releases of those packages?  At which point where
they forked?

Regards,
Leo

Message #131 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v25)
Date: Sat, 30 Jan 2021 12:04:46 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-webrtc-for-telegram-desktop.patch (text/x-patch, attachment)]

[0013-gnu-Add-rlottie-for-telegram-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-libtgvoip-for-telegram-desktop.patch (text/x-patch, attachment)]

[0015-gnu-kwayland-Disable-failing-tests.patch (text/x-patch, attachment)]

[0016-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #134 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v26)
Date: Sat, 30 Jan 2021 13:02:50 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-webrtc-for-telegram-desktop.patch (text/x-patch, attachment)]

[0013-gnu-Add-rlottie-for-telegram-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-libtgvoip-for-telegram-desktop.patch (text/x-patch, attachment)]

[0015-gnu-kwayland-Disable-failing-tests.patch (text/x-patch, attachment)]

[0016-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #137 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v25)
Date: Sat, 30 Jan 2021 19:24:07 +0100

Am Samstag, den 30.01.2021, 12:46 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > > +  (let ((commit "cbd43984ebdf783e94c8303c41385bf82aa36d5b")
> > > +        (revision "12"))
> > > +    (hidden-package
> > > +     (package
> > > +       (inherit rlottie)
> > > +       (version
> > > +        (git-version "0.2" revision commit))
> > According to Github, Telegram's rlottie is 19 commits ahead and 193
> > commits behind Samsung's rlottie, whereas Samsung has had 34
> > commits to
> > master since the release of 0.2.  In other words, this should still
> > be
> > 0.1, and I'm not too sure about revision 12.
> 
> The desktop-app/rlottie forked samsung/rlottie at a commit
> corresponding 
> to v0.2. After forking, desktop-app/rlottie made 19 commits. The
> 12th 
> commit is what the package is what this package is building from.
> Hence 
> the revision number 12.
That timeline makes little sense.  The v0.2 release was on August 19th
2020, but the two libraries diverge on August 7th -- again according to
Github.  The files also indicate 0.1.

> > > +    (name "telegram-desktop")
> > > +    (version "2.5.8")
> > Any news w.r.t. tdesktop#10182 in this build?
> 
> Nope! :-(
> 
> But build fails w.r.t updated version of tg_owt. I'll have to send
> v26.
I don't think building static libraries is very guixy.  If 2.5.8 is no
significant improvement over 2.5.1 in that regard, let's stay with the
latter while we can still build shared libraries.

Regards,
Leo

Message #140 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Telegram Desktop (v27)
Date: Sat, 30 Jan 2021 14:02:32 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-c-gsl.patch (text/x-patch, attachment)]

[0002-gnu-Add-fcitx-qt5.patch (text/x-patch, attachment)]

[0003-gnu-libappindicator-Propagate-some-inputs-as-per-.pc.patch (text/x-patch, attachment)]

[0004-gnu-Add-libchewing.patch (text/x-patch, attachment)]

[0005-gnu-Add-hime.patch (text/x-patch, attachment)]

[0006-gnu-Add-nimf.patch (text/x-patch, attachment)]

[0007-gnu-Add-cmake-shared.patch (text/x-patch, attachment)]

[0008-gnu-Add-materialdecoration.patch (text/x-patch, attachment)]

[0009-gnu-Add-range-v3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rlottie.patch (text/x-patch, attachment)]

[0011-gnu-Add-qt5ct.patch (text/x-patch, attachment)]

[0012-gnu-Add-webrtc-for-telegram-desktop.patch (text/x-patch, attachment)]

[0013-gnu-Add-rlottie-for-telegram-desktop.patch (text/x-patch, attachment)]

[0014-gnu-Add-libtgvoip-for-telegram-desktop.patch (text/x-patch, attachment)]

[0015-gnu-Add-telegram-desktop.patch (text/x-patch, attachment)]

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #143 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v25)
Date: Sat, 30 Jan 2021 14:30:22 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>>>> +  (let ((commit "cbd43984ebdf783e94c8303c41385bf82aa36d5b")
>>>> +        (revision "12"))
>>>> +    (hidden-package
>>>> +     (package
>>>> +       (inherit rlottie)
>>>> +       (version
>>>> +        (git-version "0.2" revision commit))
>>> According to Github, Telegram's rlottie is 19 commits ahead and 193
>>> commits behind Samsung's rlottie, whereas Samsung has had 34
>>> commits to
>>> master since the release of 0.2.  In other words, this should still
>>> be
>>> 0.1, and I'm not too sure about revision 12.
>>
>> The desktop-app/rlottie forked samsung/rlottie at a commit
>> corresponding
>> to v0.2. After forking, desktop-app/rlottie made 19 commits. The
>> 12th
>> commit is what the package is what this package is building from.
>> Hence
>> the revision number 12.
> That timeline makes little sense.  The v0.2 release was on August 19th
> 2020, but the two libraries diverge on August 7th -- again according to
> Github.  The files also indicate 0.1.
> 
>>>> +    (name "telegram-desktop")
>>>> +    (version "2.5.8")
>>> Any news w.r.t. tdesktop#10182 in this build?
>>
>> Nope! :-(
>>
>> But build fails w.r.t updated version of tg_owt. I'll have to send
>> v26.
> I don't think building static libraries is very guixy.  If 2.5.8 is no
> significant improvement over 2.5.1 in that regard, let's stay with the
> latter while we can still build shared libraries.

Agreed. I have sent v27.

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #148 received at 45721-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721-done <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 09:37:13 +0100

Pushed with a small change – instead of using 0 for the rlottie base
version, it's 0.0.1 in line with upstream.

Thanks for your hard work!

Message #151 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 14:57:57 +0100

Hi Raghav,

thanks for your hard work on Telegram! I always avoided it as I know
from openSUSE packaging that it's quite a bunch for work...

`libchewing` has FAILs in the test suite when building with my standard
12 cores:
test-easy-symbol
test-fullshape

When building with `--cores=1` the test suite passes, maybe we should
set the build on parallel. It doesn't take much longer...

~Jonathan

Message #154 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Raghav Gururajan
 <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 15:10:13 +0100

Hi Jonathan,
Am Sonntag, den 31.01.2021, 14:57 +0100 schrieb Jonathan Brielmaier:
> Hi Raghav,
> 
> thanks for your hard work on Telegram! I always avoided it as I know
> from openSUSE packaging that it's quite a bunch for work...
> 
> `libchewing` has FAILs in the test suite when building with my
> standard
> 12 cores:
> test-easy-symbol
> test-fullshape
> 
> When building with `--cores=1` the test suite passes, maybe we should
> set the build on parallel. It doesn't take much longer...
> 
> ~Jonathan
If you're willing to write up a patch, I'd be happy to push that for
you.  It seems libchewing fails on CI as well.  Is that the same issue
you're experiencing or is it a different one?

Regards,
Leo

Message #157 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 17:50:00 +0100

[Message part 1 (text/plain, inline)]

On 31.01.21 15:10, Leo Prikler wrote:
> Hi Jonathan,
> Am Sonntag, den 31.01.2021, 14:57 +0100 schrieb Jonathan Brielmaier:
>> Hi Raghav,
>>
>> thanks for your hard work on Telegram! I always avoided it as I know
>> from openSUSE packaging that it's quite a bunch for work...
>>
>> `libchewing` has FAILs in the test suite when building with my
>> standard
>> 12 cores:
>> test-easy-symbol
>> test-fullshape
>>
>> When building with `--cores=1` the test suite passes, maybe we should
>> set the build on parallel. It doesn't take much longer...
>>
>> ~Jonathan
> If you're willing to write up a patch, I'd be happy to push that for
> you.  It seems libchewing fails on CI as well.  Is that the same issue
> you're experiencing or is it a different one?

On i686 and aarch64 are the same both tests mentioned above failing.

So I guess a `#:parallel-tests? #f` is the best solution here. Attached
is my patch, which I would push later if you have no objections...

[0001-gnu-libchewing-Disable-parallel-tests.patch (text/x-patch, attachment)]

Message #160 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, Raghav Gururajan
 <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 17:56:17 +0100

Am Sonntag, den 31.01.2021, 17:50 +0100 schrieb Jonathan Brielmaier:
> On 31.01.21 15:10, Leo Prikler wrote:
> > Hi Jonathan,
> > Am Sonntag, den 31.01.2021, 14:57 +0100 schrieb Jonathan
> > Brielmaier:
> > > Hi Raghav,
> > > 
> > > thanks for your hard work on Telegram! I always avoided it as I
> > > know
> > > from openSUSE packaging that it's quite a bunch for work...
> > > 
> > > `libchewing` has FAILs in the test suite when building with my
> > > standard
> > > 12 cores:
> > > test-easy-symbol
> > > test-fullshape
> > > 
> > > When building with `--cores=1` the test suite passes, maybe we
> > > should
> > > set the build on parallel. It doesn't take much longer...
> > > 
> > > ~Jonathan
> > If you're willing to write up a patch, I'd be happy to push that
> > for
> > you.  It seems libchewing fails on CI as well.  Is that the same
> > issue
> > you're experiencing or is it a different one?
> 
> On i686 and aarch64 are the same both tests mentioned above failing.
> 
> So I guess a `#:parallel-tests? #f` is the best solution here.
> Attached
> is my patch, which I would push later if you have no objections...
I'd personally pack the comment inside the list, otherwise LGTM.

Message #163 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Raghav Gururajan <rg <at> raghavgururajan.name>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 18:01:55 +0100

On 31.01.21 17:56, Leo Prikler wrote:
>> On i686 and aarch64 are the same both tests mentioned above failing.
>>
>> So I guess a `#:parallel-tests? #f` is the best solution here.
>> Attached
>> is my patch, which I would push later if you have no objections...
> I'd personally pack the comment inside the list, otherwise LGTM.
>

Hint accepted and pushed as 63c237d0448d92b3f0b0f9e9c337b2078a27a715.

Message #166 received at 45721-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721-done <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 14:11:24 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Pushed with a small change – instead of using 0 for the rlottie base
> version, it's 0.0.1 in line with upstream.

Thanks a lot.

> Thanks for your hard work!

:-)

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #169 received at 45721 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>, 45721 <at> debbugs.gnu.org
Subject: Re: Telegram Desktop (v27)
Date: Sun, 31 Jan 2021 14:14:52 -0500

[Message part 1 (text/plain, inline)]

Hi Jonathan!

>>> On i686 and aarch64 are the same both tests mentioned above failing.
>>>
>>> So I guess a `#:parallel-tests? #f` is the best solution here.
>>> Attached
>>> is my patch, which I would push later if you have no objections...
>> I'd personally pack the comment inside the list, otherwise LGTM.
>>
> 
> Hint accepted and pushed as 63c237d0448d92b3f0b0f9e9c337b2078a27a715.

Thanks for fixing it.

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.