GNU bug report logs - #45763
27.1; fido-mode does not work with icomplete-in-buffer completion

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: simon254@HIDDEN; Done: Juri Linkov <juri@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 28 Feb 2023 12:14:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 28 07:14:22 2023
Received: from localhost ([127.0.0.1]:49850 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pWysA-0003QF-HK
	for submit <at> debbugs.gnu.org; Tue, 28 Feb 2023 07:14:22 -0500
Received: from eggs.gnu.org ([209.51.188.92]:45530)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pWys9-0003Px-3z
 for 45763 <at> debbugs.gnu.org; Tue, 28 Feb 2023 07:14:21 -0500
Received: from fencepost.gnu.org ([209.51.188.10])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pWys2-0006Bo-OQ; Tue, 28 Feb 2023 07:14:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Qsf40hh/pmYMRe5txxSSHHcrnH76JS7KnDRpHyu3IXs=; b=O9fv0qUeJ9hr
 3nt0IyONnQK+OSdNGZowa5A7y2M3FV8M99hocxzH6lbdmGNDAC3PqHz0M/dBTfxGzeBpOWKtJFZ36
 K2h/MRg09124OxATmlOwxxt+rOfnLSN+TsUv3PDYlSbjv6LZGouWBQhUOg1pIRJQVjdWy/gZXhy8P
 nboa1OBSQ7EoXVPF7vE7ObyLKzmUEgky7lHZAkw3sxgIlu1L5DUh+VXi2897O/zhG6sgI6s5UfGFg
 5QXZ0Mytqcxx5a0Pd61macqluMlxGyGenzy7kcIU8JCQ5ejy3DV9sMHLBNG34EndbQI7BnFTu2qbF
 Us8lMLe/9kqtiX495PRW8w==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pWyrx-0004V6-O5; Tue, 28 Feb 2023 07:14:14 -0500
Date: Tue, 28 Feb 2023 14:14:19 +0200
Message-Id: <83h6v6gf6s.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86a60yp5o4.fsf@HIDDEN> (message from Juri Linkov on
 Tue, 28 Feb 2023 09:55:07 +0200)
Subject: Re: bug#45763: 27.1;
 fido-mode does not work with icomplete-in-buffer completion
References: <556652585.117858.1610281874781@HIDDEN>
 <87r1eswdp5.fsf@HIDDEN> <86mt4zar3h.fsf@HIDDEN>
 <CALDnm52KvfeqjjA41Zp3qUFQxRNLwk3k9H-gVP8VXdAtrACJ0g@HIDDEN>
 <86a60yp5o4.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, joaotavora@HIDDEN,
 monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
> From: Juri Linkov <juri@HIDDEN>
> Date: Tue, 28 Feb 2023 09:55:07 +0200
> 
> >> I fixed in-buffer completion in the commit a7a984c0ebe.
> >> Now your patch works nicely in fido-mode,
> >> so I pushed it was well, thanks.
> >
> > If this is effectively fixing things shouldn't it be in emacs-29?
> 
> I could backport to the emacs-29 branch if Eli agrees.

Please show the patch you want to install on emacs-29.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 28 Feb 2023 09:18:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 28 04:18:27 2023
Received: from localhost ([127.0.0.1]:49711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pWw7v-0006du-5p
	for submit <at> debbugs.gnu.org; Tue, 28 Feb 2023 04:18:27 -0500
Received: from mail-oa1-f42.google.com ([209.85.160.42]:43928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1pWw7t-0006dh-8j
 for 45763 <at> debbugs.gnu.org; Tue, 28 Feb 2023 04:18:25 -0500
Received: by mail-oa1-f42.google.com with SMTP id
 586e51a60fabf-172094e10e3so10220201fac.10
 for <45763 <at> debbugs.gnu.org>; Tue, 28 Feb 2023 01:18:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1677575899;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=tkbB0fuVXYzLgpklibDm7Ldg5lbfw1i0+9t5qemmOtU=;
 b=La3N/lbpnq4oxJpNodZnJVNqWlCCmdjUDQ33H5AXthWBkxRgSQ8P6m3uihprxvAsSj
 3KMvkoi/3MsFeM/EL65fxITxIk35F/N/I5tyVMN5S9WkIzfxZpoB4kKBCYORO//qWjfa
 eMy7aSgq/zSJTXeO38mRcQuYOGWHid/M+gAudaXoa7NDUojPp78KpDWhm2360Q473FoY
 OdGbdRsNzFtpzLRbje4q4Gjx+8flPczTSnpTqaYDWxNZetfTTzcfCiwiyM3AxLzvMstK
 1/Hgmz5Wv398XRFGfbl6TyjrGwFbq6ZBtL2tpQtf/Lfr2li5LzQQYkaaU8+wP97aKgwj
 e/kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1677575899;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=tkbB0fuVXYzLgpklibDm7Ldg5lbfw1i0+9t5qemmOtU=;
 b=sIaqAFH/wMkMYgTET8ZxgWxWl6wLHBoc7Da1kUTyyJISkFzCYruo/FlD1uteDZlBMu
 EJVFVUFfYpx0b+QLgDa2YKy+EHv0sVvPLTle/pEG4jSyxjJLSLN/GcPLpoDuMtJ3eGwq
 UW2PuQXT0+kIIWECG5EOn6I7BgpKAHHQ/tGiWm6we2UnSkUzVqzGFPjZgK7v6uq7LTbI
 q+mla9KlxDtIzFUiklOepHIaRqUidYx7hTZE3waaneeMcB9yEn/dqGyK8eN4dzvMUxfD
 2JhUUjPWU9ozssrqWpB/IekQhiiuSzHmexzXPrnzgOO1698Ty3zeJKXwk6/syHZ3zw3E
 QuMw==
X-Gm-Message-State: AO0yUKUeolwyE1Sc2fvMSACatVtk2T1+48TsHF2Wr7SOj7hHg3tIeQZY
 PfFFTJN5nv/MXVxx2zwLup3/6R4zcKH7c5lblTc=
X-Google-Smtp-Source: AK7set+R/uYgs+ihujC59KhruQ8wAWNXNc30ExOW/koiuecrUlFWqAQpDkow3le7dtxF+rZy2md+bQct7fy/8hutvdA=
X-Received: by 2002:a05:6870:c7a6:b0:171:8f59:3437 with SMTP id
 dy38-20020a056870c7a600b001718f593437mr520800oab.8.1677575899368; Tue, 28 Feb
 2023 01:18:19 -0800 (PST)
MIME-Version: 1.0
References: <556652585.117858.1610281874781@HIDDEN>
 <87r1eswdp5.fsf@HIDDEN> <86mt4zar3h.fsf@HIDDEN>
 <CALDnm52KvfeqjjA41Zp3qUFQxRNLwk3k9H-gVP8VXdAtrACJ0g@HIDDEN>
 <86a60yp5o4.fsf@HIDDEN>
In-Reply-To: <86a60yp5o4.fsf@HIDDEN>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Tue, 28 Feb 2023 09:18:08 +0000
Message-ID: <CALDnm51kuf2iUBne_iG15Do=iTjsLz8AwDhFvYh7=R3srbDytg@HIDDEN>
Subject: Re: bug#45763: 27.1;
 fido-mode does not work with icomplete-in-buffer completion
To: Juri Linkov <juri@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000090d36305f5bf13be"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN,
 Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000090d36305f5bf13be
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I just realized the patch shown in this bug is my own, and there's no
notice of what was done to fix this bug. Did you push my patch? Or
something else?

When I wrote it, it didn't work, according to the message.

Jo=C3=A3o

On Tue, Feb 28, 2023, 08:16 Juri Linkov <juri@HIDDEN> wrote:

> >> I fixed in-buffer completion in the commit a7a984c0ebe.
> >> Now your patch works nicely in fido-mode,
> >> so I pushed it was well, thanks.
> >
> > If this is effectively fixing things shouldn't it be in emacs-29?
>
> I could backport to the emacs-29 branch if Eli agrees.
>

--00000000000090d36305f5bf13be
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">I just realized the patch shown in this bug is my own, an=
d there&#39;s no notice of what was done to fix this bug. Did you push my p=
atch? Or something else?<div dir=3D"auto"><br></div><div dir=3D"auto">When =
I wrote it, it didn&#39;t work, according to the message.</div><div dir=3D"=
auto"><br></div><div dir=3D"auto">Jo=C3=A3o</div></div><br><div class=3D"gm=
ail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Feb 28, 2023, 08:1=
6 Juri Linkov &lt;<a href=3D"mailto:juri@HIDDEN">juri@HIDDEN</a>&gt=
; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex">&gt;&gt; I fixed in-buffer=
 completion in the commit a7a984c0ebe.<br>
&gt;&gt; Now your patch works nicely in fido-mode,<br>
&gt;&gt; so I pushed it was well, thanks.<br>
&gt;<br>
&gt; If this is effectively fixing things shouldn&#39;t it be in emacs-29?<=
br>
<br>
I could backport to the emacs-29 branch if Eli agrees.<br>
</blockquote></div>

--00000000000090d36305f5bf13be--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 28 Feb 2023 08:16:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 28 03:16:36 2023
Received: from localhost ([127.0.0.1]:49584 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pWvA3-0004vB-PP
	for submit <at> debbugs.gnu.org; Tue, 28 Feb 2023 03:16:35 -0500
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42489)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pWvA1-0004ux-V4
 for 45763 <at> debbugs.gnu.org; Tue, 28 Feb 2023 03:16:34 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id AF2A84000F;
 Tue, 28 Feb 2023 08:16:24 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= <joaotavora@HIDDEN>
Subject: Re: bug#45763: 27.1; fido-mode does not work with
 icomplete-in-buffer completion
In-Reply-To: <CALDnm52KvfeqjjA41Zp3qUFQxRNLwk3k9H-gVP8VXdAtrACJ0g@HIDDEN>
 (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora=22's?= message of "Tue, 28 Feb 2023
 00:13:42 +0000")
Organization: LINKOV.NET
References: <556652585.117858.1610281874781@HIDDEN>
 <87r1eswdp5.fsf@HIDDEN> <86mt4zar3h.fsf@HIDDEN>
 <CALDnm52KvfeqjjA41Zp3qUFQxRNLwk3k9H-gVP8VXdAtrACJ0g@HIDDEN>
Date: Tue, 28 Feb 2023 09:55:07 +0200
Message-ID: <86a60yp5o4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> I fixed in-buffer completion in the commit a7a984c0ebe.
>> Now your patch works nicely in fido-mode,
>> so I pushed it was well, thanks.
>
> If this is effectively fixing things shouldn't it be in emacs-29?

I could backport to the emacs-29 branch if Eli agrees.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 28 Feb 2023 00:12:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 27 19:12:07 2023
Received: from localhost ([127.0.0.1]:49251 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pWnbD-0005Su-63
	for submit <at> debbugs.gnu.org; Mon, 27 Feb 2023 19:12:07 -0500
Received: from mail-oi1-f176.google.com ([209.85.167.176]:39696)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1pWnb9-0005SE-KJ
 for 45763 <at> debbugs.gnu.org; Mon, 27 Feb 2023 19:12:05 -0500
Received: by mail-oi1-f176.google.com with SMTP id bj30so930343oib.6
 for <45763 <at> debbugs.gnu.org>; Mon, 27 Feb 2023 16:12:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1677543118;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=jpXUZK5yxs3hdUt+Y2cT51vok5NIIGWWdYxCmP0slpo=;
 b=T6QTkcia6EOmnUbWCjud9vPYOmid+nDgEGYULaEyF7S2k0t+79+S2ETGmaS97uJ0Xw
 pY8y6G+L1ORQc0N9pP0B6ldD4TWPo4Ye7KWcOP0T6owK51YPD4hfkeYlRXpu0iZoWYWG
 kwZMgSv+s78vEYd6fggouHx26srZ9TLFtKgCgrphOYsbPCiGl4TlNbxbP4NvKL9S2U1Y
 vqWGzYnb4BV12BhIOfFavHNZjGiPmV1ClElCCHquICwQR5KjQTlycH92PHxAmvx/K4iz
 cpFBpfv1H6HjyIyEyqXSiKwieCV3kpSxQSnKJqiYrrPaqrnCPXs/c/7YD1o4KTCBgu0z
 2a+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1677543118;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=jpXUZK5yxs3hdUt+Y2cT51vok5NIIGWWdYxCmP0slpo=;
 b=1vnK8VxdjGGGJFRVGnX/Frzd0Y9ROyDaqPyU/V1lmMUjlHYa3Ii5CkmJDs+5dzBS9A
 7x91fmFRRBiPRky+Ji876KgOMYTYqxrNfjDalJRoQRSS/X6NwD9VqSOhKyhCfiZYYGh/
 seY/HS90tzGS+RgwLp051gsrSn5UaM6v/uqvs2mweWS3ReeRYPmGxN2bfF8jpGgXVMmU
 sfAbKcNxvyYgReKkA5osQf3/ma0WCjqWmG4sYx8SADVBsq6I0+Kb9Kc323Yq9XQBBOT9
 KkyT5H8OIDSNoX3/ZrMEGL9A3EaqyYqWJDCoaKZO5ciay61lSWvakOTuX6wz9iXBvOsI
 aIpg==
X-Gm-Message-State: AO0yUKW8SS62tsbOMugb1oZmZ6ke/OA7GeGHs7gSZubl43WKilRXuNXP
 4loLWOJD0GqfMrdq8GNWQMw6yxdFFWM66yqkYbA=
X-Google-Smtp-Source: AK7set+9nP+gToPuDcXbHN5mw34p6nMKGmCMfDpCGpbJsBu41CqPDDjIH3yEqnvwMOSTi4EXNrbbDzYt1axynIKjtR4=
X-Received: by 2002:a05:6808:646:b0:37f:a3b7:c877 with SMTP id
 z6-20020a056808064600b0037fa3b7c877mr322628oih.8.1677543117858; Mon, 27 Feb
 2023 16:11:57 -0800 (PST)
MIME-Version: 1.0
References: <556652585.117858.1610281874781@HIDDEN>
 <87r1eswdp5.fsf@HIDDEN> <86mt4zar3h.fsf@HIDDEN>
In-Reply-To: <86mt4zar3h.fsf@HIDDEN>
From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Date: Tue, 28 Feb 2023 00:13:42 +0000
Message-ID: <CALDnm52KvfeqjjA41Zp3qUFQxRNLwk3k9H-gVP8VXdAtrACJ0g@HIDDEN>
Subject: Re: bug#45763: 27.1;
 fido-mode does not work with icomplete-in-buffer completion
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> I fixed in-buffer completion in the commit a7a984c0ebe.
> Now your patch works nicely in fido-mode,
> so I pushed it was well, thanks.

If this is effectively fixing things shouldn't it be in emacs-29?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.
bug marked as fixed in version 30.0.50, send any further explanations to 45763 <at> debbugs.gnu.org and simon254@HIDDEN Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 27 Feb 2023 18:42:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 27 13:42:12 2023
Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pWiRv-0000Qy-Mf
	for submit <at> debbugs.gnu.org; Mon, 27 Feb 2023 13:42:11 -0500
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:37293)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1pWiRt-0000Qe-PO; Mon, 27 Feb 2023 13:42:10 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id F1E194000F;
 Mon, 27 Feb 2023 18:42:00 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= <joaotavora@HIDDEN>
Subject: Re: bug#45763: 27.1; fido-mode does not work with
 icomplete-in-buffer completion
In-Reply-To: <87r1eswdp5.fsf@HIDDEN> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?=
 =?iso-8859-1?Q?=22's?= message of "Tue, 17
 Aug 2021 11:47:02 +0100")
Organization: LINKOV.NET
References: <556652585.117858.1610281874781@HIDDEN>
 <87r1eswdp5.fsf@HIDDEN>
Date: Mon, 27 Feb 2023 20:41:22 +0200
Message-ID: <86mt4zar3h.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 45763 30.0.50
thanks

>> (setq icomplete-in-buffer t)
>> (fido-mode t)
>> type:
>> "(icompl" followed by C-M-i (completion-at-point) 
>> -> default completion is invoked, not fido-mode
>
> It's true, it doesn't.  And either does icomplete-mode.  It's completely
> broken.  Even if I do this to fido-mode, it's still broken, quite
> broken, I don't know how to fix it.
>
> But I would like to fix it, maybe by letting the choice still happen
> from the minibuffer while.  Let's keep this bug open to track this
> development.

I fixed in-buffer completion in the commit a7a984c0ebe.
Now your patch works nicely in fido-mode,
so I pushed it was well, thanks.

> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index e06b33e43b..89ace7e434 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -411,9 +411,12 @@ fido-mode
>    :global t :group 'icomplete
>    (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
>    (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)
> +  (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup)
>    (when fido-mode
>      (icomplete-mode -1)
>      (setq icomplete-mode t)
> +    (when icomplete-in-buffer
> +      (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup))
>      (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
>      (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at 45763 <at> debbugs.gnu.org:


Received: (at 45763) by debbugs.gnu.org; 17 Aug 2021 10:47:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 17 06:47:14 2021
Received: from localhost ([127.0.0.1]:51936 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mFwck-0006pj-0f
	for submit <at> debbugs.gnu.org; Tue, 17 Aug 2021 06:47:14 -0400
Received: from mail-wr1-f47.google.com ([209.85.221.47]:46646)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1mFwcg-0006if-1G
 for 45763 <at> debbugs.gnu.org; Tue, 17 Aug 2021 06:47:12 -0400
Received: by mail-wr1-f47.google.com with SMTP id f5so27846109wrm.13
 for <45763 <at> debbugs.gnu.org>; Tue, 17 Aug 2021 03:47:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=;
 b=poc5DsfJ28A49BnYD6c2sr4eLHwwOmOPKFDq3CHBMkfUi8PhWzGAZxcMjIpA2853o3
 c8arBu6oWsp0SzoGrWBjMZhoyrOmPhnuMni6pWBSajY4oWCwHUrSGgMynNDgXIYDHeRE
 QRhBGh7esBC+GI2TYDJMmi+UBQJe8Rhg7zMyGxjbMBGgbuoZnZZPBZQ3oxCPLtYtv+zw
 WSlbWI4n0jKv6QSJDorcQedmXrYxOOOkbJjmKQbBkpqddFt4hTarIiwsCVbsaJoLd/uM
 gQJ/GKneBB42Q2L0OJYPXcO9z2W8B9p3D93lHeyrm+aPCCv/o3A2CMx0NuaUJ4K6yYHl
 fEvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=;
 b=X7Fb/5OCtFv6FZ1dwAggDIrSGPFty7te8Y+OgldZt8iwpNe5/YIfgmoCgyWIlT0jUp
 UO1pTNZTY6TKSy3eZSpEAsJEWU+jDEdF5VUItC4yFXtlMC5OjgB+WoxuDDi7v+jU7Ika
 qtIqMj1HGaL2ni/RNfwLqJXKOIH0hiLr8u+PtJlbeMO6Ej6+hZQFgRfF1BuMhHSa4gVa
 dmJRA1jJ28DJt2XITX4nuMUjCCWQ43rhIYc9PL385cQeQVAi0ecQHHzvzpZU1RpSZEhA
 ARaKzvAn7Zmn0kAEjGRhTiWJazQ8xfphbaPlUzR7UbH+S+1P9P1RlzaEDmcdgtFpHU/W
 8ORA==
X-Gm-Message-State: AOAM5325t8UBmdEBW8hW6OgaXXRpZBUFfSchcq5i8FRfV01DLWaW/Jcw
 VupNDyvex8e8u0Czbx67Gl4=
X-Google-Smtp-Source: ABdhPJwvWqzh5Z4zIqcQsD2nPZd1SFV/bsGxsFyRgQI0CcMBFXId3Pm6Rt3M6ztehMNmDmmGgKWqGg==
X-Received: by 2002:a5d:6e0c:: with SMTP id h12mr3278044wrz.334.1629197224068; 
 Tue, 17 Aug 2021 03:47:04 -0700 (PDT)
Received: from krug (a94-133-27-132.cpe.netcabo.pt. [94.133.27.132])
 by smtp.gmail.com with ESMTPSA id r4sm1655027wmq.34.2021.08.17.03.47.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 17 Aug 2021 03:47:03 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text
 editors" <bug-gnu-emacs@HIDDEN>
Subject: Re: bug#45763: 27.1; fido-mode does not work with
 icomplete-in-buffer completion
References: <556652585.117858.1610281874781@HIDDEN>
Date: Tue, 17 Aug 2021 11:47:02 +0100
In-Reply-To: <556652585.117858.1610281874781@HIDDEN> (simon's
 message of "Sun, 10 Jan 2021 12:31:14 +0000 (GMT)")
Message-ID: <87r1eswdp5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 45763
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@HIDDEN> writes:

> in *sratch* evaluate
> (setq icomplete-in-buffer t)
> (fido-mode t)
> type:
> "(icompl" followed by C-M-i (completion-at-point)=20
> -> default completion is invoked, not fido-mode

It's true, it doesn't.  And either does icomplete-mode.  It's completely
broken.  Even if I do this to fido-mode, it's still broken, quite
broken, I don't know how to fix it.

But I would like to fix it, maybe by letting the choice still happen
from the minibuffer while.  Let's keep this bug open to track this
development.

Jo=C3=A3o

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index e06b33e43b..89ace7e434 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -411,9 +411,12 @@ fido-mode
   :global t :group 'icomplete
   (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
   (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)
+  (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setu=
p)
   (when fido-mode
     (icomplete-mode -1)
     (setq icomplete-mode t)
+    (when icomplete-in-buffer
+      (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-set=
up))
     (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
     (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)))
=20





>
> same happens for shell completion:
>
> M-x shell
> ls xxx followed by tab -> default completion is invoked, not fido-mode
>
> In GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 =
Version 10.14.6 (Build 18G95))
> of 2020-08-12 built on builder10-14.porkrind.org
> Windowing system distributor 'Apple', version 10.3.1894
> System Description:  Mac OS X 10.15.7
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> Configured using:
> 'configure --with-ns '--enable-locallisppath=3D/Library/Application
> Support/Emacs/${version}/site-lisp:/Library/Application
> Support/Emacs/site-lisp' --with-modules'
>
> Configured features:
> NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
> THREADS JSON PDUMPER
>
> Important settings:
>   value of $LANG: en_GB.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
> format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
> epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
> subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
> cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
> tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
> mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
> tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
> newcomment text-mode elisp-mode lisp-mode prog-mode register page
> tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
> jit-lock font-lock syntax facemenu font-core term/tty-colors frame
> minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
> tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
> romanian slovak czech european ethiopic indian cyrillic chinese
> composite charscript charprop case-table epa-hook jka-cmpr-hook help
> simple abbrev obarray cl-preloaded nadvice loaddefs button faces
> cus-face macroexp files text-properties overlay sha1 md5 base64 format
> env code-pages mule custom widget hashtable-print-readable backquote
> threads kqueue cocoa ns multi-tty make-network-process emacs)
>
> Memory information:
> ((conses 16 44811 6704)
> (symbols 48 5927 1)
> (strings 32 15254 1703)
> (string-bytes 1 504784)
> (vectors 16 10174)
> (vector-slots 8 126879 9518)
> (floats 8 19 39)
> (intervals 56 189 0)
> (buffers 1000 11))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 Aug 2021 10:47:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 17 06:47:18 2021
Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mFwcn-0006sp-Jt
	for submit <at> debbugs.gnu.org; Tue, 17 Aug 2021 06:47:18 -0400
Received: from lists.gnu.org ([209.51.188.17]:55498)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1mFwch-0006nl-NL
 for submit <at> debbugs.gnu.org; Tue, 17 Aug 2021 06:47:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59114)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joaotavora@HIDDEN>)
 id 1mFwcf-00030S-C9
 for bug-gnu-emacs@HIDDEN; Tue, 17 Aug 2021 06:47:11 -0400
Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:34453)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <joaotavora@HIDDEN>)
 id 1mFwcc-0000Rs-4R
 for bug-gnu-emacs@HIDDEN; Tue, 17 Aug 2021 06:47:09 -0400
Received: by mail-wr1-x434.google.com with SMTP id h13so27964089wrp.1
 for <bug-gnu-emacs@HIDDEN>; Tue, 17 Aug 2021 03:47:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=;
 b=poc5DsfJ28A49BnYD6c2sr4eLHwwOmOPKFDq3CHBMkfUi8PhWzGAZxcMjIpA2853o3
 c8arBu6oWsp0SzoGrWBjMZhoyrOmPhnuMni6pWBSajY4oWCwHUrSGgMynNDgXIYDHeRE
 QRhBGh7esBC+GI2TYDJMmi+UBQJe8Rhg7zMyGxjbMBGgbuoZnZZPBZQ3oxCPLtYtv+zw
 WSlbWI4n0jKv6QSJDorcQedmXrYxOOOkbJjmKQbBkpqddFt4hTarIiwsCVbsaJoLd/uM
 gQJ/GKneBB42Q2L0OJYPXcO9z2W8B9p3D93lHeyrm+aPCCv/o3A2CMx0NuaUJ4K6yYHl
 fEvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=;
 b=T4DlRAAJZl89geUPs3cKQqwkUqXYCuIRAQklNHKIuvGhIx19jWI4cyTUf/sEQQ0wF8
 0kVM3lbeQtPsXrx8kY2WEu7e3zIiFBjxO4Db6/dlKJ5mJuTEwWnB0BWA/JvfYEC1Lmt0
 rsLDb2hkgtS6xKad4k7plxJ8AO+YymYgge17N3wk3eRo6lHq3WOZUCk4DU39bLVoM9pw
 a8DNl8l4/sarF2f0gkHp3Vh7UJwbCrE+L5JWi1AUPMQYvX9MNqqz3sCmntiIZuaZdrem
 TkSIMBQhmo+26CaK95KoPbYYD5oCcHC7tDbCUY2HyHotzrMEIYAvQI+rGhxa4QHlxzUX
 NLug==
X-Gm-Message-State: AOAM533jZkKndYubPUQRFiQce8aS0ws2tSVCTOvs7+dAyvQplvE8sTDv
 ypyXzxulrFQ1HB42EI2aSkM=
X-Google-Smtp-Source: ABdhPJwvWqzh5Z4zIqcQsD2nPZd1SFV/bsGxsFyRgQI0CcMBFXId3Pm6Rt3M6ztehMNmDmmGgKWqGg==
X-Received: by 2002:a5d:6e0c:: with SMTP id h12mr3278044wrz.334.1629197224068; 
 Tue, 17 Aug 2021 03:47:04 -0700 (PDT)
Received: from krug (a94-133-27-132.cpe.netcabo.pt. [94.133.27.132])
 by smtp.gmail.com with ESMTPSA id r4sm1655027wmq.34.2021.08.17.03.47.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 17 Aug 2021 03:47:03 -0700 (PDT)
From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
To: simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text
 editors" <bug-gnu-emacs@HIDDEN>
Subject: Re: bug#45763: 27.1; fido-mode does not work with
 icomplete-in-buffer completion
References: <556652585.117858.1610281874781@HIDDEN>
Date: Tue, 17 Aug 2021 11:47:02 +0100
In-Reply-To: <556652585.117858.1610281874781@HIDDEN> (simon's
 message of "Sun, 10 Jan 2021 12:31:14 +0000 (GMT)")
Message-ID: <87r1eswdp5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::434;
 envelope-from=joaotavora@HIDDEN; helo=mail-wr1-x434.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: 45763 <at> debbugs.gnu.org, simon254@HIDDEN, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@HIDDEN> writes:

> in *sratch* evaluate
> (setq icomplete-in-buffer t)
> (fido-mode t)
> type:
> "(icompl" followed by C-M-i (completion-at-point)=20
> -> default completion is invoked, not fido-mode

It's true, it doesn't.  And either does icomplete-mode.  It's completely
broken.  Even if I do this to fido-mode, it's still broken, quite
broken, I don't know how to fix it.

But I would like to fix it, maybe by letting the choice still happen
from the minibuffer while.  Let's keep this bug open to track this
development.

Jo=C3=A3o

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index e06b33e43b..89ace7e434 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -411,9 +411,12 @@ fido-mode
   :global t :group 'icomplete
   (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
   (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)
+  (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setu=
p)
   (when fido-mode
     (icomplete-mode -1)
     (setq icomplete-mode t)
+    (when icomplete-in-buffer
+      (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-set=
up))
     (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
     (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)))
=20





>
> same happens for shell completion:
>
> M-x shell
> ls xxx followed by tab -> default completion is invoked, not fido-mode
>
> In GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 =
Version 10.14.6 (Build 18G95))
> of 2020-08-12 built on builder10-14.porkrind.org
> Windowing system distributor 'Apple', version 10.3.1894
> System Description:  Mac OS X 10.15.7
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> Configured using:
> 'configure --with-ns '--enable-locallisppath=3D/Library/Application
> Support/Emacs/${version}/site-lisp:/Library/Application
> Support/Emacs/site-lisp' --with-modules'
>
> Configured features:
> NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
> THREADS JSON PDUMPER
>
> Important settings:
>   value of $LANG: en_GB.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
> format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
> epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
> subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
> cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
> tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
> mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
> tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
> newcomment text-mode elisp-mode lisp-mode prog-mode register page
> tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
> jit-lock font-lock syntax facemenu font-core term/tty-colors frame
> minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
> tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
> romanian slovak czech european ethiopic indian cyrillic chinese
> composite charscript charprop case-table epa-hook jka-cmpr-hook help
> simple abbrev obarray cl-preloaded nadvice loaddefs button faces
> cus-face macroexp files text-properties overlay sha1 md5 base64 format
> env code-pages mule custom widget hashtable-print-readable backquote
> threads kqueue cocoa ns multi-tty make-network-process emacs)
>
> Memory information:
> ((conses 16 44811 6704)
> (symbols 48 5927 1)
> (strings 32 15254 1703)
> (string-bytes 1 504784)
> (vectors 16 10174)
> (vector-slots 8 126879 9518)
> (floats 8 19 39)
> (intervals 56 189 0)
> (buffers 1000 11))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Jan 2021 12:37:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 10 07:37:08 2021
Received: from localhost ([127.0.0.1]:53332 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kyZxv-0001Hy-Ny
	for submit <at> debbugs.gnu.org; Sun, 10 Jan 2021 07:37:08 -0500
Received: from lists.gnu.org ([209.51.188.17]:33400)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <simon254@HIDDEN>) id 1kyZsf-0000SP-EQ
 for submit <at> debbugs.gnu.org; Sun, 10 Jan 2021 07:31:37 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:49550)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <simon254@HIDDEN>)
 id 1kyZsd-00046J-Nw
 for bug-gnu-emacs@HIDDEN; Sun, 10 Jan 2021 07:31:37 -0500
Received: from mout-p-101.mailbox.org ([80.241.56.151]:48030)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <simon254@HIDDEN>)
 id 1kyZsX-0002aA-OM
 for bug-gnu-emacs@HIDDEN; Sun, 10 Jan 2021 07:31:35 -0500
Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4DDGRB1nDhzQlXB
 for <bug-gnu-emacs@HIDDEN>; Sun, 10 Jan 2021 13:31:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-transfer-encoding:content-type:content-type:mime-version
 :subject:subject:message-id:from:from:date:date:received; s=
 mail20150812; t=1610281874; bh=sg2gUg2oAEC8w/Q1RbIWae8/UbVjVC+Lo
 LYcHmFVfSc=; b=FNPgvopG23/Ewr1liiYiWXlFqT3RsX/iHSpYB0v+jysfFc3j1
 I1OjNLxs7fZ2GA3H+yAbh4BJPlgV4fbmN0CYaiKR+W4GPowDskmbh1zim1EROanK
 v17bpq3wXaveYD5NNwIhXd7TU4KCAINWmvsJoKIrfEI4TzMYgJD2SRNJG4/PH75y
 lZtbec6GuvjqPVAkQk8YIkCPGsEKlNyyokJs4NipWp0+/UO5VAIqvDhasSw3XZ26
 j5R0kMsHANN0YhAvkJVY6KFtXDDrf1LQ7UooP/68kAljBOK4+DGWNyYT6u1ymM9+
 NAkyu2LHTyoFVtmjXfi0jWkOggfEyltiXyLLw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1610281876;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=8qRp304d4zrlHyLiHUvVbxnswPh5wLSl2JYGMGvweZs=;
 b=vDg7aHQVO/cgnsuCwyY9c84SAbKSljKicZ+mBjXGd/4zxD+47Sy8mzn/s9hzT/E0pzMLbu
 F8/4pog/4ndv2nI8IGiI6VB+x7hfugeXgYjkiOYuRiFxFAkZmHQiRfO7FSj24syGVFiFtl
 7VXJfUCY64eO+tKFfwW1ZdLprAlsl+1Og8KT5TPsI02t9oui4kRy/tkyCKT92R+FYlNj+D
 mOZwGbnbY10iUzAFGZTyfKE2SXaw5vibJlYh4tE6beOwYU8PYAcK/EBEI1I4izr/0xQIuR
 u5KDXojX/GmADOvVVgcJtHHhRNegi2gtMxQFBLP4Jdw5fJ/Mj6bcrWnnK43nTw==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp2.mailbox.org ([80.241.60.241])
 by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172])
 (amavisd-new, port 10030)
 with ESMTP id v8KqyYhtwFoR for <bug-gnu-emacs@HIDDEN>;
 Sun, 10 Jan 2021 13:31:14 +0100 (CET)
Date: Sun, 10 Jan 2021 12:31:14 +0000 (GMT)
From: simon254@HIDDEN
To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>
Message-ID: <556652585.117858.1610281874781@HIDDEN>
Subject: 27.1; fido-mode does not work with icomplete-in-buffer completion
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -4.09 / 15.00 / 15.00
X-Rspamd-Queue-Id: 4699C1718
X-Rspamd-UID: 283ffa
Received-SPF: pass client-ip=80.241.56.151; envelope-from=simon254@HIDDEN;
 helo=mout-p-101.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 10 Jan 2021 07:37:00 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


in *sratch* evaluate
(setq icomplete-in-buffer t)
(fido-mode t)
type:
"(icompl" followed by C-M-i (completion-at-point) 
-> default completion is invoked, not fido-mode

same happens for shell completion:

M-x shell
ls xxx followed by tab -> default completion is invoked, not fido-mode

In GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95))
of 2020-08-12 built on builder10-14.porkrind.org
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.7

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
'configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
THREADS JSON PDUMPER

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core term/tty-colors frame
minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
threads kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 44811 6704)
(symbols 48 5927 1)
(strings 32 15254 1703)
(string-bytes 1 504784)
(vectors 16 10174)
(vector-slots 8 126879 9518)
(floats 8 19 39)
(intervals 56 189 0)
(buffers 1000 11))




Acknowledgement sent to simon254@HIDDEN:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#45763; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 28 Feb 2023 12:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.