GNU bug report logs - #45808
28.0.50; [PATCH] Add option remember-diary-regexp

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45808 in the body.
You can then email your comments to 45808 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Add option remember-diary-regexp
Date: Tue, 12 Jan 2021 00:26:25 -0300

[Message part 1 (text/plain, inline)]

The regexp to extract diary entries on remember.el is hardcoded.
Here is a patch to add a new option to configure a custom regexp.

[0001-Add-option-remember-diary-regexp.patch (text/x-diff, attachment)]

Message #8 received at 45808 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
Cc: 45808 <at> debbugs.gnu.org
Subject: Re: bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp
Date: Tue, 12 Jan 2021 17:15:09 +0200

> From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
> Date: Tue, 12 Jan 2021 00:26:25 -0300
> 
> The regexp to extract diary entries on remember.el is hardcoded.
> Here is a patch to add a new option to configure a custom regexp.

Thanks, but can you please describe the situation where this regexp
will need to be modified?

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp
Date: Tue, 12 Jan 2021 12:53:29 -0300

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
>> Date: Tue, 12 Jan 2021 00:26:25 -0300
>> 
>> The regexp to extract diary entries on remember.el is hardcoded.
>> Here is a patch to add a new option to configure a custom regexp.
>
> Thanks, but can you please describe the situation where this regexp
> will need to be modified?

There are multiple cases, for example, if the user wants to
automatically extract diary entries of lines that starts with a date
pattern (e.g.: dd/mm/yyyy). This new option does not target a specific
user case but rather opens a range of possibilities by not relying on a
hardcoded (and not documented) behavior.

By the way, here is a patch with updated docstring.

[0001-Add-option-remember-diary-regexp.patch (text/x-diff, attachment)]

Message #14 received at 45808 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
Cc: 45808 <at> debbugs.gnu.org
Subject: Re: bug#45808: 28.0.50; [PATCH] Add option remember-diary-regexp
Date: Wed, 20 Jan 2021 17:46:22 +0100

Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com> writes:

> There are multiple cases, for example, if the user wants to
> automatically extract diary entries of lines that starts with a date
> pattern (e.g.: dd/mm/yyyy). This new option does not target a specific
> user case but rather opens a range of possibilities by not relying on a
> hardcoded (and not documented) behavior.

Perhaps it should be a defconst instead of a defcustom, though, if the
user isn't supposed to alter it, but just use it?

> By the way, here is a patch with updated docstring.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.