GNU bug report logs - #45811
28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45811 in the body.
You can then email your comments to 45811 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Respect remember-save-after-remembering on
 remember-diary-extract-entries
Date: Tue, 12 Jan 2021 01:21:50 -0300

[Message part 1 (text/plain, inline)]

On remember.el, when option 'remember-handler-functions' contains
handler 'remember-diary-extract-entries', entries will be appended to
Diary file. However, the Diary file will not be saved automatically. I
could not find any documentation describing if this behavior is
expected, and the docstring for 'remember-save-after-remembering' does
not mention how the Diary file should be handled in this case. Given
that, there is a patch attached to automatically save the Diary file
when option 'remember-save-after-remembering' is 't'. If this is the
wrong behavior, we could improve the improve the docstring or show the
Diary buffer to user after data is appended.

[0001-Respect-remember-save-after-remembering-on-remember-.patch (text/x-diff, attachment)]

Message #8 received at 45811 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
Cc: 45811 <at> debbugs.gnu.org
Subject: Re: bug#45811: 28.0.50; [PATCH] Respect
 remember-save-after-remembering on remember-diary-extract-entries
Date: Tue, 12 Jan 2021 15:26:34 +0100

This (and the other two patches) to remember.el look good to me, but are
too large (in total) to be applied without assigning the copyright for
the changes to the FSF.  Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45811: 28.0.50; [PATCH] Respect
 remember-save-after-remembering on remember-diary-extract-entries
Date: Tue, 12 Jan 2021 16:05:38 -0300

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> This (and the other two patches) to remember.el look good to me, but are
> too large (in total) to be applied without assigning the copyright for
> the changes to the FSF.  Would you be willing to sign such paperwork?

Yes, sure! Just send me the paperwork and the instructions on how to
sign it.

Thank you.

Message #14 received at 45811 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
Cc: 45811 <at> debbugs.gnu.org
Subject: Re: bug#45811: 28.0.50; [PATCH] Respect
 remember-save-after-remembering on remember-diary-extract-entries
Date: Tue, 12 Jan 2021 20:26:14 +0100

Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> This (and the other two patches) to remember.el look good to me, but are
>> too large (in total) to be applied without assigning the copyright for
>> the changes to the FSF.  Would you be willing to sign such paperwork?
>
> Yes, sure! Just send me the paperwork and the instructions on how to
> sign it.

Great!

Here's how to get started:

Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#45811: 28.0.50; [PATCH] Respect
 remember-save-after-remembering on remember-diary-extract-entries
Date: Tue, 19 Jan 2021 21:12:52 -0300

Hi Lars,

My assignment/disclaimer process with the FSF is concluded.

Regards,
Gabriel

Message #20 received at 45811 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com>
Cc: 45811 <at> debbugs.gnu.org
Subject: Re: bug#45811: 28.0.50; [PATCH] Respect
 remember-save-after-remembering on remember-diary-extract-entries
Date: Wed, 20 Jan 2021 17:54:55 +0100

Gabriel do Nascimento Ribeiro <gabriel376 <at> hotmail.com> writes:

> On remember.el, when option 'remember-handler-functions' contains
> handler 'remember-diary-extract-entries', entries will be appended to
> Diary file. However, the Diary file will not be saved automatically. I
> could not find any documentation describing if this behavior is
> expected, and the docstring for 'remember-save-after-remembering' does
> not mention how the Diary file should be handled in this case. Given
> that, there is a patch attached to automatically save the Diary file
> when option 'remember-save-after-remembering' is 't'. If this is the
> wrong behavior, we could improve the improve the docstring or show the
> Diary buffer to user after data is appended.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.