GNU bug report logs - #45814
[PATCH] [native-comp] drop -ldl on OpenBSD

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45814 in the body.
You can then email your comments to 45814 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Omar Polo <op <at> omarpolo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] [native-comp] drop -ldl on OpenBSD
Date: Tue, 12 Jan 2021 14:18:51 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

TL;DR: on openbsd the various dl* functions are in libc.  The attached
patch drops the -ldl here.

Longer version:

I wanted to try the native-comp.  On OpenBSD gcc 10 isn't available, and
gcc 8 doesn't bundle libgccjit.  I hacked the port of of gcc 8 to
provide also the libgccjit, but even if the "smoke test" worked,
building emacs with gcc8 and libgccjit failed.  (this was a couple of
months ago at least).  Today I gave it another shot and built gcc 10
from sources somewhere in my $HOME, and then managed to get emacs up and
running :)  -- honestly, given the amount of hacks to get gcc10 working
in $HOME I am surprised nothing has exploded yet.

I still get a bunch of warnings (atm *Warnings* is 301 lines long), but
they are related to how I installed libgccjit and gcc10, not emacs
itself.

Anyway, none of the above is really about the patch.  The only real
modification on the emacs side was to drop -ldl (and something related
get getopt_long, but I need to investigate that a bit more).

Thanks


In GNU Emacs 28.0.50 (build 1, x86_64-unknown-openbsd6.8, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-01-12 built on venera
Repository revision: ce0c9c349363b5dbea56f7e32c838a93c729263d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: OpenBSD venera 6.8 GENERIC.MP#223 amd64

Configured using:
 'configure CC=mygcc 'CFLAGS=-I /home/op/opt/gcc10/include/
 -I/usr/include -I/usr/local/include' 'LDFLAGS=-L/usr/lib
 -L/usr/local/lib -L/home/op/opt/gcc10/lib -lmyuglyhack'
 --prefix=/home/op/opt/native-emacs --with-x-toolkit=lucid
 --with-nativecomp --without-makeinfo'

[diff (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
/Omar Polo

Message #8 received at 45814 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Omar Polo <op <at> omarpolo.com>
Cc: 45814 <at> debbugs.gnu.org
Subject: Re: bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD
Date: Tue, 12 Jan 2021 20:04:40 +0000

Omar Polo <op <at> omarpolo.com> writes:

> Tags: patch
>
> TL;DR: on openbsd the various dl* functions are in libc.  The attached
> patch drops the -ldl here.

Hi Omar,

thanks for the patch!

what's the state of your copyright paperwork?

  Andrea

Message #11 received at 45814 <at> debbugs.gnu.org (full text, mbox):

From: Omar Polo <op <at> omarpolo.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 45814 <at> debbugs.gnu.org
Subject: Re: bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD
Date: Tue, 12 Jan 2021 21:12:43 +0100

Andrea Corallo <akrl <at> sdf.org> writes:

> Omar Polo <op <at> omarpolo.com> writes:
>
>> Tags: patch
>>
>> TL;DR: on openbsd the various dl* functions are in libc.  The attached
>> patch drops the -ldl here.
>
> Hi Omar,
>
> thanks for the patch!
>
> what's the state of your copyright paperwork?
>
>   Andrea

I got it approved just a couple of days ago.  Should I attach the pdf?
If it's enough, I submitted another patch recently[0] that was merged.
(sorry for the probably dumb question, but these are my first
contribution to a GNU project)

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45729

Thanks,

Omar Polo

Message #14 received at 45814 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Omar Polo <op <at> omarpolo.com>
Cc: 45814 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD
Date: Tue, 12 Jan 2021 21:16:36 +0100

Omar Polo <op <at> omarpolo.com> writes:

> I got it approved just a couple of days ago.  Should I attach the pdf?

I can confirm that Omar has copyright assignment papers on file.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 45814-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Omar Polo <op <at> omarpolo.com>
Cc: 45814-done <at> debbugs.gnu.org
Subject: Re: bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD
Date: Tue, 12 Jan 2021 20:35:18 +0000

Omar Polo <op <at> omarpolo.com> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Omar Polo <op <at> omarpolo.com> writes:
>>
>>> Tags: patch
>>>
>>> TL;DR: on openbsd the various dl* functions are in libc.  The attached
>>> patch drops the -ldl here.
>>
>> Hi Omar,
>>
>> thanks for the patch!
>>
>> what's the state of your copyright paperwork?
>>
>>   Andrea
>
> I got it approved just a couple of days ago.  Should I attach the pdf?
> If it's enough, I submitted another patch recently[0] that was merged.
> (sorry for the probably dumb question, but these are my first
> contribution to a GNU project)

Nice, so congrats your second patch is in as 79b9a262ff :)

Closing

Thanks

  Andrea

PS Please next time format the patch with git adding a simple Changelog
entry (see "** Commit messages" in CONTRIBUTE).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.